You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@pinot.apache.org by GitBox <gi...@apache.org> on 2019/07/29 07:04:55 UTC
[GitHub] [incubator-pinot] codecov-io commented on issue #4476: Clean up
test utils, disconnect fake instances
codecov-io commented on issue #4476: Clean up test utils, disconnect fake instances
URL: https://github.com/apache/incubator-pinot/pull/4476#issuecomment-515871603
# [Codecov](https://codecov.io/gh/apache/incubator-pinot/pull/4476?src=pr&el=h1) Report
> Merging [#4476](https://codecov.io/gh/apache/incubator-pinot/pull/4476?src=pr&el=desc) into [master](https://codecov.io/gh/apache/incubator-pinot/commit/9d64d8a664defa355664110ca89f2a80c09052b1?src=pr&el=desc) will **increase** coverage by `0.02%`.
> The diff coverage is `100%`.
[![Impacted file tree graph](https://codecov.io/gh/apache/incubator-pinot/pull/4476/graphs/tree.svg?width=650&token=4ibza2ugkz&height=150&src=pr)](https://codecov.io/gh/apache/incubator-pinot/pull/4476?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #4476 +/- ##
============================================
+ Coverage 65.75% 65.78% +0.02%
Complexity 20 20
============================================
Files 1060 1057 -3
Lines 55072 54981 -91
Branches 8009 8007 -2
============================================
- Hits 36215 36168 -47
+ Misses 16234 16198 -36
+ Partials 2623 2615 -8
```
| [Impacted Files](https://codecov.io/gh/apache/incubator-pinot/pull/4476?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...pinot/server/starter/helix/HelixServerStarter.java](https://codecov.io/gh/apache/incubator-pinot/pull/4476/diff?src=pr&el=tree#diff-cGlub3Qtc2VydmVyL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9waW5vdC9zZXJ2ZXIvc3RhcnRlci9oZWxpeC9IZWxpeFNlcnZlclN0YXJ0ZXIuamF2YQ==) | `44.21% <100%> (-0.39%)` | `0 <0> (ø)` | |
| [...n/java/org/apache/pinot/common/utils/URIUtils.java](https://codecov.io/gh/apache/incubator-pinot/pull/4476/diff?src=pr&el=tree#diff-cGlub3QtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9waW5vdC9jb21tb24vdXRpbHMvVVJJVXRpbHMuamF2YQ==) | `61.9% <0%> (-9.53%)` | `0% <0%> (ø)` | |
| [...elix/core/periodictask/ControllerPeriodicTask.java](https://codecov.io/gh/apache/incubator-pinot/pull/4476/diff?src=pr&el=tree#diff-cGlub3QtY29udHJvbGxlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvcGlub3QvY29udHJvbGxlci9oZWxpeC9jb3JlL3BlcmlvZGljdGFzay9Db250cm9sbGVyUGVyaW9kaWNUYXNrLmphdmE=) | `76.31% <0%> (-7.9%)` | `0% <0%> (ø)` | |
| [...nsport/netty/PooledNettyClientResourceManager.java](https://codecov.io/gh/apache/incubator-pinot/pull/4476/diff?src=pr&el=tree#diff-cGlub3QtdHJhbnNwb3J0L3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9waW5vdC90cmFuc3BvcnQvbmV0dHkvUG9vbGVkTmV0dHlDbGllbnRSZXNvdXJjZU1hbmFnZXIuamF2YQ==) | `85.41% <0%> (-4.17%)` | `0% <0%> (ø)` | |
| [.../BrokerResourceOnlineOfflineStateModelFactory.java](https://codecov.io/gh/apache/incubator-pinot/pull/4476/diff?src=pr&el=tree#diff-cGlub3QtYnJva2VyL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9waW5vdC9icm9rZXIvYnJva2VyL2hlbGl4L0Jyb2tlclJlc291cmNlT25saW5lT2ZmbGluZVN0YXRlTW9kZWxGYWN0b3J5LmphdmE=) | `46.42% <0%> (-3.58%)` | `0% <0%> (ø)` | |
| [.../controller/helix/ControllerRequestURLBuilder.java](https://codecov.io/gh/apache/incubator-pinot/pull/4476/diff?src=pr&el=tree#diff-cGlub3QtY29udHJvbGxlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvcGlub3QvY29udHJvbGxlci9oZWxpeC9Db250cm9sbGVyUmVxdWVzdFVSTEJ1aWxkZXIuamF2YQ==) | `70.96% <0%> (-3.23%)` | `0% <0%> (ø)` | |
| [...inot/core/operator/docidsets/AndBlockDocIdSet.java](https://codecov.io/gh/apache/incubator-pinot/pull/4476/diff?src=pr&el=tree#diff-cGlub3QtY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvcGlub3QvY29yZS9vcGVyYXRvci9kb2NpZHNldHMvQW5kQmxvY2tEb2NJZFNldC5qYXZh) | `55.55% <0%> (-2.09%)` | `0% <0%> (ø)` | |
| [...l/FixedByteSingleColumnMultiValueReaderWriter.java](https://codecov.io/gh/apache/incubator-pinot/pull/4476/diff?src=pr&el=tree#diff-cGlub3QtY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvcGlub3QvY29yZS9pby9yZWFkZXJ3cml0ZXIvaW1wbC9GaXhlZEJ5dGVTaW5nbGVDb2x1bW5NdWx0aVZhbHVlUmVhZGVyV3JpdGVyLmphdmE=) | `68.91% <0%> (-2.08%)` | `0% <0%> (ø)` | |
| [...not/broker/requesthandler/RangeMergeOptimizer.java](https://codecov.io/gh/apache/incubator-pinot/pull/4476/diff?src=pr&el=tree#diff-cGlub3QtYnJva2VyL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9waW5vdC9icm9rZXIvcmVxdWVzdGhhbmRsZXIvUmFuZ2VNZXJnZU9wdGltaXplci5qYXZh) | `89.7% <0%> (-1.48%)` | `0% <0%> (ø)` | |
| [...lix/core/realtime/PinotRealtimeSegmentManager.java](https://codecov.io/gh/apache/incubator-pinot/pull/4476/diff?src=pr&el=tree#diff-cGlub3QtY29udHJvbGxlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvcGlub3QvY29udHJvbGxlci9oZWxpeC9jb3JlL3JlYWx0aW1lL1Bpbm90UmVhbHRpbWVTZWdtZW50TWFuYWdlci5qYXZh) | `78% <0%> (-1%)` | `0% <0%> (ø)` | |
| ... and [16 more](https://codecov.io/gh/apache/incubator-pinot/pull/4476/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-pinot/pull/4476?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-pinot/pull/4476?src=pr&el=footer). Last update [9d64d8a...3b50bb4](https://codecov.io/gh/apache/incubator-pinot/pull/4476?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org