[GitHub] [doris] morningman commented on a diff in pull request #21975: [opt](filecache) use weak_ptr to cache the file handle of file segment

["morningman (via GitHub)" <gi...@apache.org>]

morningman commented on code in PR #21975:
URL: https://github.com/apache/doris/pull/21975#discussion_r1270151394


##########
be/src/common/config.cpp:
##########
@@ -1012,6 +1012,7 @@ DEFINE_mInt32(s3_write_buffer_size, "5242880");
 // can at most buffer 50MB data. And the num of multi part upload task is
 // s3_write_buffer_whole_size / s3_write_buffer_size
 DEFINE_mInt32(s3_write_buffer_whole_size, "524288000");
+DEFINE_mInt64(file_cache_max_file_reader_cache_size, "1000000");

Review Comment:
   Add comment 



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org