You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@tvm.apache.org by "grg-haas (via GitHub)" <gi...@apache.org> on 2023/08/14 22:10:15 UTC
[GitHub] [tvm] grg-haas opened a new pull request, #15551: [VTA] Use std c++ allocation functions rather than memalign/free
grg-haas opened a new pull request, #15551:
URL: https://github.com/apache/tvm/pull/15551
The VTA runtime uses `memalign` in two places to allocate aligned memory. While technically deprecated, this function does usually work in typical software environments. However, when working with mixed C/C++ runtime environments, this approach can error catastrophically as the two languages allocate the same memory pages on their respective heaps. These two instances of `memalign`/`free` are the only two remaining ones which use C-like allocation APIs. Therefore, this PR moves these over to `std::aligned_alloc`/`std::free` in order to fully standardize on C++ allocation APIs and avoid this issue.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@tvm.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [tvm] Lunderberg commented on pull request #15551: [VTA] Use std c++ allocation functions rather than memalign/free
Posted by "Lunderberg (via GitHub)" <gi...@apache.org>.
Lunderberg commented on PR #15551:
URL: https://github.com/apache/tvm/pull/15551#issuecomment-1684623267
Thank you for the update, and I like the standardization on `std::aligned_alloc`. During the recent updates to ensure aligned memory allocations, I had mostly retained whatever style of allocation was done at each point, to minimize the extent of the changes, and hadn't considered the potential of incompatible C/C++ runtimes.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@tvm.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [tvm] tvm-bot commented on pull request #15551: [VTA] Use std c++ allocation functions rather than memalign/free
Posted by "tvm-bot (via GitHub)" <gi...@apache.org>.
tvm-bot commented on PR #15551:
URL: https://github.com/apache/tvm/pull/15551#issuecomment-1678146829
<!---bot-comment-->
Thanks for contributing to TVM! Please refer to the contributing guidelines https://tvm.apache.org/docs/contribute/ for useful information and tips. Please request code reviews from [Reviewers](https://github.com/apache/incubator-tvm/blob/master/CONTRIBUTORS.md#reviewers) by @-ing them in a comment.
<!--bot-comment-ccs-start-->
* No users to tag found in teams: `vta` <sub>See [#10317](https://github.com/apache/tvm/issues/10317) for details</sub><!--bot-comment-ccs-end-->
<sub>Generated by [tvm-bot](https://github.com/apache/tvm/blob/main/ci/README.md#github-actions)</sub>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@tvm.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [VTA] Use std c++ allocation functions rather than memalign/free [tvm]
Posted by "tqchen (via GitHub)" <gi...@apache.org>.
tqchen closed pull request #15551: [VTA] Use std c++ allocation functions rather than memalign/free
URL: https://github.com/apache/tvm/pull/15551
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@tvm.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [tvm] grg-haas commented on pull request #15551: [VTA] Use std c++ allocation functions rather than memalign/free
Posted by "grg-haas (via GitHub)" <gi...@apache.org>.
grg-haas commented on PR #15551:
URL: https://github.com/apache/tvm/pull/15551#issuecomment-1678150909
Unsure who to tag here as a reviewer, but I believe some of this code is by @tmoreau89 and seems to have been semi-recently worked on by @Lunderberg
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@tvm.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org