You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@doris.apache.org by GitBox <gi...@apache.org> on 2021/12/06 05:51:05 UTC
[GitHub] [incubator-doris] xinyiZzz commented on a change in pull request #7234: [Thread] Add thread local variable ThreadContext
xinyiZzz commented on a change in pull request #7234:
URL: https://github.com/apache/incubator-doris/pull/7234#discussion_r762718454
##########
File path: be/src/runtime/thread_context.h
##########
@@ -0,0 +1,92 @@
+// Licensed to the Apache Software Foundation (ASF) under one
+// or more contributor license agreements. See the NOTICE file
+// distributed with this work for additional information
+// regarding copyright ownership. The ASF licenses this file
+// to you under the Apache License, Version 2.0 (the
+// "License"); you may not use this file except in compliance
+// with the License. You may obtain a copy of the License at
+//
+// http://www.apache.org/licenses/LICENSE-2.0
+//
+// Unless required by applicable law or agreed to in writing,
+// software distributed under the License is distributed on an
+// "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+// KIND, either express or implied. See the License for the
+// specific language governing permissions and limitations
+// under the License.
+
+#pragma once
+
+#include <string>
+#include <thread>
+
+#include "gen_cpp/Types_types.h"
+
+namespace doris {
+
+// The thread context saves some info about a working thread.
+// 2 requried info:
+// 1. thread_id: Current thread id, Auto generated.
+// 2. type: The type is a enum value indicating which type of task current thread is running.
+// For example: QUERY, LOAD, COMPACTION, ...
+// 3. task id: A unique id to identify this task. maybe query id, load job id, etc.
+//
+// There may be other optional info to be added later.
+class ThreadContext {
+public:
+ enum TaskType {
+ UNKNOWN = 0,
+ QUERY,
+ LOAD,
+ COMPACTION
+ // to be added ...
Review comment:
Thats great
##########
File path: be/src/runtime/thread_context.h
##########
@@ -0,0 +1,92 @@
+// Licensed to the Apache Software Foundation (ASF) under one
+// or more contributor license agreements. See the NOTICE file
+// distributed with this work for additional information
+// regarding copyright ownership. The ASF licenses this file
+// to you under the Apache License, Version 2.0 (the
+// "License"); you may not use this file except in compliance
+// with the License. You may obtain a copy of the License at
+//
+// http://www.apache.org/licenses/LICENSE-2.0
+//
+// Unless required by applicable law or agreed to in writing,
+// software distributed under the License is distributed on an
+// "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+// KIND, either express or implied. See the License for the
+// specific language governing permissions and limitations
+// under the License.
+
+#pragma once
+
+#include <string>
+#include <thread>
+
+#include "gen_cpp/Types_types.h"
+
+namespace doris {
+
+// The thread context saves some info about a working thread.
+// 2 requried info:
+// 1. thread_id: Current thread id, Auto generated.
+// 2. type: The type is a enum value indicating which type of task current thread is running.
+// For example: QUERY, LOAD, COMPACTION, ...
+// 3. task id: A unique id to identify this task. maybe query id, load job id, etc.
+//
+// There may be other optional info to be added later.
+class ThreadContext {
+public:
+ enum TaskType {
+ UNKNOWN = 0,
+ QUERY,
+ LOAD,
+ COMPACTION
+ // to be added ...
+ };
+
+public:
+ ThreadContext() : _thread_id(std::this_thread::get_id()), _type(TaskType::UNKNOWN) {}
+ ~ThreadContext() {}
+
+ void attach(TaskType type, const std::string& task_id,
+ const TUniqueId& fragment_instance_id = TUniqueId()) {
+ _type = type;
+ _task_id = task_id;
+ _fragment_instance_id = fragment_instance_id;
+ }
+
+ void detach() {
+ _type = TaskType::UNKNOWN;
+ _task_id = "";
+ _fragment_instance_id = TUniqueId();
+ }
+
+ const std::string type();
+ const std::string& task_id() const { return _task_id; }
+ const std::thread::id& thread_id() { return _thread_id; }
+
+private:
+ std::thread::id _thread_id;
+ TaskType _type;
+ std::string _task_id;
+ TUniqueId _fragment_instance_id;
+};
+
+inline thread_local ThreadContext thread_local_ctx;
+
+inline const std::string TASK_TYPE_STRING(ThreadContext::TaskType type) {
Review comment:
done
##########
File path: be/src/runtime/thread_context.h
##########
@@ -0,0 +1,92 @@
+// Licensed to the Apache Software Foundation (ASF) under one
+// or more contributor license agreements. See the NOTICE file
+// distributed with this work for additional information
+// regarding copyright ownership. The ASF licenses this file
+// to you under the Apache License, Version 2.0 (the
+// "License"); you may not use this file except in compliance
+// with the License. You may obtain a copy of the License at
+//
+// http://www.apache.org/licenses/LICENSE-2.0
+//
+// Unless required by applicable law or agreed to in writing,
+// software distributed under the License is distributed on an
+// "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+// KIND, either express or implied. See the License for the
+// specific language governing permissions and limitations
+// under the License.
+
+#pragma once
+
+#include <string>
+#include <thread>
+
+#include "gen_cpp/Types_types.h"
+
+namespace doris {
+
+// The thread context saves some info about a working thread.
+// 2 requried info:
+// 1. thread_id: Current thread id, Auto generated.
+// 2. type: The type is a enum value indicating which type of task current thread is running.
+// For example: QUERY, LOAD, COMPACTION, ...
+// 3. task id: A unique id to identify this task. maybe query id, load job id, etc.
+//
+// There may be other optional info to be added later.
+class ThreadContext {
+public:
+ enum TaskType {
+ UNKNOWN = 0,
+ QUERY,
+ LOAD,
+ COMPACTION
+ // to be added ...
+ };
+
+public:
+ ThreadContext() : _thread_id(std::this_thread::get_id()), _type(TaskType::UNKNOWN) {}
+ ~ThreadContext() {}
+
+ void attach(TaskType type, const std::string& task_id,
+ const TUniqueId& fragment_instance_id = TUniqueId()) {
+ _type = type;
+ _task_id = task_id;
+ _fragment_instance_id = fragment_instance_id;
+ }
+
+ void detach() {
+ _type = TaskType::UNKNOWN;
+ _task_id = "";
+ _fragment_instance_id = TUniqueId();
+ }
+
+ const std::string type();
Review comment:
done
##########
File path: be/src/runtime/thread_context.h
##########
@@ -0,0 +1,92 @@
+// Licensed to the Apache Software Foundation (ASF) under one
+// or more contributor license agreements. See the NOTICE file
+// distributed with this work for additional information
+// regarding copyright ownership. The ASF licenses this file
+// to you under the Apache License, Version 2.0 (the
+// "License"); you may not use this file except in compliance
+// with the License. You may obtain a copy of the License at
+//
+// http://www.apache.org/licenses/LICENSE-2.0
+//
+// Unless required by applicable law or agreed to in writing,
+// software distributed under the License is distributed on an
+// "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+// KIND, either express or implied. See the License for the
+// specific language governing permissions and limitations
+// under the License.
+
+#pragma once
+
+#include <string>
+#include <thread>
+
+#include "gen_cpp/Types_types.h"
+
+namespace doris {
+
+// The thread context saves some info about a working thread.
+// 2 requried info:
+// 1. thread_id: Current thread id, Auto generated.
+// 2. type: The type is a enum value indicating which type of task current thread is running.
+// For example: QUERY, LOAD, COMPACTION, ...
+// 3. task id: A unique id to identify this task. maybe query id, load job id, etc.
+//
+// There may be other optional info to be added later.
+class ThreadContext {
+public:
+ enum TaskType {
+ UNKNOWN = 0,
+ QUERY,
+ LOAD,
+ COMPACTION
+ // to be added ...
+ };
+
+public:
+ ThreadContext() : _thread_id(std::this_thread::get_id()), _type(TaskType::UNKNOWN) {}
+ ~ThreadContext() {}
+
+ void attach(TaskType type, const std::string& task_id,
+ const TUniqueId& fragment_instance_id = TUniqueId()) {
+ _type = type;
+ _task_id = task_id;
+ _fragment_instance_id = fragment_instance_id;
+ }
+
+ void detach() {
+ _type = TaskType::UNKNOWN;
+ _task_id = "";
+ _fragment_instance_id = TUniqueId();
+ }
+
+ const std::string type();
+ const std::string& task_id() const { return _task_id; }
+ const std::thread::id& thread_id() { return _thread_id; }
Review comment:
done
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org