You are viewing a plain text version of this content. The canonical link for it is here.

Posted to issues@iceberg.apache.org by GitBox <gi...@apache.org> on 2021/06/21 20:59:44 UTC

[GitHub] [iceberg] rdblue commented on a change in pull request #2712: Use CharSequenceSet instead of Set to avoid undefined equality check behavior

rdblue commented on a change in pull request #2712:
URL: https://github.com/apache/iceberg/pull/2712#discussion_r655700520



##########
File path: core/src/main/java/org/apache/iceberg/ManifestFilterManager.java
##########
@@ -337,6 +338,7 @@ private boolean canContainDeletedFiles(ManifestFile manifest) {
     return canContainExpressionDeletes || canContainDroppedPartitions || canContainDroppedFiles || canContainDropBySeq;
   }
 
+  @SuppressWarnings("CollectionUndefinedEquality")

Review comment:
       Are the suppressions still needed now that a different set class is used?




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org