You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@ambari.apache.org by Yurii Shylov <yu...@gmail.com> on 2015/01/15 18:12:55 UTC
Review Request 29933: Upgrade pack for Flume
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/29933/
-----------------------------------------------------------
Review request for Ambari, Alejandro Fernandez, Dmitro Lisnichenko, and Nate Cole.
Bugs: AMBARI-9154
https://issues.apache.org/jira/browse/AMBARI-9154
Repository: ambari
Description
-------
Upgrade pack for Flume
Diffs
-----
ambari-server/src/main/resources/common-services/FLUME/1.4.0.2.0/package/scripts/flume_handler.py 849fcf1
ambari-server/src/main/resources/common-services/FLUME/1.4.0.2.0/package/scripts/flume_upgrade.py PRE-CREATION
ambari-server/src/main/resources/common-services/FLUME/1.4.0.2.0/package/scripts/params.py 28c4240
ambari-server/src/main/resources/stacks/HDP/2.2/upgrades/upgrade-2.2.xml 15aa1f5
ambari-server/src/test/python/stacks/2.0.6/FLUME/test_flume.py 193eefb
ambari-server/src/test/python/stacks/2.0.6/configs/flume_22.json 3a7aa33
Diff: https://reviews.apache.org/r/29933/diff/
Testing
-------
Thanks,
Yurii Shylov
Re: Review Request 29933: Upgrade pack for Flume
Posted by Nate Cole <nc...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/29933/#review68475
-----------------------------------------------------------
Ship it!
Ship It!
- Nate Cole
On Jan. 16, 2015, 3:19 p.m., Yurii Shylov wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/29933/
> -----------------------------------------------------------
>
> (Updated Jan. 16, 2015, 3:19 p.m.)
>
>
> Review request for Ambari, Alejandro Fernandez, Dmitro Lisnichenko, and Nate Cole.
>
>
> Bugs: AMBARI-9154
> https://issues.apache.org/jira/browse/AMBARI-9154
>
>
> Repository: ambari
>
>
> Description
> -------
>
> Upgrade pack for Flume
>
>
> Diffs
> -----
>
> ambari-server/src/main/resources/common-services/FLUME/1.4.0.2.0/package/scripts/flume_handler.py 849fcf1
> ambari-server/src/main/resources/common-services/FLUME/1.4.0.2.0/package/scripts/flume_upgrade.py PRE-CREATION
> ambari-server/src/main/resources/common-services/FLUME/1.4.0.2.0/package/scripts/params.py 28c4240
> ambari-server/src/main/resources/stacks/HDP/2.2/upgrades/upgrade-2.2.xml 4a4b158
> ambari-server/src/test/python/stacks/2.0.6/FLUME/test_flume.py 193eefb
> ambari-server/src/test/python/stacks/2.0.6/configs/flume_22.json 3a7aa33
>
> Diff: https://reviews.apache.org/r/29933/diff/
>
>
> Testing
> -------
>
> Total run:586
> Total errors:0
> Total failures:0
> OK
>
>
> Thanks,
>
> Yurii Shylov
>
>
Re: Review Request 29933: Upgrade pack for Flume
Posted by Dmitro Lisnichenko <dl...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/29933/#review68467
-----------------------------------------------------------
Ship it!
Ship It!
- Dmitro Lisnichenko
On Jan. 16, 2015, 8:19 p.m., Yurii Shylov wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/29933/
> -----------------------------------------------------------
>
> (Updated Jan. 16, 2015, 8:19 p.m.)
>
>
> Review request for Ambari, Alejandro Fernandez, Dmitro Lisnichenko, and Nate Cole.
>
>
> Bugs: AMBARI-9154
> https://issues.apache.org/jira/browse/AMBARI-9154
>
>
> Repository: ambari
>
>
> Description
> -------
>
> Upgrade pack for Flume
>
>
> Diffs
> -----
>
> ambari-server/src/main/resources/common-services/FLUME/1.4.0.2.0/package/scripts/flume_handler.py 849fcf1
> ambari-server/src/main/resources/common-services/FLUME/1.4.0.2.0/package/scripts/flume_upgrade.py PRE-CREATION
> ambari-server/src/main/resources/common-services/FLUME/1.4.0.2.0/package/scripts/params.py 28c4240
> ambari-server/src/main/resources/stacks/HDP/2.2/upgrades/upgrade-2.2.xml 4a4b158
> ambari-server/src/test/python/stacks/2.0.6/FLUME/test_flume.py 193eefb
> ambari-server/src/test/python/stacks/2.0.6/configs/flume_22.json 3a7aa33
>
> Diff: https://reviews.apache.org/r/29933/diff/
>
>
> Testing
> -------
>
> Total run:586
> Total errors:0
> Total failures:0
> OK
>
>
> Thanks,
>
> Yurii Shylov
>
>
Re: Review Request 29933: Upgrade pack for Flume
Posted by Yurii Shylov <yu...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/29933/
-----------------------------------------------------------
(Updated Янв. 16, 2015, 8:19 п.п.)
Review request for Ambari, Alejandro Fernandez, Dmitro Lisnichenko, and Nate Cole.
Changes
-------
Update according to comments
Bugs: AMBARI-9154
https://issues.apache.org/jira/browse/AMBARI-9154
Repository: ambari
Description
-------
Upgrade pack for Flume
Diffs (updated)
-----
ambari-server/src/main/resources/common-services/FLUME/1.4.0.2.0/package/scripts/flume_handler.py 849fcf1
ambari-server/src/main/resources/common-services/FLUME/1.4.0.2.0/package/scripts/flume_upgrade.py PRE-CREATION
ambari-server/src/main/resources/common-services/FLUME/1.4.0.2.0/package/scripts/params.py 28c4240
ambari-server/src/main/resources/stacks/HDP/2.2/upgrades/upgrade-2.2.xml 4a4b158
ambari-server/src/test/python/stacks/2.0.6/FLUME/test_flume.py 193eefb
ambari-server/src/test/python/stacks/2.0.6/configs/flume_22.json 3a7aa33
Diff: https://reviews.apache.org/r/29933/diff/
Testing (updated)
-------
Total run:586
Total errors:0
Total failures:0
OK
Thanks,
Yurii Shylov
Re: Review Request 29933: Upgrade pack for Flume
Posted by Nate Cole <nc...@hortonworks.com>.
> On Jan. 15, 2015, 12:24 p.m., Nate Cole wrote:
> > ambari-server/src/main/resources/stacks/HDP/2.2/upgrades/upgrade-2.2.xml, lines 147-150
> > <https://reviews.apache.org/r/29933/diff/1/?file=822708#file822708line147>
> >
> > Flume should go in it's own group. Actually Slider should too, so please fix that. The order should be Storm, Slider, Flume.
Oh, and please also mark the group that gets Flume with <skippable>true</skippable. Thanks.
- Nate
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/29933/#review68269
-----------------------------------------------------------
On Jan. 15, 2015, 12:12 p.m., Yurii Shylov wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/29933/
> -----------------------------------------------------------
>
> (Updated Jan. 15, 2015, 12:12 p.m.)
>
>
> Review request for Ambari, Alejandro Fernandez, Dmitro Lisnichenko, and Nate Cole.
>
>
> Bugs: AMBARI-9154
> https://issues.apache.org/jira/browse/AMBARI-9154
>
>
> Repository: ambari
>
>
> Description
> -------
>
> Upgrade pack for Flume
>
>
> Diffs
> -----
>
> ambari-server/src/main/resources/common-services/FLUME/1.4.0.2.0/package/scripts/flume_handler.py 849fcf1
> ambari-server/src/main/resources/common-services/FLUME/1.4.0.2.0/package/scripts/flume_upgrade.py PRE-CREATION
> ambari-server/src/main/resources/common-services/FLUME/1.4.0.2.0/package/scripts/params.py 28c4240
> ambari-server/src/main/resources/stacks/HDP/2.2/upgrades/upgrade-2.2.xml 15aa1f5
> ambari-server/src/test/python/stacks/2.0.6/FLUME/test_flume.py 193eefb
> ambari-server/src/test/python/stacks/2.0.6/configs/flume_22.json 3a7aa33
>
> Diff: https://reviews.apache.org/r/29933/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Yurii Shylov
>
>
Re: Review Request 29933: Upgrade pack for Flume
Posted by Nate Cole <nc...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/29933/#review68269
-----------------------------------------------------------
ambari-server/src/main/resources/common-services/FLUME/1.4.0.2.0/package/scripts/flume_handler.py
<https://reviews.apache.org/r/29933/#comment112442>
Expand *, just like for java.
ambari-server/src/main/resources/common-services/FLUME/1.4.0.2.0/package/scripts/flume_upgrade.py
<https://reviews.apache.org/r/29933/#comment112444>
Do we need to handle mutliple backups in the case something goes wrong and the old tar is still there?
ambari-server/src/main/resources/stacks/HDP/2.2/upgrades/upgrade-2.2.xml
<https://reviews.apache.org/r/29933/#comment112447>
Flume should go in it's own group. Actually Slider should too, so please fix that. The order should be Storm, Slider, Flume.
- Nate Cole
On Jan. 15, 2015, 12:12 p.m., Yurii Shylov wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/29933/
> -----------------------------------------------------------
>
> (Updated Jan. 15, 2015, 12:12 p.m.)
>
>
> Review request for Ambari, Alejandro Fernandez, Dmitro Lisnichenko, and Nate Cole.
>
>
> Bugs: AMBARI-9154
> https://issues.apache.org/jira/browse/AMBARI-9154
>
>
> Repository: ambari
>
>
> Description
> -------
>
> Upgrade pack for Flume
>
>
> Diffs
> -----
>
> ambari-server/src/main/resources/common-services/FLUME/1.4.0.2.0/package/scripts/flume_handler.py 849fcf1
> ambari-server/src/main/resources/common-services/FLUME/1.4.0.2.0/package/scripts/flume_upgrade.py PRE-CREATION
> ambari-server/src/main/resources/common-services/FLUME/1.4.0.2.0/package/scripts/params.py 28c4240
> ambari-server/src/main/resources/stacks/HDP/2.2/upgrades/upgrade-2.2.xml 15aa1f5
> ambari-server/src/test/python/stacks/2.0.6/FLUME/test_flume.py 193eefb
> ambari-server/src/test/python/stacks/2.0.6/configs/flume_22.json 3a7aa33
>
> Diff: https://reviews.apache.org/r/29933/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Yurii Shylov
>
>
Re: Review Request 29933: Upgrade pack for Flume
Posted by Alejandro Fernandez <af...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/29933/#review68276
-----------------------------------------------------------
Fix It, then Ship It
- Alejandro Fernandez
On Jan. 15, 2015, 5:12 p.m., Yurii Shylov wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/29933/
> -----------------------------------------------------------
>
> (Updated Jan. 15, 2015, 5:12 p.m.)
>
>
> Review request for Ambari, Alejandro Fernandez, Dmitro Lisnichenko, and Nate Cole.
>
>
> Bugs: AMBARI-9154
> https://issues.apache.org/jira/browse/AMBARI-9154
>
>
> Repository: ambari
>
>
> Description
> -------
>
> Upgrade pack for Flume
>
>
> Diffs
> -----
>
> ambari-server/src/main/resources/common-services/FLUME/1.4.0.2.0/package/scripts/flume_handler.py 849fcf1
> ambari-server/src/main/resources/common-services/FLUME/1.4.0.2.0/package/scripts/flume_upgrade.py PRE-CREATION
> ambari-server/src/main/resources/common-services/FLUME/1.4.0.2.0/package/scripts/params.py 28c4240
> ambari-server/src/main/resources/stacks/HDP/2.2/upgrades/upgrade-2.2.xml 15aa1f5
> ambari-server/src/test/python/stacks/2.0.6/FLUME/test_flume.py 193eefb
> ambari-server/src/test/python/stacks/2.0.6/configs/flume_22.json 3a7aa33
>
> Diff: https://reviews.apache.org/r/29933/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Yurii Shylov
>
>
Re: Review Request 29933: Upgrade pack for Flume
Posted by Dmitro Lisnichenko <dl...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/29933/#review68271
-----------------------------------------------------------
Ship it!
Ship It!
- Dmitro Lisnichenko
On Jan. 15, 2015, 5:12 p.m., Yurii Shylov wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/29933/
> -----------------------------------------------------------
>
> (Updated Jan. 15, 2015, 5:12 p.m.)
>
>
> Review request for Ambari, Alejandro Fernandez, Dmitro Lisnichenko, and Nate Cole.
>
>
> Bugs: AMBARI-9154
> https://issues.apache.org/jira/browse/AMBARI-9154
>
>
> Repository: ambari
>
>
> Description
> -------
>
> Upgrade pack for Flume
>
>
> Diffs
> -----
>
> ambari-server/src/main/resources/common-services/FLUME/1.4.0.2.0/package/scripts/flume_handler.py 849fcf1
> ambari-server/src/main/resources/common-services/FLUME/1.4.0.2.0/package/scripts/flume_upgrade.py PRE-CREATION
> ambari-server/src/main/resources/common-services/FLUME/1.4.0.2.0/package/scripts/params.py 28c4240
> ambari-server/src/main/resources/stacks/HDP/2.2/upgrades/upgrade-2.2.xml 15aa1f5
> ambari-server/src/test/python/stacks/2.0.6/FLUME/test_flume.py 193eefb
> ambari-server/src/test/python/stacks/2.0.6/configs/flume_22.json 3a7aa33
>
> Diff: https://reviews.apache.org/r/29933/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Yurii Shylov
>
>