You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by "HyukjinKwon (via GitHub)" <gi...@apache.org> on 2023/10/04 08:52:58 UTC
[PR] [SPARK-45345][BUILD] Clean Scala version change leftovers in `release-build.sh` [spark]
HyukjinKwon opened a new pull request, #43212:
URL: https://github.com/apache/spark/pull/43212
### What changes were proposed in this pull request?
This PR proposes to clean Scala version change leftovers in `release-build.sh`ean
### Why are the changes needed?
For the proper releases.
### Does this PR introduce _any_ user-facing change?
No, dev-only.
### How was this patch tested?
Manually tested the changes.
### Was this patch authored or co-authored using generative AI tooling?
No,
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
Re: [PR] [SPARK-45345][BUILD] Clean Scala version change leftovers in `release-build.sh` [spark]
Posted by "HyukjinKwon (via GitHub)" <gi...@apache.org>.
HyukjinKwon commented on PR #43212:
URL: https://github.com/apache/spark/pull/43212#issuecomment-1746463360
cc @LuciferYang @dongjoon-hyun
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
Re: [PR] [SPARK-45345][BUILD] Clean Scala version change leftovers in `release-build.sh` [spark]
Posted by "beliefer (via GitHub)" <gi...@apache.org>.
beliefer commented on code in PR #43212:
URL: https://github.com/apache/spark/pull/43212#discussion_r1345545123
##########
dev/create-release/release-build.sh:
##########
@@ -186,6 +186,9 @@ if [[ $SPARK_VERSION < "3.2" ]]; then
fi
PUBLISH_SCALA_2_12=1
+if [[ $SPARK_VERSION < "4.0" ]]; then
+ PUBLISH_SCALA_2_12=0
+fi
Review Comment:
It seems PUBLISH_SCALA_2_12 and PUBLISH_SCALA_2_13 will be 0, if `SPARK_VERSION < "3.2"`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
Re: [PR] [SPARK-45345][BUILD] Clean Scala version change leftovers in `release-build.sh` [spark]
Posted by "LuciferYang (via GitHub)" <gi...@apache.org>.
LuciferYang commented on PR #43212:
URL: https://github.com/apache/spark/pull/43212#issuecomment-1746552518
https://github.com/apache/spark/blob/cc4ecb5104e37d5e530d44b41fc1d8f8116e37d8/dev/create-release/release-build.sh#L332-L350
Doesn't the logic above need to be fixed?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
Re: [PR] [SPARK-45345][BUILD] Clean Scala version change leftovers in `release-build.sh` [spark]
Posted by "HyukjinKwon (via GitHub)" <gi...@apache.org>.
HyukjinKwon closed pull request #43212: [SPARK-45345][BUILD] Clean Scala version change leftovers in `release-build.sh`
URL: https://github.com/apache/spark/pull/43212
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
Re: [PR] [SPARK-45345][BUILD] Clean Scala version change leftovers in `release-build.sh` [spark]
Posted by "LuciferYang (via GitHub)" <gi...@apache.org>.
LuciferYang commented on PR #43212:
URL: https://github.com/apache/spark/pull/43212#issuecomment-1746559331
https://github.com/apache/spark/blob/cc4ecb5104e37d5e530d44b41fc1d8f8116e37d8/dev/create-release/release-build.sh#L199-L203
This logic is unrelated to Scala, but it seems necessary to add a Java version check for 4.0+, as it will be released by Java 17. Maybe in a separate pr?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
Re: [PR] [SPARK-45345][BUILD] Clean Scala version change leftovers in `release-build.sh` [spark]
Posted by "beliefer (via GitHub)" <gi...@apache.org>.
beliefer commented on code in PR #43212:
URL: https://github.com/apache/spark/pull/43212#discussion_r1345545123
##########
dev/create-release/release-build.sh:
##########
@@ -186,6 +186,9 @@ if [[ $SPARK_VERSION < "3.2" ]]; then
fi
PUBLISH_SCALA_2_12=1
+if [[ $SPARK_VERSION < "4.0" ]]; then
+ PUBLISH_SCALA_2_12=0
+fi
Review Comment:
It seems `PUBLISH_SCALA_2_12` and `PUBLISH_SCALA_2_13` will both be 0, if `SPARK_VERSION < "3.2"`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
Re: [PR] [SPARK-45345][BUILD] Clean Scala version change leftovers in `release-build.sh` [spark]
Posted by "HyukjinKwon (via GitHub)" <gi...@apache.org>.
HyukjinKwon commented on PR #43212:
URL: https://github.com/apache/spark/pull/43212#issuecomment-1747809425
Manually tested.
Merged to master.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org