You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@ambari.apache.org by Vishal Suvagia via Review Board <no...@reviews.apache.org> on 2017/04/27 14:04:26 UTC
Review Request 58797: AMBARI-20868 : Ranger admin start fails when
Ambari Infra is turned off.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/58797/
-----------------------------------------------------------
Review request for Ambari, Alejandro Fernandez, Gautam Borad, Mugdha Varadkar, Oliver Szabo, and Velmurugan Periasamy.
Bugs: AMBARI-20868
https://issues.apache.org/jira/browse/AMBARI-20868
Repository: ambari
Description
-------
Ranger Admin start fails when Ambari Infra or External Solr service is down,. need to handle errors and ensure Ranger start works, despite solr service being down.
Diffs
-----
ambari-server/src/main/resources/common-services/RANGER/0.4.0/package/scripts/setup_ranger_xml.py e56a705
ambari-server/src/main/resources/common-services/RANGER/0.7.0/properties/ranger-solrconfig.xml.j2 34ce70d
Diff: https://reviews.apache.org/r/58797/diff/1/
Testing
-------
Verified fresh install on Cent-OS 6.
Thanks,
Vishal Suvagia
Re: Review Request 58797: AMBARI-20868 : Ranger admin start fails when
Ambari Infra is turned off.
Posted by Oliver Szabo <os...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/58797/#review173196
-----------------------------------------------------------
ambari-server/src/main/resources/common-services/RANGER/0.4.0/package/scripts/setup_ranger_xml.py
Lines 746 (patched)
<https://reviews.apache.org/r/58797/#comment246253>
it catches the error during collection creation, but this can be fail at where solr_cloud_util.add_solr_roles is called as well (it uses solr rest api, if solr is down, that can fail)
- Oliver Szabo
On April 27, 2017, 2:04 p.m., Vishal Suvagia wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/58797/
> -----------------------------------------------------------
>
> (Updated April 27, 2017, 2:04 p.m.)
>
>
> Review request for Ambari, Alejandro Fernandez, Gautam Borad, Mugdha Varadkar, Oliver Szabo, and Velmurugan Periasamy.
>
>
> Bugs: AMBARI-20868
> https://issues.apache.org/jira/browse/AMBARI-20868
>
>
> Repository: ambari
>
>
> Description
> -------
>
> Ranger Admin start fails when Ambari Infra or External Solr service is down,. need to handle errors and ensure Ranger start works, despite solr service being down.
>
>
> Diffs
> -----
>
> ambari-server/src/main/resources/common-services/RANGER/0.4.0/package/scripts/setup_ranger_xml.py e56a705
> ambari-server/src/main/resources/common-services/RANGER/0.7.0/properties/ranger-solrconfig.xml.j2 34ce70d
>
>
> Diff: https://reviews.apache.org/r/58797/diff/1/
>
>
> Testing
> -------
>
> Verified fresh install on Cent-OS 6.
>
>
> Thanks,
>
> Vishal Suvagia
>
>
Re: Review Request 58797: AMBARI-20868 : Ranger admin start fails when
Ambari Infra is turned off.
Posted by Mugdha Varadkar <mu...@freestoneinfotech.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/58797/#review173904
-----------------------------------------------------------
Ship it!
Ship It!
- Mugdha Varadkar
On May 4, 2017, 1:27 p.m., Vishal Suvagia wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/58797/
> -----------------------------------------------------------
>
> (Updated May 4, 2017, 1:27 p.m.)
>
>
> Review request for Ambari, Alejandro Fernandez, Gautam Borad, Mugdha Varadkar, Oliver Szabo, and Velmurugan Periasamy.
>
>
> Bugs: AMBARI-20868
> https://issues.apache.org/jira/browse/AMBARI-20868
>
>
> Repository: ambari
>
>
> Description
> -------
>
> Ranger Admin start fails when Ambari Infra or External Solr service is down,. need to handle errors and ensure Ranger start works, despite solr service being down.
>
>
> Diffs
> -----
>
> ambari-server/src/main/resources/common-services/RANGER/0.4.0/package/scripts/setup_ranger_xml.py a8b7f24
> ambari-server/src/main/resources/common-services/RANGER/0.7.0/properties/ranger-solrconfig.xml.j2 34ce70d
> ambari-server/src/main/resources/stacks/HDP/2.6/services/stack_advisor.py ad44033
>
>
> Diff: https://reviews.apache.org/r/58797/diff/3/
>
>
> Testing
> -------
>
> Verified fresh install on Cent-OS 6.
>
>
> Thanks,
>
> Vishal Suvagia
>
>
Re: Review Request 58797: AMBARI-20868 : Ranger admin start fails when
Ambari Infra is turned off.
Posted by Oliver Szabo <os...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/58797/#review173900
-----------------------------------------------------------
Ship it!
Ship It!
- Oliver Szabo
On máj. 4, 2017, 1:27 du, Vishal Suvagia wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/58797/
> -----------------------------------------------------------
>
> (Updated máj. 4, 2017, 1:27 du)
>
>
> Review request for Ambari, Alejandro Fernandez, Gautam Borad, Mugdha Varadkar, Oliver Szabo, and Velmurugan Periasamy.
>
>
> Bugs: AMBARI-20868
> https://issues.apache.org/jira/browse/AMBARI-20868
>
>
> Repository: ambari
>
>
> Description
> -------
>
> Ranger Admin start fails when Ambari Infra or External Solr service is down,. need to handle errors and ensure Ranger start works, despite solr service being down.
>
>
> Diffs
> -----
>
> ambari-server/src/main/resources/common-services/RANGER/0.4.0/package/scripts/setup_ranger_xml.py a8b7f24
> ambari-server/src/main/resources/common-services/RANGER/0.7.0/properties/ranger-solrconfig.xml.j2 34ce70d
> ambari-server/src/main/resources/stacks/HDP/2.6/services/stack_advisor.py ad44033
>
>
> Diff: https://reviews.apache.org/r/58797/diff/3/
>
>
> Testing
> -------
>
> Verified fresh install on Cent-OS 6.
>
>
> Thanks,
>
> Vishal Suvagia
>
>
Re: Review Request 58797: AMBARI-20868 : Ranger admin start fails when
Ambari Infra is turned off.
Posted by Vishal Suvagia via Review Board <no...@reviews.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/58797/
-----------------------------------------------------------
(Updated May 4, 2017, 1:27 p.m.)
Review request for Ambari, Alejandro Fernandez, Gautam Borad, Mugdha Varadkar, Oliver Szabo, and Velmurugan Periasamy.
Changes
-------
Updated patch to handle errors using ExecutionFailure instead of Exceptions.
Bugs: AMBARI-20868
https://issues.apache.org/jira/browse/AMBARI-20868
Repository: ambari
Description
-------
Ranger Admin start fails when Ambari Infra or External Solr service is down,. need to handle errors and ensure Ranger start works, despite solr service being down.
Diffs (updated)
-----
ambari-server/src/main/resources/common-services/RANGER/0.4.0/package/scripts/setup_ranger_xml.py a8b7f24
ambari-server/src/main/resources/common-services/RANGER/0.7.0/properties/ranger-solrconfig.xml.j2 34ce70d
ambari-server/src/main/resources/stacks/HDP/2.6/services/stack_advisor.py ad44033
Diff: https://reviews.apache.org/r/58797/diff/3/
Changes: https://reviews.apache.org/r/58797/diff/2-3/
Testing
-------
Verified fresh install on Cent-OS 6.
Thanks,
Vishal Suvagia
Re: Review Request 58797: AMBARI-20868 : Ranger admin start fails when
Ambari Infra is turned off.
Posted by Vishal Suvagia via Review Board <no...@reviews.apache.org>.
> On May 2, 2017, 10:10 a.m., Oliver Szabo wrote:
> > Im feeling that is not really the right solution to put the whole code into a big try catch block. it wont fail with even syntactic errors.
Hi Oliver,
This is basically done so as to start Ranger irrespective of zookeeper error which can come in check_znode, As the error can now be visible to the user this may not affect the Ranger service start at all.
- Vishal
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/58797/#review173577
-----------------------------------------------------------
On April 27, 2017, 3:51 p.m., Vishal Suvagia wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/58797/
> -----------------------------------------------------------
>
> (Updated April 27, 2017, 3:51 p.m.)
>
>
> Review request for Ambari, Alejandro Fernandez, Gautam Borad, Mugdha Varadkar, Oliver Szabo, and Velmurugan Periasamy.
>
>
> Bugs: AMBARI-20868
> https://issues.apache.org/jira/browse/AMBARI-20868
>
>
> Repository: ambari
>
>
> Description
> -------
>
> Ranger Admin start fails when Ambari Infra or External Solr service is down,. need to handle errors and ensure Ranger start works, despite solr service being down.
>
>
> Diffs
> -----
>
> ambari-server/src/main/resources/common-services/RANGER/0.4.0/package/scripts/setup_ranger_xml.py e56a705
> ambari-server/src/main/resources/common-services/RANGER/0.7.0/properties/ranger-solrconfig.xml.j2 34ce70d
>
>
> Diff: https://reviews.apache.org/r/58797/diff/2/
>
>
> Testing
> -------
>
> Verified fresh install on Cent-OS 6.
>
>
> Thanks,
>
> Vishal Suvagia
>
>
Re: Review Request 58797: AMBARI-20868 : Ranger admin start fails when
Ambari Infra is turned off.
Posted by Oliver Szabo <os...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/58797/#review173577
-----------------------------------------------------------
Im feeling that is not really the right solution to put the whole code into a big try catch block. it wont fail with even syntactic errors.
- Oliver Szabo
On April 27, 2017, 3:51 p.m., Vishal Suvagia wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/58797/
> -----------------------------------------------------------
>
> (Updated April 27, 2017, 3:51 p.m.)
>
>
> Review request for Ambari, Alejandro Fernandez, Gautam Borad, Mugdha Varadkar, Oliver Szabo, and Velmurugan Periasamy.
>
>
> Bugs: AMBARI-20868
> https://issues.apache.org/jira/browse/AMBARI-20868
>
>
> Repository: ambari
>
>
> Description
> -------
>
> Ranger Admin start fails when Ambari Infra or External Solr service is down,. need to handle errors and ensure Ranger start works, despite solr service being down.
>
>
> Diffs
> -----
>
> ambari-server/src/main/resources/common-services/RANGER/0.4.0/package/scripts/setup_ranger_xml.py e56a705
> ambari-server/src/main/resources/common-services/RANGER/0.7.0/properties/ranger-solrconfig.xml.j2 34ce70d
>
>
> Diff: https://reviews.apache.org/r/58797/diff/2/
>
>
> Testing
> -------
>
> Verified fresh install on Cent-OS 6.
>
>
> Thanks,
>
> Vishal Suvagia
>
>
Re: Review Request 58797: AMBARI-20868 : Ranger admin start fails when
Ambari Infra is turned off.
Posted by Oliver Szabo <os...@hortonworks.com>.
> On May 2, 2017, 2:50 p.m., Oliver Szabo wrote:
> > ambari-server/src/main/resources/common-services/RANGER/0.4.0/package/scripts/setup_ranger_xml.py
> > Lines 752 (patched)
> > <https://reviews.apache.org/r/58797/diff/2/?file=1701458#file1701458line752>
> >
> > try to use "resource_management.core.exceptions.ExecutionFailed" to make sure that is not a syntax error or something else
sorry I mean like runtime errors (with invalid types etc.), not syntax errors. those should not be compiled, so tests would fail on those.
- Oliver
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/58797/#review173591
-----------------------------------------------------------
On April 27, 2017, 3:51 p.m., Vishal Suvagia wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/58797/
> -----------------------------------------------------------
>
> (Updated April 27, 2017, 3:51 p.m.)
>
>
> Review request for Ambari, Alejandro Fernandez, Gautam Borad, Mugdha Varadkar, Oliver Szabo, and Velmurugan Periasamy.
>
>
> Bugs: AMBARI-20868
> https://issues.apache.org/jira/browse/AMBARI-20868
>
>
> Repository: ambari
>
>
> Description
> -------
>
> Ranger Admin start fails when Ambari Infra or External Solr service is down,. need to handle errors and ensure Ranger start works, despite solr service being down.
>
>
> Diffs
> -----
>
> ambari-server/src/main/resources/common-services/RANGER/0.4.0/package/scripts/setup_ranger_xml.py e56a705
> ambari-server/src/main/resources/common-services/RANGER/0.7.0/properties/ranger-solrconfig.xml.j2 34ce70d
>
>
> Diff: https://reviews.apache.org/r/58797/diff/2/
>
>
> Testing
> -------
>
> Verified fresh install on Cent-OS 6.
>
>
> Thanks,
>
> Vishal Suvagia
>
>
Re: Review Request 58797: AMBARI-20868 : Ranger admin start fails when
Ambari Infra is turned off.
Posted by Oliver Szabo <os...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/58797/#review173591
-----------------------------------------------------------
ambari-server/src/main/resources/common-services/RANGER/0.4.0/package/scripts/setup_ranger_xml.py
Lines 752 (patched)
<https://reviews.apache.org/r/58797/#comment246578>
try to use "resource_management.core.exceptions.ExecutionFailed" to make sure that is not a syntax error or something else
- Oliver Szabo
On April 27, 2017, 3:51 p.m., Vishal Suvagia wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/58797/
> -----------------------------------------------------------
>
> (Updated April 27, 2017, 3:51 p.m.)
>
>
> Review request for Ambari, Alejandro Fernandez, Gautam Borad, Mugdha Varadkar, Oliver Szabo, and Velmurugan Periasamy.
>
>
> Bugs: AMBARI-20868
> https://issues.apache.org/jira/browse/AMBARI-20868
>
>
> Repository: ambari
>
>
> Description
> -------
>
> Ranger Admin start fails when Ambari Infra or External Solr service is down,. need to handle errors and ensure Ranger start works, despite solr service being down.
>
>
> Diffs
> -----
>
> ambari-server/src/main/resources/common-services/RANGER/0.4.0/package/scripts/setup_ranger_xml.py e56a705
> ambari-server/src/main/resources/common-services/RANGER/0.7.0/properties/ranger-solrconfig.xml.j2 34ce70d
>
>
> Diff: https://reviews.apache.org/r/58797/diff/2/
>
>
> Testing
> -------
>
> Verified fresh install on Cent-OS 6.
>
>
> Thanks,
>
> Vishal Suvagia
>
>
Re: Review Request 58797: AMBARI-20868 : Ranger admin start fails when
Ambari Infra is turned off.
Posted by Mugdha Varadkar <mu...@freestoneinfotech.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/58797/#review173287
-----------------------------------------------------------
Ship it!
Ship It!
- Mugdha Varadkar
On April 27, 2017, 3:51 p.m., Vishal Suvagia wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/58797/
> -----------------------------------------------------------
>
> (Updated April 27, 2017, 3:51 p.m.)
>
>
> Review request for Ambari, Alejandro Fernandez, Gautam Borad, Mugdha Varadkar, Oliver Szabo, and Velmurugan Periasamy.
>
>
> Bugs: AMBARI-20868
> https://issues.apache.org/jira/browse/AMBARI-20868
>
>
> Repository: ambari
>
>
> Description
> -------
>
> Ranger Admin start fails when Ambari Infra or External Solr service is down,. need to handle errors and ensure Ranger start works, despite solr service being down.
>
>
> Diffs
> -----
>
> ambari-server/src/main/resources/common-services/RANGER/0.4.0/package/scripts/setup_ranger_xml.py e56a705
> ambari-server/src/main/resources/common-services/RANGER/0.7.0/properties/ranger-solrconfig.xml.j2 34ce70d
>
>
> Diff: https://reviews.apache.org/r/58797/diff/2/
>
>
> Testing
> -------
>
> Verified fresh install on Cent-OS 6.
>
>
> Thanks,
>
> Vishal Suvagia
>
>
Re: Review Request 58797: AMBARI-20868 : Ranger admin start fails when
Ambari Infra is turned off.
Posted by Vishal Suvagia via Review Board <no...@reviews.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/58797/
-----------------------------------------------------------
(Updated April 27, 2017, 3:51 p.m.)
Review request for Ambari, Alejandro Fernandez, Gautam Borad, Mugdha Varadkar, Oliver Szabo, and Velmurugan Periasamy.
Changes
-------
Updated patch to address review comments
Bugs: AMBARI-20868
https://issues.apache.org/jira/browse/AMBARI-20868
Repository: ambari
Description
-------
Ranger Admin start fails when Ambari Infra or External Solr service is down,. need to handle errors and ensure Ranger start works, despite solr service being down.
Diffs (updated)
-----
ambari-server/src/main/resources/common-services/RANGER/0.4.0/package/scripts/setup_ranger_xml.py e56a705
ambari-server/src/main/resources/common-services/RANGER/0.7.0/properties/ranger-solrconfig.xml.j2 34ce70d
Diff: https://reviews.apache.org/r/58797/diff/2/
Changes: https://reviews.apache.org/r/58797/diff/1-2/
Testing
-------
Verified fresh install on Cent-OS 6.
Thanks,
Vishal Suvagia