You are viewing a plain text version of this content. The canonical link for it is here.
Posted to gitbox@activemq.apache.org by GitBox <gi...@apache.org> on 2019/03/08 17:45:55 UTC
[GitHub] [activemq-artemis] k-wall commented on issue #2568: ARTEMIS-2262:
Correlate management response messages with the request
k-wall commented on issue #2568: ARTEMIS-2262: Correlate management response messages with the request
URL: https://github.com/apache/activemq-artemis/pull/2568#issuecomment-471015062
Glad to see the feature accepted. If the coding can be improved along the lines @michaelandrepearce suggested great. I don't have the depth of code base experience to be able to make the deeper changes efficiently.
The second PR did leave a question in the comments in the code. You'll probably want to remove this. See `ManagementServiceImpl#getCorrelationIdentity`. As I said there, there was a difficultly presented by `CoreMessage#getUserId`. For my use-case, correlation by *correlation-id* is sufficient so the correlation by *management id* could be removed if you prefer. If you decide to do that, the support tests ManagementServiceImplTest#testCorrelateResponseByMessageID and AmqpManagementTest#testCorrelationByMessageID* need to be removed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services