[GitHub] [hive] kasakrisz commented on a diff in pull request #4162: HIVE-26997: Iceberg: Vectorization gets disabled at runtime in merge-into statement

["kasakrisz (via GitHub)" <gi...@apache.org>]

kasakrisz commented on code in PR #4162:
URL: https://github.com/apache/hive/pull/4162#discussion_r1151445817


##########
iceberg/iceberg-handler/src/main/java/org/apache/iceberg/mr/hive/IcebergAcidUtil.java:
##########
@@ -93,10 +95,16 @@ public static Schema createFileReadSchemaWithVirtualColums(List<Types.NestedFiel
    * @param dataCols The columns of the serde projection schema
    * @return The schema for SerDe operations, extended with metadata columns needed for deletes
    */
-  public static Schema createSerdeSchemaForDelete(List<Types.NestedField> dataCols) {
-    List<Types.NestedField> cols = Lists.newArrayListWithCapacity(dataCols.size() + SERDE_META_COLS.size());
+  public static Schema createSerdeSchemaForDelete(List<Types.NestedField> dataCols, boolean partitioned,
+      Properties serDeProperties) {
+    boolean skipRowData = Boolean.parseBoolean(serDeProperties.getProperty(WriterBuilder.ICEBERG_DELETE_SKIPROWDATA,
+        WriterBuilder.ICEBERG_DELETE_SKIPROWDATA_DEFAULT));
+    List<Types.NestedField> cols = Lists.newArrayListWithCapacity(
+        SERDE_META_COLS.size() + (skipRowData || partitioned ? 0 : dataCols.size()));

Review Comment:
   is it `skipRowData && !partitioned` ?



##########
iceberg/iceberg-handler/src/test/queries/positive/vectorized_iceberg_merge_mixed.q:
##########
@@ -0,0 +1,197 @@
+-- SORT_QUERY_RESULTS

Review Comment:
   Please add test for merging partitioned iceberg tables.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org
For additional commands, e-mail: gitbox-help@hive.apache.org