You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@airflow.apache.org by GitBox <gi...@apache.org> on 2021/01/04 17:01:07 UTC

[GitHub] [airflow] turbaszek commented on a change in pull request #13458: Log migrations info in consistent way

turbaszek commented on a change in pull request #13458:
URL: https://github.com/apache/airflow/pull/13458#discussion_r551443691



##########
File path: airflow/migrations/versions/2c6edca13270_resource_based_permissions.py
##########
@@ -307,7 +309,10 @@ def remap_permissions():
 
 def upgrade():
     """Apply Resource based permissions."""
+    log = logging.getLogger()
+    handlers = log.handlers[:]

Review comment:
       Won't it get mutated? I wanted to make a deep copy to avoid situation that we had some time ago in Airflow with handlers 😄  




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org