You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@kie.apache.org by "tkobayas (via GitHub)" <gi...@apache.org> on 2026/05/19 08:45:14 UTC
[PR] [incubator-kie-drools-6706] Parallel Build of Inline Accumulate rules… [incubator-kie-drools]
tkobayas opened a new pull request, #6708:
URL: https://github.com/apache/incubator-kie-drools/pull/6708
… cause a build error
- Fixes https://github.com/apache/incubator-kie-drools/issues/6706
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@kie.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@kie.apache.org
For additional commands, e-mail: commits-help@kie.apache.org
Re: [PR] [incubator-kie-drools-6706] Parallel Build of Inline Accumulate rules… [incubator-kie-drools]
Posted by "tkobayas (via GitHub)" <gi...@apache.org>.
tkobayas commented on code in PR #6708:
URL: https://github.com/apache/incubator-kie-drools/pull/6708#discussion_r3264903936
##########
drools-model/drools-model-codegen/src/main/java/org/drools/model/codegen/execmodel/PackageModel.java:
##########
@@ -154,7 +155,7 @@ public class PackageModel {
private final List<MethodDeclaration> functions = new ArrayList<>();
- private final List<TypeDeclaration> generatedPOJOs = new ArrayList<>();
+ private final List<TypeDeclaration> generatedPOJOs = new CopyOnWriteArrayList<>();
Review Comment:
During build, helper classes like `accumulate5Accumulate68` are added to this list. With a plain `ArrayList`, the added class may lost under concurrency and resulted in a build erorr.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@kie.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@kie.apache.org
For additional commands, e-mail: commits-help@kie.apache.org
Re: [PR] [incubator-kie-drools-6706] Parallel Build of Inline Accumulate rules… [incubator-kie-drools]
Posted by "tkobayas (via GitHub)" <gi...@apache.org>.
tkobayas commented on code in PR #6708:
URL: https://github.com/apache/incubator-kie-drools/pull/6708#discussion_r3264903936
##########
drools-model/drools-model-codegen/src/main/java/org/drools/model/codegen/execmodel/PackageModel.java:
##########
@@ -154,7 +155,7 @@ public class PackageModel {
private final List<MethodDeclaration> functions = new ArrayList<>();
- private final List<TypeDeclaration> generatedPOJOs = new ArrayList<>();
+ private final List<TypeDeclaration> generatedPOJOs = new CopyOnWriteArrayList<>();
Review Comment:
During build, helper classes like `accumulate5Accumulate68` are added to this list. With a plain `ArrayList`, the added class may be lost under concurrency and result in a build error.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@kie.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@kie.apache.org
For additional commands, e-mail: commits-help@kie.apache.org
Re: [PR] [incubator-kie-drools-6706] Parallel Build of Inline Accumulate rules… [incubator-kie-drools]
Posted by "tkobayas (via GitHub)" <gi...@apache.org>.
tkobayas commented on code in PR #6708:
URL: https://github.com/apache/incubator-kie-drools/pull/6708#discussion_r3264903936
##########
drools-model/drools-model-codegen/src/main/java/org/drools/model/codegen/execmodel/PackageModel.java:
##########
@@ -154,7 +155,7 @@ public class PackageModel {
private final List<MethodDeclaration> functions = new ArrayList<>();
- private final List<TypeDeclaration> generatedPOJOs = new ArrayList<>();
+ private final List<TypeDeclaration> generatedPOJOs = new CopyOnWriteArrayList<>();
Review Comment:
During build, helper classes like `accumulate5Accumulate68` are added to this list. With a plain `ArrayList`, the added class may be lost under concurrency and result in a build error.
We may have to fix other lists in `PackageModel`, but so far I can only reproduce this issue, so the fix is only this one.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@kie.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@kie.apache.org
For additional commands, e-mail: commits-help@kie.apache.org
Re: [PR] [incubator-kie-drools-6706] Parallel Build of Inline Accumulate rules… [incubator-kie-drools]
Posted by "tkobayas (via GitHub)" <gi...@apache.org>.
tkobayas merged PR #6708:
URL: https://github.com/apache/incubator-kie-drools/pull/6708
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@kie.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@kie.apache.org
For additional commands, e-mail: commits-help@kie.apache.org