You are viewing a plain text version of this content. The canonical link for it is here.

Posted to oak-issues@jackrabbit.apache.org by "Francesco Mari (JIRA)" <ji...@apache.org> on 2017/02/02 09:25:51 UTC

[jira] [Commented] (OAK-5276) The check command overloads the meaning of the "deep" option

    [ https://issues.apache.org/jira/browse/OAK-5276?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15849709#comment-15849709 ] 

Francesco Mari commented on OAK-5276:
-------------------------------------

The patch looks good to me, but you should also update the documentation at {{oak-doc/src/site/markdown/nodestore/segment/overview.md}} accordingly.

> The check command overloads the meaning of the "deep" option
> ------------------------------------------------------------
>
>                 Key: OAK-5276
>                 URL: https://issues.apache.org/jira/browse/OAK-5276
>             Project: Jackrabbit Oak
>          Issue Type: Improvement
>          Components: run, segment-tar
>            Reporter: Francesco Mari
>            Assignee: Andrei Dulceanu
>            Priority: Minor
>              Labels: tooling
>             Fix For: 1.8, 1.6.1
>
>         Attachments: OAK-5276.patch
>
>
> The {{--deep}} option accepted by the {{check}} command is semantically overloaded. It is used both as a flag to enable deep content traversal and as a way to specify the frequency of debug messages printed by the tool. 
> This option should be split in two. In particular, {{--deep}} should retain its behaviour of on/off flag for deep traversal, and a new command line option should be introduced to specify the interval of debug messages.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)