[GitHub] [maven-build-cache-extension] gnodet commented on a diff in pull request #14: [MBUILDCACHE-20] Use local cache before remote cache by default

[GitBox <gi...@apache.org>]

gnodet commented on code in PR #14:
URL: https://github.com/apache/maven-build-cache-extension/pull/14#discussion_r874823004


##########
src/main/java/org/apache/maven/buildcache/CacheControllerImpl.java:
##########
@@ -166,22 +166,22 @@ public CacheResult findCachedBuild( MavenSession session, MavenProject project,
         ProjectsInputInfo inputInfo = projectInputCalculator.calculateInput( project );
 
         final CacheContext context = new CacheContext( project, inputInfo, session );
-        // remote build first
-        CacheResult result = findCachedBuild( mojoExecutions, context );

Review Comment:
   Well, that was exactly what I was trying to fix.  If there was no remote build cached, but a local build, a lookup did occur...



##########
src/main/java/org/apache/maven/buildcache/CacheControllerImpl.java:
##########
@@ -166,22 +166,22 @@ public CacheResult findCachedBuild( MavenSession session, MavenProject project,
         ProjectsInputInfo inputInfo = projectInputCalculator.calculateInput( project );
 
         final CacheContext context = new CacheContext( project, inputInfo, session );
-        // remote build first
-        CacheResult result = findCachedBuild( mojoExecutions, context );

Review Comment:
   @AlexanderAshitkin Well, that was exactly what I was trying to fix.  If there was no remote build cached, but a local build, a lookup did occur...



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org