[GitHub] surajpindoria closed pull request #8: CB-5235 Resolved InAppBroswer failed test case on WP8

[GitBox <gi...@apache.org>]

surajpindoria closed pull request #8: CB-5235 Resolved InAppBroswer failed test case on WP8
URL: https://github.com/apache/cordova-plugin-inappbrowser/pull/8
 
 
   

This is a PR merged from a forked repository.
As GitHub hides the original diff on merge, it is displayed below for
the sake of provenance:

As this is a foreign pull request (from a fork), the diff is supplied
below (as it won't show otherwise due to GitHub magic):

diff --git a/src/wp/InAppBrowser.cs b/src/wp/InAppBrowser.cs
index 46e13849..c51ed587 100644
--- a/src/wp/InAppBrowser.cs
+++ b/src/wp/InAppBrowser.cs
@@ -47,17 +47,23 @@ public void open(string options)
                 _blank - always open in the InAppBrowser 
                 _system - always open in the system web browser 
             */
-            switch (target)
+
+            if (null == target || target.Equals("_self"))
+            {
+                ShowCordovaBrowser(urlLoc);
+            }
+            else if (target.Equals("_system"))
             {
-                case "_blank":
-                    ShowInAppBrowser(urlLoc);
-                    break;
-                case "_self":
-                    ShowCordovaBrowser(urlLoc);
-                    break;
-                case "_system":
-                    ShowSystemBrowser(urlLoc);
-                    break;
+                ShowSystemBrowser(urlLoc);
+            }
+            else// new AppBrowser or anything else;
+            {
+                ShowInAppBrowser(urlLoc);
+                if (!target.Equals("_blank"))
+                {
+                    //anything else
+                    System.Diagnostics.Debug.WriteLine("InAppBrowser open unkonw target: " + target + " ,with url? " + urlLoc);
+                }
             }
 
 


 

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@cordova.apache.org
For additional commands, e-mail: commits-help@cordova.apache.org