You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@ponymail.apache.org by GitBox <gi...@apache.org> on 2021/11/29 18:11:29 UTC

[GitHub] [incubator-ponymail-foal] sebbASF opened a new issue #165: formdata.py %-decodes the query string twice, which can result in corruption

sebbASF opened a new issue #165:
URL: https://github.com/apache/incubator-ponymail-foal/issues/165


   https://github.com/apache/incubator-ponymail-foal/blob/0615306c26f83ae073ba3ca0875af97eb0114972/server/plugins/formdata.py#L38
   
   AFAICT, the request.query_string has already been %-decoded, so calling parse_qsl can result in corrupting the extracted information.
   
   For example, ?id=a%2520c becomes 'a c'; it should be 'a%20c'
   
   There is actually no need to use parse_qsl as the required info is already in the field request.query which is a MultiDictProxy containing the already-decoded values.
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@ponymail.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [incubator-ponymail-foal] Humbedooh commented on issue #165: formdata.py %-decodes the query string twice, which can result in corruption

Posted by GitBox <gi...@apache.org>.
Humbedooh commented on issue #165:
URL: https://github.com/apache/incubator-ponymail-foal/issues/165#issuecomment-981893458


   Should be fixed and refactored now.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@ponymail.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [incubator-ponymail-foal] Humbedooh closed issue #165: formdata.py %-decodes the query string twice, which can result in corruption

Posted by GitBox <gi...@apache.org>.
Humbedooh closed issue #165:
URL: https://github.com/apache/incubator-ponymail-foal/issues/165


   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@ponymail.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org