[GitHub] [iceberg] singhpk234 commented on a diff in pull request #5277: Build: Allowlist only required git properties in IcebergBuild info

[GitBox <gi...@apache.org>]

singhpk234 commented on code in PR #5277:
URL: https://github.com/apache/iceberg/pull/5277#discussion_r921094413


##########
build.gradle:
##########
@@ -64,6 +64,7 @@ gitProperties {
   gitPropertiesResourceDir = file("${rootDir}/build")
   extProperty = 'gitProps'
   failOnNoGitDirectory = true
+  keys = ['git.commit.id.abbrev', 'git.commit.id', 'git.branch', 'git.tags', 'git.build.version']

Review Comment:
   sure added, i just wanted to omit exposing the two props (git.build.host & git.remote.origin.url) hence added the change to only allow props required by us. 



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org