You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@ambari.apache.org by Robert Levas <rl...@hortonworks.com> on 2015/12/04 15:49:48 UTC
Review Request 40972: User with SERVICE.MODIFY_CONFIGS authorization
fails with 403 status updating configs
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/40972/
-----------------------------------------------------------
Review request for Ambari, Jonathan Hurley, Myroslav Papirkovskyy, Nate Cole, and Sumit Mohanty.
Bugs: AMBARI-14210
https://issues.apache.org/jira/browse/AMBARI-14210
Repository: ambari
Description
-------
User with SERVICE.MODIFY_CONFIGS authorization fails with 403 status updating configs
# PUT /api/v1/clusters/:cluster_name
```
[
{
"Clusters": {
"desired_config": [
{
"type": "zoo.cfg",
"tag": "version1449226525346",
"properties": {
"autopurge.purgeInterval": "24",
"autopurge.snapRetainCount": "30",
"dataDir": "/hadoop/zookeeper",
"tickTime": "2000",
"initLimit": "11",
"syncLimit": "5",
"clientPort": "2181"
},
"service_config_version_note": ""
}
]
}
}
]
```
Diffs
-----
ambari-server/src/main/java/org/apache/ambari/server/controller/AmbariManagementControllerImpl.java 2266a13
ambari-server/src/main/java/org/apache/ambari/server/security/authorization/AuthorizationHelper.java e303066
ambari-server/src/main/java/org/apache/ambari/server/security/authorization/RoleAuthorization.java 1f53b06
ambari-server/src/test/java/org/apache/ambari/server/controller/internal/ClusterResourceProviderTest.java 827f979
ambari-server/src/test/java/org/apache/ambari/server/security/TestAuthenticationFactory.java 94f119c
ambari-server/src/test/java/org/apache/ambari/server/security/authorization/AuthorizationHelperTest.java bd1d12b
Diff: https://reviews.apache.org/r/40972/diff/
Testing
-------
Manually tested using users with different roles
# Local test results: PASSED
# Jenkins test results: PENDING
Thanks,
Robert Levas
Re: Review Request 40972: User with SERVICE.MODIFY_CONFIGS
authorization fails with 403 status updating configs
Posted by Jonathan Hurley <jh...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/40972/#review109109
-----------------------------------------------------------
Ship it!
Ship It!
- Jonathan Hurley
On Dec. 4, 2015, 9:49 a.m., Robert Levas wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/40972/
> -----------------------------------------------------------
>
> (Updated Dec. 4, 2015, 9:49 a.m.)
>
>
> Review request for Ambari, Jonathan Hurley, Myroslav Papirkovskyy, Nate Cole, and Sumit Mohanty.
>
>
> Bugs: AMBARI-14210
> https://issues.apache.org/jira/browse/AMBARI-14210
>
>
> Repository: ambari
>
>
> Description
> -------
>
> User with SERVICE.MODIFY_CONFIGS authorization fails with 403 status updating configs
>
> # PUT /api/v1/clusters/:cluster_name
> ```
> [
> {
> "Clusters": {
> "desired_config": [
> {
> "type": "zoo.cfg",
> "tag": "version1449226525346",
> "properties": {
> "autopurge.purgeInterval": "24",
> "autopurge.snapRetainCount": "30",
> "dataDir": "/hadoop/zookeeper",
> "tickTime": "2000",
> "initLimit": "11",
> "syncLimit": "5",
> "clientPort": "2181"
> },
> "service_config_version_note": ""
> }
> ]
> }
> }
> ]
> ```
>
>
> Diffs
> -----
>
> ambari-server/src/main/java/org/apache/ambari/server/controller/AmbariManagementControllerImpl.java 2266a13
> ambari-server/src/main/java/org/apache/ambari/server/security/authorization/AuthorizationHelper.java e303066
> ambari-server/src/main/java/org/apache/ambari/server/security/authorization/RoleAuthorization.java 1f53b06
> ambari-server/src/test/java/org/apache/ambari/server/controller/internal/ClusterResourceProviderTest.java 827f979
> ambari-server/src/test/java/org/apache/ambari/server/security/TestAuthenticationFactory.java 94f119c
> ambari-server/src/test/java/org/apache/ambari/server/security/authorization/AuthorizationHelperTest.java bd1d12b
>
> Diff: https://reviews.apache.org/r/40972/diff/
>
>
> Testing
> -------
>
> Manually tested using users with different roles
>
> # Local test results: PASSED
>
> # Jenkins test results: PENDING
>
>
> Thanks,
>
> Robert Levas
>
>
Re: Review Request 40972: User with SERVICE.MODIFY_CONFIGS
authorization fails with 403 status updating configs
Posted by Nate Cole <nc...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/40972/#review109036
-----------------------------------------------------------
Ship it!
Ship It!
- Nate Cole
On Dec. 4, 2015, 9:49 a.m., Robert Levas wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/40972/
> -----------------------------------------------------------
>
> (Updated Dec. 4, 2015, 9:49 a.m.)
>
>
> Review request for Ambari, Jonathan Hurley, Myroslav Papirkovskyy, Nate Cole, and Sumit Mohanty.
>
>
> Bugs: AMBARI-14210
> https://issues.apache.org/jira/browse/AMBARI-14210
>
>
> Repository: ambari
>
>
> Description
> -------
>
> User with SERVICE.MODIFY_CONFIGS authorization fails with 403 status updating configs
>
> # PUT /api/v1/clusters/:cluster_name
> ```
> [
> {
> "Clusters": {
> "desired_config": [
> {
> "type": "zoo.cfg",
> "tag": "version1449226525346",
> "properties": {
> "autopurge.purgeInterval": "24",
> "autopurge.snapRetainCount": "30",
> "dataDir": "/hadoop/zookeeper",
> "tickTime": "2000",
> "initLimit": "11",
> "syncLimit": "5",
> "clientPort": "2181"
> },
> "service_config_version_note": ""
> }
> ]
> }
> }
> ]
> ```
>
>
> Diffs
> -----
>
> ambari-server/src/main/java/org/apache/ambari/server/controller/AmbariManagementControllerImpl.java 2266a13
> ambari-server/src/main/java/org/apache/ambari/server/security/authorization/AuthorizationHelper.java e303066
> ambari-server/src/main/java/org/apache/ambari/server/security/authorization/RoleAuthorization.java 1f53b06
> ambari-server/src/test/java/org/apache/ambari/server/controller/internal/ClusterResourceProviderTest.java 827f979
> ambari-server/src/test/java/org/apache/ambari/server/security/TestAuthenticationFactory.java 94f119c
> ambari-server/src/test/java/org/apache/ambari/server/security/authorization/AuthorizationHelperTest.java bd1d12b
>
> Diff: https://reviews.apache.org/r/40972/diff/
>
>
> Testing
> -------
>
> Manually tested using users with different roles
>
> # Local test results: PASSED
>
> # Jenkins test results: PENDING
>
>
> Thanks,
>
> Robert Levas
>
>