You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@carbondata.apache.org by xm_zzc <44...@qq.com> on 2018/04/25 16:09:21 UTC

Change the 'comment' content for column when execute command 'desc formatted table_name'

Hi dev:
  Currently the 'comment' content for column is ambiguous and unclear when
execute command 'desc formatted table_name', for example:
  ran create table sql:
  CREATE TABLE IF NOT EXISTS test_table (
    id INT,
    name STRING,
    city STRING,
    salary LONG,
    tax DOUBLE
    )
    STORED BY 'carbondata'
    TBLPROPERTIES(
    'streaming'='false', 'sort_columns'='name,id',
'dictionary_include'='name');
    
  and then ran 'desc formatted test_table', it showed the content below:
  |col_name  |data_type     |comment                                     |
  +----------+--------------+--------------------------------------------+
  |id        |int           |KEY COLUMN,NOINVERTEDINDEX,null             |
  |name      |string        |DICTIONARY, KEY COLUMN,null                 |
  |city      |string        |KEY COLUMN,null                             |
  |salary    |bigint        |MEASURE,null                                |
  |tax       |double        |MEASURE,null                                |
  |          |              |                                            |
  
  1. what's the 'KEY COLUMN' mean? all document do not describe this
concept, just introduce dimension column, measure column, inverted index,
dictionary column and so on.
  2. Actually 'city' field is just a dimension column and does not have
inverted index, but 'id', 'name' and 'city' field are shown as 'KEY COLUMN',
how to distinguish between them?
  
  So IMO, We can show more detailed information on 'comment' column and
remove 'KEY COLUMN' description, for example:
  run 'desc formatted test_table', it can show the content below:
  |col_name  |data_type     |comment                                     |
  +----------+--------------+--------------------------------------------+
  |id        |int           |DIMENSION,NOINVERTEDINDEX,null              |
  |name      |string        |DIMENSION,DICTIONARY,INVERTEDINDEX,null     |
  |city      |string        |DIMENSION,null                              |
  |salary    |bigint        |MEASURE,null                                |
  |tax       |double        |MEASURE,null                                |
  |          |              |                                            |
  
  How about this change? Any suggestion for this? Please let me know.




--
Sent from: http://apache-carbondata-dev-mailing-list-archive.1130556.n5.nabble.com/

Re: Change the 'comment' content for column when execute command 'desc formatted table_name'

Posted by Liang Chen <ch...@gmail.com>.
Hi

Thank you started the discussion.

Propose to completely optimize this part, my suggestion as below :

CREATE TABLE IF NOT EXISTS test_table (
    id INT COMMENT 'device id for sensor XYZ',
    name STRING,
    salary LONG,
    tax DOUBLE
    )
PARTITIONED BY (city STRING)
STORED BY 'carbondata' 
TBLPROPERTIES('SORT_COLUMNS'='name,id','NO_INVERTED_INDEX'='id','DICTIONARY_INCLUDE'='name')

## Table Schema Information	
|col_name  |data_type     |comment                                     |
+----------+--------------+--------------------------------------------+
|id        |int           |device id for sensor XYZ       
|name      |string        |                 
|city      |string        |    
|salary    |bigint        |
|tax       |double        |    	

## Table Basic Information
|Database Name                       |default                                                                        
|                                                                        |
|Table Name                          |test_table                                                                     
|                                                                        |
|CARBON Store Path                   |/Users/apple/DEMO/presto_test/data                                             
|                                                                        |
|Comment                             |                                                                               
|                                                                        |                                                                    
|                                                                        |
|Table Data Size                     |0                                                                              
|                                                                        |
|Table Index Size                    |0                                                                              
|                                                                        |
|Last Update Time                    |0    
	
## Detailed Table Properties Information
|SORT_COLUMNS             |name,id
|NO_INVERTED_INDEX        |id
|DICTIONARY_INCLUDE       |name
|TABLE_BLOCKSIZE          |1024 MB 
|SORT_SCOPE               |LOCAL_SORT 
|STREAMING                |false 

## Detailed Partition Information
|PARTITION_COLUMNS        |city

## Location Path

## As Select_statement


Regards
Liang


xm_zzc wrote
> Hi dev:
>   Currently the 'comment' content for column is ambiguous and unclear when
> execute command 'desc formatted table_name', for example:
>   ran create table sql:
>   CREATE TABLE IF NOT EXISTS test_table (
>     id INT,
>     name STRING,
>     city STRING,
>     salary LONG,
>     tax DOUBLE
>     )
>     STORED BY 'carbondata'
>     TBLPROPERTIES(
>     'streaming'='false', 'sort_columns'='name,id',
> 'dictionary_include'='name');
>     
>   and then ran 'desc formatted test_table', it showed the content below:
>   |col_name  |data_type     |comment                                     |
>   +----------+--------------+--------------------------------------------+
>   |id            |int                |
*
> KEY COLUMN,NOINVERTEDINDEX
*
> ,null             |
>   |name      |string            |DICTIONARY, 
*
> KEY COLUMN
*
> ,null                 |
>   |city         |string            |
*
> KEY COLUMN
*
> ,null                             |
>   |salary     |bigint             |MEASURE,null                               
> |
>   |tax         |double            |MEASURE,null                               
> |
>   |          |              |                                            |
>   
>   1. what's the 'KEY COLUMN' mean? all document do not describe this
> concept, just introduce dimension column, measure column, inverted index,
> dictionary column and so on.
>   2. Actually 'city' field is just a dimension column and does not have
> inverted index, but 'id', 'name' and 'city' field are shown as 'KEY
> COLUMN',
> how to distinguish between them?
>   
>   So IMO, We can show more detailed information on 'comment' column and
> remove 'KEY COLUMN' description, for example:
>   run 'desc formatted test_table', it can show the content below:
>   |col_name  |data_type     |comment                                     |
>   +----------+--------------+--------------------------------------------+
>   |id            |int               |
*
> DIMENSION,NOINVERTEDINDEX
*
> ,null              |
>   |name      |string           |
*
> DIMENSION,DICTIONARY,INVERTEDINDEX
*
> ,null     |
>   |city         |string           |
*
> DIMENSION
*
> ,null                              |
>   |salary     |bigint            |MEASURE,null                               
> |
>   |tax         |double           |MEASURE,null                               
> |
>   |          |              |                                            |
>   
>   How about this change? Any suggestion for this? Please let me know.
> 
> 
> 
> 
> --
> Sent from:
> http://apache-carbondata-dev-mailing-list-archive.1130556.n5.nabble.com/





--
Sent from: http://apache-carbondata-dev-mailing-list-archive.1130556.n5.nabble.com/

Re: Change the 'comment' content for column when execute command 'desc formatted table_name'

Posted by Liang Chen <ch...@gmail.com>.
Hi Ravi

Good thinking.

Because the inverted index columns by default are the same as sort_column
columns,  from the user perspective, he only need to set no_inverted_index
columns in sort_column columns,  so i proposed to display only the
no_inverted_index columns info which be set by user.

Anyway, in "data management on carbondata" need to update the info: inverted
index columns by default be enabled along with sort_columns....

Regards
Liang


ravipesala wrote
> I agree with Liang's suggestion to align the information with table
> schema. And I have one suggestion related to NO_INVERTED_INDEX , instead
> of mentioning no inverted index columns better mention which are inverted
> index columns. It is very hard user to understand which are inverted index
> columns and it is useful if we change our default behaviour of selecting
> index columns if we provide this information to table describe command.
> Regards,
> Ravindra.
> 
> Sent from Mailspring (https://link.getmailspring.com/link/

> 1524723947.local-c273b69b-15c2-v1.2.1-7e7447b6@

> /0?redirect=https%3A%2F%2Fgetmailspring.com%2F&recipient=ZGV2QGNhcmJvbmRhdGEuYXBhY2hlLm9yZw%3D%3D),
> the best free email app for work
> On Apr 26 2018, at 10:34 am, manishgupta88 &lt;

> tomanishgupta18@

> &gt; wrote:
>>
>> I agree with Liang. We can modify the complete describe formatted command
>> display and show the detailed information as suggested by Liang.
>> Liang we can make a small change in your suggestion. As we are displaying
>> the information to the user we should not include Underscore(_) in the
>> property names and in place of DICTIONARY_INCLUDE and DICTIONARY_EXCLUDE
>> we
>> can just say Dictionary columns and No Dictionary Columns.
>>
>> ## Detailed Table Properties Information
>> |Sort Columns |name,id
>> |No Inverted Index |id
>> |Dictionary Columns |name
>> |Table BlockSize |1024 MB
>> |Sort Scope |LOCAL_SORT
>> |Streaming |false
>>
>> Regards
>> Manish Gupta
>>
>>
>>
>> --
>> Sent from:
>> http://apache-carbondata-dev-mailing-list-archive.1130556.n5.nabble.com/
>>





--
Sent from: http://apache-carbondata-dev-mailing-list-archive.1130556.n5.nabble.com/

Re: Change the 'comment' content for column when execute command 'desc formatted table_name'

Posted by Ravindra Pesala <ra...@gmail.com>.
I agree with Liang's suggestion to align the information with table schema. And I have one suggestion related to NO_INVERTED_INDEX , instead of mentioning no inverted index columns better mention which are inverted index columns. It is very hard user to understand which are inverted index columns and it is useful if we change our default behaviour of selecting index columns if we provide this information to table describe command.
Regards,
Ravindra.

Sent from Mailspring (https://link.getmailspring.com/link/1524723947.local-c273b69b-15c2-v1.2.1-7e7447b6@getmailspring.com/0?redirect=https%3A%2F%2Fgetmailspring.com%2F&recipient=ZGV2QGNhcmJvbmRhdGEuYXBhY2hlLm9yZw%3D%3D), the best free email app for work
On Apr 26 2018, at 10:34 am, manishgupta88 <to...@gmail.com> wrote:
>
> I agree with Liang. We can modify the complete describe formatted command
> display and show the detailed information as suggested by Liang.
> Liang we can make a small change in your suggestion. As we are displaying
> the information to the user we should not include Underscore(_) in the
> property names and in place of DICTIONARY_INCLUDE and DICTIONARY_EXCLUDE we
> can just say Dictionary columns and No Dictionary Columns.
>
> ## Detailed Table Properties Information
> |Sort Columns |name,id
> |No Inverted Index |id
> |Dictionary Columns |name
> |Table BlockSize |1024 MB
> |Sort Scope |LOCAL_SORT
> |Streaming |false
>
> Regards
> Manish Gupta
>
>
>
> --
> Sent from: http://apache-carbondata-dev-mailing-list-archive.1130556.n5.nabble.com/
>

Re: Change the 'comment' content for column when execute command 'desc formatted table_name'

Posted by xm_zzc <44...@qq.com>.
please see:
http://apache-carbondata-dev-mailing-list-archive.1130556.n5.nabble.com/file/t1/desc_table_info.txt



--
Sent from: http://apache-carbondata-dev-mailing-list-archive.1130556.n5.nabble.com/

Re: Change the 'comment' content for column when execute command 'desc formatted table_name'

Posted by xuchuanyin <xu...@hust.edu.cn>.
Then what's the final output looks like?



--
Sent from: http://apache-carbondata-dev-mailing-list-archive.1130556.n5.nabble.com/

Re: Change the 'comment' content for column when execute command 'desc formatted table_name'

Posted by xm_zzc <44...@qq.com>.
hi, xuchuanyin: 
  I can raise a pr for this change in a few days.



--
Sent from: http://apache-carbondata-dev-mailing-list-archive.1130556.n5.nabble.com/

Re: Change the 'comment' content for column when execute command 'desc formatted table_name'

Posted by xuchuanyin <xu...@hust.edu.cn>.
How is this going?
Who can make a final conclusion?



--
Sent from: http://apache-carbondata-dev-mailing-list-archive.1130556.n5.nabble.com/

Re: Change the 'comment' content for column when execute command 'desc formatted table_name'

Posted by xm_zzc <44...@qq.com>.
Hi Jacky:
  OK, I have uploaded attachments to CARBONDATA-2595: 
https://issues.apache.org/jira/browse/CARBONDATA-2595
<https://issues.apache.org/jira/browse/CARBONDATA-2595>  , please take a
look.



--
Sent from: http://apache-carbondata-dev-mailing-list-archive.1130556.n5.nabble.com/

Re: Change the 'comment' content for column when execute command 'desc formatted table_name'

Posted by Jacky Li <ja...@qq.com>.
Hi ZZC,

Can you create a JIRA ticket and upload the design doc, in mail list we can not get the attachment

Regards,
Jacky

> 在 2018年8月20日，上午11:20，xm_zzc <44...@qq.com> 写道：
> 
> Hi dev:
>  Now I am working on this, the new format is shown in attachment, please
> give me some feedback.
>  There is one question: if user uses CTAS to create table, do we need to
> show the 'select sql' in the result of 'desc formatted table'? If yes, how
> to get 'select sql'? now I just can get a non-formatted sql from
> 'CarbonSparkSqlParser.scala' (Jacky mentioned), for example:
> 
> *CREATE TABLE IF NOT EXISTS test_table
> STORED BY 'carbondata'
> TBLPROPERTIES(
> 'streaming'='false', 'sort_columns'='id,city', 'dictionary_include'='name')
> AS SELECT * from source_test ;*
> 
> The non-formatted sql I get is :
> *SELECT*fromsource_test*
> 
> desc_formatted.txt
> <http://apache-carbondata-dev-mailing-list-archive.1130556.n5.nabble.com/file/t133/desc_formatted.txt>  
> desc_formatted_external.txt
> <http://apache-carbondata-dev-mailing-list-archive.1130556.n5.nabble.com/file/t133/desc_formatted_external.txt>  
> 
> 
> 
> 
> 
> 
> --
> Sent from: http://apache-carbondata-dev-mailing-list-archive.1130556.n5.nabble.com/
>

Re: Change the 'comment' content for column when execute command 'desc formatted table_name'

Posted by xm_zzc <44...@qq.com>.
Hi all:
  Got it, thanks for your suggestions, I will implement this and raise a pr.



--
Sent from: http://apache-carbondata-dev-mailing-list-archive.1130556.n5.nabble.com/

Re: Change the 'comment' content for column when execute command 'desc formatted table_name'

Posted by Ravindra Pesala <ra...@gmail.com>.
Yes, I agree with Liang. We no need to consider showing sql in describe
table in case of CTAS.

Regards
Ravindra

On Tue, 21 Aug 2018 at 20:47, Raghunandan S <
carbondatacontributions@gmail.com> wrote:

> Hi,
> In opinion it is not required to show the original select sql. Also is
> there a way to get it? I don't think it can be got.
>
>
> Regards
> Raghu
>
> On Tue, 21 Aug 2018, 8:02 pm Liang Chen, <ch...@gmail.com> wrote:
>
> > Hi
> >
> > 1. Agree with likun's comments(4 points) :
> >
> > 2. About 'select sql' for CTAS , you can leave it. we can consider it
> > later.
> >
> > Regards
> > Liang
> >
> > Jacky Li wrote
> > > Hi ZZC,
> > >
> > > I have checked the doc in CARBONDATA-2595. I have following comments:
> > > 1. In the Table Basic Information section, it is better to print the
> > Table
> > > Path instead of "CARBON Store Path”
> > > 2. For the Table Data Size  and Index Size, can you format the output
> in
> > > GB, MB, KB, etc
> > > 3. For the Last Update Time, can you format the output in UTC time like
> > > YYYY-MM-DD hh:mm:ss
> > > 4. In table property, I think maybe some properties are missing, like
> > > block size, blocklet size, long string
> > >
> > > For implementation, I suggest to write the main logic of collecting
> these
> > > information in java so that it is easier to write tools for it. One
> tool
> > > can be this SQL command and another tool I can think of is an
> standalone
> > > java executable that  can print these information on the screen by
> > reading
> > > the given table path. (We can put this standalone tool in SDK module)
> > >
> > > Regards,
> > > Jacky
> > >
> > >
> > >> 在 2018年8月20日，上午11:20，xm_zzc <
> >
> > > 441586683@
> >
> > >> 写道：
> > >>
> > >> Hi dev:
> > >>  Now I am working on this, the new format is shown in attachment,
> please
> > >> give me some feedback.
> > >>  There is one question: if user uses CTAS to create table, do we need
> to
> > >> show the 'select sql' in the result of 'desc formatted table'? If yes,
> > >> how
> > >> to get 'select sql'? now I just can get a non-formatted sql from
> > >> 'CarbonSparkSqlParser.scala' (Jacky mentioned), for example:
> > >>
> > >> *CREATE TABLE IF NOT EXISTS test_table
> > >> STORED BY 'carbondata'
> > >> TBLPROPERTIES(
> > >> 'streaming'='false', 'sort_columns'='id,city',
> > >> 'dictionary_include'='name')
> > >> AS SELECT * from source_test ;*
> > >>
> > >> The non-formatted sql I get is :
> > >> *SELECT*fromsource_test*
> > >>
> > >> desc_formatted.txt
> > >> &lt;
> >
> http://apache-carbondata-dev-mailing-list-archive.1130556.n5.nabble.com/file/t133/desc_formatted.txt&gt
> ;
> >
> > >> desc_formatted_external.txt
> > >> &lt;
> >
> http://apache-carbondata-dev-mailing-list-archive.1130556.n5.nabble.com/file/t133/desc_formatted_external.txt&gt
> ;
> >
> > >>
> > >>
> > >>
> > >>
> > >>
> > >>
> > >> --
> > >> Sent from:
> > >>
> > http://apache-carbondata-dev-mailing-list-archive.1130556.n5.nabble.com/
> > >>
> >
> >
> >
> >
> >
> > --
> > Sent from:
> > http://apache-carbondata-dev-mailing-list-archive.1130556.n5.nabble.com/
> >
>


-- 
Thanks & Regards,
Ravi

Re: Change the 'comment' content for column when execute command 'desc formatted table_name'

Posted by Raghunandan S <ca...@gmail.com>.
Hi,
In opinion it is not required to show the original select sql. Also is
there a way to get it? I don't think it can be got.


Regards
Raghu

On Tue, 21 Aug 2018, 8:02 pm Liang Chen, <ch...@gmail.com> wrote:

> Hi
>
> 1. Agree with likun's comments(4 points) :
>
> 2. About 'select sql' for CTAS , you can leave it. we can consider it
> later.
>
> Regards
> Liang
>
> Jacky Li wrote
> > Hi ZZC,
> >
> > I have checked the doc in CARBONDATA-2595. I have following comments:
> > 1. In the Table Basic Information section, it is better to print the
> Table
> > Path instead of "CARBON Store Path”
> > 2. For the Table Data Size  and Index Size, can you format the output in
> > GB, MB, KB, etc
> > 3. For the Last Update Time, can you format the output in UTC time like
> > YYYY-MM-DD hh:mm:ss
> > 4. In table property, I think maybe some properties are missing, like
> > block size, blocklet size, long string
> >
> > For implementation, I suggest to write the main logic of collecting these
> > information in java so that it is easier to write tools for it. One tool
> > can be this SQL command and another tool I can think of is an standalone
> > java executable that  can print these information on the screen by
> reading
> > the given table path. (We can put this standalone tool in SDK module)
> >
> > Regards,
> > Jacky
> >
> >
> >> 在 2018年8月20日，上午11:20，xm_zzc <
>
> > 441586683@
>
> >> 写道：
> >>
> >> Hi dev:
> >>  Now I am working on this, the new format is shown in attachment, please
> >> give me some feedback.
> >>  There is one question: if user uses CTAS to create table, do we need to
> >> show the 'select sql' in the result of 'desc formatted table'? If yes,
> >> how
> >> to get 'select sql'? now I just can get a non-formatted sql from
> >> 'CarbonSparkSqlParser.scala' (Jacky mentioned), for example:
> >>
> >> *CREATE TABLE IF NOT EXISTS test_table
> >> STORED BY 'carbondata'
> >> TBLPROPERTIES(
> >> 'streaming'='false', 'sort_columns'='id,city',
> >> 'dictionary_include'='name')
> >> AS SELECT * from source_test ;*
> >>
> >> The non-formatted sql I get is :
> >> *SELECT*fromsource_test*
> >>
> >> desc_formatted.txt
> >> &lt;
> http://apache-carbondata-dev-mailing-list-archive.1130556.n5.nabble.com/file/t133/desc_formatted.txt&gt;
>
> >> desc_formatted_external.txt
> >> &lt;
> http://apache-carbondata-dev-mailing-list-archive.1130556.n5.nabble.com/file/t133/desc_formatted_external.txt&gt;
>
> >>
> >>
> >>
> >>
> >>
> >>
> >> --
> >> Sent from:
> >>
> http://apache-carbondata-dev-mailing-list-archive.1130556.n5.nabble.com/
> >>
>
>
>
>
>
> --
> Sent from:
> http://apache-carbondata-dev-mailing-list-archive.1130556.n5.nabble.com/
>

Re: Change the 'comment' content for column when execute command 'desc formatted table_name'

Posted by Liang Chen <ch...@gmail.com>.
Hi

1. Agree with likun's comments(4 points) : 

2. About 'select sql' for CTAS , you can leave it. we can consider it later.

Regards
Liang

Jacky Li wrote
> Hi ZZC,
> 
> I have checked the doc in CARBONDATA-2595. I have following comments:
> 1. In the Table Basic Information section, it is better to print the Table
> Path instead of "CARBON Store Path”
> 2. For the Table Data Size  and Index Size, can you format the output in
> GB, MB, KB, etc
> 3. For the Last Update Time, can you format the output in UTC time like
> YYYY-MM-DD hh:mm:ss
> 4. In table property, I think maybe some properties are missing, like
> block size, blocklet size, long string
> 
> For implementation, I suggest to write the main logic of collecting these
> information in java so that it is easier to write tools for it. One tool
> can be this SQL command and another tool I can think of is an standalone
> java executable that  can print these information on the screen by reading
> the given table path. (We can put this standalone tool in SDK module)
> 
> Regards,
> Jacky
> 
> 
>> 在 2018年8月20日，上午11:20，xm_zzc <

> 441586683@

>> 写道：
>> 
>> Hi dev:
>>  Now I am working on this, the new format is shown in attachment, please
>> give me some feedback.
>>  There is one question: if user uses CTAS to create table, do we need to
>> show the 'select sql' in the result of 'desc formatted table'? If yes,
>> how
>> to get 'select sql'? now I just can get a non-formatted sql from
>> 'CarbonSparkSqlParser.scala' (Jacky mentioned), for example:
>> 
>> *CREATE TABLE IF NOT EXISTS test_table
>> STORED BY 'carbondata'
>> TBLPROPERTIES(
>> 'streaming'='false', 'sort_columns'='id,city',
>> 'dictionary_include'='name')
>> AS SELECT * from source_test ;*
>> 
>> The non-formatted sql I get is :
>> *SELECT*fromsource_test*
>> 
>> desc_formatted.txt
>> &lt;http://apache-carbondata-dev-mailing-list-archive.1130556.n5.nabble.com/file/t133/desc_formatted.txt&gt;  
>> desc_formatted_external.txt
>> &lt;http://apache-carbondata-dev-mailing-list-archive.1130556.n5.nabble.com/file/t133/desc_formatted_external.txt&gt;  
>> 
>> 
>> 
>> 
>> 
>> 
>> --
>> Sent from:
>> http://apache-carbondata-dev-mailing-list-archive.1130556.n5.nabble.com/
>>





--
Sent from: http://apache-carbondata-dev-mailing-list-archive.1130556.n5.nabble.com/

Re: Change the 'comment' content for column when execute command 'desc formatted table_name'

Posted by Jacky Li <ja...@qq.com>.
Hi ZZC,

I have checked the doc in CARBONDATA-2595. I have following comments:
1. In the Table Basic Information section, it is better to print the Table Path instead of "CARBON Store Path”
2. For the Table Data Size  and Index Size, can you format the output in GB, MB, KB, etc
3. For the Last Update Time, can you format the output in UTC time like YYYY-MM-DD hh:mm:ss
4. In table property, I think maybe some properties are missing, like block size, blocklet size, long string

For implementation, I suggest to write the main logic of collecting these information in java so that it is easier to write tools for it. One tool can be this SQL command and another tool I can think of is an standalone java executable that  can print these information on the screen by reading the given table path. (We can put this standalone tool in SDK module)

Regards,
Jacky


> 在 2018年8月20日，上午11:20，xm_zzc <44...@qq.com> 写道：
> 
> Hi dev:
>  Now I am working on this, the new format is shown in attachment, please
> give me some feedback.
>  There is one question: if user uses CTAS to create table, do we need to
> show the 'select sql' in the result of 'desc formatted table'? If yes, how
> to get 'select sql'? now I just can get a non-formatted sql from
> 'CarbonSparkSqlParser.scala' (Jacky mentioned), for example:
> 
> *CREATE TABLE IF NOT EXISTS test_table
> STORED BY 'carbondata'
> TBLPROPERTIES(
> 'streaming'='false', 'sort_columns'='id,city', 'dictionary_include'='name')
> AS SELECT * from source_test ;*
> 
> The non-formatted sql I get is :
> *SELECT*fromsource_test*
> 
> desc_formatted.txt
> <http://apache-carbondata-dev-mailing-list-archive.1130556.n5.nabble.com/file/t133/desc_formatted.txt>  
> desc_formatted_external.txt
> <http://apache-carbondata-dev-mailing-list-archive.1130556.n5.nabble.com/file/t133/desc_formatted_external.txt>  
> 
> 
> 
> 
> 
> 
> --
> Sent from: http://apache-carbondata-dev-mailing-list-archive.1130556.n5.nabble.com/
>

Re: Change the 'comment' content for column when execute command 'desc formatted table_name'

Posted by xm_zzc <44...@qq.com>.
Hi dev:
  Now I am working on this, the new format is shown in attachment, please
give me some feedback.
  There is one question: if user uses CTAS to create table, do we need to
show the 'select sql' in the result of 'desc formatted table'? If yes, how
to get 'select sql'? now I just can get a non-formatted sql from
'CarbonSparkSqlParser.scala' (Jacky mentioned), for example:

*CREATE TABLE IF NOT EXISTS test_table
STORED BY 'carbondata'
TBLPROPERTIES(
'streaming'='false', 'sort_columns'='id,city', 'dictionary_include'='name')
AS SELECT * from source_test ;*

The non-formatted sql I get is :
*SELECT*fromsource_test*

desc_formatted.txt
<http://apache-carbondata-dev-mailing-list-archive.1130556.n5.nabble.com/file/t133/desc_formatted.txt>  
desc_formatted_external.txt
<http://apache-carbondata-dev-mailing-list-archive.1130556.n5.nabble.com/file/t133/desc_formatted_external.txt>  






--
Sent from: http://apache-carbondata-dev-mailing-list-archive.1130556.n5.nabble.com/

Re: Change the 'comment' content for column when execute command 'desc formatted table_name'

Posted by Jacky Li <ja...@qq.com>.

> 在 2018年4月26日，下午1:04，manishgupta88 <to...@gmail.com> 写道：
> 
> I agree with Liang. We can modify the complete describe formatted command
> display and show the detailed information as suggested by Liang.
> Liang we can make a small change in your suggestion. As we are displaying
> the information to the user we should not include Underscore(_) in the
> property names and in place of DICTIONARY_INCLUDE and DICTIONARY_EXCLUDE we
> can just say Dictionary columns and No Dictionary Columns.
> 

Likun:  I think it is better to print the table property name and value as it is defined by the user, and only the table properties should be print in a proper order, for example:
Sort related: SORT_COLUMNS, SORT_SCOPE
Encoding related: DICTIONARY_INCLUDE, NO_INVERTED_INDEX
Other properties: TABLE_BLOCKSIZE, STREAMING, etc

> ## Detailed Table Properties Information 
> |Sort Columns             |name,id 
> |No Inverted Index      |id 
> |Dictionary Columns    |name 
> |Table BlockSize          |1024 MB 
> |Sort Scope                |LOCAL_SORT 
> |Streaming                 |false 
> 
> Regards
> Manish Gupta
> 
> 
> --
> Sent from: http://apache-carbondata-dev-mailing-list-archive.1130556.n5.nabble.com/

Re: Change the 'comment' content for column when execute command 'desc formatted table_name'

Posted by manishgupta88 <to...@gmail.com>.
I agree with Liang. We can modify the complete describe formatted command
display and show the detailed information as suggested by Liang.
Liang we can make a small change in your suggestion. As we are displaying
the information to the user we should not include Underscore(_) in the
property names and in place of DICTIONARY_INCLUDE and DICTIONARY_EXCLUDE we
can just say Dictionary columns and No Dictionary Columns.

## Detailed Table Properties Information 
|Sort Columns             |name,id 
|No Inverted Index      |id 
|Dictionary Columns    |name 
|Table BlockSize          |1024 MB 
|Sort Scope                |LOCAL_SORT 
|Streaming                 |false 

Regards
Manish Gupta



--
Sent from: http://apache-carbondata-dev-mailing-list-archive.1130556.n5.nabble.com/

Re: Change the 'comment' content for column when execute command 'desc formatted table_name'

Posted by Venkata Gollamudi <g....@gmail.com>.
I agree with Liang, Better we align with create table terminology and
properties. Details of properties, user can easily get from Create table
DDL documentation.

Regards,
Ramana

On Thu, Apr 26, 2018 at 8:17 AM, Liang Chen <ch...@gmail.com> wrote:

> Hi
>
> Attaching my proposed "desc_table_info":
> desc_table_info.txt
> <http://apache-carbondata-dev-mailing-list-archive.1130556.
> n5.nabble.com/file/t1/desc_table_info.txt>
>
> Regards
> Liang
>
>
>
> --
> Sent from: http://apache-carbondata-dev-mailing-list-archive.1130556.
> n5.nabble.com/
>

Re: Change the 'comment' content for column when execute command 'desc formatted table_name'

Posted by Liang Chen <ch...@gmail.com>.
Hi

Attaching my proposed "desc_table_info":
desc_table_info.txt
<http://apache-carbondata-dev-mailing-list-archive.1130556.n5.nabble.com/file/t1/desc_table_info.txt>  

Regards
Liang



--
Sent from: http://apache-carbondata-dev-mailing-list-archive.1130556.n5.nabble.com/

Re: Change the 'comment' content for column when execute command 'desc formatted table_name'

Posted by Jacky Li <ja...@qq.com>.
The example is missing in my last mail, now I have put the example in 
CARBONDATA-3087 <https://issues.apache.org/jira/browse/CARBONDATA-3087>  ,
please go to the JIRA and reply if you have any comment

Regards,
Jacky



--
Sent from: http://apache-carbondata-dev-mailing-list-archive.1130556.n5.nabble.com/

Re: Change the 'comment' content for column when execute command 'desc formatted table_name'

Posted by Jacky Li <ja...@qq.com>.
Hi,

I revisit this discussion again, and suggest to change the DESC FORMATTED
output to following:



The information is outline in 6 sections:
1. Table basic information
2. Index information
3. Encoding information
4. Compaction information
5. Partition information (only for partition table)
6. Dynamic information

Please check whether it contains enough information of your preference, I
will create a JIRA and PR soon. 

Regards,
Jacky



--
Sent from: http://apache-carbondata-dev-mailing-list-archive.1130556.n5.nabble.com/

Re: Change the 'comment' content for column when execute command 'desc formatted table_name'

Posted by Jacky Li <ja...@qq.com>.
I think for all table property that documented in  https://github.com/apache/carbondata/blob/master/docs/ddl-of-carbondata.md <https://github.com/apache/carbondata/blob/master/docs/ddl-of-carbondata.md>, we should write their values in the schema file. 
Because the default value for these properties may change, if they are changes, user will not know what is the table property that was used when writing the file.

Regards,
Jacky Li


> 在 2018年10月8日，上午12:20，xm_zzc <44...@qq.com> 写道：
> 
> Hi:
>  I agree with Jacky. 
>  Currently if i use the default value of blocklet size (64mb) to create a
> table and load some data into table, and then change the default value of
> blocklet size to 128mb, it will affect the table created before, is it
> right? I think it still need to use 64mb as blocklet size for tables created
> before.
> 
> These properties either specified by user or from default value need to be
> saved when create table:
> property                                                value        default
> value
> |Blocklet Size                                       |64 MB      |64 MB     
> |
> |Table Block Size                                  |1024 MB    |1024 MB    |
> |SORT_SCOPE                                      |LOCAL_SORT |LOCAL_SORT |
> |CACHE_LEVEL                                     |BLOCKLET   |BLOCK      |
> |AUTO_LOAD_MERGE                            |true       |false      |
> |COMPACTION_LEVEL_THRESHOLD        |2,8        |4,3        |
> |COMPACTION_PRESERVE_SEGMENTS    |0          |0          |
> |ALLOWED_COMPACTION_DAYS             |0          |0          |
> |MAJOR_COMPACTION_SIZE                  |3072 MB    |1024 MB    |
> |Local Dictionary Enabled                       |false      |false      |
> 
> Hi Jacky:
>  I think we need to refactor CarbonCli module and move some common tools to
> core module, and then CarbonCli module and Spark2 module can use them,
> right?
> 
> 
> 
> 
> --
> Sent from: http://apache-carbondata-dev-mailing-list-archive.1130556.n5.nabble.com/
>

Re: Change the 'comment' content for column when execute command 'desc formatted table_name'

Posted by xm_zzc <44...@qq.com>.
Hi:
  I agree with Jacky. 
  Currently if i use the default value of blocklet size (64mb) to create a
table and load some data into table, and then change the default value of
blocklet size to 128mb, it will affect the table created before, is it
right? I think it still need to use 64mb as blocklet size for tables created
before.

These properties either specified by user or from default value need to be
saved when create table:
property                                                value        default
value
|Blocklet Size                                       |64 MB      |64 MB     
|
|Table Block Size                                  |1024 MB    |1024 MB    |
|SORT_SCOPE                                      |LOCAL_SORT |LOCAL_SORT |
|CACHE_LEVEL                                     |BLOCKLET   |BLOCK      |
|AUTO_LOAD_MERGE                            |true       |false      |
|COMPACTION_LEVEL_THRESHOLD        |2,8        |4,3        |
|COMPACTION_PRESERVE_SEGMENTS    |0          |0          |
|ALLOWED_COMPACTION_DAYS             |0          |0          |
|MAJOR_COMPACTION_SIZE                  |3072 MB    |1024 MB    |
|Local Dictionary Enabled                       |false      |false      |

Hi Jacky:
  I think we need to refactor CarbonCli module and move some common tools to
core module, and then CarbonCli module and Spark2 module can use them,
right?




--
Sent from: http://apache-carbondata-dev-mailing-list-archive.1130556.n5.nabble.com/

Re: Change the 'comment' content for column when execute command 'desc formatted table_name'

Posted by Jacky Li <ja...@qq.com>.
Looking at the DESC FORMATTED command again, I still feel it is not very
clear for the table property section. 
For table properties, I think it is not very good for DESC command to print
the default value if the user does not specify when creating the table.
Because the default value in CarbonCommonConstain file may change from
version to version, I think it is better to always write the default value
to table property (in schema file) when loading the table. Then in DESC
table, we can always get the table properties from the schema file. 

So I suggest we do following:
1. categorize the properties into file level, table level, system level
2. write the file level property into data file's footer, including all file
level properties either specified by user or from default value.
3. write the table level property into schema file, including all table
level properties either specified by user or from default value.
4. DESC command should print the properties read from the schema file, which
should contain all table level properties.

Another suggestion is that besides just printing the schema and table
properties like the standard hive DESC command, we can introduce another
command to print the output from calling CarbonCli tool for more profiling
and debugging information, like writing how many files the table contains,
what is the average size of page/blocklet, min/max percentage etc. For
example, the syntax of this command can be "SUMMARY table_name" 

Regards,
Jacky



--
Sent from: http://apache-carbondata-dev-mailing-list-archive.1130556.n5.nabble.com/