[GitHub] [airflow] mik-laj commented on a change in pull request #10329: More fancy environment checking

[GitBox <gi...@apache.org>]

mik-laj commented on a change in pull request #10329:
URL: https://github.com/apache/airflow/pull/10329#discussion_r470920057



##########
File path: scripts/ci/in_container/check_environment.sh
##########
@@ -131,34 +119,21 @@ function resetdb_if_requested() {
     return $?
 }
 
-if [[ -n ${BACKEND:=} ]]; then
-    echo "==============================================================================================="
-    echo "             Checking backend: ${BACKEND}"
-    echo "==============================================================================================="
 
-    set +e
+echo "==============================================================================================="
+echo "             Checking integrations and backends"
+echo "==============================================================================================="
+if [[ -n ${BACKEND:=} ]]; then

Review comment:
       I don't think it is like you say. This function communicates through a global variable - EXIT_CODE, not "real" exit codes. We can clean up some code in this file to make it clearer. Thanks for comment.
   




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org