You are viewing a plain text version of this content. The canonical link for it is here.
Posted to xap-dev@incubator.apache.org by "James Margaris (JIRA)" <xa...@incubator.apache.org> on 2007/03/22 00:04:32 UTC

[jira] Created: (XAP-344) Should support a passthrough mechanism for setting up css classes on components

Should support a passthrough mechanism for setting up css classes on components
-------------------------------------------------------------------------------

                 Key: XAP-344
                 URL: https://issues.apache.org/jira/browse/XAP-344
             Project: XAP
          Issue Type: New Feature
          Components: Widgets
            Reporter: James Margaris
         Assigned To: Turyn, Michael


Right now there is no good way to assign custom classes to widgets. I propose:

1. All xal elements should support the class attribute which is a space-separated list of classes. 

2. For each entry in the attribute we should assign that entry to the base HTML container node/ root dom node. (Simply pass through to the underlying HTML tag)

3. In addition we want to support the various style states. So if they have a class called myClass we should automatically adjust that to myClassMouseOver the same way we do for built-in classes. Currently we have logic in AbstractWidgetBridge that will automatically change the class attribute to different permuations of the tag name, like "buttonMouseOver", "buttonMouseDown", etc. We should allow user-defined classes to use the same process and automatically add/remove state-specific permutations with mouse events.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Closed: (XAP-344) Should support a passthrough mechanism for setting up css classes on components

Posted by "Trevor Oldak (JIRA)" <xa...@incubator.apache.org>.
     [ https://issues.apache.org/jira/browse/XAP-344?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Trevor Oldak closed XAP-344.
----------------------------


> Should support a passthrough mechanism for setting up css classes on components
> -------------------------------------------------------------------------------
>
>                 Key: XAP-344
>                 URL: https://issues.apache.org/jira/browse/XAP-344
>             Project: XAP
>          Issue Type: New Feature
>          Components: Widgets: Other
>            Reporter: James Margaris
>            Assignee: Turyn, Michael
>
> Right now there is no good way to assign custom classes to widgets. I propose:
> 1. All xal elements should support the class attribute which is a space-separated list of classes. 
> 2. For each entry in the attribute we should assign that entry to the base HTML container node/ root dom node. (Simply pass through to the underlying HTML tag)
> 3. In addition we want to support the various style states. So if they have a class called myClass we should automatically adjust that to myClassMouseOver the same way we do for built-in classes. Currently we have logic in AbstractWidgetBridge that will automatically change the class attribute to different permuations of the tag name, like "buttonMouseOver", "buttonMouseDown", etc. We should allow user-defined classes to use the same process and automatically add/remove state-specific permutations with mouse events.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Commented: (XAP-344) Should support a passthrough mechanism for setting up css classes on components

Posted by "Turyn, Michael (JIRA)" <xa...@incubator.apache.org>.
    [ https://issues.apache.org/jira/browse/XAP-344?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12493572 ] 

Turyn, Michael commented on XAP-344:
------------------------------------

The node-map stuff is in there; it turned out to be easier to do it that way for LabelBridge and VerticalSplitPaneBridge.  To use it, override the default method  "getStylingNodesMap() ":
xap.bridges.basic.AbstractWidgetBridge.prototype.getStylingNodesMap = function(){
	if( ! this._stylingNodeMap ){
		this._stylingNodeMap = {"": this.getRootDomNode()} ;
	}
	return this._stylingNodeMap ;
}

...so that the method adds other string/node pairs.

> Should support a passthrough mechanism for setting up css classes on components
> -------------------------------------------------------------------------------
>
>                 Key: XAP-344
>                 URL: https://issues.apache.org/jira/browse/XAP-344
>             Project: XAP
>          Issue Type: New Feature
>          Components: Widgets: Other
>            Reporter: James Margaris
>         Assigned To: Turyn, Michael
>
> Right now there is no good way to assign custom classes to widgets. I propose:
> 1. All xal elements should support the class attribute which is a space-separated list of classes. 
> 2. For each entry in the attribute we should assign that entry to the base HTML container node/ root dom node. (Simply pass through to the underlying HTML tag)
> 3. In addition we want to support the various style states. So if they have a class called myClass we should automatically adjust that to myClassMouseOver the same way we do for built-in classes. Currently we have logic in AbstractWidgetBridge that will automatically change the class attribute to different permuations of the tag name, like "buttonMouseOver", "buttonMouseDown", etc. We should allow user-defined classes to use the same process and automatically add/remove state-specific permutations with mouse events.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Resolved: (XAP-344) Should support a passthrough mechanism for setting up css classes on components

Posted by "Turyn, Michael (JIRA)" <xa...@incubator.apache.org>.
     [ https://issues.apache.org/jira/browse/XAP-344?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Turyn, Michael resolved XAP-344.
--------------------------------

    Resolution: Fixed

See comments.

> Should support a passthrough mechanism for setting up css classes on components
> -------------------------------------------------------------------------------
>
>                 Key: XAP-344
>                 URL: https://issues.apache.org/jira/browse/XAP-344
>             Project: XAP
>          Issue Type: New Feature
>          Components: Widgets: Other
>            Reporter: James Margaris
>         Assigned To: Turyn, Michael
>
> Right now there is no good way to assign custom classes to widgets. I propose:
> 1. All xal elements should support the class attribute which is a space-separated list of classes. 
> 2. For each entry in the attribute we should assign that entry to the base HTML container node/ root dom node. (Simply pass through to the underlying HTML tag)
> 3. In addition we want to support the various style states. So if they have a class called myClass we should automatically adjust that to myClassMouseOver the same way we do for built-in classes. Currently we have logic in AbstractWidgetBridge that will automatically change the class attribute to different permuations of the tag name, like "buttonMouseOver", "buttonMouseDown", etc. We should allow user-defined classes to use the same process and automatically add/remove state-specific permutations with mouse events.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Commented: (XAP-344) Should support a passthrough mechanism for setting up css classes on components

Posted by "Turyn, Michael (JIRA)" <xa...@incubator.apache.org>.
    [ https://issues.apache.org/jira/browse/XAP-344?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12483181 ] 

Turyn, Michael commented on XAP-344:
------------------------------------

Widget styling may depend on more than one html dom node's styling---for example, we might want a header to be grey with a solid black border, the content panel to be inset and  rgb(255,255,240), ahd the enclosing node (rootDomNode in our parlance) to have a ridged border.

I would suggest that <em>eventually</em> we go to a more complicated system that  will map to named nodes in the widget, so that we can apply (e.g.):
                myWidget-footerMouseOver
                myWidget-clientMouseOver
                myWidgetMouseOver
...where the last still applies to the enclosing dom node.

Eventually; for now let's don't over-complicate.

> Should support a passthrough mechanism for setting up css classes on components
> -------------------------------------------------------------------------------
>
>                 Key: XAP-344
>                 URL: https://issues.apache.org/jira/browse/XAP-344
>             Project: XAP
>          Issue Type: New Feature
>          Components: Widgets
>            Reporter: James Margaris
>         Assigned To: Turyn, Michael
>
> Right now there is no good way to assign custom classes to widgets. I propose:
> 1. All xal elements should support the class attribute which is a space-separated list of classes. 
> 2. For each entry in the attribute we should assign that entry to the base HTML container node/ root dom node. (Simply pass through to the underlying HTML tag)
> 3. In addition we want to support the various style states. So if they have a class called myClass we should automatically adjust that to myClassMouseOver the same way we do for built-in classes. Currently we have logic in AbstractWidgetBridge that will automatically change the class attribute to different permuations of the tag name, like "buttonMouseOver", "buttonMouseDown", etc. We should allow user-defined classes to use the same process and automatically add/remove state-specific permutations with mouse events.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Commented: (XAP-344) Should support a passthrough mechanism for setting up css classes on components

Posted by "Turyn, Michael (JIRA)" <xa...@incubator.apache.org>.
    [ https://issues.apache.org/jira/browse/XAP-344?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12483345 ] 

Turyn, Michael commented on XAP-344:
------------------------------------

Done. See revision 521514.

> Should support a passthrough mechanism for setting up css classes on components
> -------------------------------------------------------------------------------
>
>                 Key: XAP-344
>                 URL: https://issues.apache.org/jira/browse/XAP-344
>             Project: XAP
>          Issue Type: New Feature
>          Components: Widgets
>            Reporter: James Margaris
>         Assigned To: Turyn, Michael
>
> Right now there is no good way to assign custom classes to widgets. I propose:
> 1. All xal elements should support the class attribute which is a space-separated list of classes. 
> 2. For each entry in the attribute we should assign that entry to the base HTML container node/ root dom node. (Simply pass through to the underlying HTML tag)
> 3. In addition we want to support the various style states. So if they have a class called myClass we should automatically adjust that to myClassMouseOver the same way we do for built-in classes. Currently we have logic in AbstractWidgetBridge that will automatically change the class attribute to different permuations of the tag name, like "buttonMouseOver", "buttonMouseDown", etc. We should allow user-defined classes to use the same process and automatically add/remove state-specific permutations with mouse events.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.