You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@yunikorn.apache.org by GitBox <gi...@apache.org> on 2022/05/14 05:08:08 UTC
[GitHub] [yunikorn-k8shim] codecov[bot] commented on pull request #422: [YUNIKORN-186] clean up events in k8shim
codecov[bot] commented on PR #422:
URL: https://github.com/apache/yunikorn-k8shim/pull/422#issuecomment-1126642792
# [Codecov](https://codecov.io/gh/apache/yunikorn-k8shim/pull/422?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#422](https://codecov.io/gh/apache/yunikorn-k8shim/pull/422?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (928eb9b) into [master](https://codecov.io/gh/apache/yunikorn-k8shim/commit/dc1faba1b5f18210b8f4216cfc57cb001e787b51?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (dc1faba) will **increase** coverage by `1.23%`.
> The diff coverage is `83.55%`.
```diff
@@ Coverage Diff @@
## master #422 +/- ##
==========================================
+ Coverage 65.50% 66.73% +1.23%
==========================================
Files 40 39 -1
Lines 6406 6572 +166
==========================================
+ Hits 4196 4386 +190
+ Misses 2047 2023 -24
Partials 163 163
```
| [Impacted Files](https://codecov.io/gh/apache/yunikorn-k8shim/pull/422?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
|---|---|---|
| [pkg/cache/amprotocol\_mock.go](https://codecov.io/gh/apache/yunikorn-k8shim/pull/422/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cGtnL2NhY2hlL2FtcHJvdG9jb2xfbW9jay5nbw==) | `0.00% <0.00%> (ø)` | |
| [pkg/cache/context.go](https://codecov.io/gh/apache/yunikorn-k8shim/pull/422/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cGtnL2NhY2hlL2NvbnRleHQuZ28=) | `45.79% <28.57%> (-0.07%)` | :arrow_down: |
| [pkg/dispatcher/dispatcher.go](https://codecov.io/gh/apache/yunikorn-k8shim/pull/422/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cGtnL2Rpc3BhdGNoZXIvZGlzcGF0Y2hlci5nbw==) | `76.22% <50.00%> (+1.39%)` | :arrow_up: |
| [pkg/cache/application.go](https://codecov.io/gh/apache/yunikorn-k8shim/pull/422/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cGtnL2NhY2hlL2FwcGxpY2F0aW9uLmdv) | `70.44% <70.00%> (-2.61%)` | :arrow_down: |
| [pkg/cache/task\_state.go](https://codecov.io/gh/apache/yunikorn-k8shim/pull/422/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cGtnL2NhY2hlL3Rhc2tfc3RhdGUuZ28=) | `70.29% <70.29%> (ø)` | |
| [pkg/cache/task.go](https://codecov.io/gh/apache/yunikorn-k8shim/pull/422/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cGtnL2NhY2hlL3Rhc2suZ28=) | `69.04% <73.07%> (-4.02%)` | :arrow_down: |
| [pkg/shim/scheduler.go](https://codecov.io/gh/apache/yunikorn-k8shim/pull/422/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cGtnL3NoaW0vc2NoZWR1bGVyLmdv) | `73.20% <80.00%> (-4.40%)` | :arrow_down: |
| [pkg/cache/nodes.go](https://codecov.io/gh/apache/yunikorn-k8shim/pull/422/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cGtnL2NhY2hlL25vZGVzLmdv) | `79.59% <83.33%> (ø)` | |
| [pkg/cache/application\_state.go](https://codecov.io/gh/apache/yunikorn-k8shim/pull/422/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cGtnL2NhY2hlL2FwcGxpY2F0aW9uX3N0YXRlLmdv) | `90.18% <90.18%> (ø)` | |
| [pkg/shim/scheduler\_state.go](https://codecov.io/gh/apache/yunikorn-k8shim/pull/422/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cGtnL3NoaW0vc2NoZWR1bGVyX3N0YXRlLmdv) | `95.69% <95.69%> (ø)` | |
| ... and [7 more](https://codecov.io/gh/apache/yunikorn-k8shim/pull/422/diff?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/yunikorn-k8shim/pull/422?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/yunikorn-k8shim/pull/422?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [dc1faba...928eb9b](https://codecov.io/gh/apache/yunikorn-k8shim/pull/422?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@yunikorn.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org