You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@tinkerpop.apache.org by spmallette <gi...@git.apache.org> on 2016/09/22 14:57:59 UTC
[GitHub] tinkerpop pull request #433: TINKERPOP-1249 Add keep-alive functionality to ...
GitHub user spmallette opened a pull request:
https://github.com/apache/tinkerpop/pull/433
TINKERPOP-1249 Add keep-alive functionality to websockets Java Driver
https://issues.apache.org/jira/browse/TINKERPOP-1249
If a connection goes idle, the driver will periodically send a ping to the server to keep the connection alive.
All good with `mvn clean install && mvn verify -pl gremlin-server -DskipIntegrationTests=false`. Also ran some manual tests and did some memory profiling of the driver to make sure there were no leaks.
VOTE +1
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/apache/tinkerpop TINKERPOP-1249
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/tinkerpop/pull/433.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #433
----
commit d881484a40ef7c5924e97a1adce7d0a7bf6654ea
Author: Stephen Mallette <sp...@genoprime.com>
Date: 2016-09-22T11:48:59Z
Add keep-alive functionality to Java Driver.
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] tinkerpop issue #433: TINKERPOP-1249 Add keep-alive functionality to websock...
Posted by spmallette <gi...@git.apache.org>.
Github user spmallette commented on the issue:
https://github.com/apache/tinkerpop/pull/433
@robertdale thanks for testing that. If you pass in your own `Cluster`, then the `DriverRemoteConnection`, expects you to manage it. In this way, a `Cluster` can be shared.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] tinkerpop issue #433: TINKERPOP-1249 Add keep-alive functionality to websock...
Posted by robertdale <gi...@git.apache.org>.
Github user robertdale commented on the issue:
https://github.com/apache/tinkerpop/pull/433
Tested a clean console build with 3.2.2 server. Pinging works as expected. Closing each Client, a Cluster, and ':remote close' does stop pinging as expected.
Not sure what the expected behavior is here but this does not stop pinging after close. I had expected it to work like Client. Instead the Cluster must be closed.
```
cluster = Cluster.open('conf/remote-objects.yaml')
rem = DriverRemoteConnection.using(cluster, 'g')
g = EmptyGraph.instance().traversal().withRemote(rem)
g.V()
rem.close()
```
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] tinkerpop pull request #433: TINKERPOP-1249 Add keep-alive functionality to ...
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/tinkerpop/pull/433
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] tinkerpop issue #433: TINKERPOP-1249 Add keep-alive functionality to websock...
Posted by PommeVerte <gi...@git.apache.org>.
Github user PommeVerte commented on the issue:
https://github.com/apache/tinkerpop/pull/433
VOTE +1 I get the pinging as well. Looks good.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] tinkerpop issue #433: TINKERPOP-1249 Add keep-alive functionality to websock...
Posted by robertdale <gi...@git.apache.org>.
Github user robertdale commented on the issue:
https://github.com/apache/tinkerpop/pull/433
Use your favorite packet sniffer. I used tcpdump.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] tinkerpop issue #433: TINKERPOP-1249 Add keep-alive functionality to websock...
Posted by dkuppitz <gi...@git.apache.org>.
Github user dkuppitz commented on the issue:
https://github.com/apache/tinkerpop/pull/433
`docker/build.sh -t -i -n` succeeded.
VOTE: +1
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] tinkerpop issue #433: TINKERPOP-1249 Add keep-alive functionality to websock...
Posted by robertdale <gi...@git.apache.org>.
Github user robertdale commented on the issue:
https://github.com/apache/tinkerpop/pull/433
Yup, there it is right there in the javadoc: When close() is called, the Cluster is left open for the caller to close.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] tinkerpop issue #433: TINKERPOP-1249 Add keep-alive functionality to websock...
Posted by k4rthikr <gi...@git.apache.org>.
Github user k4rthikr commented on the issue:
https://github.com/apache/tinkerpop/pull/433
How do I know that pings are happening in the background? In other words, how do I test this?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---