[jira] [Work logged] (ARTEMIS-3413) Validate Mirror with removeQueue=false

["ASF GitHub Bot (Jira)" <ji...@apache.org>]

     [ https://issues.apache.org/jira/browse/ARTEMIS-3413?focusedWorklogId=635121&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-635121 ]

ASF GitHub Bot logged work on ARTEMIS-3413:
-------------------------------------------

                Author: ASF GitHub Bot
            Created on: 06/Aug/21 12:38
            Start Date: 06/Aug/21 12:38
    Worklog Time Spent: 10m 
      Work Description: gemmellr opened a new pull request #3689:
URL: https://github.com/apache/activemq-artemis/pull/3689


   2ee22912f07d4418e1f71bd496e016ad3123fede just added a test called "testDeleteQueueWithRemoveFalse" (just abvoe the context of this change). That in itself seems fine, but what was odd is the diff context for the change ended with context showing an existing test "testDoNotSendDelete" that appeared to want to test the same thing.
   
   However it doesnt actually do that at all,  doing exactly the same thing as a third "testDoNotSendCreate" test, due to an argument not being used. This third test also doesnt do what its name suggests, with both of them instead verifying that a create command _is_ being sent.
   
   This cleans things up so one test verifies the create is sent and the other that it isnt when configured, and renames them accordingly.
   
   
   (Setting up a test server and monitoring that no mirroring command was sent when configured not to would probably be a better and faster test. But for another time..)


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: gitbox-unsubscribe@activemq.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Issue Time Tracking
-------------------

            Worklog Id:     (was: 635121)
    Remaining Estimate: 0h
            Time Spent: 10m

> Validate Mirror with removeQueue=false
> --------------------------------------
>
>                 Key: ARTEMIS-3413
>                 URL: https://issues.apache.org/jira/browse/ARTEMIS-3413
>             Project: ActiveMQ Artemis
>          Issue Type: Test
>            Reporter: Clebert Suconic
>            Priority: Major
>             Fix For: 2.18.0
>
>          Time Spent: 10m
>  Remaining Estimate: 0h
>




--
This message was sent by Atlassian Jira
(v8.3.4#803005)