You are viewing a plain text version of this content. The canonical link for it is here.

Posted to github@beam.apache.org by GitBox <gi...@apache.org> on 2020/03/26 14:52:14 UTC

[GitHub] [beam] iemejia commented on issue #11055: [BEAM-9436] Improve GBK in spark structured streaming runner

iemejia commented on issue #11055: [BEAM-9436] Improve GBK in spark structured streaming runner
URL: https://github.com/apache/beam/pull/11055#issuecomment-604475588
 
 
   I think the point of the comment (or at least on my case on OOM) was not about this PR solving it or not but more about removing the comment `// Materialize groupByKeyOnly values, potential OOM because of creation of new iterable` which i think gave a valid orientation and now can be missed for someone reading the code, so probably letting the comment back is enough (of course in an updated version if it makes sense). 

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services