[GitHub] [ozone] sodonnel commented on a diff in pull request #3661: HDDS-6967. EC: Handle maintenance replicas in ECUnderReplicationHandler

[GitBox <gi...@apache.org>]

sodonnel commented on code in PR #3661:
URL: https://github.com/apache/ozone/pull/3661#discussion_r952433248


##########
hadoop-hdds/server-scm/src/main/java/org/apache/hadoop/hdds/scm/container/replication/ECContainerReplicaCount.java:
##########
@@ -196,6 +196,29 @@ public Set<Integer> maintenanceIndexes() {
     return maintenanceIndexes.keySet();
   }
 
+  /**
+   * Gets a set containing all maintenance only indexes. These are replicas
+   * that are only on maintenance nodes, without any copies on healthy nodes.
+   *
+   * @param includePendingAdd true if any indexes that are pending an add
+   * {@link ContainerReplicaOp.PendingOpType#ADD} should be excluded
+   * @return set containing maintenance only indexes or empty set if none are
+   * in maintenance
+   */
+  public Set<Integer> maintenanceOnlyIndexes(boolean includePendingAdd) {

Review Comment:
   I think we should remove the other version of maintenanceOnlyIndexes that returns a list, and make everything use this one. It keeps it consistent with decommissionOnlyIndexes



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org