You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@skywalking.apache.org by GitBox <gi...@apache.org> on 2021/03/03 12:33:19 UTC
[GitHub] [skywalking] yaojingguo opened a new pull request #6480: Remove unnecessary check for getSkyWalkingDynamicField invocation
yaojingguo opened a new pull request #6480:
URL: https://github.com/apache/skywalking/pull/6480
For the details on how this PR works, refer to #6456.
I have checked the following Kafka usages:
- `KafkaProducer.send(record)`
- `KafkaProducer.send(record, callback)`
- `KafkaTemplate.send(topic, data)`
- `KafkaTemplate.execute(callback)` such as
```java
kafkaTemplate.execute(
(Producer<String, String> producer) -> {
producer.send(
new ProducerRecord<>(topic, data),
(RecordMetadata metadata, Exception e) -> {
// ...
});
return 0;
});
```
In all the above usages, `objInst.getSkyWalkingDynamicField()` is `null`.
@zifeihan
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6480: Remove unnecessary check for getSkyWalkingDynamicField invocation
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #6480:
URL: https://github.com/apache/skywalking/pull/6480#issuecomment-789727063
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/6480?src=pr&el=h1) Report
> Merging [#6480](https://codecov.io/gh/apache/skywalking/pull/6480?src=pr&el=desc) (b16aca4) into [master](https://codecov.io/gh/apache/skywalking/commit/cb16e524da2bf45258e67052443a6b9bc2460855?el=desc) (cb16e52) will **decrease** coverage by `10.09%`.
> The diff coverage is `n/a`.
[![Impacted file tree graph](https://codecov.io/gh/apache/skywalking/pull/6480/graphs/tree.svg?width=650&height=150&src=pr&token=qrILxY5yA8)](https://codecov.io/gh/apache/skywalking/pull/6480?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #6480 +/- ##
=============================================
- Coverage 54.08% 43.99% -10.10%
+ Complexity 4088 3343 -745
=============================================
Files 1778 1018 -760
Lines 37771 24858 -12913
Branches 4156 2437 -1719
=============================================
- Hits 20429 10936 -9493
+ Misses 16361 12993 -3368
+ Partials 981 929 -52
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/6480?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...che/skywalking/apm/agent/core/meter/MeterType.java](https://codecov.io/gh/apache/skywalking/pull/6480/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvbWV0ZXIvTWV0ZXJUeXBlLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (ø%)` | |
| [...skywalking/oap/server/core/alarm/AlarmMessage.java](https://codecov.io/gh/apache/skywalking/pull/6480/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYWxhcm0vQWxhcm1NZXNzYWdlLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...e/skywalking/apm/agent/core/meter/CounterMode.java](https://codecov.io/gh/apache/skywalking/pull/6480/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvbWV0ZXIvQ291bnRlck1vZGUuamF2YQ==) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (ø%)` | |
| [...org/apache/skywalking/apm/toolkit/meter/Gauge.java](https://codecov.io/gh/apache/skywalking/pull/6480/diff?src=pr&el=tree#diff-YXBtLWFwcGxpY2F0aW9uLXRvb2xraXQvYXBtLXRvb2xraXQtbWV0ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL3Rvb2xraXQvbWV0ZXIvR2F1Z2UuamF2YQ==) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (ø%)` | |
| [...ng/oap/server/core/analysis/config/NoneStream.java](https://codecov.io/gh/apache/skywalking/pull/6480/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvY29uZmlnL05vbmVTdHJlYW0uamF2YQ==) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...g/oap/server/core/cluster/ClusterHealthStatus.java](https://codecov.io/gh/apache/skywalking/pull/6480/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvY2x1c3Rlci9DbHVzdGVySGVhbHRoU3RhdHVzLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (ø%)` | |
| [...ng/apm/agent/core/context/trace/LogDataEntity.java](https://codecov.io/gh/apache/skywalking/pull/6480/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29udGV4dC90cmFjZS9Mb2dEYXRhRW50aXR5LmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (ø%)` | |
| [...p/server/core/analysis/metrics/MinLongMetrics.java](https://codecov.io/gh/apache/skywalking/pull/6480/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0cmljcy9NaW5Mb25nTWV0cmljcy5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (ø%)` | |
| [...er/exporter/provider/grpc/GRPCExporterSetting.java](https://codecov.io/gh/apache/skywalking/pull/6480/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9leHBvcnRlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2V4cG9ydGVyL3Byb3ZpZGVyL2dycGMvR1JQQ0V4cG9ydGVyU2V0dGluZy5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (ø%)` | |
| [...lking/oap/server/analyzer/event/EventAnalyzer.java](https://codecov.io/gh/apache/skywalking/pull/6480/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9ldmVudC1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2FuYWx5emVyL2V2ZW50L0V2ZW50QW5hbHl6ZXIuamF2YQ==) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-6.00%)` | |
| ... and [1296 more](https://codecov.io/gh/apache/skywalking/pull/6480/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/6480?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/6480?src=pr&el=footer). Last update [9946ec4...5c9722d](https://codecov.io/gh/apache/skywalking/pull/6480?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6480: Remove unnecessary check for getSkyWalkingDynamicField invocation
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #6480:
URL: https://github.com/apache/skywalking/pull/6480#issuecomment-789727063
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/6480?src=pr&el=h1) Report
> Merging [#6480](https://codecov.io/gh/apache/skywalking/pull/6480?src=pr&el=desc) (9f84ae1) into [master](https://codecov.io/gh/apache/skywalking/commit/de6a731d72fb87dd574da1d9b42495fdd29b4311?el=desc) (de6a731) will **decrease** coverage by `16.35%`.
> The diff coverage is `19.04%`.
[![Impacted file tree graph](https://codecov.io/gh/apache/skywalking/pull/6480/graphs/tree.svg?width=650&height=150&src=pr&token=qrILxY5yA8)](https://codecov.io/gh/apache/skywalking/pull/6480?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #6480 +/- ##
=============================================
- Coverage 54.00% 37.65% -16.36%
+ Complexity 4075 2708 -1367
=============================================
Files 1777 1024 -753
Lines 37757 24915 -12842
Branches 4153 2441 -1712
=============================================
- Hits 20392 9381 -11011
+ Misses 16385 14805 -1580
+ Partials 980 729 -251
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/6480?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...g/oap/log/analyzer/dsl/spec/filter/FilterSpec.java](https://codecov.io/gh/apache/skywalking/pull/6480/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9sb2ctYW5hbHl6ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL2xvZy9hbmFseXplci9kc2wvc3BlYy9maWx0ZXIvRmlsdGVyU3BlYy5qYXZh) | `44.61% <0.00%> (-6.27%)` | `7.00 <0.00> (ø)` | |
| [...p/log/analyzer/dsl/spec/parser/TextParserSpec.java](https://codecov.io/gh/apache/skywalking/pull/6480/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9sb2ctYW5hbHl6ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL2xvZy9hbmFseXplci9kc2wvc3BlYy9wYXJzZXIvVGV4dFBhcnNlclNwZWMuamF2YQ==) | `64.28% <0.00%> (-10.72%)` | `4.00 <0.00> (ø)` | |
| [...p/log/analyzer/dsl/spec/parser/YamlParserSpec.java](https://codecov.io/gh/apache/skywalking/pull/6480/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9sb2ctYW5hbHl6ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL2xvZy9hbmFseXplci9kc2wvc3BlYy9wYXJzZXIvWWFtbFBhcnNlclNwZWMuamF2YQ==) | `75.00% <ø> (ø)` | `1.00 <0.00> (ø)` | |
| [...p/log/analyzer/dsl/spec/parser/JsonParserSpec.java](https://codecov.io/gh/apache/skywalking/pull/6480/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9sb2ctYW5hbHl6ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL2xvZy9hbmFseXplci9kc2wvc3BlYy9wYXJzZXIvSnNvblBhcnNlclNwZWMuamF2YQ==) | `80.00% <50.00%> (+5.00%)` | `1.00 <0.00> (ø)` | |
| [...g/analyzer/dsl/spec/parser/AbstractParserSpec.java](https://codecov.io/gh/apache/skywalking/pull/6480/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9sb2ctYW5hbHl6ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL2xvZy9hbmFseXplci9kc2wvc3BlYy9wYXJzZXIvQWJzdHJhY3RQYXJzZXJTcGVjLmphdmE=) | `100.00% <100.00%> (ø)` | `1.00 <1.00> (?)` | |
| [...pache/skywalking/apm/agent/core/base64/Base64.java](https://codecov.io/gh/apache/skywalking/pull/6480/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvYmFzZTY0L0Jhc2U2NC5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-3.00%)` | |
| [...che/skywalking/apm/agent/core/meter/MeterType.java](https://codecov.io/gh/apache/skywalking/pull/6480/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvbWV0ZXIvTWV0ZXJUeXBlLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (ø%)` | |
| [...skywalking/oap/server/core/alarm/AlarmMessage.java](https://codecov.io/gh/apache/skywalking/pull/6480/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYWxhcm0vQWxhcm1NZXNzYWdlLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...e/skywalking/apm/agent/core/meter/CounterMode.java](https://codecov.io/gh/apache/skywalking/pull/6480/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvbWV0ZXIvQ291bnRlck1vZGUuamF2YQ==) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (ø%)` | |
| [...ywalking/apm/agent/core/logging/core/LogLevel.java](https://codecov.io/gh/apache/skywalking/pull/6480/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvbG9nZ2luZy9jb3JlL0xvZ0xldmVsLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| ... and [1358 more](https://codecov.io/gh/apache/skywalking/pull/6480/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/6480?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/6480?src=pr&el=footer). Last update [cb16e52...a8c1e14](https://codecov.io/gh/apache/skywalking/pull/6480?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6480: Remove unnecessary check for getSkyWalkingDynamicField invocation
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #6480:
URL: https://github.com/apache/skywalking/pull/6480#issuecomment-789727063
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/6480?src=pr&el=h1) Report
> Merging [#6480](https://codecov.io/gh/apache/skywalking/pull/6480?src=pr&el=desc) (b16aca4) into [master](https://codecov.io/gh/apache/skywalking/commit/cb16e524da2bf45258e67052443a6b9bc2460855?el=desc) (cb16e52) will **decrease** coverage by `10.72%`.
> The diff coverage is `n/a`.
[![Impacted file tree graph](https://codecov.io/gh/apache/skywalking/pull/6480/graphs/tree.svg?width=650&height=150&src=pr&token=qrILxY5yA8)](https://codecov.io/gh/apache/skywalking/pull/6480?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #6480 +/- ##
=============================================
- Coverage 54.08% 43.36% -10.73%
+ Complexity 4088 3298 -790
=============================================
Files 1778 1018 -760
Lines 37771 24857 -12914
Branches 4156 2433 -1723
=============================================
- Hits 20429 10779 -9650
+ Misses 16361 13152 -3209
+ Partials 981 926 -55
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/6480?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...che/skywalking/apm/agent/core/meter/MeterType.java](https://codecov.io/gh/apache/skywalking/pull/6480/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvbWV0ZXIvTWV0ZXJUeXBlLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (ø%)` | |
| [...skywalking/oap/server/core/alarm/AlarmMessage.java](https://codecov.io/gh/apache/skywalking/pull/6480/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYWxhcm0vQWxhcm1NZXNzYWdlLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...e/skywalking/apm/agent/core/meter/CounterMode.java](https://codecov.io/gh/apache/skywalking/pull/6480/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvbWV0ZXIvQ291bnRlck1vZGUuamF2YQ==) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (ø%)` | |
| [...org/apache/skywalking/apm/toolkit/meter/Gauge.java](https://codecov.io/gh/apache/skywalking/pull/6480/diff?src=pr&el=tree#diff-YXBtLWFwcGxpY2F0aW9uLXRvb2xraXQvYXBtLXRvb2xraXQtbWV0ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL3Rvb2xraXQvbWV0ZXIvR2F1Z2UuamF2YQ==) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (ø%)` | |
| [...ng/oap/server/core/analysis/config/NoneStream.java](https://codecov.io/gh/apache/skywalking/pull/6480/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvY29uZmlnL05vbmVTdHJlYW0uamF2YQ==) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...g/oap/server/core/cluster/ClusterHealthStatus.java](https://codecov.io/gh/apache/skywalking/pull/6480/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvY2x1c3Rlci9DbHVzdGVySGVhbHRoU3RhdHVzLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (ø%)` | |
| [...ng/apm/agent/core/context/trace/LogDataEntity.java](https://codecov.io/gh/apache/skywalking/pull/6480/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29udGV4dC90cmFjZS9Mb2dEYXRhRW50aXR5LmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (ø%)` | |
| [...p/server/core/analysis/metrics/MinLongMetrics.java](https://codecov.io/gh/apache/skywalking/pull/6480/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0cmljcy9NaW5Mb25nTWV0cmljcy5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (ø%)` | |
| [...er/exporter/provider/grpc/GRPCExporterSetting.java](https://codecov.io/gh/apache/skywalking/pull/6480/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9leHBvcnRlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2V4cG9ydGVyL3Byb3ZpZGVyL2dycGMvR1JQQ0V4cG9ydGVyU2V0dGluZy5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (ø%)` | |
| [...lking/oap/server/analyzer/event/EventAnalyzer.java](https://codecov.io/gh/apache/skywalking/pull/6480/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9ldmVudC1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2FuYWx5emVyL2V2ZW50L0V2ZW50QW5hbHl6ZXIuamF2YQ==) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-6.00%)` | |
| ... and [1300 more](https://codecov.io/gh/apache/skywalking/pull/6480/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/6480?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/6480?src=pr&el=footer). Last update [9946ec4...5c9722d](https://codecov.io/gh/apache/skywalking/pull/6480?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6480: Remove unnecessary check for getSkyWalkingDynamicField invocation
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #6480:
URL: https://github.com/apache/skywalking/pull/6480#issuecomment-789727063
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/6480?src=pr&el=h1) Report
> Merging [#6480](https://codecov.io/gh/apache/skywalking/pull/6480?src=pr&el=desc) (a8c1e14) into [master](https://codecov.io/gh/apache/skywalking/commit/de6a731d72fb87dd574da1d9b42495fdd29b4311?el=desc) (de6a731) will **increase** coverage by `2.85%`.
> The diff coverage is `n/a`.
[![Impacted file tree graph](https://codecov.io/gh/apache/skywalking/pull/6480/graphs/tree.svg?width=650&height=150&src=pr&token=qrILxY5yA8)](https://codecov.io/gh/apache/skywalking/pull/6480?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #6480 +/- ##
============================================
+ Coverage 54.00% 56.86% +2.85%
+ Complexity 4075 822 -3253
============================================
Files 1777 177 -1600
Lines 37757 4312 -33445
Branches 4153 491 -3662
============================================
- Hits 20392 2452 -17940
+ Misses 16385 1548 -14837
+ Partials 980 312 -668
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/6480?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...t/status/HierarchyMatchExceptionCheckStrategy.java](https://codecov.io/gh/apache/skywalking/pull/6480/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29udGV4dC9zdGF0dXMvSGllcmFyY2h5TWF0Y2hFeGNlcHRpb25DaGVja1N0cmF0ZWd5LmphdmE=) | `9.09% <0.00%> (-90.91%)` | `1.00% <0.00%> (ø%)` | |
| [...alking/apm/agent/core/logging/core/FileWriter.java](https://codecov.io/gh/apache/skywalking/pull/6480/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvbG9nZ2luZy9jb3JlL0ZpbGVXcml0ZXIuamF2YQ==) | `0.00% <0.00%> (-88.10%)` | `0.00% <0.00%> (ø%)` | |
| [...g/apm/agent/core/context/status/StatusChecker.java](https://codecov.io/gh/apache/skywalking/pull/6480/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29udGV4dC9zdGF0dXMvU3RhdHVzQ2hlY2tlci5qYXZh) | `23.80% <0.00%> (-76.20%)` | `1.00% <0.00%> (ø%)` | |
| [...ywalking/apm/agent/core/plugin/PluginSelector.java](https://codecov.io/gh/apache/skywalking/pull/6480/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcGx1Z2luL1BsdWdpblNlbGVjdG9yLmphdmE=) | `28.57% <0.00%> (-71.43%)` | `2.00% <0.00%> (ø%)` | |
| [...re/logging/core/converters/AgentNameConverter.java](https://codecov.io/gh/apache/skywalking/pull/6480/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvbG9nZ2luZy9jb3JlL2NvbnZlcnRlcnMvQWdlbnROYW1lQ29udmVydGVyLmphdmE=) | `0.00% <0.00%> (-66.67%)` | `0.00% <0.00%> (ø%)` | |
| [...re/logging/core/converters/ThrowableConverter.java](https://codecov.io/gh/apache/skywalking/pull/6480/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvbG9nZ2luZy9jb3JlL2NvbnZlcnRlcnMvVGhyb3dhYmxlQ29udmVydGVyLmphdmE=) | `16.66% <0.00%> (-66.67%)` | `2.00% <0.00%> (ø%)` | |
| [...he/skywalking/apm/commons/datacarrier/EnvUtil.java](https://codecov.io/gh/apache/skywalking/pull/6480/diff?src=pr&el=tree#diff-YXBtLWNvbW1vbnMvYXBtLWRhdGFjYXJyaWVyL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL2FwbS9jb21tb25zL2RhdGFjYXJyaWVyL0VudlV0aWwuamF2YQ==) | `20.00% <0.00%> (-60.00%)` | `1.00% <0.00%> (ø%)` | |
| [...lking/apm/agent/core/context/ExtensionContext.java](https://codecov.io/gh/apache/skywalking/pull/6480/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29udGV4dC9FeHRlbnNpb25Db250ZXh0LmphdmE=) | `23.25% <0.00%> (-51.17%)` | `7.00% <0.00%> (ø%)` | |
| [...core/context/status/OffExceptionCheckStrategy.java](https://codecov.io/gh/apache/skywalking/pull/6480/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29udGV4dC9zdGF0dXMvT2ZmRXhjZXB0aW9uQ2hlY2tTdHJhdGVneS5qYXZh) | `50.00% <0.00%> (-50.00%)` | `1.00% <0.00%> (ø%)` | |
| [...kywalking/apm/commons/datacarrier/DataCarrier.java](https://codecov.io/gh/apache/skywalking/pull/6480/diff?src=pr&el=tree#diff-YXBtLWNvbW1vbnMvYXBtLWRhdGFjYXJyaWVyL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL2FwbS9jb21tb25zL2RhdGFjYXJyaWVyL0RhdGFDYXJyaWVyLmphdmE=) | `38.46% <0.00%> (-46.16%)` | `6.00% <0.00%> (-4.00%)` | |
| ... and [1691 more](https://codecov.io/gh/apache/skywalking/pull/6480/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/6480?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/6480?src=pr&el=footer). Last update [cb16e52...a8c1e14](https://codecov.io/gh/apache/skywalking/pull/6480?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6480: Remove unnecessary check for getSkyWalkingDynamicField invocation
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #6480:
URL: https://github.com/apache/skywalking/pull/6480#issuecomment-789727063
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/6480?src=pr&el=h1) Report
> Merging [#6480](https://codecov.io/gh/apache/skywalking/pull/6480?src=pr&el=desc) (b16aca4) into [master](https://codecov.io/gh/apache/skywalking/commit/cb16e524da2bf45258e67052443a6b9bc2460855?el=desc) (cb16e52) will **decrease** coverage by `7.40%`.
> The diff coverage is `n/a`.
[![Impacted file tree graph](https://codecov.io/gh/apache/skywalking/pull/6480/graphs/tree.svg?width=650&height=150&src=pr&token=qrILxY5yA8)](https://codecov.io/gh/apache/skywalking/pull/6480?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #6480 +/- ##
============================================
- Coverage 54.08% 46.68% -7.41%
+ Complexity 4088 3512 -576
============================================
Files 1778 1021 -757
Lines 37771 24886 -12885
Branches 4156 2437 -1719
============================================
- Hits 20429 11618 -8811
+ Misses 16361 12259 -4102
- Partials 981 1009 +28
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/6480?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...che/skywalking/apm/agent/core/meter/MeterType.java](https://codecov.io/gh/apache/skywalking/pull/6480/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvbWV0ZXIvTWV0ZXJUeXBlLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (ø%)` | |
| [...skywalking/oap/server/core/alarm/AlarmMessage.java](https://codecov.io/gh/apache/skywalking/pull/6480/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYWxhcm0vQWxhcm1NZXNzYWdlLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...e/skywalking/apm/agent/core/meter/CounterMode.java](https://codecov.io/gh/apache/skywalking/pull/6480/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvbWV0ZXIvQ291bnRlck1vZGUuamF2YQ==) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (ø%)` | |
| [...org/apache/skywalking/apm/toolkit/meter/Gauge.java](https://codecov.io/gh/apache/skywalking/pull/6480/diff?src=pr&el=tree#diff-YXBtLWFwcGxpY2F0aW9uLXRvb2xraXQvYXBtLXRvb2xraXQtbWV0ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL3Rvb2xraXQvbWV0ZXIvR2F1Z2UuamF2YQ==) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (ø%)` | |
| [...ng/oap/server/core/analysis/config/NoneStream.java](https://codecov.io/gh/apache/skywalking/pull/6480/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvY29uZmlnL05vbmVTdHJlYW0uamF2YQ==) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...g/oap/server/core/cluster/ClusterHealthStatus.java](https://codecov.io/gh/apache/skywalking/pull/6480/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvY2x1c3Rlci9DbHVzdGVySGVhbHRoU3RhdHVzLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (ø%)` | |
| [...ng/apm/agent/core/context/trace/LogDataEntity.java](https://codecov.io/gh/apache/skywalking/pull/6480/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29udGV4dC90cmFjZS9Mb2dEYXRhRW50aXR5LmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (ø%)` | |
| [...p/server/core/analysis/metrics/MinLongMetrics.java](https://codecov.io/gh/apache/skywalking/pull/6480/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0cmljcy9NaW5Mb25nTWV0cmljcy5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (ø%)` | |
| [...er/exporter/provider/grpc/GRPCExporterSetting.java](https://codecov.io/gh/apache/skywalking/pull/6480/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9leHBvcnRlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2V4cG9ydGVyL3Byb3ZpZGVyL2dycGMvR1JQQ0V4cG9ydGVyU2V0dGluZy5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (ø%)` | |
| [...ent/core/plugin/bytebuddy/ReturnTypeNameMatch.java](https://codecov.io/gh/apache/skywalking/pull/6480/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcGx1Z2luL2J5dGVidWRkeS9SZXR1cm5UeXBlTmFtZU1hdGNoLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (ø%)` | |
| ... and [1281 more](https://codecov.io/gh/apache/skywalking/pull/6480/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/6480?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/6480?src=pr&el=footer). Last update [9946ec4...5c9722d](https://codecov.io/gh/apache/skywalking/pull/6480?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6480: Remove unnecessary check for getSkyWalkingDynamicField invocation
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #6480:
URL: https://github.com/apache/skywalking/pull/6480#issuecomment-789727063
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/6480?src=pr&el=h1) Report
> Merging [#6480](https://codecov.io/gh/apache/skywalking/pull/6480?src=pr&el=desc) (a8c1e14) into [master](https://codecov.io/gh/apache/skywalking/commit/de6a731d72fb87dd574da1d9b42495fdd29b4311?el=desc) (de6a731) will **decrease** coverage by `15.05%`.
> The diff coverage is `19.04%`.
[![Impacted file tree graph](https://codecov.io/gh/apache/skywalking/pull/6480/graphs/tree.svg?width=650&height=150&src=pr&token=qrILxY5yA8)](https://codecov.io/gh/apache/skywalking/pull/6480?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #6480 +/- ##
=============================================
- Coverage 54.00% 38.94% -15.06%
+ Complexity 4075 2830 -1245
=============================================
Files 1777 967 -810
Lines 37757 23484 -14273
Branches 4153 2264 -1889
=============================================
- Hits 20392 9147 -11245
+ Misses 16385 13582 -2803
+ Partials 980 755 -225
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/6480?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...g/oap/log/analyzer/dsl/spec/filter/FilterSpec.java](https://codecov.io/gh/apache/skywalking/pull/6480/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9sb2ctYW5hbHl6ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL2xvZy9hbmFseXplci9kc2wvc3BlYy9maWx0ZXIvRmlsdGVyU3BlYy5qYXZh) | `35.38% <0.00%> (-15.50%)` | `5.00 <0.00> (-2.00)` | |
| [...p/log/analyzer/dsl/spec/parser/TextParserSpec.java](https://codecov.io/gh/apache/skywalking/pull/6480/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9sb2ctYW5hbHl6ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL2xvZy9hbmFseXplci9kc2wvc3BlYy9wYXJzZXIvVGV4dFBhcnNlclNwZWMuamF2YQ==) | `14.28% <0.00%> (-60.72%)` | `1.00 <0.00> (-3.00)` | |
| [...p/log/analyzer/dsl/spec/parser/YamlParserSpec.java](https://codecov.io/gh/apache/skywalking/pull/6480/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9sb2ctYW5hbHl6ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL2xvZy9hbmFseXplci9kc2wvc3BlYy9wYXJzZXIvWWFtbFBhcnNlclNwZWMuamF2YQ==) | `75.00% <ø> (ø)` | `1.00 <0.00> (ø)` | |
| [...p/log/analyzer/dsl/spec/parser/JsonParserSpec.java](https://codecov.io/gh/apache/skywalking/pull/6480/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9sb2ctYW5hbHl6ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL2xvZy9hbmFseXplci9kc2wvc3BlYy9wYXJzZXIvSnNvblBhcnNlclNwZWMuamF2YQ==) | `80.00% <50.00%> (+5.00%)` | `1.00 <0.00> (ø)` | |
| [...g/analyzer/dsl/spec/parser/AbstractParserSpec.java](https://codecov.io/gh/apache/skywalking/pull/6480/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9sb2ctYW5hbHl6ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL2xvZy9hbmFseXplci9kc2wvc3BlYy9wYXJzZXIvQWJzdHJhY3RQYXJzZXJTcGVjLmphdmE=) | `100.00% <100.00%> (ø)` | `1.00 <1.00> (?)` | |
| [...skywalking/oap/server/core/alarm/AlarmMessage.java](https://codecov.io/gh/apache/skywalking/pull/6480/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYWxhcm0vQWxhcm1NZXNzYWdlLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...kywalking/oap/server/core/storage/AbstractDAO.java](https://codecov.io/gh/apache/skywalking/pull/6480/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvc3RvcmFnZS9BYnN0cmFjdERBTy5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-2.00%)` | |
| [...ng/oap/server/core/analysis/config/NoneStream.java](https://codecov.io/gh/apache/skywalking/pull/6480/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvY29uZmlnL05vbmVTdHJlYW0uamF2YQ==) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...g/oap/server/core/cluster/ClusterHealthStatus.java](https://codecov.io/gh/apache/skywalking/pull/6480/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvY2x1c3Rlci9DbHVzdGVySGVhbHRoU3RhdHVzLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (ø%)` | |
| [...ng/apm/agent/core/context/trace/LogDataEntity.java](https://codecov.io/gh/apache/skywalking/pull/6480/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29udGV4dC90cmFjZS9Mb2dEYXRhRW50aXR5LmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (ø%)` | |
| ... and [1361 more](https://codecov.io/gh/apache/skywalking/pull/6480/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/6480?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/6480?src=pr&el=footer). Last update [cb16e52...a8c1e14](https://codecov.io/gh/apache/skywalking/pull/6480?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6480: Remove unnecessary check for getSkyWalkingDynamicField invocation
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #6480:
URL: https://github.com/apache/skywalking/pull/6480#issuecomment-789727063
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/6480?src=pr&el=h1) Report
> Merging [#6480](https://codecov.io/gh/apache/skywalking/pull/6480?src=pr&el=desc) (9f84ae1) into [master](https://codecov.io/gh/apache/skywalking/commit/de6a731d72fb87dd574da1d9b42495fdd29b4311?el=desc) (de6a731) will **decrease** coverage by `22.05%`.
> The diff coverage is `19.04%`.
[![Impacted file tree graph](https://codecov.io/gh/apache/skywalking/pull/6480/graphs/tree.svg?width=650&height=150&src=pr&token=qrILxY5yA8)](https://codecov.io/gh/apache/skywalking/pull/6480?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #6480 +/- ##
=============================================
- Coverage 54.00% 31.95% -22.06%
+ Complexity 4075 2372 -1703
=============================================
Files 1777 1018 -759
Lines 37757 24759 -12998
Branches 4153 2429 -1724
=============================================
- Hits 20392 7912 -12480
+ Misses 16385 16246 -139
+ Partials 980 601 -379
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/6480?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...g/oap/log/analyzer/dsl/spec/filter/FilterSpec.java](https://codecov.io/gh/apache/skywalking/pull/6480/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9sb2ctYW5hbHl6ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL2xvZy9hbmFseXplci9kc2wvc3BlYy9maWx0ZXIvRmlsdGVyU3BlYy5qYXZh) | `44.61% <0.00%> (-6.27%)` | `7.00 <0.00> (ø)` | |
| [...p/log/analyzer/dsl/spec/parser/TextParserSpec.java](https://codecov.io/gh/apache/skywalking/pull/6480/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9sb2ctYW5hbHl6ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL2xvZy9hbmFseXplci9kc2wvc3BlYy9wYXJzZXIvVGV4dFBhcnNlclNwZWMuamF2YQ==) | `64.28% <0.00%> (-10.72%)` | `4.00 <0.00> (ø)` | |
| [...p/log/analyzer/dsl/spec/parser/YamlParserSpec.java](https://codecov.io/gh/apache/skywalking/pull/6480/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9sb2ctYW5hbHl6ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL2xvZy9hbmFseXplci9kc2wvc3BlYy9wYXJzZXIvWWFtbFBhcnNlclNwZWMuamF2YQ==) | `75.00% <ø> (ø)` | `1.00 <0.00> (ø)` | |
| [...p/log/analyzer/dsl/spec/parser/JsonParserSpec.java](https://codecov.io/gh/apache/skywalking/pull/6480/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9sb2ctYW5hbHl6ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL2xvZy9hbmFseXplci9kc2wvc3BlYy9wYXJzZXIvSnNvblBhcnNlclNwZWMuamF2YQ==) | `80.00% <50.00%> (+5.00%)` | `1.00 <0.00> (ø)` | |
| [...g/analyzer/dsl/spec/parser/AbstractParserSpec.java](https://codecov.io/gh/apache/skywalking/pull/6480/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9sb2ctYW5hbHl6ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL2xvZy9hbmFseXplci9kc2wvc3BlYy9wYXJzZXIvQWJzdHJhY3RQYXJzZXJTcGVjLmphdmE=) | `100.00% <100.00%> (ø)` | `1.00 <1.00> (?)` | |
| [...pache/skywalking/apm/agent/core/base64/Base64.java](https://codecov.io/gh/apache/skywalking/pull/6480/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvYmFzZTY0L0Jhc2U2NC5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-3.00%)` | |
| [...che/skywalking/apm/agent/core/meter/MeterType.java](https://codecov.io/gh/apache/skywalking/pull/6480/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvbWV0ZXIvTWV0ZXJUeXBlLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (ø%)` | |
| [...skywalking/oap/server/core/alarm/AlarmMessage.java](https://codecov.io/gh/apache/skywalking/pull/6480/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYWxhcm0vQWxhcm1NZXNzYWdlLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...e/skywalking/apm/agent/core/meter/CounterMode.java](https://codecov.io/gh/apache/skywalking/pull/6480/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvbWV0ZXIvQ291bnRlck1vZGUuamF2YQ==) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (ø%)` | |
| [...ywalking/apm/agent/core/logging/core/LogLevel.java](https://codecov.io/gh/apache/skywalking/pull/6480/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvbG9nZ2luZy9jb3JlL0xvZ0xldmVsLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| ... and [1384 more](https://codecov.io/gh/apache/skywalking/pull/6480/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/6480?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/6480?src=pr&el=footer). Last update [cb16e52...a8c1e14](https://codecov.io/gh/apache/skywalking/pull/6480?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6480: Remove unnecessary check for getSkyWalkingDynamicField invocation
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #6480:
URL: https://github.com/apache/skywalking/pull/6480#issuecomment-789727063
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/6480?src=pr&el=h1) Report
> Merging [#6480](https://codecov.io/gh/apache/skywalking/pull/6480?src=pr&el=desc) (b16aca4) into [master](https://codecov.io/gh/apache/skywalking/commit/cb16e524da2bf45258e67052443a6b9bc2460855?el=desc) (cb16e52) will **decrease** coverage by `7.94%`.
> The diff coverage is `n/a`.
[![Impacted file tree graph](https://codecov.io/gh/apache/skywalking/pull/6480/graphs/tree.svg?width=650&height=150&src=pr&token=qrILxY5yA8)](https://codecov.io/gh/apache/skywalking/pull/6480?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #6480 +/- ##
============================================
- Coverage 54.08% 46.14% -7.95%
+ Complexity 4088 3491 -597
============================================
Files 1778 1021 -757
Lines 37771 24886 -12885
Branches 4156 2437 -1719
============================================
- Hits 20429 11483 -8946
+ Misses 16361 12423 -3938
+ Partials 981 980 -1
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/6480?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...che/skywalking/apm/agent/core/meter/MeterType.java](https://codecov.io/gh/apache/skywalking/pull/6480/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvbWV0ZXIvTWV0ZXJUeXBlLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (ø%)` | |
| [...skywalking/oap/server/core/alarm/AlarmMessage.java](https://codecov.io/gh/apache/skywalking/pull/6480/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYWxhcm0vQWxhcm1NZXNzYWdlLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...e/skywalking/apm/agent/core/meter/CounterMode.java](https://codecov.io/gh/apache/skywalking/pull/6480/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvbWV0ZXIvQ291bnRlck1vZGUuamF2YQ==) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (ø%)` | |
| [...org/apache/skywalking/apm/toolkit/meter/Gauge.java](https://codecov.io/gh/apache/skywalking/pull/6480/diff?src=pr&el=tree#diff-YXBtLWFwcGxpY2F0aW9uLXRvb2xraXQvYXBtLXRvb2xraXQtbWV0ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL3Rvb2xraXQvbWV0ZXIvR2F1Z2UuamF2YQ==) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (ø%)` | |
| [...ng/oap/server/core/analysis/config/NoneStream.java](https://codecov.io/gh/apache/skywalking/pull/6480/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvY29uZmlnL05vbmVTdHJlYW0uamF2YQ==) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...g/oap/server/core/cluster/ClusterHealthStatus.java](https://codecov.io/gh/apache/skywalking/pull/6480/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvY2x1c3Rlci9DbHVzdGVySGVhbHRoU3RhdHVzLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (ø%)` | |
| [...ng/apm/agent/core/context/trace/LogDataEntity.java](https://codecov.io/gh/apache/skywalking/pull/6480/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29udGV4dC90cmFjZS9Mb2dEYXRhRW50aXR5LmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (ø%)` | |
| [...p/server/core/analysis/metrics/MinLongMetrics.java](https://codecov.io/gh/apache/skywalking/pull/6480/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0cmljcy9NaW5Mb25nTWV0cmljcy5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (ø%)` | |
| [...er/exporter/provider/grpc/GRPCExporterSetting.java](https://codecov.io/gh/apache/skywalking/pull/6480/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9leHBvcnRlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2V4cG9ydGVyL3Byb3ZpZGVyL2dycGMvR1JQQ0V4cG9ydGVyU2V0dGluZy5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (ø%)` | |
| [...ent/core/plugin/bytebuddy/ReturnTypeNameMatch.java](https://codecov.io/gh/apache/skywalking/pull/6480/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcGx1Z2luL2J5dGVidWRkeS9SZXR1cm5UeXBlTmFtZU1hdGNoLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (ø%)` | |
| ... and [1281 more](https://codecov.io/gh/apache/skywalking/pull/6480/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/6480?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/6480?src=pr&el=footer). Last update [9946ec4...5c9722d](https://codecov.io/gh/apache/skywalking/pull/6480?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6480: Remove unnecessary check for getSkyWalkingDynamicField invocation
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #6480:
URL: https://github.com/apache/skywalking/pull/6480#issuecomment-789727063
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/6480?src=pr&el=h1) Report
> Merging [#6480](https://codecov.io/gh/apache/skywalking/pull/6480?src=pr&el=desc) (9f84ae1) into [master](https://codecov.io/gh/apache/skywalking/commit/de6a731d72fb87dd574da1d9b42495fdd29b4311?el=desc) (de6a731) will **decrease** coverage by `22.02%`.
> The diff coverage is `19.04%`.
[![Impacted file tree graph](https://codecov.io/gh/apache/skywalking/pull/6480/graphs/tree.svg?width=650&height=150&src=pr&token=qrILxY5yA8)](https://codecov.io/gh/apache/skywalking/pull/6480?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #6480 +/- ##
=============================================
- Coverage 54.00% 31.98% -22.03%
+ Complexity 4075 2307 -1768
=============================================
Files 1777 988 -789
Lines 37757 23942 -13815
Branches 4153 2349 -1804
=============================================
- Hits 20392 7658 -12734
+ Misses 16385 15698 -687
+ Partials 980 586 -394
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/6480?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...g/oap/log/analyzer/dsl/spec/filter/FilterSpec.java](https://codecov.io/gh/apache/skywalking/pull/6480/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9sb2ctYW5hbHl6ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL2xvZy9hbmFseXplci9kc2wvc3BlYy9maWx0ZXIvRmlsdGVyU3BlYy5qYXZh) | `44.61% <0.00%> (-6.27%)` | `7.00 <0.00> (ø)` | |
| [...p/log/analyzer/dsl/spec/parser/TextParserSpec.java](https://codecov.io/gh/apache/skywalking/pull/6480/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9sb2ctYW5hbHl6ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL2xvZy9hbmFseXplci9kc2wvc3BlYy9wYXJzZXIvVGV4dFBhcnNlclNwZWMuamF2YQ==) | `64.28% <0.00%> (-10.72%)` | `4.00 <0.00> (ø)` | |
| [...p/log/analyzer/dsl/spec/parser/YamlParserSpec.java](https://codecov.io/gh/apache/skywalking/pull/6480/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9sb2ctYW5hbHl6ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL2xvZy9hbmFseXplci9kc2wvc3BlYy9wYXJzZXIvWWFtbFBhcnNlclNwZWMuamF2YQ==) | `75.00% <ø> (ø)` | `1.00 <0.00> (ø)` | |
| [...p/log/analyzer/dsl/spec/parser/JsonParserSpec.java](https://codecov.io/gh/apache/skywalking/pull/6480/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9sb2ctYW5hbHl6ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL2xvZy9hbmFseXplci9kc2wvc3BlYy9wYXJzZXIvSnNvblBhcnNlclNwZWMuamF2YQ==) | `80.00% <50.00%> (+5.00%)` | `1.00 <0.00> (ø)` | |
| [...g/analyzer/dsl/spec/parser/AbstractParserSpec.java](https://codecov.io/gh/apache/skywalking/pull/6480/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9sb2ctYW5hbHl6ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL2xvZy9hbmFseXplci9kc2wvc3BlYy9wYXJzZXIvQWJzdHJhY3RQYXJzZXJTcGVjLmphdmE=) | `100.00% <100.00%> (ø)` | `1.00 <1.00> (?)` | |
| [...pache/skywalking/apm/agent/core/base64/Base64.java](https://codecov.io/gh/apache/skywalking/pull/6480/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvYmFzZTY0L0Jhc2U2NC5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-3.00%)` | |
| [...che/skywalking/apm/agent/core/meter/MeterType.java](https://codecov.io/gh/apache/skywalking/pull/6480/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvbWV0ZXIvTWV0ZXJUeXBlLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (ø%)` | |
| [...skywalking/oap/server/core/alarm/AlarmMessage.java](https://codecov.io/gh/apache/skywalking/pull/6480/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYWxhcm0vQWxhcm1NZXNzYWdlLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...e/skywalking/apm/agent/core/meter/CounterMode.java](https://codecov.io/gh/apache/skywalking/pull/6480/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvbWV0ZXIvQ291bnRlck1vZGUuamF2YQ==) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (ø%)` | |
| [...ywalking/apm/agent/core/logging/core/LogLevel.java](https://codecov.io/gh/apache/skywalking/pull/6480/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvbG9nZ2luZy9jb3JlL0xvZ0xldmVsLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| ... and [1406 more](https://codecov.io/gh/apache/skywalking/pull/6480/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/6480?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/6480?src=pr&el=footer). Last update [cb16e52...a8c1e14](https://codecov.io/gh/apache/skywalking/pull/6480?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6480: Remove unnecessary check for getSkyWalkingDynamicField invocation
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #6480:
URL: https://github.com/apache/skywalking/pull/6480#issuecomment-789727063
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/6480?src=pr&el=h1) Report
> Merging [#6480](https://codecov.io/gh/apache/skywalking/pull/6480?src=pr&el=desc) (9f84ae1) into [master](https://codecov.io/gh/apache/skywalking/commit/de6a731d72fb87dd574da1d9b42495fdd29b4311?el=desc) (de6a731) will **decrease** coverage by `17.76%`.
> The diff coverage is `19.04%`.
[![Impacted file tree graph](https://codecov.io/gh/apache/skywalking/pull/6480/graphs/tree.svg?width=650&height=150&src=pr&token=qrILxY5yA8)](https://codecov.io/gh/apache/skywalking/pull/6480?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #6480 +/- ##
=============================================
- Coverage 54.00% 36.24% -17.77%
+ Complexity 4075 2632 -1443
=============================================
Files 1777 1022 -755
Lines 37757 24904 -12853
Branches 4153 2441 -1712
=============================================
- Hits 20392 9026 -11366
+ Misses 16385 15190 -1195
+ Partials 980 688 -292
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/6480?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...g/oap/log/analyzer/dsl/spec/filter/FilterSpec.java](https://codecov.io/gh/apache/skywalking/pull/6480/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9sb2ctYW5hbHl6ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL2xvZy9hbmFseXplci9kc2wvc3BlYy9maWx0ZXIvRmlsdGVyU3BlYy5qYXZh) | `44.61% <0.00%> (-6.27%)` | `7.00 <0.00> (ø)` | |
| [...p/log/analyzer/dsl/spec/parser/TextParserSpec.java](https://codecov.io/gh/apache/skywalking/pull/6480/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9sb2ctYW5hbHl6ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL2xvZy9hbmFseXplci9kc2wvc3BlYy9wYXJzZXIvVGV4dFBhcnNlclNwZWMuamF2YQ==) | `64.28% <0.00%> (-10.72%)` | `4.00 <0.00> (ø)` | |
| [...p/log/analyzer/dsl/spec/parser/YamlParserSpec.java](https://codecov.io/gh/apache/skywalking/pull/6480/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9sb2ctYW5hbHl6ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL2xvZy9hbmFseXplci9kc2wvc3BlYy9wYXJzZXIvWWFtbFBhcnNlclNwZWMuamF2YQ==) | `75.00% <ø> (ø)` | `1.00 <0.00> (ø)` | |
| [...p/log/analyzer/dsl/spec/parser/JsonParserSpec.java](https://codecov.io/gh/apache/skywalking/pull/6480/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9sb2ctYW5hbHl6ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL2xvZy9hbmFseXplci9kc2wvc3BlYy9wYXJzZXIvSnNvblBhcnNlclNwZWMuamF2YQ==) | `80.00% <50.00%> (+5.00%)` | `1.00 <0.00> (ø)` | |
| [...g/analyzer/dsl/spec/parser/AbstractParserSpec.java](https://codecov.io/gh/apache/skywalking/pull/6480/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9sb2ctYW5hbHl6ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL2xvZy9hbmFseXplci9kc2wvc3BlYy9wYXJzZXIvQWJzdHJhY3RQYXJzZXJTcGVjLmphdmE=) | `100.00% <100.00%> (ø)` | `1.00 <1.00> (?)` | |
| [...pache/skywalking/apm/agent/core/base64/Base64.java](https://codecov.io/gh/apache/skywalking/pull/6480/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvYmFzZTY0L0Jhc2U2NC5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-3.00%)` | |
| [...che/skywalking/apm/agent/core/meter/MeterType.java](https://codecov.io/gh/apache/skywalking/pull/6480/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvbWV0ZXIvTWV0ZXJUeXBlLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (ø%)` | |
| [...skywalking/oap/server/core/alarm/AlarmMessage.java](https://codecov.io/gh/apache/skywalking/pull/6480/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYWxhcm0vQWxhcm1NZXNzYWdlLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...e/skywalking/apm/agent/core/meter/CounterMode.java](https://codecov.io/gh/apache/skywalking/pull/6480/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvbWV0ZXIvQ291bnRlck1vZGUuamF2YQ==) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (ø%)` | |
| [...ywalking/apm/agent/core/logging/core/LogLevel.java](https://codecov.io/gh/apache/skywalking/pull/6480/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvbG9nZ2luZy9jb3JlL0xvZ0xldmVsLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| ... and [1365 more](https://codecov.io/gh/apache/skywalking/pull/6480/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/6480?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/6480?src=pr&el=footer). Last update [cb16e52...a8c1e14](https://codecov.io/gh/apache/skywalking/pull/6480?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6480: Remove unnecessary check for getSkyWalkingDynamicField invocation
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #6480:
URL: https://github.com/apache/skywalking/pull/6480#issuecomment-789727063
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/6480?src=pr&el=h1) Report
> Merging [#6480](https://codecov.io/gh/apache/skywalking/pull/6480?src=pr&el=desc) (b16aca4) into [master](https://codecov.io/gh/apache/skywalking/commit/cb16e524da2bf45258e67052443a6b9bc2460855?el=desc) (cb16e52) will **decrease** coverage by `9.73%`.
> The diff coverage is `n/a`.
[![Impacted file tree graph](https://codecov.io/gh/apache/skywalking/pull/6480/graphs/tree.svg?width=650&height=150&src=pr&token=qrILxY5yA8)](https://codecov.io/gh/apache/skywalking/pull/6480?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #6480 +/- ##
============================================
- Coverage 54.08% 44.35% -9.74%
+ Complexity 4088 3363 -725
============================================
Files 1778 1018 -760
Lines 37771 24871 -12900
Branches 4156 2437 -1719
============================================
- Hits 20429 11031 -9398
+ Misses 16361 12900 -3461
+ Partials 981 940 -41
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/6480?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...che/skywalking/apm/agent/core/meter/MeterType.java](https://codecov.io/gh/apache/skywalking/pull/6480/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvbWV0ZXIvTWV0ZXJUeXBlLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (ø%)` | |
| [...skywalking/oap/server/core/alarm/AlarmMessage.java](https://codecov.io/gh/apache/skywalking/pull/6480/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYWxhcm0vQWxhcm1NZXNzYWdlLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...e/skywalking/apm/agent/core/meter/CounterMode.java](https://codecov.io/gh/apache/skywalking/pull/6480/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvbWV0ZXIvQ291bnRlck1vZGUuamF2YQ==) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (ø%)` | |
| [...org/apache/skywalking/apm/toolkit/meter/Gauge.java](https://codecov.io/gh/apache/skywalking/pull/6480/diff?src=pr&el=tree#diff-YXBtLWFwcGxpY2F0aW9uLXRvb2xraXQvYXBtLXRvb2xraXQtbWV0ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL3Rvb2xraXQvbWV0ZXIvR2F1Z2UuamF2YQ==) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (ø%)` | |
| [...ng/oap/server/core/analysis/config/NoneStream.java](https://codecov.io/gh/apache/skywalking/pull/6480/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvY29uZmlnL05vbmVTdHJlYW0uamF2YQ==) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...g/oap/server/core/cluster/ClusterHealthStatus.java](https://codecov.io/gh/apache/skywalking/pull/6480/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvY2x1c3Rlci9DbHVzdGVySGVhbHRoU3RhdHVzLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (ø%)` | |
| [...ng/apm/agent/core/context/trace/LogDataEntity.java](https://codecov.io/gh/apache/skywalking/pull/6480/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29udGV4dC90cmFjZS9Mb2dEYXRhRW50aXR5LmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (ø%)` | |
| [...p/server/core/analysis/metrics/MinLongMetrics.java](https://codecov.io/gh/apache/skywalking/pull/6480/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0cmljcy9NaW5Mb25nTWV0cmljcy5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (ø%)` | |
| [...er/exporter/provider/grpc/GRPCExporterSetting.java](https://codecov.io/gh/apache/skywalking/pull/6480/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9leHBvcnRlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2V4cG9ydGVyL3Byb3ZpZGVyL2dycGMvR1JQQ0V4cG9ydGVyU2V0dGluZy5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (ø%)` | |
| [...log/analyzer/provider/log/ILogAnalyzerService.java](https://codecov.io/gh/apache/skywalking/pull/6480/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9sb2ctYW5hbHl6ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL2xvZy9hbmFseXplci9wcm92aWRlci9sb2cvSUxvZ0FuYWx5emVyU2VydmljZS5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| ... and [1291 more](https://codecov.io/gh/apache/skywalking/pull/6480/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/6480?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/6480?src=pr&el=footer). Last update [9946ec4...5c9722d](https://codecov.io/gh/apache/skywalking/pull/6480?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6480: Remove unnecessary check for getSkyWalkingDynamicField invocation
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #6480:
URL: https://github.com/apache/skywalking/pull/6480#issuecomment-789727063
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/6480?src=pr&el=h1) Report
> Merging [#6480](https://codecov.io/gh/apache/skywalking/pull/6480?src=pr&el=desc) (9f84ae1) into [master](https://codecov.io/gh/apache/skywalking/commit/de6a731d72fb87dd574da1d9b42495fdd29b4311?el=desc) (de6a731) will **decrease** coverage by `16.24%`.
> The diff coverage is `19.04%`.
[![Impacted file tree graph](https://codecov.io/gh/apache/skywalking/pull/6480/graphs/tree.svg?width=650&height=150&src=pr&token=qrILxY5yA8)](https://codecov.io/gh/apache/skywalking/pull/6480?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #6480 +/- ##
=============================================
- Coverage 54.00% 37.76% -16.25%
+ Complexity 4075 2711 -1364
=============================================
Files 1777 1025 -752
Lines 37757 24919 -12838
Branches 4153 2441 -1712
=============================================
- Hits 20392 9410 -10982
+ Misses 16385 14770 -1615
+ Partials 980 739 -241
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/6480?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...g/oap/log/analyzer/dsl/spec/filter/FilterSpec.java](https://codecov.io/gh/apache/skywalking/pull/6480/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9sb2ctYW5hbHl6ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL2xvZy9hbmFseXplci9kc2wvc3BlYy9maWx0ZXIvRmlsdGVyU3BlYy5qYXZh) | `44.61% <0.00%> (-6.27%)` | `7.00 <0.00> (ø)` | |
| [...p/log/analyzer/dsl/spec/parser/TextParserSpec.java](https://codecov.io/gh/apache/skywalking/pull/6480/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9sb2ctYW5hbHl6ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL2xvZy9hbmFseXplci9kc2wvc3BlYy9wYXJzZXIvVGV4dFBhcnNlclNwZWMuamF2YQ==) | `64.28% <0.00%> (-10.72%)` | `4.00 <0.00> (ø)` | |
| [...p/log/analyzer/dsl/spec/parser/YamlParserSpec.java](https://codecov.io/gh/apache/skywalking/pull/6480/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9sb2ctYW5hbHl6ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL2xvZy9hbmFseXplci9kc2wvc3BlYy9wYXJzZXIvWWFtbFBhcnNlclNwZWMuamF2YQ==) | `75.00% <ø> (ø)` | `1.00 <0.00> (ø)` | |
| [...p/log/analyzer/dsl/spec/parser/JsonParserSpec.java](https://codecov.io/gh/apache/skywalking/pull/6480/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9sb2ctYW5hbHl6ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL2xvZy9hbmFseXplci9kc2wvc3BlYy9wYXJzZXIvSnNvblBhcnNlclNwZWMuamF2YQ==) | `80.00% <50.00%> (+5.00%)` | `1.00 <0.00> (ø)` | |
| [...g/analyzer/dsl/spec/parser/AbstractParserSpec.java](https://codecov.io/gh/apache/skywalking/pull/6480/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9sb2ctYW5hbHl6ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL2xvZy9hbmFseXplci9kc2wvc3BlYy9wYXJzZXIvQWJzdHJhY3RQYXJzZXJTcGVjLmphdmE=) | `100.00% <100.00%> (ø)` | `1.00 <1.00> (?)` | |
| [...pache/skywalking/apm/agent/core/base64/Base64.java](https://codecov.io/gh/apache/skywalking/pull/6480/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvYmFzZTY0L0Jhc2U2NC5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-3.00%)` | |
| [...che/skywalking/apm/agent/core/meter/MeterType.java](https://codecov.io/gh/apache/skywalking/pull/6480/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvbWV0ZXIvTWV0ZXJUeXBlLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (ø%)` | |
| [...skywalking/oap/server/core/alarm/AlarmMessage.java](https://codecov.io/gh/apache/skywalking/pull/6480/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYWxhcm0vQWxhcm1NZXNzYWdlLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...e/skywalking/apm/agent/core/meter/CounterMode.java](https://codecov.io/gh/apache/skywalking/pull/6480/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvbWV0ZXIvQ291bnRlck1vZGUuamF2YQ==) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (ø%)` | |
| [...ywalking/apm/agent/core/logging/core/LogLevel.java](https://codecov.io/gh/apache/skywalking/pull/6480/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvbG9nZ2luZy9jb3JlL0xvZ0xldmVsLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| ... and [1358 more](https://codecov.io/gh/apache/skywalking/pull/6480/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/6480?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/6480?src=pr&el=footer). Last update [cb16e52...a8c1e14](https://codecov.io/gh/apache/skywalking/pull/6480?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] wu-sheng merged pull request #6480: Remove unnecessary check for getSkyWalkingDynamicField invocation
Posted by GitBox <gi...@apache.org>.
wu-sheng merged pull request #6480:
URL: https://github.com/apache/skywalking/pull/6480
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6480: Remove unnecessary check for getSkyWalkingDynamicField invocation
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #6480:
URL: https://github.com/apache/skywalking/pull/6480#issuecomment-789727063
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/6480?src=pr&el=h1) Report
> Merging [#6480](https://codecov.io/gh/apache/skywalking/pull/6480?src=pr&el=desc) (a8c1e14) into [master](https://codecov.io/gh/apache/skywalking/commit/de6a731d72fb87dd574da1d9b42495fdd29b4311?el=desc) (de6a731) will **decrease** coverage by `17.31%`.
> The diff coverage is `19.04%`.
[![Impacted file tree graph](https://codecov.io/gh/apache/skywalking/pull/6480/graphs/tree.svg?width=650&height=150&src=pr&token=qrILxY5yA8)](https://codecov.io/gh/apache/skywalking/pull/6480?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #6480 +/- ##
=============================================
- Coverage 54.00% 36.69% -17.32%
+ Complexity 4075 2690 -1385
=============================================
Files 1777 967 -810
Lines 37757 23373 -14384
Branches 4153 2256 -1897
=============================================
- Hits 20392 8576 -11816
+ Misses 16385 14074 -2311
+ Partials 980 723 -257
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/6480?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...g/oap/log/analyzer/dsl/spec/filter/FilterSpec.java](https://codecov.io/gh/apache/skywalking/pull/6480/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9sb2ctYW5hbHl6ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL2xvZy9hbmFseXplci9kc2wvc3BlYy9maWx0ZXIvRmlsdGVyU3BlYy5qYXZh) | `35.38% <0.00%> (-15.50%)` | `5.00 <0.00> (-2.00)` | |
| [...p/log/analyzer/dsl/spec/parser/TextParserSpec.java](https://codecov.io/gh/apache/skywalking/pull/6480/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9sb2ctYW5hbHl6ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL2xvZy9hbmFseXplci9kc2wvc3BlYy9wYXJzZXIvVGV4dFBhcnNlclNwZWMuamF2YQ==) | `14.28% <0.00%> (-60.72%)` | `1.00 <0.00> (-3.00)` | |
| [...p/log/analyzer/dsl/spec/parser/YamlParserSpec.java](https://codecov.io/gh/apache/skywalking/pull/6480/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9sb2ctYW5hbHl6ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL2xvZy9hbmFseXplci9kc2wvc3BlYy9wYXJzZXIvWWFtbFBhcnNlclNwZWMuamF2YQ==) | `75.00% <ø> (ø)` | `1.00 <0.00> (ø)` | |
| [...p/log/analyzer/dsl/spec/parser/JsonParserSpec.java](https://codecov.io/gh/apache/skywalking/pull/6480/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9sb2ctYW5hbHl6ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL2xvZy9hbmFseXplci9kc2wvc3BlYy9wYXJzZXIvSnNvblBhcnNlclNwZWMuamF2YQ==) | `80.00% <50.00%> (+5.00%)` | `1.00 <0.00> (ø)` | |
| [...g/analyzer/dsl/spec/parser/AbstractParserSpec.java](https://codecov.io/gh/apache/skywalking/pull/6480/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9sb2ctYW5hbHl6ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL2xvZy9hbmFseXplci9kc2wvc3BlYy9wYXJzZXIvQWJzdHJhY3RQYXJzZXJTcGVjLmphdmE=) | `100.00% <100.00%> (ø)` | `1.00 <1.00> (?)` | |
| [...skywalking/oap/server/core/alarm/AlarmMessage.java](https://codecov.io/gh/apache/skywalking/pull/6480/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYWxhcm0vQWxhcm1NZXNzYWdlLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...kywalking/oap/server/core/storage/AbstractDAO.java](https://codecov.io/gh/apache/skywalking/pull/6480/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvc3RvcmFnZS9BYnN0cmFjdERBTy5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-2.00%)` | |
| [...ng/oap/server/core/analysis/config/NoneStream.java](https://codecov.io/gh/apache/skywalking/pull/6480/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvY29uZmlnL05vbmVTdHJlYW0uamF2YQ==) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...g/oap/server/core/cluster/ClusterHealthStatus.java](https://codecov.io/gh/apache/skywalking/pull/6480/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvY2x1c3Rlci9DbHVzdGVySGVhbHRoU3RhdHVzLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (ø%)` | |
| [...ng/apm/agent/core/context/trace/LogDataEntity.java](https://codecov.io/gh/apache/skywalking/pull/6480/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29udGV4dC90cmFjZS9Mb2dEYXRhRW50aXR5LmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (ø%)` | |
| ... and [1375 more](https://codecov.io/gh/apache/skywalking/pull/6480/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/6480?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/6480?src=pr&el=footer). Last update [cb16e52...a8c1e14](https://codecov.io/gh/apache/skywalking/pull/6480?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6480: Remove unnecessary check for getSkyWalkingDynamicField invocation
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #6480:
URL: https://github.com/apache/skywalking/pull/6480#issuecomment-789727063
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/6480?src=pr&el=h1) Report
> Merging [#6480](https://codecov.io/gh/apache/skywalking/pull/6480?src=pr&el=desc) (a8c1e14) into [master](https://codecov.io/gh/apache/skywalking/commit/de6a731d72fb87dd574da1d9b42495fdd29b4311?el=desc) (de6a731) will **increase** coverage by `2.01%`.
> The diff coverage is `n/a`.
[![Impacted file tree graph](https://codecov.io/gh/apache/skywalking/pull/6480/graphs/tree.svg?width=650&height=150&src=pr&token=qrILxY5yA8)](https://codecov.io/gh/apache/skywalking/pull/6480?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #6480 +/- ##
============================================
+ Coverage 54.00% 56.02% +2.01%
+ Complexity 4075 822 -3253
============================================
Files 1777 181 -1596
Lines 37757 4377 -33380
Branches 4153 499 -3654
============================================
- Hits 20392 2452 -17940
+ Misses 16385 1613 -14772
+ Partials 980 312 -668
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/6480?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...ng/apm/agent/core/context/trace/LogDataEntity.java](https://codecov.io/gh/apache/skywalking/pull/6480/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29udGV4dC90cmFjZS9Mb2dEYXRhRW50aXR5LmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (ø%)` | |
| [...ent/core/context/status/ExceptionCheckContext.java](https://codecov.io/gh/apache/skywalking/pull/6480/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29udGV4dC9zdGF0dXMvRXhjZXB0aW9uQ2hlY2tDb250ZXh0LmphdmE=) | `0.00% <0.00%> (-90.91%)` | `0.00% <0.00%> (ø%)` | |
| [...t/status/HierarchyMatchExceptionCheckStrategy.java](https://codecov.io/gh/apache/skywalking/pull/6480/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29udGV4dC9zdGF0dXMvSGllcmFyY2h5TWF0Y2hFeGNlcHRpb25DaGVja1N0cmF0ZWd5LmphdmE=) | `9.09% <0.00%> (-90.91%)` | `1.00% <0.00%> (ø%)` | |
| [...alking/apm/agent/core/logging/core/FileWriter.java](https://codecov.io/gh/apache/skywalking/pull/6480/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvbG9nZ2luZy9jb3JlL0ZpbGVXcml0ZXIuamF2YQ==) | `0.00% <0.00%> (-88.10%)` | `0.00% <0.00%> (ø%)` | |
| [...king/apm/agent/core/context/util/KeyValuePair.java](https://codecov.io/gh/apache/skywalking/pull/6480/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29udGV4dC91dGlsL0tleVZhbHVlUGFpci5qYXZh) | `0.00% <0.00%> (-80.00%)` | `0.00% <0.00%> (ø%)` | |
| [...g/apm/agent/core/context/status/StatusChecker.java](https://codecov.io/gh/apache/skywalking/pull/6480/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29udGV4dC9zdGF0dXMvU3RhdHVzQ2hlY2tlci5qYXZh) | `23.80% <0.00%> (-76.20%)` | `1.00% <0.00%> (ø%)` | |
| [...ywalking/apm/agent/core/plugin/PluginSelector.java](https://codecov.io/gh/apache/skywalking/pull/6480/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcGx1Z2luL1BsdWdpblNlbGVjdG9yLmphdmE=) | `28.57% <0.00%> (-71.43%)` | `2.00% <0.00%> (ø%)` | |
| [.../agent/core/context/util/ThrowableTransformer.java](https://codecov.io/gh/apache/skywalking/pull/6480/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29udGV4dC91dGlsL1Rocm93YWJsZVRyYW5zZm9ybWVyLmphdmE=) | `0.00% <0.00%> (-69.24%)` | `0.00% <0.00%> (ø%)` | |
| [...re/logging/core/converters/AgentNameConverter.java](https://codecov.io/gh/apache/skywalking/pull/6480/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvbG9nZ2luZy9jb3JlL2NvbnZlcnRlcnMvQWdlbnROYW1lQ29udmVydGVyLmphdmE=) | `0.00% <0.00%> (-66.67%)` | `0.00% <0.00%> (ø%)` | |
| [...re/logging/core/converters/ThrowableConverter.java](https://codecov.io/gh/apache/skywalking/pull/6480/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvbG9nZ2luZy9jb3JlL2NvbnZlcnRlcnMvVGhyb3dhYmxlQ29udmVydGVyLmphdmE=) | `16.66% <0.00%> (-66.67%)` | `2.00% <0.00%> (ø%)` | |
| ... and [1691 more](https://codecov.io/gh/apache/skywalking/pull/6480/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/6480?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/6480?src=pr&el=footer). Last update [cb16e52...a8c1e14](https://codecov.io/gh/apache/skywalking/pull/6480?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] wu-sheng commented on pull request #6480: Remove unnecessary check for getSkyWalkingDynamicField invocation
Posted by GitBox <gi...@apache.org>.
wu-sheng commented on pull request #6480:
URL: https://github.com/apache/skywalking/pull/6480#issuecomment-790262200
> It is good for me, can you include a fix for #6481
Please don't mix 2 fixed in one commit. If this is good, please merge first.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6480: Remove unnecessary check for getSkyWalkingDynamicField invocation
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #6480:
URL: https://github.com/apache/skywalking/pull/6480#issuecomment-789727063
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/6480?src=pr&el=h1) Report
> Merging [#6480](https://codecov.io/gh/apache/skywalking/pull/6480?src=pr&el=desc) (a8c1e14) into [master](https://codecov.io/gh/apache/skywalking/commit/de6a731d72fb87dd574da1d9b42495fdd29b4311?el=desc) (de6a731) will **increase** coverage by `2.01%`.
> The diff coverage is `n/a`.
[![Impacted file tree graph](https://codecov.io/gh/apache/skywalking/pull/6480/graphs/tree.svg?width=650&height=150&src=pr&token=qrILxY5yA8)](https://codecov.io/gh/apache/skywalking/pull/6480?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #6480 +/- ##
============================================
+ Coverage 54.00% 56.02% +2.01%
+ Complexity 4075 822 -3253
============================================
Files 1777 181 -1596
Lines 37757 4377 -33380
Branches 4153 499 -3654
============================================
- Hits 20392 2452 -17940
+ Misses 16385 1613 -14772
+ Partials 980 312 -668
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/6480?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...ng/apm/agent/core/context/trace/LogDataEntity.java](https://codecov.io/gh/apache/skywalking/pull/6480/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29udGV4dC90cmFjZS9Mb2dEYXRhRW50aXR5LmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (ø%)` | |
| [...ent/core/context/status/ExceptionCheckContext.java](https://codecov.io/gh/apache/skywalking/pull/6480/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29udGV4dC9zdGF0dXMvRXhjZXB0aW9uQ2hlY2tDb250ZXh0LmphdmE=) | `0.00% <0.00%> (-90.91%)` | `0.00% <0.00%> (ø%)` | |
| [...t/status/HierarchyMatchExceptionCheckStrategy.java](https://codecov.io/gh/apache/skywalking/pull/6480/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29udGV4dC9zdGF0dXMvSGllcmFyY2h5TWF0Y2hFeGNlcHRpb25DaGVja1N0cmF0ZWd5LmphdmE=) | `9.09% <0.00%> (-90.91%)` | `1.00% <0.00%> (ø%)` | |
| [...alking/apm/agent/core/logging/core/FileWriter.java](https://codecov.io/gh/apache/skywalking/pull/6480/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvbG9nZ2luZy9jb3JlL0ZpbGVXcml0ZXIuamF2YQ==) | `0.00% <0.00%> (-88.10%)` | `0.00% <0.00%> (ø%)` | |
| [...king/apm/agent/core/context/util/KeyValuePair.java](https://codecov.io/gh/apache/skywalking/pull/6480/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29udGV4dC91dGlsL0tleVZhbHVlUGFpci5qYXZh) | `0.00% <0.00%> (-80.00%)` | `0.00% <0.00%> (ø%)` | |
| [...g/apm/agent/core/context/status/StatusChecker.java](https://codecov.io/gh/apache/skywalking/pull/6480/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29udGV4dC9zdGF0dXMvU3RhdHVzQ2hlY2tlci5qYXZh) | `23.80% <0.00%> (-76.20%)` | `1.00% <0.00%> (ø%)` | |
| [...ywalking/apm/agent/core/plugin/PluginSelector.java](https://codecov.io/gh/apache/skywalking/pull/6480/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcGx1Z2luL1BsdWdpblNlbGVjdG9yLmphdmE=) | `28.57% <0.00%> (-71.43%)` | `2.00% <0.00%> (ø%)` | |
| [.../agent/core/context/util/ThrowableTransformer.java](https://codecov.io/gh/apache/skywalking/pull/6480/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29udGV4dC91dGlsL1Rocm93YWJsZVRyYW5zZm9ybWVyLmphdmE=) | `0.00% <0.00%> (-69.24%)` | `0.00% <0.00%> (ø%)` | |
| [...re/logging/core/converters/AgentNameConverter.java](https://codecov.io/gh/apache/skywalking/pull/6480/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvbG9nZ2luZy9jb3JlL2NvbnZlcnRlcnMvQWdlbnROYW1lQ29udmVydGVyLmphdmE=) | `0.00% <0.00%> (-66.67%)` | `0.00% <0.00%> (ø%)` | |
| [...re/logging/core/converters/ThrowableConverter.java](https://codecov.io/gh/apache/skywalking/pull/6480/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvbG9nZ2luZy9jb3JlL2NvbnZlcnRlcnMvVGhyb3dhYmxlQ29udmVydGVyLmphdmE=) | `16.66% <0.00%> (-66.67%)` | `2.00% <0.00%> (ø%)` | |
| ... and [1691 more](https://codecov.io/gh/apache/skywalking/pull/6480/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/6480?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/6480?src=pr&el=footer). Last update [cb16e52...a8c1e14](https://codecov.io/gh/apache/skywalking/pull/6480?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6480: Remove unnecessary check for getSkyWalkingDynamicField invocation
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #6480:
URL: https://github.com/apache/skywalking/pull/6480#issuecomment-789727063
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/6480?src=pr&el=h1) Report
> Merging [#6480](https://codecov.io/gh/apache/skywalking/pull/6480?src=pr&el=desc) (9f84ae1) into [master](https://codecov.io/gh/apache/skywalking/commit/de6a731d72fb87dd574da1d9b42495fdd29b4311?el=desc) (de6a731) will **decrease** coverage by `16.24%`.
> The diff coverage is `19.04%`.
[![Impacted file tree graph](https://codecov.io/gh/apache/skywalking/pull/6480/graphs/tree.svg?width=650&height=150&src=pr&token=qrILxY5yA8)](https://codecov.io/gh/apache/skywalking/pull/6480?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #6480 +/- ##
=============================================
- Coverage 54.00% 37.76% -16.25%
+ Complexity 4075 2711 -1364
=============================================
Files 1777 1025 -752
Lines 37757 24919 -12838
Branches 4153 2441 -1712
=============================================
- Hits 20392 9410 -10982
+ Misses 16385 14770 -1615
+ Partials 980 739 -241
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/6480?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...g/oap/log/analyzer/dsl/spec/filter/FilterSpec.java](https://codecov.io/gh/apache/skywalking/pull/6480/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9sb2ctYW5hbHl6ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL2xvZy9hbmFseXplci9kc2wvc3BlYy9maWx0ZXIvRmlsdGVyU3BlYy5qYXZh) | `44.61% <0.00%> (-6.27%)` | `7.00 <0.00> (ø)` | |
| [...p/log/analyzer/dsl/spec/parser/TextParserSpec.java](https://codecov.io/gh/apache/skywalking/pull/6480/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9sb2ctYW5hbHl6ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL2xvZy9hbmFseXplci9kc2wvc3BlYy9wYXJzZXIvVGV4dFBhcnNlclNwZWMuamF2YQ==) | `64.28% <0.00%> (-10.72%)` | `4.00 <0.00> (ø)` | |
| [...p/log/analyzer/dsl/spec/parser/YamlParserSpec.java](https://codecov.io/gh/apache/skywalking/pull/6480/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9sb2ctYW5hbHl6ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL2xvZy9hbmFseXplci9kc2wvc3BlYy9wYXJzZXIvWWFtbFBhcnNlclNwZWMuamF2YQ==) | `75.00% <ø> (ø)` | `1.00 <0.00> (ø)` | |
| [...p/log/analyzer/dsl/spec/parser/JsonParserSpec.java](https://codecov.io/gh/apache/skywalking/pull/6480/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9sb2ctYW5hbHl6ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL2xvZy9hbmFseXplci9kc2wvc3BlYy9wYXJzZXIvSnNvblBhcnNlclNwZWMuamF2YQ==) | `80.00% <50.00%> (+5.00%)` | `1.00 <0.00> (ø)` | |
| [...g/analyzer/dsl/spec/parser/AbstractParserSpec.java](https://codecov.io/gh/apache/skywalking/pull/6480/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9sb2ctYW5hbHl6ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL2xvZy9hbmFseXplci9kc2wvc3BlYy9wYXJzZXIvQWJzdHJhY3RQYXJzZXJTcGVjLmphdmE=) | `100.00% <100.00%> (ø)` | `1.00 <1.00> (?)` | |
| [...pache/skywalking/apm/agent/core/base64/Base64.java](https://codecov.io/gh/apache/skywalking/pull/6480/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvYmFzZTY0L0Jhc2U2NC5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-3.00%)` | |
| [...che/skywalking/apm/agent/core/meter/MeterType.java](https://codecov.io/gh/apache/skywalking/pull/6480/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvbWV0ZXIvTWV0ZXJUeXBlLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (ø%)` | |
| [...skywalking/oap/server/core/alarm/AlarmMessage.java](https://codecov.io/gh/apache/skywalking/pull/6480/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYWxhcm0vQWxhcm1NZXNzYWdlLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...e/skywalking/apm/agent/core/meter/CounterMode.java](https://codecov.io/gh/apache/skywalking/pull/6480/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvbWV0ZXIvQ291bnRlck1vZGUuamF2YQ==) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (ø%)` | |
| [...ywalking/apm/agent/core/logging/core/LogLevel.java](https://codecov.io/gh/apache/skywalking/pull/6480/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvbG9nZ2luZy9jb3JlL0xvZ0xldmVsLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| ... and [1358 more](https://codecov.io/gh/apache/skywalking/pull/6480/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/6480?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/6480?src=pr&el=footer). Last update [cb16e52...a8c1e14](https://codecov.io/gh/apache/skywalking/pull/6480?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6480: Remove unnecessary check for getSkyWalkingDynamicField invocation
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #6480:
URL: https://github.com/apache/skywalking/pull/6480#issuecomment-789727063
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/6480?src=pr&el=h1) Report
> Merging [#6480](https://codecov.io/gh/apache/skywalking/pull/6480?src=pr&el=desc) (9f84ae1) into [master](https://codecov.io/gh/apache/skywalking/commit/de6a731d72fb87dd574da1d9b42495fdd29b4311?el=desc) (de6a731) will **decrease** coverage by `54.00%`.
> The diff coverage is `n/a`.
[![Impacted file tree graph](https://codecov.io/gh/apache/skywalking/pull/6480/graphs/tree.svg?width=650&height=150&src=pr&token=qrILxY5yA8)](https://codecov.io/gh/apache/skywalking/pull/6480?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #6480 +/- ##
============================================
- Coverage 54.00% 0.00% -54.01%
============================================
Files 1777 176 -1601
Lines 37757 4291 -33466
Branches 4153 493 -3660
============================================
- Hits 20392 0 -20392
+ Misses 16385 4291 -12094
+ Partials 980 0 -980
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/6480?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...pache/skywalking/apm/agent/core/base64/Base64.java](https://codecov.io/gh/apache/skywalking/pull/6480/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvYmFzZTY0L0Jhc2U2NC5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-3.00%)` | |
| [...king/apm/util/RunnableWithExceptionProtection.java](https://codecov.io/gh/apache/skywalking/pull/6480/diff?src=pr&el=tree#diff-YXBtLWNvbW1vbnMvYXBtLXV0aWwvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL3V0aWwvUnVubmFibGVXaXRoRXhjZXB0aW9uUHJvdGVjdGlvbi5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-2.00%)` | |
| [...ywalking/apm/agent/core/logging/core/LogLevel.java](https://codecov.io/gh/apache/skywalking/pull/6480/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvbG9nZ2luZy9jb3JlL0xvZ0xldmVsLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...ywalking/apm/agent/core/plugin/EnhanceContext.java](https://codecov.io/gh/apache/skywalking/pull/6480/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcGx1Z2luL0VuaGFuY2VDb250ZXh0LmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-5.00%)` | |
| [...ywalking/apm/agent/core/plugin/PluginSelector.java](https://codecov.io/gh/apache/skywalking/pull/6480/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcGx1Z2luL1BsdWdpblNlbGVjdG9yLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-2.00%)` | |
| [...ywalking/apm/agent/core/profile/ProfileStatus.java](https://codecov.io/gh/apache/skywalking/pull/6480/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcHJvZmlsZS9Qcm9maWxlU3RhdHVzLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...walking/apm/agent/core/context/SW8CarrierItem.java](https://codecov.io/gh/apache/skywalking/pull/6480/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29udGV4dC9TVzhDYXJyaWVySXRlbS5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-2.00%)` | |
| [...walking/apm/agent/core/jvm/cpu/SunCpuAccessor.java](https://codecov.io/gh/apache/skywalking/pull/6480/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvanZtL2NwdS9TdW5DcHVBY2Nlc3Nvci5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-2.00%)` | |
| [...walking/apm/agent/core/logging/core/LogOutput.java](https://codecov.io/gh/apache/skywalking/pull/6480/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvbG9nZ2luZy9jb3JlL0xvZ091dHB1dC5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...walking/apm/agent/core/plugin/match/NameMatch.java](https://codecov.io/gh/apache/skywalking/pull/6480/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcGx1Z2luL21hdGNoL05hbWVNYXRjaC5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-3.00%)` | |
| ... and [1750 more](https://codecov.io/gh/apache/skywalking/pull/6480/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/6480?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/6480?src=pr&el=footer). Last update [cb16e52...a8c1e14](https://codecov.io/gh/apache/skywalking/pull/6480?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6480: Remove unnecessary check for getSkyWalkingDynamicField invocation
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #6480:
URL: https://github.com/apache/skywalking/pull/6480#issuecomment-789727063
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/6480?src=pr&el=h1) Report
> Merging [#6480](https://codecov.io/gh/apache/skywalking/pull/6480?src=pr&el=desc) (9f84ae1) into [master](https://codecov.io/gh/apache/skywalking/commit/de6a731d72fb87dd574da1d9b42495fdd29b4311?el=desc) (de6a731) will **decrease** coverage by `54.00%`.
> The diff coverage is `n/a`.
[![Impacted file tree graph](https://codecov.io/gh/apache/skywalking/pull/6480/graphs/tree.svg?width=650&height=150&src=pr&token=qrILxY5yA8)](https://codecov.io/gh/apache/skywalking/pull/6480?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #6480 +/- ##
============================================
- Coverage 54.00% 0.00% -54.01%
============================================
Files 1777 199 -1578
Lines 37757 4706 -33051
Branches 4153 548 -3605
============================================
- Hits 20392 0 -20392
+ Misses 16385 4706 -11679
+ Partials 980 0 -980
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/6480?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...pache/skywalking/apm/agent/core/base64/Base64.java](https://codecov.io/gh/apache/skywalking/pull/6480/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvYmFzZTY0L0Jhc2U2NC5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-3.00%)` | |
| [...che/skywalking/apm/agent/core/meter/MeterType.java](https://codecov.io/gh/apache/skywalking/pull/6480/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvbWV0ZXIvTWV0ZXJUeXBlLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (ø%)` | |
| [...e/skywalking/apm/agent/core/meter/CounterMode.java](https://codecov.io/gh/apache/skywalking/pull/6480/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvbWV0ZXIvQ291bnRlck1vZGUuamF2YQ==) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (ø%)` | |
| [...king/apm/util/RunnableWithExceptionProtection.java](https://codecov.io/gh/apache/skywalking/pull/6480/diff?src=pr&el=tree#diff-YXBtLWNvbW1vbnMvYXBtLXV0aWwvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL3V0aWwvUnVubmFibGVXaXRoRXhjZXB0aW9uUHJvdGVjdGlvbi5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-2.00%)` | |
| [...ywalking/apm/agent/core/logging/core/LogLevel.java](https://codecov.io/gh/apache/skywalking/pull/6480/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvbG9nZ2luZy9jb3JlL0xvZ0xldmVsLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...ywalking/apm/agent/core/plugin/EnhanceContext.java](https://codecov.io/gh/apache/skywalking/pull/6480/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcGx1Z2luL0VuaGFuY2VDb250ZXh0LmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-5.00%)` | |
| [...ywalking/apm/agent/core/plugin/PluginSelector.java](https://codecov.io/gh/apache/skywalking/pull/6480/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcGx1Z2luL1BsdWdpblNlbGVjdG9yLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-2.00%)` | |
| [...ywalking/apm/agent/core/profile/ProfileStatus.java](https://codecov.io/gh/apache/skywalking/pull/6480/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcHJvZmlsZS9Qcm9maWxlU3RhdHVzLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...walking/apm/agent/core/context/SW8CarrierItem.java](https://codecov.io/gh/apache/skywalking/pull/6480/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29udGV4dC9TVzhDYXJyaWVySXRlbS5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-2.00%)` | |
| [...walking/apm/agent/core/jvm/cpu/SunCpuAccessor.java](https://codecov.io/gh/apache/skywalking/pull/6480/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvanZtL2NwdS9TdW5DcHVBY2Nlc3Nvci5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-2.00%)` | |
| ... and [1749 more](https://codecov.io/gh/apache/skywalking/pull/6480/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/6480?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/6480?src=pr&el=footer). Last update [cb16e52...a8c1e14](https://codecov.io/gh/apache/skywalking/pull/6480?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6480: Remove unnecessary check for getSkyWalkingDynamicField invocation
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #6480:
URL: https://github.com/apache/skywalking/pull/6480#issuecomment-789727063
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/6480?src=pr&el=h1) Report
> Merging [#6480](https://codecov.io/gh/apache/skywalking/pull/6480?src=pr&el=desc) (9f84ae1) into [master](https://codecov.io/gh/apache/skywalking/commit/de6a731d72fb87dd574da1d9b42495fdd29b4311?el=desc) (de6a731) will **decrease** coverage by `17.78%`.
> The diff coverage is `19.04%`.
[![Impacted file tree graph](https://codecov.io/gh/apache/skywalking/pull/6480/graphs/tree.svg?width=650&height=150&src=pr&token=qrILxY5yA8)](https://codecov.io/gh/apache/skywalking/pull/6480?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #6480 +/- ##
=============================================
- Coverage 54.00% 36.22% -17.79%
+ Complexity 4075 2632 -1443
=============================================
Files 1777 1024 -753
Lines 37757 24915 -12842
Branches 4153 2441 -1712
=============================================
- Hits 20392 9026 -11366
+ Misses 16385 15201 -1184
+ Partials 980 688 -292
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/6480?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...g/oap/log/analyzer/dsl/spec/filter/FilterSpec.java](https://codecov.io/gh/apache/skywalking/pull/6480/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9sb2ctYW5hbHl6ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL2xvZy9hbmFseXplci9kc2wvc3BlYy9maWx0ZXIvRmlsdGVyU3BlYy5qYXZh) | `44.61% <0.00%> (-6.27%)` | `7.00 <0.00> (ø)` | |
| [...p/log/analyzer/dsl/spec/parser/TextParserSpec.java](https://codecov.io/gh/apache/skywalking/pull/6480/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9sb2ctYW5hbHl6ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL2xvZy9hbmFseXplci9kc2wvc3BlYy9wYXJzZXIvVGV4dFBhcnNlclNwZWMuamF2YQ==) | `64.28% <0.00%> (-10.72%)` | `4.00 <0.00> (ø)` | |
| [...p/log/analyzer/dsl/spec/parser/YamlParserSpec.java](https://codecov.io/gh/apache/skywalking/pull/6480/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9sb2ctYW5hbHl6ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL2xvZy9hbmFseXplci9kc2wvc3BlYy9wYXJzZXIvWWFtbFBhcnNlclNwZWMuamF2YQ==) | `75.00% <ø> (ø)` | `1.00 <0.00> (ø)` | |
| [...p/log/analyzer/dsl/spec/parser/JsonParserSpec.java](https://codecov.io/gh/apache/skywalking/pull/6480/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9sb2ctYW5hbHl6ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL2xvZy9hbmFseXplci9kc2wvc3BlYy9wYXJzZXIvSnNvblBhcnNlclNwZWMuamF2YQ==) | `80.00% <50.00%> (+5.00%)` | `1.00 <0.00> (ø)` | |
| [...g/analyzer/dsl/spec/parser/AbstractParserSpec.java](https://codecov.io/gh/apache/skywalking/pull/6480/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9sb2ctYW5hbHl6ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL2xvZy9hbmFseXplci9kc2wvc3BlYy9wYXJzZXIvQWJzdHJhY3RQYXJzZXJTcGVjLmphdmE=) | `100.00% <100.00%> (ø)` | `1.00 <1.00> (?)` | |
| [...pache/skywalking/apm/agent/core/base64/Base64.java](https://codecov.io/gh/apache/skywalking/pull/6480/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvYmFzZTY0L0Jhc2U2NC5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-3.00%)` | |
| [...che/skywalking/apm/agent/core/meter/MeterType.java](https://codecov.io/gh/apache/skywalking/pull/6480/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvbWV0ZXIvTWV0ZXJUeXBlLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (ø%)` | |
| [...skywalking/oap/server/core/alarm/AlarmMessage.java](https://codecov.io/gh/apache/skywalking/pull/6480/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYWxhcm0vQWxhcm1NZXNzYWdlLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...e/skywalking/apm/agent/core/meter/CounterMode.java](https://codecov.io/gh/apache/skywalking/pull/6480/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvbWV0ZXIvQ291bnRlck1vZGUuamF2YQ==) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (ø%)` | |
| [...ywalking/apm/agent/core/logging/core/LogLevel.java](https://codecov.io/gh/apache/skywalking/pull/6480/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvbG9nZ2luZy9jb3JlL0xvZ0xldmVsLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| ... and [1365 more](https://codecov.io/gh/apache/skywalking/pull/6480/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/6480?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/6480?src=pr&el=footer). Last update [cb16e52...a8c1e14](https://codecov.io/gh/apache/skywalking/pull/6480?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6480: Remove unnecessary check for getSkyWalkingDynamicField invocation
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #6480:
URL: https://github.com/apache/skywalking/pull/6480#issuecomment-789727063
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/6480?src=pr&el=h1) Report
> Merging [#6480](https://codecov.io/gh/apache/skywalking/pull/6480?src=pr&el=desc) (b16aca4) into [master](https://codecov.io/gh/apache/skywalking/commit/cb16e524da2bf45258e67052443a6b9bc2460855?el=desc) (cb16e52) will **decrease** coverage by `7.93%`.
> The diff coverage is `n/a`.
[![Impacted file tree graph](https://codecov.io/gh/apache/skywalking/pull/6480/graphs/tree.svg?width=650&height=150&src=pr&token=qrILxY5yA8)](https://codecov.io/gh/apache/skywalking/pull/6480?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #6480 +/- ##
============================================
- Coverage 54.08% 46.14% -7.94%
+ Complexity 4088 3491 -597
============================================
Files 1778 1020 -758
Lines 37771 24882 -12889
Branches 4156 2437 -1719
============================================
- Hits 20429 11483 -8946
+ Misses 16361 12419 -3942
+ Partials 981 980 -1
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/6480?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...che/skywalking/apm/agent/core/meter/MeterType.java](https://codecov.io/gh/apache/skywalking/pull/6480/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvbWV0ZXIvTWV0ZXJUeXBlLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (ø%)` | |
| [...skywalking/oap/server/core/alarm/AlarmMessage.java](https://codecov.io/gh/apache/skywalking/pull/6480/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYWxhcm0vQWxhcm1NZXNzYWdlLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...e/skywalking/apm/agent/core/meter/CounterMode.java](https://codecov.io/gh/apache/skywalking/pull/6480/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvbWV0ZXIvQ291bnRlck1vZGUuamF2YQ==) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (ø%)` | |
| [...org/apache/skywalking/apm/toolkit/meter/Gauge.java](https://codecov.io/gh/apache/skywalking/pull/6480/diff?src=pr&el=tree#diff-YXBtLWFwcGxpY2F0aW9uLXRvb2xraXQvYXBtLXRvb2xraXQtbWV0ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL3Rvb2xraXQvbWV0ZXIvR2F1Z2UuamF2YQ==) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (ø%)` | |
| [...ng/oap/server/core/analysis/config/NoneStream.java](https://codecov.io/gh/apache/skywalking/pull/6480/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvY29uZmlnL05vbmVTdHJlYW0uamF2YQ==) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...g/oap/server/core/cluster/ClusterHealthStatus.java](https://codecov.io/gh/apache/skywalking/pull/6480/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvY2x1c3Rlci9DbHVzdGVySGVhbHRoU3RhdHVzLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (ø%)` | |
| [...ng/apm/agent/core/context/trace/LogDataEntity.java](https://codecov.io/gh/apache/skywalking/pull/6480/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29udGV4dC90cmFjZS9Mb2dEYXRhRW50aXR5LmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (ø%)` | |
| [...p/server/core/analysis/metrics/MinLongMetrics.java](https://codecov.io/gh/apache/skywalking/pull/6480/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0cmljcy9NaW5Mb25nTWV0cmljcy5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (ø%)` | |
| [...er/exporter/provider/grpc/GRPCExporterSetting.java](https://codecov.io/gh/apache/skywalking/pull/6480/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9leHBvcnRlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2V4cG9ydGVyL3Byb3ZpZGVyL2dycGMvR1JQQ0V4cG9ydGVyU2V0dGluZy5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (ø%)` | |
| [...ent/core/plugin/bytebuddy/ReturnTypeNameMatch.java](https://codecov.io/gh/apache/skywalking/pull/6480/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcGx1Z2luL2J5dGVidWRkeS9SZXR1cm5UeXBlTmFtZU1hdGNoLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (ø%)` | |
| ... and [1281 more](https://codecov.io/gh/apache/skywalking/pull/6480/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/6480?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/6480?src=pr&el=footer). Last update [9946ec4...5c9722d](https://codecov.io/gh/apache/skywalking/pull/6480?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6480: Remove unnecessary check for getSkyWalkingDynamicField invocation
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #6480:
URL: https://github.com/apache/skywalking/pull/6480#issuecomment-789727063
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/6480?src=pr&el=h1) Report
> Merging [#6480](https://codecov.io/gh/apache/skywalking/pull/6480?src=pr&el=desc) (9f84ae1) into [master](https://codecov.io/gh/apache/skywalking/commit/de6a731d72fb87dd574da1d9b42495fdd29b4311?el=desc) (de6a731) will **decrease** coverage by `54.00%`.
> The diff coverage is `n/a`.
[![Impacted file tree graph](https://codecov.io/gh/apache/skywalking/pull/6480/graphs/tree.svg?width=650&height=150&src=pr&token=qrILxY5yA8)](https://codecov.io/gh/apache/skywalking/pull/6480?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #6480 +/- ##
============================================
- Coverage 54.00% 0.00% -54.01%
============================================
Files 1777 182 -1595
Lines 37757 4359 -33398
Branches 4153 498 -3655
============================================
- Hits 20392 0 -20392
+ Misses 16385 4359 -12026
+ Partials 980 0 -980
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/6480?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...pache/skywalking/apm/agent/core/base64/Base64.java](https://codecov.io/gh/apache/skywalking/pull/6480/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvYmFzZTY0L0Jhc2U2NC5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-3.00%)` | |
| [...king/apm/util/RunnableWithExceptionProtection.java](https://codecov.io/gh/apache/skywalking/pull/6480/diff?src=pr&el=tree#diff-YXBtLWNvbW1vbnMvYXBtLXV0aWwvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL3V0aWwvUnVubmFibGVXaXRoRXhjZXB0aW9uUHJvdGVjdGlvbi5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-2.00%)` | |
| [...ywalking/apm/agent/core/logging/core/LogLevel.java](https://codecov.io/gh/apache/skywalking/pull/6480/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvbG9nZ2luZy9jb3JlL0xvZ0xldmVsLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...ywalking/apm/agent/core/plugin/EnhanceContext.java](https://codecov.io/gh/apache/skywalking/pull/6480/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcGx1Z2luL0VuaGFuY2VDb250ZXh0LmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-5.00%)` | |
| [...ywalking/apm/agent/core/plugin/PluginSelector.java](https://codecov.io/gh/apache/skywalking/pull/6480/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcGx1Z2luL1BsdWdpblNlbGVjdG9yLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-2.00%)` | |
| [...ywalking/apm/agent/core/profile/ProfileStatus.java](https://codecov.io/gh/apache/skywalking/pull/6480/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcHJvZmlsZS9Qcm9maWxlU3RhdHVzLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...walking/apm/agent/core/context/SW8CarrierItem.java](https://codecov.io/gh/apache/skywalking/pull/6480/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29udGV4dC9TVzhDYXJyaWVySXRlbS5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-2.00%)` | |
| [...walking/apm/agent/core/jvm/cpu/SunCpuAccessor.java](https://codecov.io/gh/apache/skywalking/pull/6480/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvanZtL2NwdS9TdW5DcHVBY2Nlc3Nvci5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-2.00%)` | |
| [...walking/apm/agent/core/logging/core/LogOutput.java](https://codecov.io/gh/apache/skywalking/pull/6480/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvbG9nZ2luZy9jb3JlL0xvZ091dHB1dC5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...walking/apm/agent/core/plugin/match/NameMatch.java](https://codecov.io/gh/apache/skywalking/pull/6480/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcGx1Z2luL21hdGNoL05hbWVNYXRjaC5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-3.00%)` | |
| ... and [1748 more](https://codecov.io/gh/apache/skywalking/pull/6480/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/6480?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/6480?src=pr&el=footer). Last update [cb16e52...a8c1e14](https://codecov.io/gh/apache/skywalking/pull/6480?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6480: Remove unnecessary check for getSkyWalkingDynamicField invocation
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #6480:
URL: https://github.com/apache/skywalking/pull/6480#issuecomment-789727063
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/6480?src=pr&el=h1) Report
> Merging [#6480](https://codecov.io/gh/apache/skywalking/pull/6480?src=pr&el=desc) (9f84ae1) into [master](https://codecov.io/gh/apache/skywalking/commit/de6a731d72fb87dd574da1d9b42495fdd29b4311?el=desc) (de6a731) will **decrease** coverage by `17.01%`.
> The diff coverage is `19.04%`.
[![Impacted file tree graph](https://codecov.io/gh/apache/skywalking/pull/6480/graphs/tree.svg?width=650&height=150&src=pr&token=qrILxY5yA8)](https://codecov.io/gh/apache/skywalking/pull/6480?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #6480 +/- ##
=============================================
- Coverage 54.00% 36.98% -17.02%
+ Complexity 4075 2663 -1412
=============================================
Files 1777 1024 -753
Lines 37757 24915 -12842
Branches 4153 2441 -1712
=============================================
- Hits 20392 9216 -11176
+ Misses 16385 14980 -1405
+ Partials 980 719 -261
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/6480?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...g/oap/log/analyzer/dsl/spec/filter/FilterSpec.java](https://codecov.io/gh/apache/skywalking/pull/6480/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9sb2ctYW5hbHl6ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL2xvZy9hbmFseXplci9kc2wvc3BlYy9maWx0ZXIvRmlsdGVyU3BlYy5qYXZh) | `44.61% <0.00%> (-6.27%)` | `7.00 <0.00> (ø)` | |
| [...p/log/analyzer/dsl/spec/parser/TextParserSpec.java](https://codecov.io/gh/apache/skywalking/pull/6480/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9sb2ctYW5hbHl6ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL2xvZy9hbmFseXplci9kc2wvc3BlYy9wYXJzZXIvVGV4dFBhcnNlclNwZWMuamF2YQ==) | `64.28% <0.00%> (-10.72%)` | `4.00 <0.00> (ø)` | |
| [...p/log/analyzer/dsl/spec/parser/YamlParserSpec.java](https://codecov.io/gh/apache/skywalking/pull/6480/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9sb2ctYW5hbHl6ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL2xvZy9hbmFseXplci9kc2wvc3BlYy9wYXJzZXIvWWFtbFBhcnNlclNwZWMuamF2YQ==) | `75.00% <ø> (ø)` | `1.00 <0.00> (ø)` | |
| [...p/log/analyzer/dsl/spec/parser/JsonParserSpec.java](https://codecov.io/gh/apache/skywalking/pull/6480/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9sb2ctYW5hbHl6ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL2xvZy9hbmFseXplci9kc2wvc3BlYy9wYXJzZXIvSnNvblBhcnNlclNwZWMuamF2YQ==) | `80.00% <50.00%> (+5.00%)` | `1.00 <0.00> (ø)` | |
| [...g/analyzer/dsl/spec/parser/AbstractParserSpec.java](https://codecov.io/gh/apache/skywalking/pull/6480/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9sb2ctYW5hbHl6ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL2xvZy9hbmFseXplci9kc2wvc3BlYy9wYXJzZXIvQWJzdHJhY3RQYXJzZXJTcGVjLmphdmE=) | `100.00% <100.00%> (ø)` | `1.00 <1.00> (?)` | |
| [...pache/skywalking/apm/agent/core/base64/Base64.java](https://codecov.io/gh/apache/skywalking/pull/6480/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvYmFzZTY0L0Jhc2U2NC5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-3.00%)` | |
| [...che/skywalking/apm/agent/core/meter/MeterType.java](https://codecov.io/gh/apache/skywalking/pull/6480/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvbWV0ZXIvTWV0ZXJUeXBlLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (ø%)` | |
| [...skywalking/oap/server/core/alarm/AlarmMessage.java](https://codecov.io/gh/apache/skywalking/pull/6480/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYWxhcm0vQWxhcm1NZXNzYWdlLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...e/skywalking/apm/agent/core/meter/CounterMode.java](https://codecov.io/gh/apache/skywalking/pull/6480/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvbWV0ZXIvQ291bnRlck1vZGUuamF2YQ==) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (ø%)` | |
| [...ywalking/apm/agent/core/logging/core/LogLevel.java](https://codecov.io/gh/apache/skywalking/pull/6480/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvbG9nZ2luZy9jb3JlL0xvZ0xldmVsLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| ... and [1365 more](https://codecov.io/gh/apache/skywalking/pull/6480/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/6480?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/6480?src=pr&el=footer). Last update [cb16e52...a8c1e14](https://codecov.io/gh/apache/skywalking/pull/6480?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6480: Remove unnecessary check for getSkyWalkingDynamicField invocation
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #6480:
URL: https://github.com/apache/skywalking/pull/6480#issuecomment-789727063
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/6480?src=pr&el=h1) Report
> Merging [#6480](https://codecov.io/gh/apache/skywalking/pull/6480?src=pr&el=desc) (9f84ae1) into [master](https://codecov.io/gh/apache/skywalking/commit/de6a731d72fb87dd574da1d9b42495fdd29b4311?el=desc) (de6a731) will **decrease** coverage by `18.38%`.
> The diff coverage is `19.04%`.
[![Impacted file tree graph](https://codecov.io/gh/apache/skywalking/pull/6480/graphs/tree.svg?width=650&height=150&src=pr&token=qrILxY5yA8)](https://codecov.io/gh/apache/skywalking/pull/6480?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #6480 +/- ##
=============================================
- Coverage 54.00% 35.62% -18.39%
+ Complexity 4075 2595 -1480
=============================================
Files 1777 1018 -759
Lines 37757 24766 -12991
Branches 4153 2429 -1724
=============================================
- Hits 20392 8823 -11569
+ Misses 16385 15272 -1113
+ Partials 980 671 -309
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/6480?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...g/oap/log/analyzer/dsl/spec/filter/FilterSpec.java](https://codecov.io/gh/apache/skywalking/pull/6480/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9sb2ctYW5hbHl6ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL2xvZy9hbmFseXplci9kc2wvc3BlYy9maWx0ZXIvRmlsdGVyU3BlYy5qYXZh) | `44.61% <0.00%> (-6.27%)` | `7.00 <0.00> (ø)` | |
| [...p/log/analyzer/dsl/spec/parser/TextParserSpec.java](https://codecov.io/gh/apache/skywalking/pull/6480/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9sb2ctYW5hbHl6ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL2xvZy9hbmFseXplci9kc2wvc3BlYy9wYXJzZXIvVGV4dFBhcnNlclNwZWMuamF2YQ==) | `64.28% <0.00%> (-10.72%)` | `4.00 <0.00> (ø)` | |
| [...p/log/analyzer/dsl/spec/parser/YamlParserSpec.java](https://codecov.io/gh/apache/skywalking/pull/6480/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9sb2ctYW5hbHl6ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL2xvZy9hbmFseXplci9kc2wvc3BlYy9wYXJzZXIvWWFtbFBhcnNlclNwZWMuamF2YQ==) | `75.00% <ø> (ø)` | `1.00 <0.00> (ø)` | |
| [...p/log/analyzer/dsl/spec/parser/JsonParserSpec.java](https://codecov.io/gh/apache/skywalking/pull/6480/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9sb2ctYW5hbHl6ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL2xvZy9hbmFseXplci9kc2wvc3BlYy9wYXJzZXIvSnNvblBhcnNlclNwZWMuamF2YQ==) | `80.00% <50.00%> (+5.00%)` | `1.00 <0.00> (ø)` | |
| [...g/analyzer/dsl/spec/parser/AbstractParserSpec.java](https://codecov.io/gh/apache/skywalking/pull/6480/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9sb2ctYW5hbHl6ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL2xvZy9hbmFseXplci9kc2wvc3BlYy9wYXJzZXIvQWJzdHJhY3RQYXJzZXJTcGVjLmphdmE=) | `100.00% <100.00%> (ø)` | `1.00 <1.00> (?)` | |
| [...pache/skywalking/apm/agent/core/base64/Base64.java](https://codecov.io/gh/apache/skywalking/pull/6480/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvYmFzZTY0L0Jhc2U2NC5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-3.00%)` | |
| [...che/skywalking/apm/agent/core/meter/MeterType.java](https://codecov.io/gh/apache/skywalking/pull/6480/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvbWV0ZXIvTWV0ZXJUeXBlLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (ø%)` | |
| [...skywalking/oap/server/core/alarm/AlarmMessage.java](https://codecov.io/gh/apache/skywalking/pull/6480/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYWxhcm0vQWxhcm1NZXNzYWdlLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...e/skywalking/apm/agent/core/meter/CounterMode.java](https://codecov.io/gh/apache/skywalking/pull/6480/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvbWV0ZXIvQ291bnRlck1vZGUuamF2YQ==) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (ø%)` | |
| [...ywalking/apm/agent/core/logging/core/LogLevel.java](https://codecov.io/gh/apache/skywalking/pull/6480/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvbG9nZ2luZy9jb3JlL0xvZ0xldmVsLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| ... and [1369 more](https://codecov.io/gh/apache/skywalking/pull/6480/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/6480?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/6480?src=pr&el=footer). Last update [cb16e52...a8c1e14](https://codecov.io/gh/apache/skywalking/pull/6480?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6480: Remove unnecessary check for getSkyWalkingDynamicField invocation
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #6480:
URL: https://github.com/apache/skywalking/pull/6480#issuecomment-789727063
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/6480?src=pr&el=h1) Report
> Merging [#6480](https://codecov.io/gh/apache/skywalking/pull/6480?src=pr&el=desc) (b16aca4) into [master](https://codecov.io/gh/apache/skywalking/commit/cb16e524da2bf45258e67052443a6b9bc2460855?el=desc) (cb16e52) will **decrease** coverage by `7.96%`.
> The diff coverage is `n/a`.
[![Impacted file tree graph](https://codecov.io/gh/apache/skywalking/pull/6480/graphs/tree.svg?width=650&height=150&src=pr&token=qrILxY5yA8)](https://codecov.io/gh/apache/skywalking/pull/6480?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #6480 +/- ##
============================================
- Coverage 54.08% 46.11% -7.97%
+ Complexity 4088 3490 -598
============================================
Files 1778 1020 -758
Lines 37771 24882 -12889
Branches 4156 2437 -1719
============================================
- Hits 20429 11475 -8954
+ Misses 16361 12427 -3934
+ Partials 981 980 -1
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/6480?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...che/skywalking/apm/agent/core/meter/MeterType.java](https://codecov.io/gh/apache/skywalking/pull/6480/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvbWV0ZXIvTWV0ZXJUeXBlLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (ø%)` | |
| [...skywalking/oap/server/core/alarm/AlarmMessage.java](https://codecov.io/gh/apache/skywalking/pull/6480/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYWxhcm0vQWxhcm1NZXNzYWdlLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...e/skywalking/apm/agent/core/meter/CounterMode.java](https://codecov.io/gh/apache/skywalking/pull/6480/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvbWV0ZXIvQ291bnRlck1vZGUuamF2YQ==) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (ø%)` | |
| [...org/apache/skywalking/apm/toolkit/meter/Gauge.java](https://codecov.io/gh/apache/skywalking/pull/6480/diff?src=pr&el=tree#diff-YXBtLWFwcGxpY2F0aW9uLXRvb2xraXQvYXBtLXRvb2xraXQtbWV0ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL3Rvb2xraXQvbWV0ZXIvR2F1Z2UuamF2YQ==) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (ø%)` | |
| [...ng/oap/server/core/analysis/config/NoneStream.java](https://codecov.io/gh/apache/skywalking/pull/6480/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvY29uZmlnL05vbmVTdHJlYW0uamF2YQ==) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...g/oap/server/core/cluster/ClusterHealthStatus.java](https://codecov.io/gh/apache/skywalking/pull/6480/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvY2x1c3Rlci9DbHVzdGVySGVhbHRoU3RhdHVzLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (ø%)` | |
| [...ng/apm/agent/core/context/trace/LogDataEntity.java](https://codecov.io/gh/apache/skywalking/pull/6480/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29udGV4dC90cmFjZS9Mb2dEYXRhRW50aXR5LmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (ø%)` | |
| [...p/server/core/analysis/metrics/MinLongMetrics.java](https://codecov.io/gh/apache/skywalking/pull/6480/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0cmljcy9NaW5Mb25nTWV0cmljcy5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (ø%)` | |
| [...er/exporter/provider/grpc/GRPCExporterSetting.java](https://codecov.io/gh/apache/skywalking/pull/6480/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9leHBvcnRlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2V4cG9ydGVyL3Byb3ZpZGVyL2dycGMvR1JQQ0V4cG9ydGVyU2V0dGluZy5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (ø%)` | |
| [...ent/core/plugin/bytebuddy/ReturnTypeNameMatch.java](https://codecov.io/gh/apache/skywalking/pull/6480/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcGx1Z2luL2J5dGVidWRkeS9SZXR1cm5UeXBlTmFtZU1hdGNoLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (ø%)` | |
| ... and [1282 more](https://codecov.io/gh/apache/skywalking/pull/6480/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/6480?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/6480?src=pr&el=footer). Last update [9946ec4...5c9722d](https://codecov.io/gh/apache/skywalking/pull/6480?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6480: Remove unnecessary check for getSkyWalkingDynamicField invocation
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #6480:
URL: https://github.com/apache/skywalking/pull/6480#issuecomment-789727063
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/6480?src=pr&el=h1) Report
> Merging [#6480](https://codecov.io/gh/apache/skywalking/pull/6480?src=pr&el=desc) (9f84ae1) into [master](https://codecov.io/gh/apache/skywalking/commit/de6a731d72fb87dd574da1d9b42495fdd29b4311?el=desc) (de6a731) will **decrease** coverage by `18.38%`.
> The diff coverage is `19.04%`.
[![Impacted file tree graph](https://codecov.io/gh/apache/skywalking/pull/6480/graphs/tree.svg?width=650&height=150&src=pr&token=qrILxY5yA8)](https://codecov.io/gh/apache/skywalking/pull/6480?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #6480 +/- ##
=============================================
- Coverage 54.00% 35.62% -18.39%
+ Complexity 4075 2595 -1480
=============================================
Files 1777 1018 -759
Lines 37757 24766 -12991
Branches 4153 2429 -1724
=============================================
- Hits 20392 8823 -11569
+ Misses 16385 15272 -1113
+ Partials 980 671 -309
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/6480?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...g/oap/log/analyzer/dsl/spec/filter/FilterSpec.java](https://codecov.io/gh/apache/skywalking/pull/6480/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9sb2ctYW5hbHl6ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL2xvZy9hbmFseXplci9kc2wvc3BlYy9maWx0ZXIvRmlsdGVyU3BlYy5qYXZh) | `44.61% <0.00%> (-6.27%)` | `7.00 <0.00> (ø)` | |
| [...p/log/analyzer/dsl/spec/parser/TextParserSpec.java](https://codecov.io/gh/apache/skywalking/pull/6480/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9sb2ctYW5hbHl6ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL2xvZy9hbmFseXplci9kc2wvc3BlYy9wYXJzZXIvVGV4dFBhcnNlclNwZWMuamF2YQ==) | `64.28% <0.00%> (-10.72%)` | `4.00 <0.00> (ø)` | |
| [...p/log/analyzer/dsl/spec/parser/YamlParserSpec.java](https://codecov.io/gh/apache/skywalking/pull/6480/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9sb2ctYW5hbHl6ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL2xvZy9hbmFseXplci9kc2wvc3BlYy9wYXJzZXIvWWFtbFBhcnNlclNwZWMuamF2YQ==) | `75.00% <ø> (ø)` | `1.00 <0.00> (ø)` | |
| [...p/log/analyzer/dsl/spec/parser/JsonParserSpec.java](https://codecov.io/gh/apache/skywalking/pull/6480/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9sb2ctYW5hbHl6ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL2xvZy9hbmFseXplci9kc2wvc3BlYy9wYXJzZXIvSnNvblBhcnNlclNwZWMuamF2YQ==) | `80.00% <50.00%> (+5.00%)` | `1.00 <0.00> (ø)` | |
| [...g/analyzer/dsl/spec/parser/AbstractParserSpec.java](https://codecov.io/gh/apache/skywalking/pull/6480/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9sb2ctYW5hbHl6ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL2xvZy9hbmFseXplci9kc2wvc3BlYy9wYXJzZXIvQWJzdHJhY3RQYXJzZXJTcGVjLmphdmE=) | `100.00% <100.00%> (ø)` | `1.00 <1.00> (?)` | |
| [...pache/skywalking/apm/agent/core/base64/Base64.java](https://codecov.io/gh/apache/skywalking/pull/6480/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvYmFzZTY0L0Jhc2U2NC5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-3.00%)` | |
| [...che/skywalking/apm/agent/core/meter/MeterType.java](https://codecov.io/gh/apache/skywalking/pull/6480/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvbWV0ZXIvTWV0ZXJUeXBlLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (ø%)` | |
| [...skywalking/oap/server/core/alarm/AlarmMessage.java](https://codecov.io/gh/apache/skywalking/pull/6480/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYWxhcm0vQWxhcm1NZXNzYWdlLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...e/skywalking/apm/agent/core/meter/CounterMode.java](https://codecov.io/gh/apache/skywalking/pull/6480/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvbWV0ZXIvQ291bnRlck1vZGUuamF2YQ==) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (ø%)` | |
| [...ywalking/apm/agent/core/logging/core/LogLevel.java](https://codecov.io/gh/apache/skywalking/pull/6480/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvbG9nZ2luZy9jb3JlL0xvZ0xldmVsLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| ... and [1369 more](https://codecov.io/gh/apache/skywalking/pull/6480/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/6480?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/6480?src=pr&el=footer). Last update [cb16e52...a8c1e14](https://codecov.io/gh/apache/skywalking/pull/6480?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6480: Remove unnecessary check for getSkyWalkingDynamicField invocation
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #6480:
URL: https://github.com/apache/skywalking/pull/6480#issuecomment-789727063
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/6480?src=pr&el=h1) Report
> Merging [#6480](https://codecov.io/gh/apache/skywalking/pull/6480?src=pr&el=desc) (9f84ae1) into [master](https://codecov.io/gh/apache/skywalking/commit/de6a731d72fb87dd574da1d9b42495fdd29b4311?el=desc) (de6a731) will **decrease** coverage by `16.24%`.
> The diff coverage is `19.04%`.
[![Impacted file tree graph](https://codecov.io/gh/apache/skywalking/pull/6480/graphs/tree.svg?width=650&height=150&src=pr&token=qrILxY5yA8)](https://codecov.io/gh/apache/skywalking/pull/6480?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #6480 +/- ##
=============================================
- Coverage 54.00% 37.76% -16.25%
+ Complexity 4075 2711 -1364
=============================================
Files 1777 1024 -753
Lines 37757 24915 -12842
Branches 4153 2441 -1712
=============================================
- Hits 20392 9410 -10982
+ Misses 16385 14766 -1619
+ Partials 980 739 -241
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/6480?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...g/oap/log/analyzer/dsl/spec/filter/FilterSpec.java](https://codecov.io/gh/apache/skywalking/pull/6480/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9sb2ctYW5hbHl6ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL2xvZy9hbmFseXplci9kc2wvc3BlYy9maWx0ZXIvRmlsdGVyU3BlYy5qYXZh) | `44.61% <0.00%> (-6.27%)` | `7.00 <0.00> (ø)` | |
| [...p/log/analyzer/dsl/spec/parser/TextParserSpec.java](https://codecov.io/gh/apache/skywalking/pull/6480/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9sb2ctYW5hbHl6ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL2xvZy9hbmFseXplci9kc2wvc3BlYy9wYXJzZXIvVGV4dFBhcnNlclNwZWMuamF2YQ==) | `64.28% <0.00%> (-10.72%)` | `4.00 <0.00> (ø)` | |
| [...p/log/analyzer/dsl/spec/parser/YamlParserSpec.java](https://codecov.io/gh/apache/skywalking/pull/6480/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9sb2ctYW5hbHl6ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL2xvZy9hbmFseXplci9kc2wvc3BlYy9wYXJzZXIvWWFtbFBhcnNlclNwZWMuamF2YQ==) | `75.00% <ø> (ø)` | `1.00 <0.00> (ø)` | |
| [...p/log/analyzer/dsl/spec/parser/JsonParserSpec.java](https://codecov.io/gh/apache/skywalking/pull/6480/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9sb2ctYW5hbHl6ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL2xvZy9hbmFseXplci9kc2wvc3BlYy9wYXJzZXIvSnNvblBhcnNlclNwZWMuamF2YQ==) | `80.00% <50.00%> (+5.00%)` | `1.00 <0.00> (ø)` | |
| [...g/analyzer/dsl/spec/parser/AbstractParserSpec.java](https://codecov.io/gh/apache/skywalking/pull/6480/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9sb2ctYW5hbHl6ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL2xvZy9hbmFseXplci9kc2wvc3BlYy9wYXJzZXIvQWJzdHJhY3RQYXJzZXJTcGVjLmphdmE=) | `100.00% <100.00%> (ø)` | `1.00 <1.00> (?)` | |
| [...pache/skywalking/apm/agent/core/base64/Base64.java](https://codecov.io/gh/apache/skywalking/pull/6480/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvYmFzZTY0L0Jhc2U2NC5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-3.00%)` | |
| [...che/skywalking/apm/agent/core/meter/MeterType.java](https://codecov.io/gh/apache/skywalking/pull/6480/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvbWV0ZXIvTWV0ZXJUeXBlLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (ø%)` | |
| [...skywalking/oap/server/core/alarm/AlarmMessage.java](https://codecov.io/gh/apache/skywalking/pull/6480/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYWxhcm0vQWxhcm1NZXNzYWdlLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...e/skywalking/apm/agent/core/meter/CounterMode.java](https://codecov.io/gh/apache/skywalking/pull/6480/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvbWV0ZXIvQ291bnRlck1vZGUuamF2YQ==) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (ø%)` | |
| [...ywalking/apm/agent/core/logging/core/LogLevel.java](https://codecov.io/gh/apache/skywalking/pull/6480/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvbG9nZ2luZy9jb3JlL0xvZ0xldmVsLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| ... and [1358 more](https://codecov.io/gh/apache/skywalking/pull/6480/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/6480?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/6480?src=pr&el=footer). Last update [cb16e52...a8c1e14](https://codecov.io/gh/apache/skywalking/pull/6480?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6480: Remove unnecessary check for getSkyWalkingDynamicField invocation
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #6480:
URL: https://github.com/apache/skywalking/pull/6480#issuecomment-789727063
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/6480?src=pr&el=h1) Report
> Merging [#6480](https://codecov.io/gh/apache/skywalking/pull/6480?src=pr&el=desc) (b16aca4) into [master](https://codecov.io/gh/apache/skywalking/commit/cb16e524da2bf45258e67052443a6b9bc2460855?el=desc) (cb16e52) will **decrease** coverage by `54.08%`.
> The diff coverage is `n/a`.
[![Impacted file tree graph](https://codecov.io/gh/apache/skywalking/pull/6480/graphs/tree.svg?width=650&height=150&src=pr&token=qrILxY5yA8)](https://codecov.io/gh/apache/skywalking/pull/6480?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #6480 +/- ##
============================================
- Coverage 54.08% 0.00% -54.09%
============================================
Files 1778 182 -1596
Lines 37771 4483 -33288
Branches 4156 522 -3634
============================================
- Hits 20429 0 -20429
+ Misses 16361 4483 -11878
+ Partials 981 0 -981
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/6480?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...pache/skywalking/apm/agent/core/base64/Base64.java](https://codecov.io/gh/apache/skywalking/pull/6480/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvYmFzZTY0L0Jhc2U2NC5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-3.00%)` | |
| [...king/apm/util/RunnableWithExceptionProtection.java](https://codecov.io/gh/apache/skywalking/pull/6480/diff?src=pr&el=tree#diff-YXBtLWNvbW1vbnMvYXBtLXV0aWwvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL3V0aWwvUnVubmFibGVXaXRoRXhjZXB0aW9uUHJvdGVjdGlvbi5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-2.00%)` | |
| [...ywalking/apm/agent/core/logging/core/LogLevel.java](https://codecov.io/gh/apache/skywalking/pull/6480/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvbG9nZ2luZy9jb3JlL0xvZ0xldmVsLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...ywalking/apm/agent/core/plugin/EnhanceContext.java](https://codecov.io/gh/apache/skywalking/pull/6480/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcGx1Z2luL0VuaGFuY2VDb250ZXh0LmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-5.00%)` | |
| [...ywalking/apm/agent/core/plugin/PluginSelector.java](https://codecov.io/gh/apache/skywalking/pull/6480/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcGx1Z2luL1BsdWdpblNlbGVjdG9yLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-2.00%)` | |
| [...ywalking/apm/agent/core/profile/ProfileStatus.java](https://codecov.io/gh/apache/skywalking/pull/6480/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcHJvZmlsZS9Qcm9maWxlU3RhdHVzLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...walking/apm/agent/core/context/SW8CarrierItem.java](https://codecov.io/gh/apache/skywalking/pull/6480/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29udGV4dC9TVzhDYXJyaWVySXRlbS5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-2.00%)` | |
| [...walking/apm/agent/core/jvm/cpu/SunCpuAccessor.java](https://codecov.io/gh/apache/skywalking/pull/6480/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvanZtL2NwdS9TdW5DcHVBY2Nlc3Nvci5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-2.00%)` | |
| [...walking/apm/agent/core/logging/core/LogOutput.java](https://codecov.io/gh/apache/skywalking/pull/6480/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvbG9nZ2luZy9jb3JlL0xvZ091dHB1dC5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...walking/apm/agent/core/plugin/match/NameMatch.java](https://codecov.io/gh/apache/skywalking/pull/6480/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcGx1Z2luL21hdGNoL05hbWVNYXRjaC5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-3.00%)` | |
| ... and [1755 more](https://codecov.io/gh/apache/skywalking/pull/6480/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/6480?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/6480?src=pr&el=footer). Last update [9946ec4...5c9722d](https://codecov.io/gh/apache/skywalking/pull/6480?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6480: Remove unnecessary check for getSkyWalkingDynamicField invocation
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #6480:
URL: https://github.com/apache/skywalking/pull/6480#issuecomment-789727063
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/6480?src=pr&el=h1) Report
> Merging [#6480](https://codecov.io/gh/apache/skywalking/pull/6480?src=pr&el=desc) (a8c1e14) into [master](https://codecov.io/gh/apache/skywalking/commit/cb16e524da2bf45258e67052443a6b9bc2460855?el=desc) (cb16e52) will **decrease** coverage by `11.92%`.
> The diff coverage is `n/a`.
[![Impacted file tree graph](https://codecov.io/gh/apache/skywalking/pull/6480/graphs/tree.svg?width=650&height=150&src=pr&token=qrILxY5yA8)](https://codecov.io/gh/apache/skywalking/pull/6480?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #6480 +/- ##
=============================================
- Coverage 54.08% 42.15% -11.93%
+ Complexity 4088 3013 -1075
=============================================
Files 1778 967 -811
Lines 37771 23497 -14274
Branches 4156 2265 -1891
=============================================
- Hits 20429 9906 -10523
+ Misses 16361 12762 -3599
+ Partials 981 829 -152
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/6480?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...skywalking/oap/server/core/alarm/AlarmMessage.java](https://codecov.io/gh/apache/skywalking/pull/6480/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYWxhcm0vQWxhcm1NZXNzYWdlLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...kywalking/oap/server/core/storage/AbstractDAO.java](https://codecov.io/gh/apache/skywalking/pull/6480/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvc3RvcmFnZS9BYnN0cmFjdERBTy5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-2.00%)` | |
| [...ng/oap/server/core/analysis/config/NoneStream.java](https://codecov.io/gh/apache/skywalking/pull/6480/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvY29uZmlnL05vbmVTdHJlYW0uamF2YQ==) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...g/oap/server/core/cluster/ClusterHealthStatus.java](https://codecov.io/gh/apache/skywalking/pull/6480/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvY2x1c3Rlci9DbHVzdGVySGVhbHRoU3RhdHVzLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (ø%)` | |
| [...ng/apm/agent/core/context/trace/LogDataEntity.java](https://codecov.io/gh/apache/skywalking/pull/6480/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29udGV4dC90cmFjZS9Mb2dEYXRhRW50aXR5LmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (ø%)` | |
| [...p/server/core/analysis/metrics/MinLongMetrics.java](https://codecov.io/gh/apache/skywalking/pull/6480/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0cmljcy9NaW5Mb25nTWV0cmljcy5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (ø%)` | |
| [...er/exporter/provider/grpc/GRPCExporterSetting.java](https://codecov.io/gh/apache/skywalking/pull/6480/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9leHBvcnRlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2V4cG9ydGVyL3Byb3ZpZGVyL2dycGMvR1JQQ0V4cG9ydGVyU2V0dGluZy5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (ø%)` | |
| [...lking/oap/server/analyzer/event/EventAnalyzer.java](https://codecov.io/gh/apache/skywalking/pull/6480/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9ldmVudC1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2FuYWx5emVyL2V2ZW50L0V2ZW50QW5hbHl6ZXIuamF2YQ==) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-6.00%)` | |
| [...rver/core/browser/source/BrowserErrorCategory.java](https://codecov.io/gh/apache/skywalking/pull/6480/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYnJvd3Nlci9zb3VyY2UvQnJvd3NlckVycm9yQ2F0ZWdvcnkuamF2YQ==) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-8.00%)` | |
| [...core/browser/source/BrowserAppTrafficCategory.java](https://codecov.io/gh/apache/skywalking/pull/6480/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYnJvd3Nlci9zb3VyY2UvQnJvd3NlckFwcFRyYWZmaWNDYXRlZ29yeS5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| ... and [1348 more](https://codecov.io/gh/apache/skywalking/pull/6480/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/6480?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/6480?src=pr&el=footer). Last update [9946ec4...5c9722d](https://codecov.io/gh/apache/skywalking/pull/6480?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6480: Remove unnecessary check for getSkyWalkingDynamicField invocation
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #6480:
URL: https://github.com/apache/skywalking/pull/6480#issuecomment-789727063
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/6480?src=pr&el=h1) Report
> Merging [#6480](https://codecov.io/gh/apache/skywalking/pull/6480?src=pr&el=desc) (a8c1e14) into [master](https://codecov.io/gh/apache/skywalking/commit/de6a731d72fb87dd574da1d9b42495fdd29b4311?el=desc) (de6a731) will **increase** coverage by `2.85%`.
> The diff coverage is `n/a`.
[![Impacted file tree graph](https://codecov.io/gh/apache/skywalking/pull/6480/graphs/tree.svg?width=650&height=150&src=pr&token=qrILxY5yA8)](https://codecov.io/gh/apache/skywalking/pull/6480?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #6480 +/- ##
============================================
+ Coverage 54.00% 56.86% +2.85%
+ Complexity 4075 822 -3253
============================================
Files 1777 177 -1600
Lines 37757 4312 -33445
Branches 4153 491 -3662
============================================
- Hits 20392 2452 -17940
+ Misses 16385 1548 -14837
+ Partials 980 312 -668
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/6480?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...t/status/HierarchyMatchExceptionCheckStrategy.java](https://codecov.io/gh/apache/skywalking/pull/6480/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29udGV4dC9zdGF0dXMvSGllcmFyY2h5TWF0Y2hFeGNlcHRpb25DaGVja1N0cmF0ZWd5LmphdmE=) | `9.09% <0.00%> (-90.91%)` | `1.00% <0.00%> (ø%)` | |
| [...alking/apm/agent/core/logging/core/FileWriter.java](https://codecov.io/gh/apache/skywalking/pull/6480/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvbG9nZ2luZy9jb3JlL0ZpbGVXcml0ZXIuamF2YQ==) | `0.00% <0.00%> (-88.10%)` | `0.00% <0.00%> (ø%)` | |
| [...g/apm/agent/core/context/status/StatusChecker.java](https://codecov.io/gh/apache/skywalking/pull/6480/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29udGV4dC9zdGF0dXMvU3RhdHVzQ2hlY2tlci5qYXZh) | `23.80% <0.00%> (-76.20%)` | `1.00% <0.00%> (ø%)` | |
| [...ywalking/apm/agent/core/plugin/PluginSelector.java](https://codecov.io/gh/apache/skywalking/pull/6480/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcGx1Z2luL1BsdWdpblNlbGVjdG9yLmphdmE=) | `28.57% <0.00%> (-71.43%)` | `2.00% <0.00%> (ø%)` | |
| [...re/logging/core/converters/AgentNameConverter.java](https://codecov.io/gh/apache/skywalking/pull/6480/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvbG9nZ2luZy9jb3JlL2NvbnZlcnRlcnMvQWdlbnROYW1lQ29udmVydGVyLmphdmE=) | `0.00% <0.00%> (-66.67%)` | `0.00% <0.00%> (ø%)` | |
| [...re/logging/core/converters/ThrowableConverter.java](https://codecov.io/gh/apache/skywalking/pull/6480/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvbG9nZ2luZy9jb3JlL2NvbnZlcnRlcnMvVGhyb3dhYmxlQ29udmVydGVyLmphdmE=) | `16.66% <0.00%> (-66.67%)` | `2.00% <0.00%> (ø%)` | |
| [...he/skywalking/apm/commons/datacarrier/EnvUtil.java](https://codecov.io/gh/apache/skywalking/pull/6480/diff?src=pr&el=tree#diff-YXBtLWNvbW1vbnMvYXBtLWRhdGFjYXJyaWVyL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL2FwbS9jb21tb25zL2RhdGFjYXJyaWVyL0VudlV0aWwuamF2YQ==) | `20.00% <0.00%> (-60.00%)` | `1.00% <0.00%> (ø%)` | |
| [...lking/apm/agent/core/context/ExtensionContext.java](https://codecov.io/gh/apache/skywalking/pull/6480/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29udGV4dC9FeHRlbnNpb25Db250ZXh0LmphdmE=) | `23.25% <0.00%> (-51.17%)` | `7.00% <0.00%> (ø%)` | |
| [...core/context/status/OffExceptionCheckStrategy.java](https://codecov.io/gh/apache/skywalking/pull/6480/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29udGV4dC9zdGF0dXMvT2ZmRXhjZXB0aW9uQ2hlY2tTdHJhdGVneS5qYXZh) | `50.00% <0.00%> (-50.00%)` | `1.00% <0.00%> (ø%)` | |
| [...kywalking/apm/commons/datacarrier/DataCarrier.java](https://codecov.io/gh/apache/skywalking/pull/6480/diff?src=pr&el=tree#diff-YXBtLWNvbW1vbnMvYXBtLWRhdGFjYXJyaWVyL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL2FwbS9jb21tb25zL2RhdGFjYXJyaWVyL0RhdGFDYXJyaWVyLmphdmE=) | `38.46% <0.00%> (-46.16%)` | `6.00% <0.00%> (-4.00%)` | |
| ... and [1691 more](https://codecov.io/gh/apache/skywalking/pull/6480/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/6480?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/6480?src=pr&el=footer). Last update [cb16e52...a8c1e14](https://codecov.io/gh/apache/skywalking/pull/6480?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6480: Remove unnecessary check for getSkyWalkingDynamicField invocation
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #6480:
URL: https://github.com/apache/skywalking/pull/6480#issuecomment-789727063
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/6480?src=pr&el=h1) Report
> Merging [#6480](https://codecov.io/gh/apache/skywalking/pull/6480?src=pr&el=desc) (a8c1e14) into [master](https://codecov.io/gh/apache/skywalking/commit/de6a731d72fb87dd574da1d9b42495fdd29b4311?el=desc) (de6a731) will **increase** coverage by `4.66%`.
> The diff coverage is `n/a`.
[![Impacted file tree graph](https://codecov.io/gh/apache/skywalking/pull/6480/graphs/tree.svg?width=650&height=150&src=pr&token=qrILxY5yA8)](https://codecov.io/gh/apache/skywalking/pull/6480?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #6480 +/- ##
============================================
+ Coverage 54.00% 58.67% +4.66%
+ Complexity 4075 822 -3253
============================================
Files 1777 171 -1606
Lines 37757 4179 -33578
Branches 4153 482 -3671
============================================
- Hits 20392 2452 -17940
+ Misses 16385 1415 -14970
+ Partials 980 312 -668
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/6480?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...t/status/HierarchyMatchExceptionCheckStrategy.java](https://codecov.io/gh/apache/skywalking/pull/6480/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29udGV4dC9zdGF0dXMvSGllcmFyY2h5TWF0Y2hFeGNlcHRpb25DaGVja1N0cmF0ZWd5LmphdmE=) | `9.09% <0.00%> (-90.91%)` | `1.00% <0.00%> (ø%)` | |
| [...g/apm/agent/core/context/status/StatusChecker.java](https://codecov.io/gh/apache/skywalking/pull/6480/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29udGV4dC9zdGF0dXMvU3RhdHVzQ2hlY2tlci5qYXZh) | `23.80% <0.00%> (-76.20%)` | `1.00% <0.00%> (ø%)` | |
| [...ywalking/apm/agent/core/plugin/PluginSelector.java](https://codecov.io/gh/apache/skywalking/pull/6480/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcGx1Z2luL1BsdWdpblNlbGVjdG9yLmphdmE=) | `28.57% <0.00%> (-71.43%)` | `2.00% <0.00%> (ø%)` | |
| [...re/logging/core/converters/AgentNameConverter.java](https://codecov.io/gh/apache/skywalking/pull/6480/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvbG9nZ2luZy9jb3JlL2NvbnZlcnRlcnMvQWdlbnROYW1lQ29udmVydGVyLmphdmE=) | `0.00% <0.00%> (-66.67%)` | `0.00% <0.00%> (ø%)` | |
| [...re/logging/core/converters/ThrowableConverter.java](https://codecov.io/gh/apache/skywalking/pull/6480/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvbG9nZ2luZy9jb3JlL2NvbnZlcnRlcnMvVGhyb3dhYmxlQ29udmVydGVyLmphdmE=) | `16.66% <0.00%> (-66.67%)` | `2.00% <0.00%> (ø%)` | |
| [...he/skywalking/apm/commons/datacarrier/EnvUtil.java](https://codecov.io/gh/apache/skywalking/pull/6480/diff?src=pr&el=tree#diff-YXBtLWNvbW1vbnMvYXBtLWRhdGFjYXJyaWVyL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL2FwbS9jb21tb25zL2RhdGFjYXJyaWVyL0VudlV0aWwuamF2YQ==) | `20.00% <0.00%> (-60.00%)` | `1.00% <0.00%> (ø%)` | |
| [...lking/apm/agent/core/context/ExtensionContext.java](https://codecov.io/gh/apache/skywalking/pull/6480/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29udGV4dC9FeHRlbnNpb25Db250ZXh0LmphdmE=) | `23.25% <0.00%> (-51.17%)` | `7.00% <0.00%> (ø%)` | |
| [...core/context/status/OffExceptionCheckStrategy.java](https://codecov.io/gh/apache/skywalking/pull/6480/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29udGV4dC9zdGF0dXMvT2ZmRXhjZXB0aW9uQ2hlY2tTdHJhdGVneS5qYXZh) | `50.00% <0.00%> (-50.00%)` | `1.00% <0.00%> (ø%)` | |
| [...kywalking/apm/commons/datacarrier/DataCarrier.java](https://codecov.io/gh/apache/skywalking/pull/6480/diff?src=pr&el=tree#diff-YXBtLWNvbW1vbnMvYXBtLWRhdGFjYXJyaWVyL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL2FwbS9jb21tb25zL2RhdGFjYXJyaWVyL0RhdGFDYXJyaWVyLmphdmE=) | `38.46% <0.00%> (-46.16%)` | `6.00% <0.00%> (-4.00%)` | |
| [...lking/apm/agent/core/sampling/SamplingService.java](https://codecov.io/gh/apache/skywalking/pull/6480/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvc2FtcGxpbmcvU2FtcGxpbmdTZXJ2aWNlLmphdmE=) | `33.33% <0.00%> (-43.59%)` | `8.00% <0.00%> (-1.00%)` | |
| ... and [1693 more](https://codecov.io/gh/apache/skywalking/pull/6480/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/6480?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/6480?src=pr&el=footer). Last update [cb16e52...a8c1e14](https://codecov.io/gh/apache/skywalking/pull/6480?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6480: Remove unnecessary check for getSkyWalkingDynamicField invocation
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #6480:
URL: https://github.com/apache/skywalking/pull/6480#issuecomment-789727063
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/6480?src=pr&el=h1) Report
> Merging [#6480](https://codecov.io/gh/apache/skywalking/pull/6480?src=pr&el=desc) (9f84ae1) into [master](https://codecov.io/gh/apache/skywalking/commit/de6a731d72fb87dd574da1d9b42495fdd29b4311?el=desc) (de6a731) will **decrease** coverage by `30.72%`.
> The diff coverage is `19.04%`.
[![Impacted file tree graph](https://codecov.io/gh/apache/skywalking/pull/6480/graphs/tree.svg?width=650&height=150&src=pr&token=qrILxY5yA8)](https://codecov.io/gh/apache/skywalking/pull/6480?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #6480 +/- ##
=============================================
- Coverage 54.00% 23.28% -30.73%
+ Complexity 4075 1733 -2342
=============================================
Files 1777 987 -790
Lines 37757 23786 -13971
Branches 4153 2316 -1837
=============================================
- Hits 20392 5538 -14854
- Misses 16385 17851 +1466
+ Partials 980 397 -583
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/6480?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...g/oap/log/analyzer/dsl/spec/filter/FilterSpec.java](https://codecov.io/gh/apache/skywalking/pull/6480/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9sb2ctYW5hbHl6ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL2xvZy9hbmFseXplci9kc2wvc3BlYy9maWx0ZXIvRmlsdGVyU3BlYy5qYXZh) | `20.00% <0.00%> (-30.88%)` | `2.00 <0.00> (-5.00)` | |
| [...p/log/analyzer/dsl/spec/parser/TextParserSpec.java](https://codecov.io/gh/apache/skywalking/pull/6480/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9sb2ctYW5hbHl6ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL2xvZy9hbmFseXplci9kc2wvc3BlYy9wYXJzZXIvVGV4dFBhcnNlclNwZWMuamF2YQ==) | `14.28% <0.00%> (-60.72%)` | `1.00 <0.00> (-3.00)` | |
| [...p/log/analyzer/dsl/spec/parser/YamlParserSpec.java](https://codecov.io/gh/apache/skywalking/pull/6480/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9sb2ctYW5hbHl6ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL2xvZy9hbmFseXplci9kc2wvc3BlYy9wYXJzZXIvWWFtbFBhcnNlclNwZWMuamF2YQ==) | `75.00% <ø> (ø)` | `1.00 <0.00> (ø)` | |
| [...p/log/analyzer/dsl/spec/parser/JsonParserSpec.java](https://codecov.io/gh/apache/skywalking/pull/6480/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9sb2ctYW5hbHl6ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL2xvZy9hbmFseXplci9kc2wvc3BlYy9wYXJzZXIvSnNvblBhcnNlclNwZWMuamF2YQ==) | `80.00% <50.00%> (+5.00%)` | `1.00 <0.00> (ø)` | |
| [...g/analyzer/dsl/spec/parser/AbstractParserSpec.java](https://codecov.io/gh/apache/skywalking/pull/6480/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9sb2ctYW5hbHl6ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL2xvZy9hbmFseXplci9kc2wvc3BlYy9wYXJzZXIvQWJzdHJhY3RQYXJzZXJTcGVjLmphdmE=) | `100.00% <100.00%> (ø)` | `1.00 <1.00> (?)` | |
| [...he/skywalking/oap/server/core/source/GCPhrase.java](https://codecov.io/gh/apache/skywalking/pull/6480/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvc291cmNlL0dDUGhyYXNlLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...pache/skywalking/apm/agent/core/base64/Base64.java](https://codecov.io/gh/apache/skywalking/pull/6480/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvYmFzZTY0L0Jhc2U2NC5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-3.00%)` | |
| [...che/skywalking/apm/agent/core/meter/MeterType.java](https://codecov.io/gh/apache/skywalking/pull/6480/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvbWV0ZXIvTWV0ZXJUeXBlLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (ø%)` | |
| [...skywalking/oap/server/core/alarm/AlarmMessage.java](https://codecov.io/gh/apache/skywalking/pull/6480/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYWxhcm0vQWxhcm1NZXNzYWdlLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...skywalking/oap/server/core/source/RequestType.java](https://codecov.io/gh/apache/skywalking/pull/6480/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvc291cmNlL1JlcXVlc3RUeXBlLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| ... and [1473 more](https://codecov.io/gh/apache/skywalking/pull/6480/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/6480?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/6480?src=pr&el=footer). Last update [cb16e52...a8c1e14](https://codecov.io/gh/apache/skywalking/pull/6480?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6480: Remove unnecessary check for getSkyWalkingDynamicField invocation
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #6480:
URL: https://github.com/apache/skywalking/pull/6480#issuecomment-789727063
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/6480?src=pr&el=h1) Report
> Merging [#6480](https://codecov.io/gh/apache/skywalking/pull/6480?src=pr&el=desc) (9f84ae1) into [master](https://codecov.io/gh/apache/skywalking/commit/de6a731d72fb87dd574da1d9b42495fdd29b4311?el=desc) (de6a731) will **decrease** coverage by `16.24%`.
> The diff coverage is `19.04%`.
[![Impacted file tree graph](https://codecov.io/gh/apache/skywalking/pull/6480/graphs/tree.svg?width=650&height=150&src=pr&token=qrILxY5yA8)](https://codecov.io/gh/apache/skywalking/pull/6480?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #6480 +/- ##
=============================================
- Coverage 54.00% 37.76% -16.25%
+ Complexity 4075 2711 -1364
=============================================
Files 1777 1025 -752
Lines 37757 24919 -12838
Branches 4153 2441 -1712
=============================================
- Hits 20392 9410 -10982
+ Misses 16385 14770 -1615
+ Partials 980 739 -241
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/6480?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...g/oap/log/analyzer/dsl/spec/filter/FilterSpec.java](https://codecov.io/gh/apache/skywalking/pull/6480/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9sb2ctYW5hbHl6ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL2xvZy9hbmFseXplci9kc2wvc3BlYy9maWx0ZXIvRmlsdGVyU3BlYy5qYXZh) | `44.61% <0.00%> (-6.27%)` | `7.00 <0.00> (ø)` | |
| [...p/log/analyzer/dsl/spec/parser/TextParserSpec.java](https://codecov.io/gh/apache/skywalking/pull/6480/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9sb2ctYW5hbHl6ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL2xvZy9hbmFseXplci9kc2wvc3BlYy9wYXJzZXIvVGV4dFBhcnNlclNwZWMuamF2YQ==) | `64.28% <0.00%> (-10.72%)` | `4.00 <0.00> (ø)` | |
| [...p/log/analyzer/dsl/spec/parser/YamlParserSpec.java](https://codecov.io/gh/apache/skywalking/pull/6480/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9sb2ctYW5hbHl6ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL2xvZy9hbmFseXplci9kc2wvc3BlYy9wYXJzZXIvWWFtbFBhcnNlclNwZWMuamF2YQ==) | `75.00% <ø> (ø)` | `1.00 <0.00> (ø)` | |
| [...p/log/analyzer/dsl/spec/parser/JsonParserSpec.java](https://codecov.io/gh/apache/skywalking/pull/6480/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9sb2ctYW5hbHl6ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL2xvZy9hbmFseXplci9kc2wvc3BlYy9wYXJzZXIvSnNvblBhcnNlclNwZWMuamF2YQ==) | `80.00% <50.00%> (+5.00%)` | `1.00 <0.00> (ø)` | |
| [...g/analyzer/dsl/spec/parser/AbstractParserSpec.java](https://codecov.io/gh/apache/skywalking/pull/6480/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9sb2ctYW5hbHl6ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL2xvZy9hbmFseXplci9kc2wvc3BlYy9wYXJzZXIvQWJzdHJhY3RQYXJzZXJTcGVjLmphdmE=) | `100.00% <100.00%> (ø)` | `1.00 <1.00> (?)` | |
| [...pache/skywalking/apm/agent/core/base64/Base64.java](https://codecov.io/gh/apache/skywalking/pull/6480/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvYmFzZTY0L0Jhc2U2NC5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-3.00%)` | |
| [...che/skywalking/apm/agent/core/meter/MeterType.java](https://codecov.io/gh/apache/skywalking/pull/6480/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvbWV0ZXIvTWV0ZXJUeXBlLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (ø%)` | |
| [...skywalking/oap/server/core/alarm/AlarmMessage.java](https://codecov.io/gh/apache/skywalking/pull/6480/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYWxhcm0vQWxhcm1NZXNzYWdlLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...e/skywalking/apm/agent/core/meter/CounterMode.java](https://codecov.io/gh/apache/skywalking/pull/6480/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvbWV0ZXIvQ291bnRlck1vZGUuamF2YQ==) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (ø%)` | |
| [...ywalking/apm/agent/core/logging/core/LogLevel.java](https://codecov.io/gh/apache/skywalking/pull/6480/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvbG9nZ2luZy9jb3JlL0xvZ0xldmVsLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| ... and [1358 more](https://codecov.io/gh/apache/skywalking/pull/6480/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/6480?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/6480?src=pr&el=footer). Last update [cb16e52...a8c1e14](https://codecov.io/gh/apache/skywalking/pull/6480?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] commented on pull request #6480: Remove unnecessary check for getSkyWalkingDynamicField invocation
Posted by GitBox <gi...@apache.org>.
codecov[bot] commented on pull request #6480:
URL: https://github.com/apache/skywalking/pull/6480#issuecomment-789727063
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/6480?src=pr&el=h1) Report
> Merging [#6480](https://codecov.io/gh/apache/skywalking/pull/6480?src=pr&el=desc) (9f84ae1) into [master](https://codecov.io/gh/apache/skywalking/commit/de6a731d72fb87dd574da1d9b42495fdd29b4311?el=desc) (de6a731) will **decrease** coverage by `54.00%`.
> The diff coverage is `n/a`.
[![Impacted file tree graph](https://codecov.io/gh/apache/skywalking/pull/6480/graphs/tree.svg?width=650&height=150&src=pr&token=qrILxY5yA8)](https://codecov.io/gh/apache/skywalking/pull/6480?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #6480 +/- ##
============================================
- Coverage 54.00% 0.00% -54.01%
============================================
Files 1777 170 -1607
Lines 37757 4220 -33537
Branches 4153 485 -3668
============================================
- Hits 20392 0 -20392
+ Misses 16385 4220 -12165
+ Partials 980 0 -980
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/6480?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...pache/skywalking/apm/agent/core/base64/Base64.java](https://codecov.io/gh/apache/skywalking/pull/6480/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvYmFzZTY0L0Jhc2U2NC5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-3.00%)` | |
| [...king/apm/util/RunnableWithExceptionProtection.java](https://codecov.io/gh/apache/skywalking/pull/6480/diff?src=pr&el=tree#diff-YXBtLWNvbW1vbnMvYXBtLXV0aWwvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL3V0aWwvUnVubmFibGVXaXRoRXhjZXB0aW9uUHJvdGVjdGlvbi5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-2.00%)` | |
| [...ywalking/apm/agent/core/logging/core/LogLevel.java](https://codecov.io/gh/apache/skywalking/pull/6480/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvbG9nZ2luZy9jb3JlL0xvZ0xldmVsLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...ywalking/apm/agent/core/plugin/EnhanceContext.java](https://codecov.io/gh/apache/skywalking/pull/6480/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcGx1Z2luL0VuaGFuY2VDb250ZXh0LmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-5.00%)` | |
| [...ywalking/apm/agent/core/plugin/PluginSelector.java](https://codecov.io/gh/apache/skywalking/pull/6480/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcGx1Z2luL1BsdWdpblNlbGVjdG9yLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-2.00%)` | |
| [...ywalking/apm/agent/core/profile/ProfileStatus.java](https://codecov.io/gh/apache/skywalking/pull/6480/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcHJvZmlsZS9Qcm9maWxlU3RhdHVzLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...walking/apm/agent/core/context/SW8CarrierItem.java](https://codecov.io/gh/apache/skywalking/pull/6480/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29udGV4dC9TVzhDYXJyaWVySXRlbS5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-2.00%)` | |
| [...walking/apm/agent/core/jvm/cpu/SunCpuAccessor.java](https://codecov.io/gh/apache/skywalking/pull/6480/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvanZtL2NwdS9TdW5DcHVBY2Nlc3Nvci5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-2.00%)` | |
| [...walking/apm/agent/core/logging/core/LogOutput.java](https://codecov.io/gh/apache/skywalking/pull/6480/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvbG9nZ2luZy9jb3JlL0xvZ091dHB1dC5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...walking/apm/agent/core/plugin/match/NameMatch.java](https://codecov.io/gh/apache/skywalking/pull/6480/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcGx1Z2luL21hdGNoL05hbWVNYXRjaC5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-3.00%)` | |
| ... and [1750 more](https://codecov.io/gh/apache/skywalking/pull/6480/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/6480?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/6480?src=pr&el=footer). Last update [cb16e52...a8c1e14](https://codecov.io/gh/apache/skywalking/pull/6480?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6480: Remove unnecessary check for getSkyWalkingDynamicField invocation
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #6480:
URL: https://github.com/apache/skywalking/pull/6480#issuecomment-789727063
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/6480?src=pr&el=h1) Report
> Merging [#6480](https://codecov.io/gh/apache/skywalking/pull/6480?src=pr&el=desc) (9f84ae1) into [master](https://codecov.io/gh/apache/skywalking/commit/de6a731d72fb87dd574da1d9b42495fdd29b4311?el=desc) (de6a731) will **decrease** coverage by `30.72%`.
> The diff coverage is `19.04%`.
[![Impacted file tree graph](https://codecov.io/gh/apache/skywalking/pull/6480/graphs/tree.svg?width=650&height=150&src=pr&token=qrILxY5yA8)](https://codecov.io/gh/apache/skywalking/pull/6480?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #6480 +/- ##
=============================================
- Coverage 54.00% 23.28% -30.73%
+ Complexity 4075 1733 -2342
=============================================
Files 1777 987 -790
Lines 37757 23786 -13971
Branches 4153 2316 -1837
=============================================
- Hits 20392 5538 -14854
- Misses 16385 17851 +1466
+ Partials 980 397 -583
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/6480?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...g/oap/log/analyzer/dsl/spec/filter/FilterSpec.java](https://codecov.io/gh/apache/skywalking/pull/6480/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9sb2ctYW5hbHl6ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL2xvZy9hbmFseXplci9kc2wvc3BlYy9maWx0ZXIvRmlsdGVyU3BlYy5qYXZh) | `20.00% <0.00%> (-30.88%)` | `2.00 <0.00> (-5.00)` | |
| [...p/log/analyzer/dsl/spec/parser/TextParserSpec.java](https://codecov.io/gh/apache/skywalking/pull/6480/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9sb2ctYW5hbHl6ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL2xvZy9hbmFseXplci9kc2wvc3BlYy9wYXJzZXIvVGV4dFBhcnNlclNwZWMuamF2YQ==) | `14.28% <0.00%> (-60.72%)` | `1.00 <0.00> (-3.00)` | |
| [...p/log/analyzer/dsl/spec/parser/YamlParserSpec.java](https://codecov.io/gh/apache/skywalking/pull/6480/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9sb2ctYW5hbHl6ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL2xvZy9hbmFseXplci9kc2wvc3BlYy9wYXJzZXIvWWFtbFBhcnNlclNwZWMuamF2YQ==) | `75.00% <ø> (ø)` | `1.00 <0.00> (ø)` | |
| [...p/log/analyzer/dsl/spec/parser/JsonParserSpec.java](https://codecov.io/gh/apache/skywalking/pull/6480/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9sb2ctYW5hbHl6ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL2xvZy9hbmFseXplci9kc2wvc3BlYy9wYXJzZXIvSnNvblBhcnNlclNwZWMuamF2YQ==) | `80.00% <50.00%> (+5.00%)` | `1.00 <0.00> (ø)` | |
| [...g/analyzer/dsl/spec/parser/AbstractParserSpec.java](https://codecov.io/gh/apache/skywalking/pull/6480/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9sb2ctYW5hbHl6ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL2xvZy9hbmFseXplci9kc2wvc3BlYy9wYXJzZXIvQWJzdHJhY3RQYXJzZXJTcGVjLmphdmE=) | `100.00% <100.00%> (ø)` | `1.00 <1.00> (?)` | |
| [...he/skywalking/oap/server/core/source/GCPhrase.java](https://codecov.io/gh/apache/skywalking/pull/6480/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvc291cmNlL0dDUGhyYXNlLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...pache/skywalking/apm/agent/core/base64/Base64.java](https://codecov.io/gh/apache/skywalking/pull/6480/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvYmFzZTY0L0Jhc2U2NC5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-3.00%)` | |
| [...che/skywalking/apm/agent/core/meter/MeterType.java](https://codecov.io/gh/apache/skywalking/pull/6480/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvbWV0ZXIvTWV0ZXJUeXBlLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (ø%)` | |
| [...skywalking/oap/server/core/alarm/AlarmMessage.java](https://codecov.io/gh/apache/skywalking/pull/6480/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYWxhcm0vQWxhcm1NZXNzYWdlLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...skywalking/oap/server/core/source/RequestType.java](https://codecov.io/gh/apache/skywalking/pull/6480/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvc291cmNlL1JlcXVlc3RUeXBlLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| ... and [1473 more](https://codecov.io/gh/apache/skywalking/pull/6480/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/6480?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/6480?src=pr&el=footer). Last update [cb16e52...a8c1e14](https://codecov.io/gh/apache/skywalking/pull/6480?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6480: Remove unnecessary check for getSkyWalkingDynamicField invocation
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #6480:
URL: https://github.com/apache/skywalking/pull/6480#issuecomment-789727063
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/6480?src=pr&el=h1) Report
> Merging [#6480](https://codecov.io/gh/apache/skywalking/pull/6480?src=pr&el=desc) (a8c1e14) into [master](https://codecov.io/gh/apache/skywalking/commit/cb16e524da2bf45258e67052443a6b9bc2460855?el=desc) (cb16e52) will **decrease** coverage by `18.53%`.
> The diff coverage is `n/a`.
[![Impacted file tree graph](https://codecov.io/gh/apache/skywalking/pull/6480/graphs/tree.svg?width=650&height=150&src=pr&token=qrILxY5yA8)](https://codecov.io/gh/apache/skywalking/pull/6480?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #6480 +/- ##
=============================================
- Coverage 58.62% 40.09% -18.54%
+ Complexity 4087 2882 -1205
=============================================
Files 987 967 -20
Lines 24408 23487 -921
Branches 2374 2264 -110
=============================================
- Hits 14310 9416 -4894
- Misses 8865 13288 +4423
+ Partials 1233 783 -450
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/6480?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...skywalking/oap/server/core/alarm/AlarmMessage.java](https://codecov.io/gh/apache/skywalking/pull/6480/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYWxhcm0vQWxhcm1NZXNzYWdlLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...kywalking/oap/server/core/storage/AbstractDAO.java](https://codecov.io/gh/apache/skywalking/pull/6480/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvc3RvcmFnZS9BYnN0cmFjdERBTy5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-2.00%)` | |
| [...ng/oap/server/core/analysis/config/NoneStream.java](https://codecov.io/gh/apache/skywalking/pull/6480/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvY29uZmlnL05vbmVTdHJlYW0uamF2YQ==) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...lking/oap/server/analyzer/event/EventAnalyzer.java](https://codecov.io/gh/apache/skywalking/pull/6480/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9ldmVudC1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2FuYWx5emVyL2V2ZW50L0V2ZW50QW5hbHl6ZXIuamF2YQ==) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-6.00%)` | |
| [...rver/core/browser/source/BrowserErrorCategory.java](https://codecov.io/gh/apache/skywalking/pull/6480/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYnJvd3Nlci9zb3VyY2UvQnJvd3NlckVycm9yQ2F0ZWdvcnkuamF2YQ==) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-8.00%)` | |
| [...core/browser/source/BrowserAppTrafficCategory.java](https://codecov.io/gh/apache/skywalking/pull/6480/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYnJvd3Nlci9zb3VyY2UvQnJvd3NlckFwcFRyYWZmaWNDYXRlZ29yeS5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...ore/analysis/metrics/expression/NotEqualMatch.java](https://codecov.io/gh/apache/skywalking/pull/6480/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0cmljcy9leHByZXNzaW9uL05vdEVxdWFsTWF0Y2guamF2YQ==) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-3.00%)` | |
| [...log/analyzer/provider/log/ILogAnalyzerService.java](https://codecov.io/gh/apache/skywalking/pull/6480/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9sb2ctYW5hbHl6ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL2xvZy9hbmFseXplci9wcm92aWRlci9sb2cvSUxvZ0FuYWx5emVyU2VydmljZS5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...server/library/util/prometheus/metrics/Metric.java](https://codecov.io/gh/apache/skywalking/pull/6480/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItbGlicmFyeS9saWJyYXJ5LXV0aWwvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9saWJyYXJ5L3V0aWwvcHJvbWV0aGV1cy9tZXRyaWNzL01ldHJpYy5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...ement/ui/template/UITemplateManagementService.java](https://codecov.io/gh/apache/skywalking/pull/6480/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvbWFuYWdlbWVudC91aS90ZW1wbGF0ZS9VSVRlbXBsYXRlTWFuYWdlbWVudFNlcnZpY2UuamF2YQ==) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-6.00%)` | |
| ... and [299 more](https://codecov.io/gh/apache/skywalking/pull/6480/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/6480?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/6480?src=pr&el=footer). Last update [cb16e52...a8c1e14](https://codecov.io/gh/apache/skywalking/pull/6480?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6480: Remove unnecessary check for getSkyWalkingDynamicField invocation
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #6480:
URL: https://github.com/apache/skywalking/pull/6480#issuecomment-789727063
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/6480?src=pr&el=h1) Report
> Merging [#6480](https://codecov.io/gh/apache/skywalking/pull/6480?src=pr&el=desc) (b16aca4) into [master](https://codecov.io/gh/apache/skywalking/commit/cb16e524da2bf45258e67052443a6b9bc2460855?el=desc) (cb16e52) will **decrease** coverage by `10.18%`.
> The diff coverage is `n/a`.
[![Impacted file tree graph](https://codecov.io/gh/apache/skywalking/pull/6480/graphs/tree.svg?width=650&height=150&src=pr&token=qrILxY5yA8)](https://codecov.io/gh/apache/skywalking/pull/6480?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #6480 +/- ##
=============================================
- Coverage 54.08% 43.89% -10.19%
+ Complexity 4088 3228 -860
=============================================
Files 1778 988 -790
Lines 37771 24040 -13731
Branches 4156 2353 -1803
=============================================
- Hits 20429 10553 -9876
+ Misses 16361 12565 -3796
+ Partials 981 922 -59
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/6480?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...che/skywalking/apm/agent/core/meter/MeterType.java](https://codecov.io/gh/apache/skywalking/pull/6480/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvbWV0ZXIvTWV0ZXJUeXBlLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (ø%)` | |
| [...skywalking/oap/server/core/alarm/AlarmMessage.java](https://codecov.io/gh/apache/skywalking/pull/6480/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYWxhcm0vQWxhcm1NZXNzYWdlLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...e/skywalking/apm/agent/core/meter/CounterMode.java](https://codecov.io/gh/apache/skywalking/pull/6480/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvbWV0ZXIvQ291bnRlck1vZGUuamF2YQ==) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (ø%)` | |
| [...org/apache/skywalking/apm/toolkit/meter/Gauge.java](https://codecov.io/gh/apache/skywalking/pull/6480/diff?src=pr&el=tree#diff-YXBtLWFwcGxpY2F0aW9uLXRvb2xraXQvYXBtLXRvb2xraXQtbWV0ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL3Rvb2xraXQvbWV0ZXIvR2F1Z2UuamF2YQ==) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (ø%)` | |
| [...ng/oap/server/core/analysis/config/NoneStream.java](https://codecov.io/gh/apache/skywalking/pull/6480/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvY29uZmlnL05vbmVTdHJlYW0uamF2YQ==) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...g/oap/server/core/cluster/ClusterHealthStatus.java](https://codecov.io/gh/apache/skywalking/pull/6480/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvY2x1c3Rlci9DbHVzdGVySGVhbHRoU3RhdHVzLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (ø%)` | |
| [...ng/apm/agent/core/context/trace/LogDataEntity.java](https://codecov.io/gh/apache/skywalking/pull/6480/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29udGV4dC90cmFjZS9Mb2dEYXRhRW50aXR5LmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (ø%)` | |
| [...p/server/core/analysis/metrics/MinLongMetrics.java](https://codecov.io/gh/apache/skywalking/pull/6480/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0cmljcy9NaW5Mb25nTWV0cmljcy5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (ø%)` | |
| [...er/exporter/provider/grpc/GRPCExporterSetting.java](https://codecov.io/gh/apache/skywalking/pull/6480/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9leHBvcnRlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2V4cG9ydGVyL3Byb3ZpZGVyL2dycGMvR1JQQ0V4cG9ydGVyU2V0dGluZy5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (ø%)` | |
| [...lking/oap/server/analyzer/event/EventAnalyzer.java](https://codecov.io/gh/apache/skywalking/pull/6480/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9ldmVudC1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2FuYWx5emVyL2V2ZW50L0V2ZW50QW5hbHl6ZXIuamF2YQ==) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-6.00%)` | |
| ... and [1324 more](https://codecov.io/gh/apache/skywalking/pull/6480/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/6480?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/6480?src=pr&el=footer). Last update [9946ec4...5c9722d](https://codecov.io/gh/apache/skywalking/pull/6480?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6480: Remove unnecessary check for getSkyWalkingDynamicField invocation
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #6480:
URL: https://github.com/apache/skywalking/pull/6480#issuecomment-789727063
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/6480?src=pr&el=h1) Report
> Merging [#6480](https://codecov.io/gh/apache/skywalking/pull/6480?src=pr&el=desc) (9f84ae1) into [master](https://codecov.io/gh/apache/skywalking/commit/de6a731d72fb87dd574da1d9b42495fdd29b4311?el=desc) (de6a731) will **decrease** coverage by `18.38%`.
> The diff coverage is `19.04%`.
[![Impacted file tree graph](https://codecov.io/gh/apache/skywalking/pull/6480/graphs/tree.svg?width=650&height=150&src=pr&token=qrILxY5yA8)](https://codecov.io/gh/apache/skywalking/pull/6480?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #6480 +/- ##
=============================================
- Coverage 54.00% 35.62% -18.39%
+ Complexity 4075 2595 -1480
=============================================
Files 1777 1018 -759
Lines 37757 24766 -12991
Branches 4153 2429 -1724
=============================================
- Hits 20392 8823 -11569
+ Misses 16385 15272 -1113
+ Partials 980 671 -309
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/6480?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...g/oap/log/analyzer/dsl/spec/filter/FilterSpec.java](https://codecov.io/gh/apache/skywalking/pull/6480/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9sb2ctYW5hbHl6ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL2xvZy9hbmFseXplci9kc2wvc3BlYy9maWx0ZXIvRmlsdGVyU3BlYy5qYXZh) | `44.61% <0.00%> (-6.27%)` | `7.00 <0.00> (ø)` | |
| [...p/log/analyzer/dsl/spec/parser/TextParserSpec.java](https://codecov.io/gh/apache/skywalking/pull/6480/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9sb2ctYW5hbHl6ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL2xvZy9hbmFseXplci9kc2wvc3BlYy9wYXJzZXIvVGV4dFBhcnNlclNwZWMuamF2YQ==) | `64.28% <0.00%> (-10.72%)` | `4.00 <0.00> (ø)` | |
| [...p/log/analyzer/dsl/spec/parser/YamlParserSpec.java](https://codecov.io/gh/apache/skywalking/pull/6480/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9sb2ctYW5hbHl6ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL2xvZy9hbmFseXplci9kc2wvc3BlYy9wYXJzZXIvWWFtbFBhcnNlclNwZWMuamF2YQ==) | `75.00% <ø> (ø)` | `1.00 <0.00> (ø)` | |
| [...p/log/analyzer/dsl/spec/parser/JsonParserSpec.java](https://codecov.io/gh/apache/skywalking/pull/6480/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9sb2ctYW5hbHl6ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL2xvZy9hbmFseXplci9kc2wvc3BlYy9wYXJzZXIvSnNvblBhcnNlclNwZWMuamF2YQ==) | `80.00% <50.00%> (+5.00%)` | `1.00 <0.00> (ø)` | |
| [...g/analyzer/dsl/spec/parser/AbstractParserSpec.java](https://codecov.io/gh/apache/skywalking/pull/6480/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9sb2ctYW5hbHl6ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL2xvZy9hbmFseXplci9kc2wvc3BlYy9wYXJzZXIvQWJzdHJhY3RQYXJzZXJTcGVjLmphdmE=) | `100.00% <100.00%> (ø)` | `1.00 <1.00> (?)` | |
| [...pache/skywalking/apm/agent/core/base64/Base64.java](https://codecov.io/gh/apache/skywalking/pull/6480/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvYmFzZTY0L0Jhc2U2NC5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-3.00%)` | |
| [...che/skywalking/apm/agent/core/meter/MeterType.java](https://codecov.io/gh/apache/skywalking/pull/6480/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvbWV0ZXIvTWV0ZXJUeXBlLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (ø%)` | |
| [...skywalking/oap/server/core/alarm/AlarmMessage.java](https://codecov.io/gh/apache/skywalking/pull/6480/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYWxhcm0vQWxhcm1NZXNzYWdlLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...e/skywalking/apm/agent/core/meter/CounterMode.java](https://codecov.io/gh/apache/skywalking/pull/6480/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvbWV0ZXIvQ291bnRlck1vZGUuamF2YQ==) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (ø%)` | |
| [...ywalking/apm/agent/core/logging/core/LogLevel.java](https://codecov.io/gh/apache/skywalking/pull/6480/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvbG9nZ2luZy9jb3JlL0xvZ0xldmVsLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| ... and [1369 more](https://codecov.io/gh/apache/skywalking/pull/6480/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/6480?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/6480?src=pr&el=footer). Last update [cb16e52...a8c1e14](https://codecov.io/gh/apache/skywalking/pull/6480?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6480: Remove unnecessary check for getSkyWalkingDynamicField invocation
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #6480:
URL: https://github.com/apache/skywalking/pull/6480#issuecomment-789727063
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/6480?src=pr&el=h1) Report
> Merging [#6480](https://codecov.io/gh/apache/skywalking/pull/6480?src=pr&el=desc) (b16aca4) into [master](https://codecov.io/gh/apache/skywalking/commit/cb16e524da2bf45258e67052443a6b9bc2460855?el=desc) (cb16e52) will **decrease** coverage by `54.08%`.
> The diff coverage is `n/a`.
[![Impacted file tree graph](https://codecov.io/gh/apache/skywalking/pull/6480/graphs/tree.svg?width=650&height=150&src=pr&token=qrILxY5yA8)](https://codecov.io/gh/apache/skywalking/pull/6480?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #6480 +/- ##
============================================
- Coverage 54.08% 0.00% -54.09%
============================================
Files 1778 181 -1597
Lines 37771 4470 -33301
Branches 4156 522 -3634
============================================
- Hits 20429 0 -20429
+ Misses 16361 4470 -11891
+ Partials 981 0 -981
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/6480?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...pache/skywalking/apm/agent/core/base64/Base64.java](https://codecov.io/gh/apache/skywalking/pull/6480/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvYmFzZTY0L0Jhc2U2NC5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-3.00%)` | |
| [...king/apm/util/RunnableWithExceptionProtection.java](https://codecov.io/gh/apache/skywalking/pull/6480/diff?src=pr&el=tree#diff-YXBtLWNvbW1vbnMvYXBtLXV0aWwvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL3V0aWwvUnVubmFibGVXaXRoRXhjZXB0aW9uUHJvdGVjdGlvbi5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-2.00%)` | |
| [...ywalking/apm/agent/core/logging/core/LogLevel.java](https://codecov.io/gh/apache/skywalking/pull/6480/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvbG9nZ2luZy9jb3JlL0xvZ0xldmVsLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...ywalking/apm/agent/core/plugin/EnhanceContext.java](https://codecov.io/gh/apache/skywalking/pull/6480/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcGx1Z2luL0VuaGFuY2VDb250ZXh0LmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-5.00%)` | |
| [...ywalking/apm/agent/core/plugin/PluginSelector.java](https://codecov.io/gh/apache/skywalking/pull/6480/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcGx1Z2luL1BsdWdpblNlbGVjdG9yLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-2.00%)` | |
| [...ywalking/apm/agent/core/profile/ProfileStatus.java](https://codecov.io/gh/apache/skywalking/pull/6480/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcHJvZmlsZS9Qcm9maWxlU3RhdHVzLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...walking/apm/agent/core/context/SW8CarrierItem.java](https://codecov.io/gh/apache/skywalking/pull/6480/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29udGV4dC9TVzhDYXJyaWVySXRlbS5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-2.00%)` | |
| [...walking/apm/agent/core/jvm/cpu/SunCpuAccessor.java](https://codecov.io/gh/apache/skywalking/pull/6480/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvanZtL2NwdS9TdW5DcHVBY2Nlc3Nvci5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-2.00%)` | |
| [...walking/apm/agent/core/logging/core/LogOutput.java](https://codecov.io/gh/apache/skywalking/pull/6480/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvbG9nZ2luZy9jb3JlL0xvZ091dHB1dC5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...walking/apm/agent/core/plugin/match/NameMatch.java](https://codecov.io/gh/apache/skywalking/pull/6480/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcGx1Z2luL21hdGNoL05hbWVNYXRjaC5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-3.00%)` | |
| ... and [1755 more](https://codecov.io/gh/apache/skywalking/pull/6480/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/6480?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/6480?src=pr&el=footer). Last update [9946ec4...5c9722d](https://codecov.io/gh/apache/skywalking/pull/6480?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] zifeihan commented on pull request #6480: Remove unnecessary check for getSkyWalkingDynamicField invocation
Posted by GitBox <gi...@apache.org>.
zifeihan commented on pull request #6480:
URL: https://github.com/apache/skywalking/pull/6480#issuecomment-790267618
> > It is good for me, can you include a fix for #6481
>
> Please don't mix 2 fixed in one commit. If this is good, please merge first.
Get it.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6480: Remove unnecessary check for getSkyWalkingDynamicField invocation
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #6480:
URL: https://github.com/apache/skywalking/pull/6480#issuecomment-789727063
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/6480?src=pr&el=h1) Report
> Merging [#6480](https://codecov.io/gh/apache/skywalking/pull/6480?src=pr&el=desc) (b16aca4) into [master](https://codecov.io/gh/apache/skywalking/commit/cb16e524da2bf45258e67052443a6b9bc2460855?el=desc) (cb16e52) will **decrease** coverage by `8.19%`.
> The diff coverage is `n/a`.
[![Impacted file tree graph](https://codecov.io/gh/apache/skywalking/pull/6480/graphs/tree.svg?width=650&height=150&src=pr&token=qrILxY5yA8)](https://codecov.io/gh/apache/skywalking/pull/6480?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #6480 +/- ##
============================================
- Coverage 54.08% 45.88% -8.20%
+ Complexity 4088 3473 -615
============================================
Files 1778 1018 -760
Lines 37771 24871 -12900
Branches 4156 2437 -1719
============================================
- Hits 20429 11413 -9016
+ Misses 16361 12477 -3884
Partials 981 981
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/6480?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...che/skywalking/apm/agent/core/meter/MeterType.java](https://codecov.io/gh/apache/skywalking/pull/6480/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvbWV0ZXIvTWV0ZXJUeXBlLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (ø%)` | |
| [...skywalking/oap/server/core/alarm/AlarmMessage.java](https://codecov.io/gh/apache/skywalking/pull/6480/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYWxhcm0vQWxhcm1NZXNzYWdlLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...e/skywalking/apm/agent/core/meter/CounterMode.java](https://codecov.io/gh/apache/skywalking/pull/6480/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvbWV0ZXIvQ291bnRlck1vZGUuamF2YQ==) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (ø%)` | |
| [...org/apache/skywalking/apm/toolkit/meter/Gauge.java](https://codecov.io/gh/apache/skywalking/pull/6480/diff?src=pr&el=tree#diff-YXBtLWFwcGxpY2F0aW9uLXRvb2xraXQvYXBtLXRvb2xraXQtbWV0ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL3Rvb2xraXQvbWV0ZXIvR2F1Z2UuamF2YQ==) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (ø%)` | |
| [...ng/oap/server/core/analysis/config/NoneStream.java](https://codecov.io/gh/apache/skywalking/pull/6480/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvY29uZmlnL05vbmVTdHJlYW0uamF2YQ==) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...g/oap/server/core/cluster/ClusterHealthStatus.java](https://codecov.io/gh/apache/skywalking/pull/6480/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvY2x1c3Rlci9DbHVzdGVySGVhbHRoU3RhdHVzLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (ø%)` | |
| [...ng/apm/agent/core/context/trace/LogDataEntity.java](https://codecov.io/gh/apache/skywalking/pull/6480/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29udGV4dC90cmFjZS9Mb2dEYXRhRW50aXR5LmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (ø%)` | |
| [...p/server/core/analysis/metrics/MinLongMetrics.java](https://codecov.io/gh/apache/skywalking/pull/6480/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0cmljcy9NaW5Mb25nTWV0cmljcy5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (ø%)` | |
| [...er/exporter/provider/grpc/GRPCExporterSetting.java](https://codecov.io/gh/apache/skywalking/pull/6480/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9leHBvcnRlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2V4cG9ydGVyL3Byb3ZpZGVyL2dycGMvR1JQQ0V4cG9ydGVyU2V0dGluZy5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (ø%)` | |
| [...log/analyzer/provider/log/ILogAnalyzerService.java](https://codecov.io/gh/apache/skywalking/pull/6480/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9sb2ctYW5hbHl6ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL2xvZy9hbmFseXplci9wcm92aWRlci9sb2cvSUxvZ0FuYWx5emVyU2VydmljZS5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| ... and [1285 more](https://codecov.io/gh/apache/skywalking/pull/6480/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/6480?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/6480?src=pr&el=footer). Last update [9946ec4...5c9722d](https://codecov.io/gh/apache/skywalking/pull/6480?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6480: Remove unnecessary check for getSkyWalkingDynamicField invocation
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #6480:
URL: https://github.com/apache/skywalking/pull/6480#issuecomment-789727063
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/6480?src=pr&el=h1) Report
> Merging [#6480](https://codecov.io/gh/apache/skywalking/pull/6480?src=pr&el=desc) (9f84ae1) into [master](https://codecov.io/gh/apache/skywalking/commit/de6a731d72fb87dd574da1d9b42495fdd29b4311?el=desc) (de6a731) will **decrease** coverage by `16.24%`.
> The diff coverage is `19.04%`.
[![Impacted file tree graph](https://codecov.io/gh/apache/skywalking/pull/6480/graphs/tree.svg?width=650&height=150&src=pr&token=qrILxY5yA8)](https://codecov.io/gh/apache/skywalking/pull/6480?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #6480 +/- ##
=============================================
- Coverage 54.00% 37.76% -16.25%
+ Complexity 4075 2711 -1364
=============================================
Files 1777 1025 -752
Lines 37757 24919 -12838
Branches 4153 2441 -1712
=============================================
- Hits 20392 9410 -10982
+ Misses 16385 14770 -1615
+ Partials 980 739 -241
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/6480?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...g/oap/log/analyzer/dsl/spec/filter/FilterSpec.java](https://codecov.io/gh/apache/skywalking/pull/6480/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9sb2ctYW5hbHl6ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL2xvZy9hbmFseXplci9kc2wvc3BlYy9maWx0ZXIvRmlsdGVyU3BlYy5qYXZh) | `44.61% <0.00%> (-6.27%)` | `7.00 <0.00> (ø)` | |
| [...p/log/analyzer/dsl/spec/parser/TextParserSpec.java](https://codecov.io/gh/apache/skywalking/pull/6480/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9sb2ctYW5hbHl6ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL2xvZy9hbmFseXplci9kc2wvc3BlYy9wYXJzZXIvVGV4dFBhcnNlclNwZWMuamF2YQ==) | `64.28% <0.00%> (-10.72%)` | `4.00 <0.00> (ø)` | |
| [...p/log/analyzer/dsl/spec/parser/YamlParserSpec.java](https://codecov.io/gh/apache/skywalking/pull/6480/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9sb2ctYW5hbHl6ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL2xvZy9hbmFseXplci9kc2wvc3BlYy9wYXJzZXIvWWFtbFBhcnNlclNwZWMuamF2YQ==) | `75.00% <ø> (ø)` | `1.00 <0.00> (ø)` | |
| [...p/log/analyzer/dsl/spec/parser/JsonParserSpec.java](https://codecov.io/gh/apache/skywalking/pull/6480/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9sb2ctYW5hbHl6ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL2xvZy9hbmFseXplci9kc2wvc3BlYy9wYXJzZXIvSnNvblBhcnNlclNwZWMuamF2YQ==) | `80.00% <50.00%> (+5.00%)` | `1.00 <0.00> (ø)` | |
| [...g/analyzer/dsl/spec/parser/AbstractParserSpec.java](https://codecov.io/gh/apache/skywalking/pull/6480/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9sb2ctYW5hbHl6ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL2xvZy9hbmFseXplci9kc2wvc3BlYy9wYXJzZXIvQWJzdHJhY3RQYXJzZXJTcGVjLmphdmE=) | `100.00% <100.00%> (ø)` | `1.00 <1.00> (?)` | |
| [...pache/skywalking/apm/agent/core/base64/Base64.java](https://codecov.io/gh/apache/skywalking/pull/6480/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvYmFzZTY0L0Jhc2U2NC5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-3.00%)` | |
| [...che/skywalking/apm/agent/core/meter/MeterType.java](https://codecov.io/gh/apache/skywalking/pull/6480/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvbWV0ZXIvTWV0ZXJUeXBlLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (ø%)` | |
| [...skywalking/oap/server/core/alarm/AlarmMessage.java](https://codecov.io/gh/apache/skywalking/pull/6480/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYWxhcm0vQWxhcm1NZXNzYWdlLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...e/skywalking/apm/agent/core/meter/CounterMode.java](https://codecov.io/gh/apache/skywalking/pull/6480/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvbWV0ZXIvQ291bnRlck1vZGUuamF2YQ==) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (ø%)` | |
| [...ywalking/apm/agent/core/logging/core/LogLevel.java](https://codecov.io/gh/apache/skywalking/pull/6480/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvbG9nZ2luZy9jb3JlL0xvZ0xldmVsLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| ... and [1358 more](https://codecov.io/gh/apache/skywalking/pull/6480/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/6480?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/6480?src=pr&el=footer). Last update [cb16e52...a8c1e14](https://codecov.io/gh/apache/skywalking/pull/6480?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6480: Remove unnecessary check for getSkyWalkingDynamicField invocation
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #6480:
URL: https://github.com/apache/skywalking/pull/6480#issuecomment-789727063
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/6480?src=pr&el=h1) Report
> Merging [#6480](https://codecov.io/gh/apache/skywalking/pull/6480?src=pr&el=desc) (a8c1e14) into [master](https://codecov.io/gh/apache/skywalking/commit/de6a731d72fb87dd574da1d9b42495fdd29b4311?el=desc) (de6a731) will **decrease** coverage by `15.85%`.
> The diff coverage is `19.04%`.
[![Impacted file tree graph](https://codecov.io/gh/apache/skywalking/pull/6480/graphs/tree.svg?width=650&height=150&src=pr&token=qrILxY5yA8)](https://codecov.io/gh/apache/skywalking/pull/6480?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #6480 +/- ##
=============================================
- Coverage 54.00% 38.14% -15.86%
+ Complexity 4075 2775 -1300
=============================================
Files 1777 967 -810
Lines 37757 23484 -14273
Branches 4153 2264 -1889
=============================================
- Hits 20392 8959 -11433
+ Misses 16385 13778 -2607
+ Partials 980 747 -233
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/6480?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...g/oap/log/analyzer/dsl/spec/filter/FilterSpec.java](https://codecov.io/gh/apache/skywalking/pull/6480/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9sb2ctYW5hbHl6ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL2xvZy9hbmFseXplci9kc2wvc3BlYy9maWx0ZXIvRmlsdGVyU3BlYy5qYXZh) | `35.38% <0.00%> (-15.50%)` | `5.00 <0.00> (-2.00)` | |
| [...p/log/analyzer/dsl/spec/parser/TextParserSpec.java](https://codecov.io/gh/apache/skywalking/pull/6480/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9sb2ctYW5hbHl6ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL2xvZy9hbmFseXplci9kc2wvc3BlYy9wYXJzZXIvVGV4dFBhcnNlclNwZWMuamF2YQ==) | `14.28% <0.00%> (-60.72%)` | `1.00 <0.00> (-3.00)` | |
| [...p/log/analyzer/dsl/spec/parser/YamlParserSpec.java](https://codecov.io/gh/apache/skywalking/pull/6480/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9sb2ctYW5hbHl6ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL2xvZy9hbmFseXplci9kc2wvc3BlYy9wYXJzZXIvWWFtbFBhcnNlclNwZWMuamF2YQ==) | `75.00% <ø> (ø)` | `1.00 <0.00> (ø)` | |
| [...p/log/analyzer/dsl/spec/parser/JsonParserSpec.java](https://codecov.io/gh/apache/skywalking/pull/6480/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9sb2ctYW5hbHl6ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL2xvZy9hbmFseXplci9kc2wvc3BlYy9wYXJzZXIvSnNvblBhcnNlclNwZWMuamF2YQ==) | `80.00% <50.00%> (+5.00%)` | `1.00 <0.00> (ø)` | |
| [...g/analyzer/dsl/spec/parser/AbstractParserSpec.java](https://codecov.io/gh/apache/skywalking/pull/6480/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9sb2ctYW5hbHl6ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL2xvZy9hbmFseXplci9kc2wvc3BlYy9wYXJzZXIvQWJzdHJhY3RQYXJzZXJTcGVjLmphdmE=) | `100.00% <100.00%> (ø)` | `1.00 <1.00> (?)` | |
| [...skywalking/oap/server/core/alarm/AlarmMessage.java](https://codecov.io/gh/apache/skywalking/pull/6480/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYWxhcm0vQWxhcm1NZXNzYWdlLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...kywalking/oap/server/core/storage/AbstractDAO.java](https://codecov.io/gh/apache/skywalking/pull/6480/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvc3RvcmFnZS9BYnN0cmFjdERBTy5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-2.00%)` | |
| [...ng/oap/server/core/analysis/config/NoneStream.java](https://codecov.io/gh/apache/skywalking/pull/6480/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvY29uZmlnL05vbmVTdHJlYW0uamF2YQ==) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...g/oap/server/core/cluster/ClusterHealthStatus.java](https://codecov.io/gh/apache/skywalking/pull/6480/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvY2x1c3Rlci9DbHVzdGVySGVhbHRoU3RhdHVzLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (ø%)` | |
| [...ng/apm/agent/core/context/trace/LogDataEntity.java](https://codecov.io/gh/apache/skywalking/pull/6480/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29udGV4dC90cmFjZS9Mb2dEYXRhRW50aXR5LmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (ø%)` | |
| ... and [1366 more](https://codecov.io/gh/apache/skywalking/pull/6480/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/6480?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/6480?src=pr&el=footer). Last update [cb16e52...a8c1e14](https://codecov.io/gh/apache/skywalking/pull/6480?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6480: Remove unnecessary check for getSkyWalkingDynamicField invocation
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #6480:
URL: https://github.com/apache/skywalking/pull/6480#issuecomment-789727063
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/6480?src=pr&el=h1) Report
> Merging [#6480](https://codecov.io/gh/apache/skywalking/pull/6480?src=pr&el=desc) (9f84ae1) into [master](https://codecov.io/gh/apache/skywalking/commit/de6a731d72fb87dd574da1d9b42495fdd29b4311?el=desc) (de6a731) will **decrease** coverage by `54.00%`.
> The diff coverage is `n/a`.
[![Impacted file tree graph](https://codecov.io/gh/apache/skywalking/pull/6480/graphs/tree.svg?width=650&height=150&src=pr&token=qrILxY5yA8)](https://codecov.io/gh/apache/skywalking/pull/6480?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #6480 +/- ##
============================================
- Coverage 54.00% 0.00% -54.01%
============================================
Files 1777 178 -1599
Lines 37757 4333 -33424
Branches 4153 497 -3656
============================================
- Hits 20392 0 -20392
+ Misses 16385 4333 -12052
+ Partials 980 0 -980
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/6480?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...pache/skywalking/apm/agent/core/base64/Base64.java](https://codecov.io/gh/apache/skywalking/pull/6480/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvYmFzZTY0L0Jhc2U2NC5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-3.00%)` | |
| [...king/apm/util/RunnableWithExceptionProtection.java](https://codecov.io/gh/apache/skywalking/pull/6480/diff?src=pr&el=tree#diff-YXBtLWNvbW1vbnMvYXBtLXV0aWwvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL3V0aWwvUnVubmFibGVXaXRoRXhjZXB0aW9uUHJvdGVjdGlvbi5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-2.00%)` | |
| [...ywalking/apm/agent/core/logging/core/LogLevel.java](https://codecov.io/gh/apache/skywalking/pull/6480/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvbG9nZ2luZy9jb3JlL0xvZ0xldmVsLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...ywalking/apm/agent/core/plugin/EnhanceContext.java](https://codecov.io/gh/apache/skywalking/pull/6480/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcGx1Z2luL0VuaGFuY2VDb250ZXh0LmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-5.00%)` | |
| [...ywalking/apm/agent/core/plugin/PluginSelector.java](https://codecov.io/gh/apache/skywalking/pull/6480/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcGx1Z2luL1BsdWdpblNlbGVjdG9yLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-2.00%)` | |
| [...ywalking/apm/agent/core/profile/ProfileStatus.java](https://codecov.io/gh/apache/skywalking/pull/6480/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcHJvZmlsZS9Qcm9maWxlU3RhdHVzLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...walking/apm/agent/core/context/SW8CarrierItem.java](https://codecov.io/gh/apache/skywalking/pull/6480/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29udGV4dC9TVzhDYXJyaWVySXRlbS5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-2.00%)` | |
| [...walking/apm/agent/core/jvm/cpu/SunCpuAccessor.java](https://codecov.io/gh/apache/skywalking/pull/6480/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvanZtL2NwdS9TdW5DcHVBY2Nlc3Nvci5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-2.00%)` | |
| [...walking/apm/agent/core/logging/core/LogOutput.java](https://codecov.io/gh/apache/skywalking/pull/6480/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvbG9nZ2luZy9jb3JlL0xvZ091dHB1dC5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...walking/apm/agent/core/plugin/match/NameMatch.java](https://codecov.io/gh/apache/skywalking/pull/6480/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcGx1Z2luL21hdGNoL05hbWVNYXRjaC5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-3.00%)` | |
| ... and [1748 more](https://codecov.io/gh/apache/skywalking/pull/6480/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/6480?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/6480?src=pr&el=footer). Last update [cb16e52...a8c1e14](https://codecov.io/gh/apache/skywalking/pull/6480?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6480: Remove unnecessary check for getSkyWalkingDynamicField invocation
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #6480:
URL: https://github.com/apache/skywalking/pull/6480#issuecomment-789727063
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/6480?src=pr&el=h1) Report
> Merging [#6480](https://codecov.io/gh/apache/skywalking/pull/6480?src=pr&el=desc) (b16aca4) into [master](https://codecov.io/gh/apache/skywalking/commit/cb16e524da2bf45258e67052443a6b9bc2460855?el=desc) (cb16e52) will **decrease** coverage by `8.21%`.
> The diff coverage is `n/a`.
[![Impacted file tree graph](https://codecov.io/gh/apache/skywalking/pull/6480/graphs/tree.svg?width=650&height=150&src=pr&token=qrILxY5yA8)](https://codecov.io/gh/apache/skywalking/pull/6480?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #6480 +/- ##
============================================
- Coverage 54.08% 45.86% -8.22%
+ Complexity 4088 3473 -615
============================================
Files 1778 1020 -758
Lines 37771 24882 -12889
Branches 4156 2437 -1719
============================================
- Hits 20429 11413 -9016
+ Misses 16361 12488 -3873
Partials 981 981
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/6480?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...che/skywalking/apm/agent/core/meter/MeterType.java](https://codecov.io/gh/apache/skywalking/pull/6480/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvbWV0ZXIvTWV0ZXJUeXBlLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (ø%)` | |
| [...skywalking/oap/server/core/alarm/AlarmMessage.java](https://codecov.io/gh/apache/skywalking/pull/6480/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYWxhcm0vQWxhcm1NZXNzYWdlLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...e/skywalking/apm/agent/core/meter/CounterMode.java](https://codecov.io/gh/apache/skywalking/pull/6480/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvbWV0ZXIvQ291bnRlck1vZGUuamF2YQ==) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (ø%)` | |
| [...org/apache/skywalking/apm/toolkit/meter/Gauge.java](https://codecov.io/gh/apache/skywalking/pull/6480/diff?src=pr&el=tree#diff-YXBtLWFwcGxpY2F0aW9uLXRvb2xraXQvYXBtLXRvb2xraXQtbWV0ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL3Rvb2xraXQvbWV0ZXIvR2F1Z2UuamF2YQ==) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (ø%)` | |
| [...ng/oap/server/core/analysis/config/NoneStream.java](https://codecov.io/gh/apache/skywalking/pull/6480/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvY29uZmlnL05vbmVTdHJlYW0uamF2YQ==) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...g/oap/server/core/cluster/ClusterHealthStatus.java](https://codecov.io/gh/apache/skywalking/pull/6480/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvY2x1c3Rlci9DbHVzdGVySGVhbHRoU3RhdHVzLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (ø%)` | |
| [...ng/apm/agent/core/context/trace/LogDataEntity.java](https://codecov.io/gh/apache/skywalking/pull/6480/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29udGV4dC90cmFjZS9Mb2dEYXRhRW50aXR5LmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (ø%)` | |
| [...p/server/core/analysis/metrics/MinLongMetrics.java](https://codecov.io/gh/apache/skywalking/pull/6480/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0cmljcy9NaW5Mb25nTWV0cmljcy5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (ø%)` | |
| [...er/exporter/provider/grpc/GRPCExporterSetting.java](https://codecov.io/gh/apache/skywalking/pull/6480/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9leHBvcnRlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2V4cG9ydGVyL3Byb3ZpZGVyL2dycGMvR1JQQ0V4cG9ydGVyU2V0dGluZy5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (ø%)` | |
| [...ent/core/plugin/bytebuddy/ReturnTypeNameMatch.java](https://codecov.io/gh/apache/skywalking/pull/6480/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcGx1Z2luL2J5dGVidWRkeS9SZXR1cm5UeXBlTmFtZU1hdGNoLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (ø%)` | |
| ... and [1285 more](https://codecov.io/gh/apache/skywalking/pull/6480/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/6480?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/6480?src=pr&el=footer). Last update [9946ec4...5c9722d](https://codecov.io/gh/apache/skywalking/pull/6480?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6480: Remove unnecessary check for getSkyWalkingDynamicField invocation
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #6480:
URL: https://github.com/apache/skywalking/pull/6480#issuecomment-789727063
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/6480?src=pr&el=h1) Report
> Merging [#6480](https://codecov.io/gh/apache/skywalking/pull/6480?src=pr&el=desc) (9f84ae1) into [master](https://codecov.io/gh/apache/skywalking/commit/de6a731d72fb87dd574da1d9b42495fdd29b4311?el=desc) (de6a731) will **decrease** coverage by `30.72%`.
> The diff coverage is `19.04%`.
[![Impacted file tree graph](https://codecov.io/gh/apache/skywalking/pull/6480/graphs/tree.svg?width=650&height=150&src=pr&token=qrILxY5yA8)](https://codecov.io/gh/apache/skywalking/pull/6480?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #6480 +/- ##
=============================================
- Coverage 54.00% 23.28% -30.73%
+ Complexity 4075 1733 -2342
=============================================
Files 1777 987 -790
Lines 37757 23786 -13971
Branches 4153 2316 -1837
=============================================
- Hits 20392 5538 -14854
- Misses 16385 17851 +1466
+ Partials 980 397 -583
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/6480?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...g/oap/log/analyzer/dsl/spec/filter/FilterSpec.java](https://codecov.io/gh/apache/skywalking/pull/6480/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9sb2ctYW5hbHl6ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL2xvZy9hbmFseXplci9kc2wvc3BlYy9maWx0ZXIvRmlsdGVyU3BlYy5qYXZh) | `20.00% <0.00%> (-30.88%)` | `2.00 <0.00> (-5.00)` | |
| [...p/log/analyzer/dsl/spec/parser/TextParserSpec.java](https://codecov.io/gh/apache/skywalking/pull/6480/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9sb2ctYW5hbHl6ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL2xvZy9hbmFseXplci9kc2wvc3BlYy9wYXJzZXIvVGV4dFBhcnNlclNwZWMuamF2YQ==) | `14.28% <0.00%> (-60.72%)` | `1.00 <0.00> (-3.00)` | |
| [...p/log/analyzer/dsl/spec/parser/YamlParserSpec.java](https://codecov.io/gh/apache/skywalking/pull/6480/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9sb2ctYW5hbHl6ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL2xvZy9hbmFseXplci9kc2wvc3BlYy9wYXJzZXIvWWFtbFBhcnNlclNwZWMuamF2YQ==) | `75.00% <ø> (ø)` | `1.00 <0.00> (ø)` | |
| [...p/log/analyzer/dsl/spec/parser/JsonParserSpec.java](https://codecov.io/gh/apache/skywalking/pull/6480/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9sb2ctYW5hbHl6ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL2xvZy9hbmFseXplci9kc2wvc3BlYy9wYXJzZXIvSnNvblBhcnNlclNwZWMuamF2YQ==) | `80.00% <50.00%> (+5.00%)` | `1.00 <0.00> (ø)` | |
| [...g/analyzer/dsl/spec/parser/AbstractParserSpec.java](https://codecov.io/gh/apache/skywalking/pull/6480/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9sb2ctYW5hbHl6ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL2xvZy9hbmFseXplci9kc2wvc3BlYy9wYXJzZXIvQWJzdHJhY3RQYXJzZXJTcGVjLmphdmE=) | `100.00% <100.00%> (ø)` | `1.00 <1.00> (?)` | |
| [...he/skywalking/oap/server/core/source/GCPhrase.java](https://codecov.io/gh/apache/skywalking/pull/6480/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvc291cmNlL0dDUGhyYXNlLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...pache/skywalking/apm/agent/core/base64/Base64.java](https://codecov.io/gh/apache/skywalking/pull/6480/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvYmFzZTY0L0Jhc2U2NC5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-3.00%)` | |
| [...che/skywalking/apm/agent/core/meter/MeterType.java](https://codecov.io/gh/apache/skywalking/pull/6480/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvbWV0ZXIvTWV0ZXJUeXBlLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (ø%)` | |
| [...skywalking/oap/server/core/alarm/AlarmMessage.java](https://codecov.io/gh/apache/skywalking/pull/6480/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYWxhcm0vQWxhcm1NZXNzYWdlLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...skywalking/oap/server/core/source/RequestType.java](https://codecov.io/gh/apache/skywalking/pull/6480/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvc291cmNlL1JlcXVlc3RUeXBlLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| ... and [1473 more](https://codecov.io/gh/apache/skywalking/pull/6480/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/6480?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/6480?src=pr&el=footer). Last update [cb16e52...a8c1e14](https://codecov.io/gh/apache/skywalking/pull/6480?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6480: Remove unnecessary check for getSkyWalkingDynamicField invocation
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #6480:
URL: https://github.com/apache/skywalking/pull/6480#issuecomment-789727063
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/6480?src=pr&el=h1) Report
> Merging [#6480](https://codecov.io/gh/apache/skywalking/pull/6480?src=pr&el=desc) (b16aca4) into [master](https://codecov.io/gh/apache/skywalking/commit/cb16e524da2bf45258e67052443a6b9bc2460855?el=desc) (cb16e52) will **decrease** coverage by `30.91%`.
> The diff coverage is `n/a`.
[![Impacted file tree graph](https://codecov.io/gh/apache/skywalking/pull/6480/graphs/tree.svg?width=650&height=150&src=pr&token=qrILxY5yA8)](https://codecov.io/gh/apache/skywalking/pull/6480?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #6480 +/- ##
=============================================
- Coverage 54.08% 23.17% -30.92%
+ Complexity 4088 1731 -2357
=============================================
Files 1778 987 -791
Lines 37771 23887 -13884
Branches 4156 2339 -1817
=============================================
- Hits 20429 5536 -14893
- Misses 16361 17952 +1591
+ Partials 981 399 -582
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/6480?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...he/skywalking/oap/server/core/source/GCPhrase.java](https://codecov.io/gh/apache/skywalking/pull/6480/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvc291cmNlL0dDUGhyYXNlLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...pache/skywalking/apm/agent/core/base64/Base64.java](https://codecov.io/gh/apache/skywalking/pull/6480/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvYmFzZTY0L0Jhc2U2NC5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-3.00%)` | |
| [...che/skywalking/apm/agent/core/meter/MeterType.java](https://codecov.io/gh/apache/skywalking/pull/6480/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvbWV0ZXIvTWV0ZXJUeXBlLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (ø%)` | |
| [...skywalking/oap/server/core/alarm/AlarmMessage.java](https://codecov.io/gh/apache/skywalking/pull/6480/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYWxhcm0vQWxhcm1NZXNzYWdlLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...skywalking/oap/server/core/source/RequestType.java](https://codecov.io/gh/apache/skywalking/pull/6480/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvc291cmNlL1JlcXVlc3RUeXBlLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...kywalking/oap/server/core/storage/AbstractDAO.java](https://codecov.io/gh/apache/skywalking/pull/6480/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvc3RvcmFnZS9BYnN0cmFjdERBTy5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-2.00%)` | |
| [...e/skywalking/apm/agent/core/meter/CounterMode.java](https://codecov.io/gh/apache/skywalking/pull/6480/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvbWV0ZXIvQ291bnRlck1vZGUuamF2YQ==) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (ø%)` | |
| [...walking/oap/server/core/source/MemoryPoolType.java](https://codecov.io/gh/apache/skywalking/pull/6480/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvc291cmNlL01lbW9yeVBvb2xUeXBlLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...alking/oap/server/core/analysis/record/Record.java](https://codecov.io/gh/apache/skywalking/pull/6480/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvcmVjb3JkL1JlY29yZC5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...ywalking/apm/agent/core/logging/core/LogLevel.java](https://codecov.io/gh/apache/skywalking/pull/6480/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvbG9nZ2luZy9jb3JlL0xvZ0xldmVsLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| ... and [1476 more](https://codecov.io/gh/apache/skywalking/pull/6480/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/6480?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/6480?src=pr&el=footer). Last update [9946ec4...5c9722d](https://codecov.io/gh/apache/skywalking/pull/6480?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6480: Remove unnecessary check for getSkyWalkingDynamicField invocation
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #6480:
URL: https://github.com/apache/skywalking/pull/6480#issuecomment-789727063
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/6480?src=pr&el=h1) Report
> Merging [#6480](https://codecov.io/gh/apache/skywalking/pull/6480?src=pr&el=desc) (b16aca4) into [master](https://codecov.io/gh/apache/skywalking/commit/cb16e524da2bf45258e67052443a6b9bc2460855?el=desc) (cb16e52) will **decrease** coverage by `54.08%`.
> The diff coverage is `n/a`.
[![Impacted file tree graph](https://codecov.io/gh/apache/skywalking/pull/6480/graphs/tree.svg?width=650&height=150&src=pr&token=qrILxY5yA8)](https://codecov.io/gh/apache/skywalking/pull/6480?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #6480 +/- ##
============================================
- Coverage 54.08% 0.00% -54.09%
============================================
Files 1778 171 -1607
Lines 37771 4229 -33542
Branches 4156 486 -3670
============================================
- Hits 20429 0 -20429
+ Misses 16361 4229 -12132
+ Partials 981 0 -981
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/6480?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...pache/skywalking/apm/agent/core/base64/Base64.java](https://codecov.io/gh/apache/skywalking/pull/6480/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvYmFzZTY0L0Jhc2U2NC5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-3.00%)` | |
| [...king/apm/util/RunnableWithExceptionProtection.java](https://codecov.io/gh/apache/skywalking/pull/6480/diff?src=pr&el=tree#diff-YXBtLWNvbW1vbnMvYXBtLXV0aWwvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL3V0aWwvUnVubmFibGVXaXRoRXhjZXB0aW9uUHJvdGVjdGlvbi5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-2.00%)` | |
| [...ywalking/apm/agent/core/logging/core/LogLevel.java](https://codecov.io/gh/apache/skywalking/pull/6480/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvbG9nZ2luZy9jb3JlL0xvZ0xldmVsLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...ywalking/apm/agent/core/plugin/EnhanceContext.java](https://codecov.io/gh/apache/skywalking/pull/6480/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcGx1Z2luL0VuaGFuY2VDb250ZXh0LmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-5.00%)` | |
| [...ywalking/apm/agent/core/plugin/PluginSelector.java](https://codecov.io/gh/apache/skywalking/pull/6480/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcGx1Z2luL1BsdWdpblNlbGVjdG9yLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-2.00%)` | |
| [...ywalking/apm/agent/core/profile/ProfileStatus.java](https://codecov.io/gh/apache/skywalking/pull/6480/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcHJvZmlsZS9Qcm9maWxlU3RhdHVzLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...walking/apm/agent/core/context/SW8CarrierItem.java](https://codecov.io/gh/apache/skywalking/pull/6480/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29udGV4dC9TVzhDYXJyaWVySXRlbS5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-2.00%)` | |
| [...walking/apm/agent/core/jvm/cpu/SunCpuAccessor.java](https://codecov.io/gh/apache/skywalking/pull/6480/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvanZtL2NwdS9TdW5DcHVBY2Nlc3Nvci5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-2.00%)` | |
| [...walking/apm/agent/core/logging/core/LogOutput.java](https://codecov.io/gh/apache/skywalking/pull/6480/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvbG9nZ2luZy9jb3JlL0xvZ091dHB1dC5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...walking/apm/agent/core/plugin/match/NameMatch.java](https://codecov.io/gh/apache/skywalking/pull/6480/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcGx1Z2luL21hdGNoL05hbWVNYXRjaC5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-3.00%)` | |
| ... and [1755 more](https://codecov.io/gh/apache/skywalking/pull/6480/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/6480?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/6480?src=pr&el=footer). Last update [9946ec4...5c9722d](https://codecov.io/gh/apache/skywalking/pull/6480?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6480: Remove unnecessary check for getSkyWalkingDynamicField invocation
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #6480:
URL: https://github.com/apache/skywalking/pull/6480#issuecomment-789727063
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/6480?src=pr&el=h1) Report
> Merging [#6480](https://codecov.io/gh/apache/skywalking/pull/6480?src=pr&el=desc) (b16aca4) into [master](https://codecov.io/gh/apache/skywalking/commit/cb16e524da2bf45258e67052443a6b9bc2460855?el=desc) (cb16e52) will **decrease** coverage by `54.08%`.
> The diff coverage is `n/a`.
[![Impacted file tree graph](https://codecov.io/gh/apache/skywalking/pull/6480/graphs/tree.svg?width=650&height=150&src=pr&token=qrILxY5yA8)](https://codecov.io/gh/apache/skywalking/pull/6480?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #6480 +/- ##
============================================
- Coverage 54.08% 0.00% -54.09%
============================================
Files 1778 183 -1595
Lines 37771 4522 -33249
Branches 4156 523 -3633
============================================
- Hits 20429 0 -20429
+ Misses 16361 4522 -11839
+ Partials 981 0 -981
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/6480?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...pache/skywalking/apm/agent/core/base64/Base64.java](https://codecov.io/gh/apache/skywalking/pull/6480/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvYmFzZTY0L0Jhc2U2NC5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-3.00%)` | |
| [...king/apm/util/RunnableWithExceptionProtection.java](https://codecov.io/gh/apache/skywalking/pull/6480/diff?src=pr&el=tree#diff-YXBtLWNvbW1vbnMvYXBtLXV0aWwvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL3V0aWwvUnVubmFibGVXaXRoRXhjZXB0aW9uUHJvdGVjdGlvbi5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-2.00%)` | |
| [...ywalking/apm/agent/core/logging/core/LogLevel.java](https://codecov.io/gh/apache/skywalking/pull/6480/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvbG9nZ2luZy9jb3JlL0xvZ0xldmVsLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...ywalking/apm/agent/core/plugin/EnhanceContext.java](https://codecov.io/gh/apache/skywalking/pull/6480/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcGx1Z2luL0VuaGFuY2VDb250ZXh0LmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-5.00%)` | |
| [...ywalking/apm/agent/core/plugin/PluginSelector.java](https://codecov.io/gh/apache/skywalking/pull/6480/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcGx1Z2luL1BsdWdpblNlbGVjdG9yLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-2.00%)` | |
| [...ywalking/apm/agent/core/profile/ProfileStatus.java](https://codecov.io/gh/apache/skywalking/pull/6480/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcHJvZmlsZS9Qcm9maWxlU3RhdHVzLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...walking/apm/agent/core/context/SW8CarrierItem.java](https://codecov.io/gh/apache/skywalking/pull/6480/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29udGV4dC9TVzhDYXJyaWVySXRlbS5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-2.00%)` | |
| [...walking/apm/agent/core/jvm/cpu/SunCpuAccessor.java](https://codecov.io/gh/apache/skywalking/pull/6480/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvanZtL2NwdS9TdW5DcHVBY2Nlc3Nvci5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-2.00%)` | |
| [...walking/apm/agent/core/logging/core/LogOutput.java](https://codecov.io/gh/apache/skywalking/pull/6480/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvbG9nZ2luZy9jb3JlL0xvZ091dHB1dC5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...walking/apm/agent/core/plugin/match/NameMatch.java](https://codecov.io/gh/apache/skywalking/pull/6480/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcGx1Z2luL21hdGNoL05hbWVNYXRjaC5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-3.00%)` | |
| ... and [1756 more](https://codecov.io/gh/apache/skywalking/pull/6480/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/6480?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/6480?src=pr&el=footer). Last update [9946ec4...5c9722d](https://codecov.io/gh/apache/skywalking/pull/6480?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6480: Remove unnecessary check for getSkyWalkingDynamicField invocation
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #6480:
URL: https://github.com/apache/skywalking/pull/6480#issuecomment-789727063
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/6480?src=pr&el=h1) Report
> Merging [#6480](https://codecov.io/gh/apache/skywalking/pull/6480?src=pr&el=desc) (b16aca4) into [master](https://codecov.io/gh/apache/skywalking/commit/cb16e524da2bf45258e67052443a6b9bc2460855?el=desc) (cb16e52) will **decrease** coverage by `54.08%`.
> The diff coverage is `n/a`.
[![Impacted file tree graph](https://codecov.io/gh/apache/skywalking/pull/6480/graphs/tree.svg?width=650&height=150&src=pr&token=qrILxY5yA8)](https://codecov.io/gh/apache/skywalking/pull/6480?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #6480 +/- ##
============================================
- Coverage 54.08% 0.00% -54.09%
============================================
Files 1778 180 -1598
Lines 37771 4397 -33374
Branches 4156 505 -3651
============================================
- Hits 20429 0 -20429
+ Misses 16361 4397 -11964
+ Partials 981 0 -981
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/6480?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...pache/skywalking/apm/agent/core/base64/Base64.java](https://codecov.io/gh/apache/skywalking/pull/6480/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvYmFzZTY0L0Jhc2U2NC5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-3.00%)` | |
| [...king/apm/util/RunnableWithExceptionProtection.java](https://codecov.io/gh/apache/skywalking/pull/6480/diff?src=pr&el=tree#diff-YXBtLWNvbW1vbnMvYXBtLXV0aWwvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL3V0aWwvUnVubmFibGVXaXRoRXhjZXB0aW9uUHJvdGVjdGlvbi5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-2.00%)` | |
| [...ywalking/apm/agent/core/logging/core/LogLevel.java](https://codecov.io/gh/apache/skywalking/pull/6480/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvbG9nZ2luZy9jb3JlL0xvZ0xldmVsLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...ywalking/apm/agent/core/plugin/EnhanceContext.java](https://codecov.io/gh/apache/skywalking/pull/6480/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcGx1Z2luL0VuaGFuY2VDb250ZXh0LmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-5.00%)` | |
| [...ywalking/apm/agent/core/plugin/PluginSelector.java](https://codecov.io/gh/apache/skywalking/pull/6480/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcGx1Z2luL1BsdWdpblNlbGVjdG9yLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-2.00%)` | |
| [...ywalking/apm/agent/core/profile/ProfileStatus.java](https://codecov.io/gh/apache/skywalking/pull/6480/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcHJvZmlsZS9Qcm9maWxlU3RhdHVzLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...walking/apm/agent/core/context/SW8CarrierItem.java](https://codecov.io/gh/apache/skywalking/pull/6480/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29udGV4dC9TVzhDYXJyaWVySXRlbS5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-2.00%)` | |
| [...walking/apm/agent/core/jvm/cpu/SunCpuAccessor.java](https://codecov.io/gh/apache/skywalking/pull/6480/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvanZtL2NwdS9TdW5DcHVBY2Nlc3Nvci5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-2.00%)` | |
| [...walking/apm/agent/core/logging/core/LogOutput.java](https://codecov.io/gh/apache/skywalking/pull/6480/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvbG9nZ2luZy9jb3JlL0xvZ091dHB1dC5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...walking/apm/agent/core/plugin/match/NameMatch.java](https://codecov.io/gh/apache/skywalking/pull/6480/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcGx1Z2luL21hdGNoL05hbWVNYXRjaC5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-3.00%)` | |
| ... and [1755 more](https://codecov.io/gh/apache/skywalking/pull/6480/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/6480?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/6480?src=pr&el=footer). Last update [9946ec4...5c9722d](https://codecov.io/gh/apache/skywalking/pull/6480?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6480: Remove unnecessary check for getSkyWalkingDynamicField invocation
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #6480:
URL: https://github.com/apache/skywalking/pull/6480#issuecomment-789727063
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/6480?src=pr&el=h1) Report
> Merging [#6480](https://codecov.io/gh/apache/skywalking/pull/6480?src=pr&el=desc) (9f84ae1) into [master](https://codecov.io/gh/apache/skywalking/commit/de6a731d72fb87dd574da1d9b42495fdd29b4311?el=desc) (de6a731) will **decrease** coverage by `19.11%`.
> The diff coverage is `19.04%`.
[![Impacted file tree graph](https://codecov.io/gh/apache/skywalking/pull/6480/graphs/tree.svg?width=650&height=150&src=pr&token=qrILxY5yA8)](https://codecov.io/gh/apache/skywalking/pull/6480?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #6480 +/- ##
=============================================
- Coverage 54.00% 34.89% -19.12%
+ Complexity 4075 2561 -1514
=============================================
Files 1777 1018 -759
Lines 37757 24759 -12998
Branches 4153 2429 -1724
=============================================
- Hits 20392 8639 -11753
+ Misses 16385 15454 -931
+ Partials 980 666 -314
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/6480?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...g/oap/log/analyzer/dsl/spec/filter/FilterSpec.java](https://codecov.io/gh/apache/skywalking/pull/6480/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9sb2ctYW5hbHl6ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL2xvZy9hbmFseXplci9kc2wvc3BlYy9maWx0ZXIvRmlsdGVyU3BlYy5qYXZh) | `44.61% <0.00%> (-6.27%)` | `7.00 <0.00> (ø)` | |
| [...p/log/analyzer/dsl/spec/parser/TextParserSpec.java](https://codecov.io/gh/apache/skywalking/pull/6480/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9sb2ctYW5hbHl6ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL2xvZy9hbmFseXplci9kc2wvc3BlYy9wYXJzZXIvVGV4dFBhcnNlclNwZWMuamF2YQ==) | `64.28% <0.00%> (-10.72%)` | `4.00 <0.00> (ø)` | |
| [...p/log/analyzer/dsl/spec/parser/YamlParserSpec.java](https://codecov.io/gh/apache/skywalking/pull/6480/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9sb2ctYW5hbHl6ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL2xvZy9hbmFseXplci9kc2wvc3BlYy9wYXJzZXIvWWFtbFBhcnNlclNwZWMuamF2YQ==) | `75.00% <ø> (ø)` | `1.00 <0.00> (ø)` | |
| [...p/log/analyzer/dsl/spec/parser/JsonParserSpec.java](https://codecov.io/gh/apache/skywalking/pull/6480/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9sb2ctYW5hbHl6ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL2xvZy9hbmFseXplci9kc2wvc3BlYy9wYXJzZXIvSnNvblBhcnNlclNwZWMuamF2YQ==) | `80.00% <50.00%> (+5.00%)` | `1.00 <0.00> (ø)` | |
| [...g/analyzer/dsl/spec/parser/AbstractParserSpec.java](https://codecov.io/gh/apache/skywalking/pull/6480/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9sb2ctYW5hbHl6ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL2xvZy9hbmFseXplci9kc2wvc3BlYy9wYXJzZXIvQWJzdHJhY3RQYXJzZXJTcGVjLmphdmE=) | `100.00% <100.00%> (ø)` | `1.00 <1.00> (?)` | |
| [...pache/skywalking/apm/agent/core/base64/Base64.java](https://codecov.io/gh/apache/skywalking/pull/6480/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvYmFzZTY0L0Jhc2U2NC5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-3.00%)` | |
| [...che/skywalking/apm/agent/core/meter/MeterType.java](https://codecov.io/gh/apache/skywalking/pull/6480/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvbWV0ZXIvTWV0ZXJUeXBlLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (ø%)` | |
| [...skywalking/oap/server/core/alarm/AlarmMessage.java](https://codecov.io/gh/apache/skywalking/pull/6480/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYWxhcm0vQWxhcm1NZXNzYWdlLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...e/skywalking/apm/agent/core/meter/CounterMode.java](https://codecov.io/gh/apache/skywalking/pull/6480/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvbWV0ZXIvQ291bnRlck1vZGUuamF2YQ==) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (ø%)` | |
| [...ywalking/apm/agent/core/logging/core/LogLevel.java](https://codecov.io/gh/apache/skywalking/pull/6480/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvbG9nZ2luZy9jb3JlL0xvZ0xldmVsLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| ... and [1371 more](https://codecov.io/gh/apache/skywalking/pull/6480/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/6480?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/6480?src=pr&el=footer). Last update [cb16e52...a8c1e14](https://codecov.io/gh/apache/skywalking/pull/6480?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6480: Remove unnecessary check for getSkyWalkingDynamicField invocation
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #6480:
URL: https://github.com/apache/skywalking/pull/6480#issuecomment-789727063
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/6480?src=pr&el=h1) Report
> Merging [#6480](https://codecov.io/gh/apache/skywalking/pull/6480?src=pr&el=desc) (a8c1e14) into [master](https://codecov.io/gh/apache/skywalking/commit/de6a731d72fb87dd574da1d9b42495fdd29b4311?el=desc) (de6a731) will **increase** coverage by `2.11%`.
> The diff coverage is `n/a`.
[![Impacted file tree graph](https://codecov.io/gh/apache/skywalking/pull/6480/graphs/tree.svg?width=650&height=150&src=pr&token=qrILxY5yA8)](https://codecov.io/gh/apache/skywalking/pull/6480?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #6480 +/- ##
============================================
+ Coverage 54.00% 56.12% +2.11%
+ Complexity 4075 823 -3252
============================================
Files 1777 181 -1596
Lines 37757 4378 -33379
Branches 4153 499 -3654
============================================
- Hits 20392 2457 -17935
+ Misses 16385 1608 -14777
+ Partials 980 313 -667
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/6480?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...ng/apm/agent/core/context/trace/LogDataEntity.java](https://codecov.io/gh/apache/skywalking/pull/6480/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29udGV4dC90cmFjZS9Mb2dEYXRhRW50aXR5LmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (ø%)` | |
| [...ent/core/context/status/ExceptionCheckContext.java](https://codecov.io/gh/apache/skywalking/pull/6480/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29udGV4dC9zdGF0dXMvRXhjZXB0aW9uQ2hlY2tDb250ZXh0LmphdmE=) | `0.00% <0.00%> (-90.91%)` | `0.00% <0.00%> (ø%)` | |
| [...t/status/HierarchyMatchExceptionCheckStrategy.java](https://codecov.io/gh/apache/skywalking/pull/6480/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29udGV4dC9zdGF0dXMvSGllcmFyY2h5TWF0Y2hFeGNlcHRpb25DaGVja1N0cmF0ZWd5LmphdmE=) | `9.09% <0.00%> (-90.91%)` | `1.00% <0.00%> (ø%)` | |
| [...alking/apm/agent/core/logging/core/FileWriter.java](https://codecov.io/gh/apache/skywalking/pull/6480/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvbG9nZ2luZy9jb3JlL0ZpbGVXcml0ZXIuamF2YQ==) | `0.00% <0.00%> (-88.10%)` | `0.00% <0.00%> (ø%)` | |
| [...king/apm/agent/core/context/util/KeyValuePair.java](https://codecov.io/gh/apache/skywalking/pull/6480/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29udGV4dC91dGlsL0tleVZhbHVlUGFpci5qYXZh) | `0.00% <0.00%> (-80.00%)` | `0.00% <0.00%> (ø%)` | |
| [...g/apm/agent/core/context/status/StatusChecker.java](https://codecov.io/gh/apache/skywalking/pull/6480/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29udGV4dC9zdGF0dXMvU3RhdHVzQ2hlY2tlci5qYXZh) | `23.80% <0.00%> (-76.20%)` | `1.00% <0.00%> (ø%)` | |
| [...ywalking/apm/agent/core/plugin/PluginSelector.java](https://codecov.io/gh/apache/skywalking/pull/6480/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcGx1Z2luL1BsdWdpblNlbGVjdG9yLmphdmE=) | `28.57% <0.00%> (-71.43%)` | `2.00% <0.00%> (ø%)` | |
| [.../agent/core/context/util/ThrowableTransformer.java](https://codecov.io/gh/apache/skywalking/pull/6480/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29udGV4dC91dGlsL1Rocm93YWJsZVRyYW5zZm9ybWVyLmphdmE=) | `0.00% <0.00%> (-69.24%)` | `0.00% <0.00%> (ø%)` | |
| [...re/logging/core/converters/AgentNameConverter.java](https://codecov.io/gh/apache/skywalking/pull/6480/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvbG9nZ2luZy9jb3JlL2NvbnZlcnRlcnMvQWdlbnROYW1lQ29udmVydGVyLmphdmE=) | `0.00% <0.00%> (-66.67%)` | `0.00% <0.00%> (ø%)` | |
| [...re/logging/core/converters/ThrowableConverter.java](https://codecov.io/gh/apache/skywalking/pull/6480/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvbG9nZ2luZy9jb3JlL2NvbnZlcnRlcnMvVGhyb3dhYmxlQ29udmVydGVyLmphdmE=) | `16.66% <0.00%> (-66.67%)` | `2.00% <0.00%> (ø%)` | |
| ... and [1690 more](https://codecov.io/gh/apache/skywalking/pull/6480/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/6480?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/6480?src=pr&el=footer). Last update [cb16e52...a8c1e14](https://codecov.io/gh/apache/skywalking/pull/6480?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6480: Remove unnecessary check for getSkyWalkingDynamicField invocation
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #6480:
URL: https://github.com/apache/skywalking/pull/6480#issuecomment-789727063
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/6480?src=pr&el=h1) Report
> Merging [#6480](https://codecov.io/gh/apache/skywalking/pull/6480?src=pr&el=desc) (9f84ae1) into [master](https://codecov.io/gh/apache/skywalking/commit/de6a731d72fb87dd574da1d9b42495fdd29b4311?el=desc) (de6a731) will **decrease** coverage by `30.72%`.
> The diff coverage is `19.04%`.
[![Impacted file tree graph](https://codecov.io/gh/apache/skywalking/pull/6480/graphs/tree.svg?width=650&height=150&src=pr&token=qrILxY5yA8)](https://codecov.io/gh/apache/skywalking/pull/6480?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #6480 +/- ##
=============================================
- Coverage 54.00% 23.28% -30.73%
+ Complexity 4075 1733 -2342
=============================================
Files 1777 987 -790
Lines 37757 23786 -13971
Branches 4153 2316 -1837
=============================================
- Hits 20392 5538 -14854
- Misses 16385 17851 +1466
+ Partials 980 397 -583
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/6480?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...g/oap/log/analyzer/dsl/spec/filter/FilterSpec.java](https://codecov.io/gh/apache/skywalking/pull/6480/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9sb2ctYW5hbHl6ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL2xvZy9hbmFseXplci9kc2wvc3BlYy9maWx0ZXIvRmlsdGVyU3BlYy5qYXZh) | `20.00% <0.00%> (-30.88%)` | `2.00 <0.00> (-5.00)` | |
| [...p/log/analyzer/dsl/spec/parser/TextParserSpec.java](https://codecov.io/gh/apache/skywalking/pull/6480/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9sb2ctYW5hbHl6ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL2xvZy9hbmFseXplci9kc2wvc3BlYy9wYXJzZXIvVGV4dFBhcnNlclNwZWMuamF2YQ==) | `14.28% <0.00%> (-60.72%)` | `1.00 <0.00> (-3.00)` | |
| [...p/log/analyzer/dsl/spec/parser/YamlParserSpec.java](https://codecov.io/gh/apache/skywalking/pull/6480/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9sb2ctYW5hbHl6ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL2xvZy9hbmFseXplci9kc2wvc3BlYy9wYXJzZXIvWWFtbFBhcnNlclNwZWMuamF2YQ==) | `75.00% <ø> (ø)` | `1.00 <0.00> (ø)` | |
| [...p/log/analyzer/dsl/spec/parser/JsonParserSpec.java](https://codecov.io/gh/apache/skywalking/pull/6480/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9sb2ctYW5hbHl6ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL2xvZy9hbmFseXplci9kc2wvc3BlYy9wYXJzZXIvSnNvblBhcnNlclNwZWMuamF2YQ==) | `80.00% <50.00%> (+5.00%)` | `1.00 <0.00> (ø)` | |
| [...g/analyzer/dsl/spec/parser/AbstractParserSpec.java](https://codecov.io/gh/apache/skywalking/pull/6480/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9sb2ctYW5hbHl6ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL2xvZy9hbmFseXplci9kc2wvc3BlYy9wYXJzZXIvQWJzdHJhY3RQYXJzZXJTcGVjLmphdmE=) | `100.00% <100.00%> (ø)` | `1.00 <1.00> (?)` | |
| [...he/skywalking/oap/server/core/source/GCPhrase.java](https://codecov.io/gh/apache/skywalking/pull/6480/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvc291cmNlL0dDUGhyYXNlLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...pache/skywalking/apm/agent/core/base64/Base64.java](https://codecov.io/gh/apache/skywalking/pull/6480/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvYmFzZTY0L0Jhc2U2NC5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-3.00%)` | |
| [...che/skywalking/apm/agent/core/meter/MeterType.java](https://codecov.io/gh/apache/skywalking/pull/6480/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvbWV0ZXIvTWV0ZXJUeXBlLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (ø%)` | |
| [...skywalking/oap/server/core/alarm/AlarmMessage.java](https://codecov.io/gh/apache/skywalking/pull/6480/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYWxhcm0vQWxhcm1NZXNzYWdlLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...skywalking/oap/server/core/source/RequestType.java](https://codecov.io/gh/apache/skywalking/pull/6480/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvc291cmNlL1JlcXVlc3RUeXBlLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| ... and [1473 more](https://codecov.io/gh/apache/skywalking/pull/6480/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/6480?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/6480?src=pr&el=footer). Last update [cb16e52...a8c1e14](https://codecov.io/gh/apache/skywalking/pull/6480?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6480: Remove unnecessary check for getSkyWalkingDynamicField invocation
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #6480:
URL: https://github.com/apache/skywalking/pull/6480#issuecomment-789727063
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/6480?src=pr&el=h1) Report
> Merging [#6480](https://codecov.io/gh/apache/skywalking/pull/6480?src=pr&el=desc) (9f84ae1) into [master](https://codecov.io/gh/apache/skywalking/commit/de6a731d72fb87dd574da1d9b42495fdd29b4311?el=desc) (de6a731) will **decrease** coverage by `18.58%`.
> The diff coverage is `19.04%`.
[![Impacted file tree graph](https://codecov.io/gh/apache/skywalking/pull/6480/graphs/tree.svg?width=650&height=150&src=pr&token=qrILxY5yA8)](https://codecov.io/gh/apache/skywalking/pull/6480?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #6480 +/- ##
=============================================
- Coverage 54.00% 35.42% -18.59%
+ Complexity 4075 2595 -1480
=============================================
Files 1777 1022 -755
Lines 37757 24904 -12853
Branches 4153 2441 -1712
=============================================
- Hits 20392 8823 -11569
+ Misses 16385 15410 -975
+ Partials 980 671 -309
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/6480?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...g/oap/log/analyzer/dsl/spec/filter/FilterSpec.java](https://codecov.io/gh/apache/skywalking/pull/6480/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9sb2ctYW5hbHl6ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL2xvZy9hbmFseXplci9kc2wvc3BlYy9maWx0ZXIvRmlsdGVyU3BlYy5qYXZh) | `44.61% <0.00%> (-6.27%)` | `7.00 <0.00> (ø)` | |
| [...p/log/analyzer/dsl/spec/parser/TextParserSpec.java](https://codecov.io/gh/apache/skywalking/pull/6480/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9sb2ctYW5hbHl6ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL2xvZy9hbmFseXplci9kc2wvc3BlYy9wYXJzZXIvVGV4dFBhcnNlclNwZWMuamF2YQ==) | `64.28% <0.00%> (-10.72%)` | `4.00 <0.00> (ø)` | |
| [...p/log/analyzer/dsl/spec/parser/YamlParserSpec.java](https://codecov.io/gh/apache/skywalking/pull/6480/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9sb2ctYW5hbHl6ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL2xvZy9hbmFseXplci9kc2wvc3BlYy9wYXJzZXIvWWFtbFBhcnNlclNwZWMuamF2YQ==) | `75.00% <ø> (ø)` | `1.00 <0.00> (ø)` | |
| [...p/log/analyzer/dsl/spec/parser/JsonParserSpec.java](https://codecov.io/gh/apache/skywalking/pull/6480/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9sb2ctYW5hbHl6ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL2xvZy9hbmFseXplci9kc2wvc3BlYy9wYXJzZXIvSnNvblBhcnNlclNwZWMuamF2YQ==) | `80.00% <50.00%> (+5.00%)` | `1.00 <0.00> (ø)` | |
| [...g/analyzer/dsl/spec/parser/AbstractParserSpec.java](https://codecov.io/gh/apache/skywalking/pull/6480/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9sb2ctYW5hbHl6ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL2xvZy9hbmFseXplci9kc2wvc3BlYy9wYXJzZXIvQWJzdHJhY3RQYXJzZXJTcGVjLmphdmE=) | `100.00% <100.00%> (ø)` | `1.00 <1.00> (?)` | |
| [...pache/skywalking/apm/agent/core/base64/Base64.java](https://codecov.io/gh/apache/skywalking/pull/6480/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvYmFzZTY0L0Jhc2U2NC5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-3.00%)` | |
| [...che/skywalking/apm/agent/core/meter/MeterType.java](https://codecov.io/gh/apache/skywalking/pull/6480/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvbWV0ZXIvTWV0ZXJUeXBlLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (ø%)` | |
| [...skywalking/oap/server/core/alarm/AlarmMessage.java](https://codecov.io/gh/apache/skywalking/pull/6480/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYWxhcm0vQWxhcm1NZXNzYWdlLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...e/skywalking/apm/agent/core/meter/CounterMode.java](https://codecov.io/gh/apache/skywalking/pull/6480/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvbWV0ZXIvQ291bnRlck1vZGUuamF2YQ==) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (ø%)` | |
| [...ywalking/apm/agent/core/logging/core/LogLevel.java](https://codecov.io/gh/apache/skywalking/pull/6480/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvbG9nZ2luZy9jb3JlL0xvZ0xldmVsLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| ... and [1370 more](https://codecov.io/gh/apache/skywalking/pull/6480/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/6480?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/6480?src=pr&el=footer). Last update [cb16e52...a8c1e14](https://codecov.io/gh/apache/skywalking/pull/6480?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6480: Remove unnecessary check for getSkyWalkingDynamicField invocation
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #6480:
URL: https://github.com/apache/skywalking/pull/6480#issuecomment-789727063
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/6480?src=pr&el=h1) Report
> Merging [#6480](https://codecov.io/gh/apache/skywalking/pull/6480?src=pr&el=desc) (a8c1e14) into [master](https://codecov.io/gh/apache/skywalking/commit/cb16e524da2bf45258e67052443a6b9bc2460855?el=desc) (cb16e52) will **decrease** coverage by `16.46%`.
> The diff coverage is `n/a`.
[![Impacted file tree graph](https://codecov.io/gh/apache/skywalking/pull/6480/graphs/tree.svg?width=650&height=150&src=pr&token=qrILxY5yA8)](https://codecov.io/gh/apache/skywalking/pull/6480?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #6480 +/- ##
=============================================
- Coverage 58.62% 42.15% -16.47%
+ Complexity 4087 3013 -1074
=============================================
Files 987 967 -20
Lines 24408 23497 -911
Branches 2374 2265 -109
=============================================
- Hits 14310 9906 -4404
- Misses 8865 12762 +3897
+ Partials 1233 829 -404
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/6480?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...skywalking/oap/server/core/alarm/AlarmMessage.java](https://codecov.io/gh/apache/skywalking/pull/6480/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYWxhcm0vQWxhcm1NZXNzYWdlLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...kywalking/oap/server/core/storage/AbstractDAO.java](https://codecov.io/gh/apache/skywalking/pull/6480/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvc3RvcmFnZS9BYnN0cmFjdERBTy5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-2.00%)` | |
| [...ng/oap/server/core/analysis/config/NoneStream.java](https://codecov.io/gh/apache/skywalking/pull/6480/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvY29uZmlnL05vbmVTdHJlYW0uamF2YQ==) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...lking/oap/server/analyzer/event/EventAnalyzer.java](https://codecov.io/gh/apache/skywalking/pull/6480/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9ldmVudC1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2FuYWx5emVyL2V2ZW50L0V2ZW50QW5hbHl6ZXIuamF2YQ==) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-6.00%)` | |
| [...rver/core/browser/source/BrowserErrorCategory.java](https://codecov.io/gh/apache/skywalking/pull/6480/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYnJvd3Nlci9zb3VyY2UvQnJvd3NlckVycm9yQ2F0ZWdvcnkuamF2YQ==) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-8.00%)` | |
| [...core/browser/source/BrowserAppTrafficCategory.java](https://codecov.io/gh/apache/skywalking/pull/6480/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYnJvd3Nlci9zb3VyY2UvQnJvd3NlckFwcFRyYWZmaWNDYXRlZ29yeS5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...ore/analysis/metrics/expression/NotEqualMatch.java](https://codecov.io/gh/apache/skywalking/pull/6480/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0cmljcy9leHByZXNzaW9uL05vdEVxdWFsTWF0Y2guamF2YQ==) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-3.00%)` | |
| [...log/analyzer/provider/log/ILogAnalyzerService.java](https://codecov.io/gh/apache/skywalking/pull/6480/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9sb2ctYW5hbHl6ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL2xvZy9hbmFseXplci9wcm92aWRlci9sb2cvSUxvZ0FuYWx5emVyU2VydmljZS5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...server/library/util/prometheus/metrics/Metric.java](https://codecov.io/gh/apache/skywalking/pull/6480/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItbGlicmFyeS9saWJyYXJ5LXV0aWwvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9saWJyYXJ5L3V0aWwvcHJvbWV0aGV1cy9tZXRyaWNzL01ldHJpYy5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...ement/ui/template/UITemplateManagementService.java](https://codecov.io/gh/apache/skywalking/pull/6480/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvbWFuYWdlbWVudC91aS90ZW1wbGF0ZS9VSVRlbXBsYXRlTWFuYWdlbWVudFNlcnZpY2UuamF2YQ==) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-6.00%)` | |
| ... and [285 more](https://codecov.io/gh/apache/skywalking/pull/6480/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/6480?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/6480?src=pr&el=footer). Last update [cb16e52...a8c1e14](https://codecov.io/gh/apache/skywalking/pull/6480?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6480: Remove unnecessary check for getSkyWalkingDynamicField invocation
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #6480:
URL: https://github.com/apache/skywalking/pull/6480#issuecomment-789727063
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/6480?src=pr&el=h1) Report
> Merging [#6480](https://codecov.io/gh/apache/skywalking/pull/6480?src=pr&el=desc) (b16aca4) into [master](https://codecov.io/gh/apache/skywalking/commit/cb16e524da2bf45258e67052443a6b9bc2460855?el=desc) (cb16e52) will **decrease** coverage by `19.75%`.
> The diff coverage is `n/a`.
[![Impacted file tree graph](https://codecov.io/gh/apache/skywalking/pull/6480/graphs/tree.svg?width=650&height=150&src=pr&token=qrILxY5yA8)](https://codecov.io/gh/apache/skywalking/pull/6480?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #6480 +/- ##
=============================================
- Coverage 54.08% 34.33% -19.76%
+ Complexity 4088 2458 -1630
=============================================
Files 1778 988 -790
Lines 37771 24038 -13733
Branches 4156 2353 -1803
=============================================
- Hits 20429 8253 -12176
+ Misses 16361 15150 -1211
+ Partials 981 635 -346
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/6480?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...pache/skywalking/apm/agent/core/base64/Base64.java](https://codecov.io/gh/apache/skywalking/pull/6480/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvYmFzZTY0L0Jhc2U2NC5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-3.00%)` | |
| [...che/skywalking/apm/agent/core/meter/MeterType.java](https://codecov.io/gh/apache/skywalking/pull/6480/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvbWV0ZXIvTWV0ZXJUeXBlLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (ø%)` | |
| [...skywalking/oap/server/core/alarm/AlarmMessage.java](https://codecov.io/gh/apache/skywalking/pull/6480/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYWxhcm0vQWxhcm1NZXNzYWdlLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...e/skywalking/apm/agent/core/meter/CounterMode.java](https://codecov.io/gh/apache/skywalking/pull/6480/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvbWV0ZXIvQ291bnRlck1vZGUuamF2YQ==) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (ø%)` | |
| [...ywalking/apm/agent/core/logging/core/LogLevel.java](https://codecov.io/gh/apache/skywalking/pull/6480/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvbG9nZ2luZy9jb3JlL0xvZ0xldmVsLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...ywalking/apm/agent/core/plugin/EnhanceContext.java](https://codecov.io/gh/apache/skywalking/pull/6480/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcGx1Z2luL0VuaGFuY2VDb250ZXh0LmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-5.00%)` | |
| [...ywalking/apm/agent/core/plugin/PluginSelector.java](https://codecov.io/gh/apache/skywalking/pull/6480/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcGx1Z2luL1BsdWdpblNlbGVjdG9yLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-2.00%)` | |
| [...ywalking/apm/agent/core/profile/ProfileStatus.java](https://codecov.io/gh/apache/skywalking/pull/6480/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcHJvZmlsZS9Qcm9maWxlU3RhdHVzLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...walking/apm/agent/core/context/SW8CarrierItem.java](https://codecov.io/gh/apache/skywalking/pull/6480/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29udGV4dC9TVzhDYXJyaWVySXRlbS5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-2.00%)` | |
| [...walking/apm/agent/core/jvm/cpu/SunCpuAccessor.java](https://codecov.io/gh/apache/skywalking/pull/6480/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvanZtL2NwdS9TdW5DcHVBY2Nlc3Nvci5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-2.00%)` | |
| ... and [1382 more](https://codecov.io/gh/apache/skywalking/pull/6480/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/6480?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/6480?src=pr&el=footer). Last update [9946ec4...5c9722d](https://codecov.io/gh/apache/skywalking/pull/6480?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6480: Remove unnecessary check for getSkyWalkingDynamicField invocation
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #6480:
URL: https://github.com/apache/skywalking/pull/6480#issuecomment-789727063
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/6480?src=pr&el=h1) Report
> Merging [#6480](https://codecov.io/gh/apache/skywalking/pull/6480?src=pr&el=desc) (b16aca4) into [master](https://codecov.io/gh/apache/skywalking/commit/cb16e524da2bf45258e67052443a6b9bc2460855?el=desc) (cb16e52) will **decrease** coverage by `54.08%`.
> The diff coverage is `n/a`.
[![Impacted file tree graph](https://codecov.io/gh/apache/skywalking/pull/6480/graphs/tree.svg?width=650&height=150&src=pr&token=qrILxY5yA8)](https://codecov.io/gh/apache/skywalking/pull/6480?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #6480 +/- ##
============================================
- Coverage 54.08% 0.00% -54.09%
============================================
Files 1778 174 -1604
Lines 37771 4320 -33451
Branches 4156 497 -3659
============================================
- Hits 20429 0 -20429
+ Misses 16361 4320 -12041
+ Partials 981 0 -981
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/6480?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...pache/skywalking/apm/agent/core/base64/Base64.java](https://codecov.io/gh/apache/skywalking/pull/6480/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvYmFzZTY0L0Jhc2U2NC5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-3.00%)` | |
| [...king/apm/util/RunnableWithExceptionProtection.java](https://codecov.io/gh/apache/skywalking/pull/6480/diff?src=pr&el=tree#diff-YXBtLWNvbW1vbnMvYXBtLXV0aWwvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL3V0aWwvUnVubmFibGVXaXRoRXhjZXB0aW9uUHJvdGVjdGlvbi5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-2.00%)` | |
| [...ywalking/apm/agent/core/logging/core/LogLevel.java](https://codecov.io/gh/apache/skywalking/pull/6480/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvbG9nZ2luZy9jb3JlL0xvZ0xldmVsLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...ywalking/apm/agent/core/plugin/EnhanceContext.java](https://codecov.io/gh/apache/skywalking/pull/6480/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcGx1Z2luL0VuaGFuY2VDb250ZXh0LmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-5.00%)` | |
| [...ywalking/apm/agent/core/plugin/PluginSelector.java](https://codecov.io/gh/apache/skywalking/pull/6480/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcGx1Z2luL1BsdWdpblNlbGVjdG9yLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-2.00%)` | |
| [...ywalking/apm/agent/core/profile/ProfileStatus.java](https://codecov.io/gh/apache/skywalking/pull/6480/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcHJvZmlsZS9Qcm9maWxlU3RhdHVzLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...walking/apm/agent/core/context/SW8CarrierItem.java](https://codecov.io/gh/apache/skywalking/pull/6480/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29udGV4dC9TVzhDYXJyaWVySXRlbS5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-2.00%)` | |
| [...walking/apm/agent/core/jvm/cpu/SunCpuAccessor.java](https://codecov.io/gh/apache/skywalking/pull/6480/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvanZtL2NwdS9TdW5DcHVBY2Nlc3Nvci5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-2.00%)` | |
| [...walking/apm/agent/core/logging/core/LogOutput.java](https://codecov.io/gh/apache/skywalking/pull/6480/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvbG9nZ2luZy9jb3JlL0xvZ091dHB1dC5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...walking/apm/agent/core/plugin/match/NameMatch.java](https://codecov.io/gh/apache/skywalking/pull/6480/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcGx1Z2luL21hdGNoL05hbWVNYXRjaC5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-3.00%)` | |
| ... and [1755 more](https://codecov.io/gh/apache/skywalking/pull/6480/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/6480?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/6480?src=pr&el=footer). Last update [9946ec4...5c9722d](https://codecov.io/gh/apache/skywalking/pull/6480?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6480: Remove unnecessary check for getSkyWalkingDynamicField invocation
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #6480:
URL: https://github.com/apache/skywalking/pull/6480#issuecomment-789727063
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/6480?src=pr&el=h1) Report
> Merging [#6480](https://codecov.io/gh/apache/skywalking/pull/6480?src=pr&el=desc) (b16aca4) into [master](https://codecov.io/gh/apache/skywalking/commit/cb16e524da2bf45258e67052443a6b9bc2460855?el=desc) (cb16e52) will **decrease** coverage by `10.70%`.
> The diff coverage is `n/a`.
[![Impacted file tree graph](https://codecov.io/gh/apache/skywalking/pull/6480/graphs/tree.svg?width=650&height=150&src=pr&token=qrILxY5yA8)](https://codecov.io/gh/apache/skywalking/pull/6480?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #6480 +/- ##
=============================================
- Coverage 54.08% 43.38% -10.71%
+ Complexity 4088 3300 -788
=============================================
Files 1778 1018 -760
Lines 37771 24857 -12914
Branches 4156 2433 -1723
=============================================
- Hits 20429 10784 -9645
+ Misses 16361 13147 -3214
+ Partials 981 926 -55
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/6480?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...che/skywalking/apm/agent/core/meter/MeterType.java](https://codecov.io/gh/apache/skywalking/pull/6480/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvbWV0ZXIvTWV0ZXJUeXBlLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (ø%)` | |
| [...skywalking/oap/server/core/alarm/AlarmMessage.java](https://codecov.io/gh/apache/skywalking/pull/6480/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYWxhcm0vQWxhcm1NZXNzYWdlLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...e/skywalking/apm/agent/core/meter/CounterMode.java](https://codecov.io/gh/apache/skywalking/pull/6480/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvbWV0ZXIvQ291bnRlck1vZGUuamF2YQ==) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (ø%)` | |
| [...org/apache/skywalking/apm/toolkit/meter/Gauge.java](https://codecov.io/gh/apache/skywalking/pull/6480/diff?src=pr&el=tree#diff-YXBtLWFwcGxpY2F0aW9uLXRvb2xraXQvYXBtLXRvb2xraXQtbWV0ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL3Rvb2xraXQvbWV0ZXIvR2F1Z2UuamF2YQ==) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (ø%)` | |
| [...ng/oap/server/core/analysis/config/NoneStream.java](https://codecov.io/gh/apache/skywalking/pull/6480/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvY29uZmlnL05vbmVTdHJlYW0uamF2YQ==) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...g/oap/server/core/cluster/ClusterHealthStatus.java](https://codecov.io/gh/apache/skywalking/pull/6480/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvY2x1c3Rlci9DbHVzdGVySGVhbHRoU3RhdHVzLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (ø%)` | |
| [...ng/apm/agent/core/context/trace/LogDataEntity.java](https://codecov.io/gh/apache/skywalking/pull/6480/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29udGV4dC90cmFjZS9Mb2dEYXRhRW50aXR5LmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (ø%)` | |
| [...p/server/core/analysis/metrics/MinLongMetrics.java](https://codecov.io/gh/apache/skywalking/pull/6480/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0cmljcy9NaW5Mb25nTWV0cmljcy5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (ø%)` | |
| [...er/exporter/provider/grpc/GRPCExporterSetting.java](https://codecov.io/gh/apache/skywalking/pull/6480/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9leHBvcnRlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2V4cG9ydGVyL3Byb3ZpZGVyL2dycGMvR1JQQ0V4cG9ydGVyU2V0dGluZy5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (ø%)` | |
| [...lking/oap/server/analyzer/event/EventAnalyzer.java](https://codecov.io/gh/apache/skywalking/pull/6480/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9ldmVudC1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2FuYWx5emVyL2V2ZW50L0V2ZW50QW5hbHl6ZXIuamF2YQ==) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-6.00%)` | |
| ... and [1299 more](https://codecov.io/gh/apache/skywalking/pull/6480/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/6480?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/6480?src=pr&el=footer). Last update [9946ec4...5c9722d](https://codecov.io/gh/apache/skywalking/pull/6480?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6480: Remove unnecessary check for getSkyWalkingDynamicField invocation
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #6480:
URL: https://github.com/apache/skywalking/pull/6480#issuecomment-789727063
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/6480?src=pr&el=h1) Report
> Merging [#6480](https://codecov.io/gh/apache/skywalking/pull/6480?src=pr&el=desc) (9f84ae1) into [master](https://codecov.io/gh/apache/skywalking/commit/de6a731d72fb87dd574da1d9b42495fdd29b4311?el=desc) (de6a731) will **decrease** coverage by `18.41%`.
> The diff coverage is `19.04%`.
[![Impacted file tree graph](https://codecov.io/gh/apache/skywalking/pull/6480/graphs/tree.svg?width=650&height=150&src=pr&token=qrILxY5yA8)](https://codecov.io/gh/apache/skywalking/pull/6480?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #6480 +/- ##
=============================================
- Coverage 54.00% 35.59% -18.42%
+ Complexity 4075 2593 -1482
=============================================
Files 1777 1018 -759
Lines 37757 24766 -12991
Branches 4153 2429 -1724
=============================================
- Hits 20392 8816 -11576
+ Misses 16385 15276 -1109
+ Partials 980 674 -306
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/6480?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...g/oap/log/analyzer/dsl/spec/filter/FilterSpec.java](https://codecov.io/gh/apache/skywalking/pull/6480/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9sb2ctYW5hbHl6ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL2xvZy9hbmFseXplci9kc2wvc3BlYy9maWx0ZXIvRmlsdGVyU3BlYy5qYXZh) | `44.61% <0.00%> (-6.27%)` | `7.00 <0.00> (ø)` | |
| [...p/log/analyzer/dsl/spec/parser/TextParserSpec.java](https://codecov.io/gh/apache/skywalking/pull/6480/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9sb2ctYW5hbHl6ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL2xvZy9hbmFseXplci9kc2wvc3BlYy9wYXJzZXIvVGV4dFBhcnNlclNwZWMuamF2YQ==) | `64.28% <0.00%> (-10.72%)` | `4.00 <0.00> (ø)` | |
| [...p/log/analyzer/dsl/spec/parser/YamlParserSpec.java](https://codecov.io/gh/apache/skywalking/pull/6480/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9sb2ctYW5hbHl6ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL2xvZy9hbmFseXplci9kc2wvc3BlYy9wYXJzZXIvWWFtbFBhcnNlclNwZWMuamF2YQ==) | `75.00% <ø> (ø)` | `1.00 <0.00> (ø)` | |
| [...p/log/analyzer/dsl/spec/parser/JsonParserSpec.java](https://codecov.io/gh/apache/skywalking/pull/6480/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9sb2ctYW5hbHl6ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL2xvZy9hbmFseXplci9kc2wvc3BlYy9wYXJzZXIvSnNvblBhcnNlclNwZWMuamF2YQ==) | `80.00% <50.00%> (+5.00%)` | `1.00 <0.00> (ø)` | |
| [...g/analyzer/dsl/spec/parser/AbstractParserSpec.java](https://codecov.io/gh/apache/skywalking/pull/6480/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9sb2ctYW5hbHl6ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL2xvZy9hbmFseXplci9kc2wvc3BlYy9wYXJzZXIvQWJzdHJhY3RQYXJzZXJTcGVjLmphdmE=) | `100.00% <100.00%> (ø)` | `1.00 <1.00> (?)` | |
| [...pache/skywalking/apm/agent/core/base64/Base64.java](https://codecov.io/gh/apache/skywalking/pull/6480/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvYmFzZTY0L0Jhc2U2NC5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-3.00%)` | |
| [...che/skywalking/apm/agent/core/meter/MeterType.java](https://codecov.io/gh/apache/skywalking/pull/6480/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvbWV0ZXIvTWV0ZXJUeXBlLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (ø%)` | |
| [...skywalking/oap/server/core/alarm/AlarmMessage.java](https://codecov.io/gh/apache/skywalking/pull/6480/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYWxhcm0vQWxhcm1NZXNzYWdlLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...e/skywalking/apm/agent/core/meter/CounterMode.java](https://codecov.io/gh/apache/skywalking/pull/6480/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvbWV0ZXIvQ291bnRlck1vZGUuamF2YQ==) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (ø%)` | |
| [...ywalking/apm/agent/core/logging/core/LogLevel.java](https://codecov.io/gh/apache/skywalking/pull/6480/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvbG9nZ2luZy9jb3JlL0xvZ0xldmVsLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| ... and [1370 more](https://codecov.io/gh/apache/skywalking/pull/6480/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/6480?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/6480?src=pr&el=footer). Last update [cb16e52...a8c1e14](https://codecov.io/gh/apache/skywalking/pull/6480?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6480: Remove unnecessary check for getSkyWalkingDynamicField invocation
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #6480:
URL: https://github.com/apache/skywalking/pull/6480#issuecomment-789727063
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/6480?src=pr&el=h1) Report
> Merging [#6480](https://codecov.io/gh/apache/skywalking/pull/6480?src=pr&el=desc) (b16aca4) into [master](https://codecov.io/gh/apache/skywalking/commit/cb16e524da2bf45258e67052443a6b9bc2460855?el=desc) (cb16e52) will **decrease** coverage by `10.77%`.
> The diff coverage is `n/a`.
[![Impacted file tree graph](https://codecov.io/gh/apache/skywalking/pull/6480/graphs/tree.svg?width=650&height=150&src=pr&token=qrILxY5yA8)](https://codecov.io/gh/apache/skywalking/pull/6480?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #6480 +/- ##
=============================================
- Coverage 54.08% 43.30% -10.78%
+ Complexity 4088 3290 -798
=============================================
Files 1778 1018 -760
Lines 37771 24857 -12914
Branches 4156 2433 -1723
=============================================
- Hits 20429 10765 -9664
+ Misses 16361 13159 -3202
+ Partials 981 933 -48
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/6480?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...che/skywalking/apm/agent/core/meter/MeterType.java](https://codecov.io/gh/apache/skywalking/pull/6480/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvbWV0ZXIvTWV0ZXJUeXBlLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (ø%)` | |
| [...skywalking/oap/server/core/alarm/AlarmMessage.java](https://codecov.io/gh/apache/skywalking/pull/6480/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYWxhcm0vQWxhcm1NZXNzYWdlLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...e/skywalking/apm/agent/core/meter/CounterMode.java](https://codecov.io/gh/apache/skywalking/pull/6480/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvbWV0ZXIvQ291bnRlck1vZGUuamF2YQ==) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (ø%)` | |
| [...org/apache/skywalking/apm/toolkit/meter/Gauge.java](https://codecov.io/gh/apache/skywalking/pull/6480/diff?src=pr&el=tree#diff-YXBtLWFwcGxpY2F0aW9uLXRvb2xraXQvYXBtLXRvb2xraXQtbWV0ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL3Rvb2xraXQvbWV0ZXIvR2F1Z2UuamF2YQ==) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (ø%)` | |
| [...ng/oap/server/core/analysis/config/NoneStream.java](https://codecov.io/gh/apache/skywalking/pull/6480/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvY29uZmlnL05vbmVTdHJlYW0uamF2YQ==) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...g/oap/server/core/cluster/ClusterHealthStatus.java](https://codecov.io/gh/apache/skywalking/pull/6480/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvY2x1c3Rlci9DbHVzdGVySGVhbHRoU3RhdHVzLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (ø%)` | |
| [...ng/apm/agent/core/context/trace/LogDataEntity.java](https://codecov.io/gh/apache/skywalking/pull/6480/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29udGV4dC90cmFjZS9Mb2dEYXRhRW50aXR5LmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (ø%)` | |
| [...p/server/core/analysis/metrics/MinLongMetrics.java](https://codecov.io/gh/apache/skywalking/pull/6480/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0cmljcy9NaW5Mb25nTWV0cmljcy5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (ø%)` | |
| [...er/exporter/provider/grpc/GRPCExporterSetting.java](https://codecov.io/gh/apache/skywalking/pull/6480/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9leHBvcnRlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2V4cG9ydGVyL3Byb3ZpZGVyL2dycGMvR1JQQ0V4cG9ydGVyU2V0dGluZy5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (ø%)` | |
| [...lking/oap/server/analyzer/event/EventAnalyzer.java](https://codecov.io/gh/apache/skywalking/pull/6480/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9ldmVudC1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2FuYWx5emVyL2V2ZW50L0V2ZW50QW5hbHl6ZXIuamF2YQ==) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-6.00%)` | |
| ... and [1304 more](https://codecov.io/gh/apache/skywalking/pull/6480/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/6480?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/6480?src=pr&el=footer). Last update [9946ec4...5c9722d](https://codecov.io/gh/apache/skywalking/pull/6480?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6480: Remove unnecessary check for getSkyWalkingDynamicField invocation
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #6480:
URL: https://github.com/apache/skywalking/pull/6480#issuecomment-789727063
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/6480?src=pr&el=h1) Report
> Merging [#6480](https://codecov.io/gh/apache/skywalking/pull/6480?src=pr&el=desc) (b16aca4) into [master](https://codecov.io/gh/apache/skywalking/commit/cb16e524da2bf45258e67052443a6b9bc2460855?el=desc) (cb16e52) will **decrease** coverage by `8.31%`.
> The diff coverage is `n/a`.
[![Impacted file tree graph](https://codecov.io/gh/apache/skywalking/pull/6480/graphs/tree.svg?width=650&height=150&src=pr&token=qrILxY5yA8)](https://codecov.io/gh/apache/skywalking/pull/6480?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #6480 +/- ##
============================================
- Coverage 54.08% 45.77% -8.32%
+ Complexity 4088 3470 -618
============================================
Files 1778 1018 -760
Lines 37771 24871 -12900
Branches 4156 2437 -1719
============================================
- Hits 20429 11384 -9045
+ Misses 16361 12515 -3846
+ Partials 981 972 -9
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/6480?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...che/skywalking/apm/agent/core/meter/MeterType.java](https://codecov.io/gh/apache/skywalking/pull/6480/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvbWV0ZXIvTWV0ZXJUeXBlLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (ø%)` | |
| [...skywalking/oap/server/core/alarm/AlarmMessage.java](https://codecov.io/gh/apache/skywalking/pull/6480/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYWxhcm0vQWxhcm1NZXNzYWdlLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...e/skywalking/apm/agent/core/meter/CounterMode.java](https://codecov.io/gh/apache/skywalking/pull/6480/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvbWV0ZXIvQ291bnRlck1vZGUuamF2YQ==) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (ø%)` | |
| [...org/apache/skywalking/apm/toolkit/meter/Gauge.java](https://codecov.io/gh/apache/skywalking/pull/6480/diff?src=pr&el=tree#diff-YXBtLWFwcGxpY2F0aW9uLXRvb2xraXQvYXBtLXRvb2xraXQtbWV0ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL3Rvb2xraXQvbWV0ZXIvR2F1Z2UuamF2YQ==) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (ø%)` | |
| [...ng/oap/server/core/analysis/config/NoneStream.java](https://codecov.io/gh/apache/skywalking/pull/6480/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvY29uZmlnL05vbmVTdHJlYW0uamF2YQ==) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...g/oap/server/core/cluster/ClusterHealthStatus.java](https://codecov.io/gh/apache/skywalking/pull/6480/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvY2x1c3Rlci9DbHVzdGVySGVhbHRoU3RhdHVzLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (ø%)` | |
| [...ng/apm/agent/core/context/trace/LogDataEntity.java](https://codecov.io/gh/apache/skywalking/pull/6480/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29udGV4dC90cmFjZS9Mb2dEYXRhRW50aXR5LmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (ø%)` | |
| [...p/server/core/analysis/metrics/MinLongMetrics.java](https://codecov.io/gh/apache/skywalking/pull/6480/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0cmljcy9NaW5Mb25nTWV0cmljcy5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (ø%)` | |
| [...er/exporter/provider/grpc/GRPCExporterSetting.java](https://codecov.io/gh/apache/skywalking/pull/6480/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9leHBvcnRlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2V4cG9ydGVyL3Byb3ZpZGVyL2dycGMvR1JQQ0V4cG9ydGVyU2V0dGluZy5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (ø%)` | |
| [...log/analyzer/provider/log/ILogAnalyzerService.java](https://codecov.io/gh/apache/skywalking/pull/6480/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9sb2ctYW5hbHl6ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL2xvZy9hbmFseXplci9wcm92aWRlci9sb2cvSUxvZ0FuYWx5emVyU2VydmljZS5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| ... and [1285 more](https://codecov.io/gh/apache/skywalking/pull/6480/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/6480?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/6480?src=pr&el=footer). Last update [9946ec4...5c9722d](https://codecov.io/gh/apache/skywalking/pull/6480?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6480: Remove unnecessary check for getSkyWalkingDynamicField invocation
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #6480:
URL: https://github.com/apache/skywalking/pull/6480#issuecomment-789727063
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/6480?src=pr&el=h1) Report
> Merging [#6480](https://codecov.io/gh/apache/skywalking/pull/6480?src=pr&el=desc) (a8c1e14) into [master](https://codecov.io/gh/apache/skywalking/commit/de6a731d72fb87dd574da1d9b42495fdd29b4311?el=desc) (de6a731) will **increase** coverage by `3.00%`.
> The diff coverage is `n/a`.
[![Impacted file tree graph](https://codecov.io/gh/apache/skywalking/pull/6480/graphs/tree.svg?width=650&height=150&src=pr&token=qrILxY5yA8)](https://codecov.io/gh/apache/skywalking/pull/6480?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #6480 +/- ##
============================================
+ Coverage 54.00% 57.01% +3.00%
+ Complexity 4075 822 -3253
============================================
Files 1777 176 -1601
Lines 37757 4301 -33456
Branches 4153 491 -3662
============================================
- Hits 20392 2452 -17940
+ Misses 16385 1537 -14848
+ Partials 980 312 -668
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/6480?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...t/status/HierarchyMatchExceptionCheckStrategy.java](https://codecov.io/gh/apache/skywalking/pull/6480/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29udGV4dC9zdGF0dXMvSGllcmFyY2h5TWF0Y2hFeGNlcHRpb25DaGVja1N0cmF0ZWd5LmphdmE=) | `9.09% <0.00%> (-90.91%)` | `1.00% <0.00%> (ø%)` | |
| [...alking/apm/agent/core/logging/core/FileWriter.java](https://codecov.io/gh/apache/skywalking/pull/6480/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvbG9nZ2luZy9jb3JlL0ZpbGVXcml0ZXIuamF2YQ==) | `0.00% <0.00%> (-88.10%)` | `0.00% <0.00%> (ø%)` | |
| [...g/apm/agent/core/context/status/StatusChecker.java](https://codecov.io/gh/apache/skywalking/pull/6480/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29udGV4dC9zdGF0dXMvU3RhdHVzQ2hlY2tlci5qYXZh) | `23.80% <0.00%> (-76.20%)` | `1.00% <0.00%> (ø%)` | |
| [...ywalking/apm/agent/core/plugin/PluginSelector.java](https://codecov.io/gh/apache/skywalking/pull/6480/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcGx1Z2luL1BsdWdpblNlbGVjdG9yLmphdmE=) | `28.57% <0.00%> (-71.43%)` | `2.00% <0.00%> (ø%)` | |
| [...re/logging/core/converters/AgentNameConverter.java](https://codecov.io/gh/apache/skywalking/pull/6480/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvbG9nZ2luZy9jb3JlL2NvbnZlcnRlcnMvQWdlbnROYW1lQ29udmVydGVyLmphdmE=) | `0.00% <0.00%> (-66.67%)` | `0.00% <0.00%> (ø%)` | |
| [...re/logging/core/converters/ThrowableConverter.java](https://codecov.io/gh/apache/skywalking/pull/6480/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvbG9nZ2luZy9jb3JlL2NvbnZlcnRlcnMvVGhyb3dhYmxlQ29udmVydGVyLmphdmE=) | `16.66% <0.00%> (-66.67%)` | `2.00% <0.00%> (ø%)` | |
| [...he/skywalking/apm/commons/datacarrier/EnvUtil.java](https://codecov.io/gh/apache/skywalking/pull/6480/diff?src=pr&el=tree#diff-YXBtLWNvbW1vbnMvYXBtLWRhdGFjYXJyaWVyL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL2FwbS9jb21tb25zL2RhdGFjYXJyaWVyL0VudlV0aWwuamF2YQ==) | `20.00% <0.00%> (-60.00%)` | `1.00% <0.00%> (ø%)` | |
| [...lking/apm/agent/core/context/ExtensionContext.java](https://codecov.io/gh/apache/skywalking/pull/6480/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29udGV4dC9FeHRlbnNpb25Db250ZXh0LmphdmE=) | `23.25% <0.00%> (-51.17%)` | `7.00% <0.00%> (ø%)` | |
| [...core/context/status/OffExceptionCheckStrategy.java](https://codecov.io/gh/apache/skywalking/pull/6480/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29udGV4dC9zdGF0dXMvT2ZmRXhjZXB0aW9uQ2hlY2tTdHJhdGVneS5qYXZh) | `50.00% <0.00%> (-50.00%)` | `1.00% <0.00%> (ø%)` | |
| [...kywalking/apm/commons/datacarrier/DataCarrier.java](https://codecov.io/gh/apache/skywalking/pull/6480/diff?src=pr&el=tree#diff-YXBtLWNvbW1vbnMvYXBtLWRhdGFjYXJyaWVyL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL2FwbS9jb21tb25zL2RhdGFjYXJyaWVyL0RhdGFDYXJyaWVyLmphdmE=) | `38.46% <0.00%> (-46.16%)` | `6.00% <0.00%> (-4.00%)` | |
| ... and [1691 more](https://codecov.io/gh/apache/skywalking/pull/6480/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/6480?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/6480?src=pr&el=footer). Last update [cb16e52...a8c1e14](https://codecov.io/gh/apache/skywalking/pull/6480?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6480: Remove unnecessary check for getSkyWalkingDynamicField invocation
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #6480:
URL: https://github.com/apache/skywalking/pull/6480#issuecomment-789727063
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/6480?src=pr&el=h1) Report
> Merging [#6480](https://codecov.io/gh/apache/skywalking/pull/6480?src=pr&el=desc) (9f84ae1) into [master](https://codecov.io/gh/apache/skywalking/commit/de6a731d72fb87dd574da1d9b42495fdd29b4311?el=desc) (de6a731) will **decrease** coverage by `16.56%`.
> The diff coverage is `19.04%`.
[![Impacted file tree graph](https://codecov.io/gh/apache/skywalking/pull/6480/graphs/tree.svg?width=650&height=150&src=pr&token=qrILxY5yA8)](https://codecov.io/gh/apache/skywalking/pull/6480?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #6480 +/- ##
=============================================
- Coverage 54.00% 37.44% -16.57%
+ Complexity 4075 2699 -1376
=============================================
Files 1777 1024 -753
Lines 37757 24915 -12842
Branches 4153 2441 -1712
=============================================
- Hits 20392 9330 -11062
+ Misses 16385 14858 -1527
+ Partials 980 727 -253
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/6480?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...g/oap/log/analyzer/dsl/spec/filter/FilterSpec.java](https://codecov.io/gh/apache/skywalking/pull/6480/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9sb2ctYW5hbHl6ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL2xvZy9hbmFseXplci9kc2wvc3BlYy9maWx0ZXIvRmlsdGVyU3BlYy5qYXZh) | `44.61% <0.00%> (-6.27%)` | `7.00 <0.00> (ø)` | |
| [...p/log/analyzer/dsl/spec/parser/TextParserSpec.java](https://codecov.io/gh/apache/skywalking/pull/6480/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9sb2ctYW5hbHl6ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL2xvZy9hbmFseXplci9kc2wvc3BlYy9wYXJzZXIvVGV4dFBhcnNlclNwZWMuamF2YQ==) | `64.28% <0.00%> (-10.72%)` | `4.00 <0.00> (ø)` | |
| [...p/log/analyzer/dsl/spec/parser/YamlParserSpec.java](https://codecov.io/gh/apache/skywalking/pull/6480/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9sb2ctYW5hbHl6ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL2xvZy9hbmFseXplci9kc2wvc3BlYy9wYXJzZXIvWWFtbFBhcnNlclNwZWMuamF2YQ==) | `75.00% <ø> (ø)` | `1.00 <0.00> (ø)` | |
| [...p/log/analyzer/dsl/spec/parser/JsonParserSpec.java](https://codecov.io/gh/apache/skywalking/pull/6480/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9sb2ctYW5hbHl6ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL2xvZy9hbmFseXplci9kc2wvc3BlYy9wYXJzZXIvSnNvblBhcnNlclNwZWMuamF2YQ==) | `80.00% <50.00%> (+5.00%)` | `1.00 <0.00> (ø)` | |
| [...g/analyzer/dsl/spec/parser/AbstractParserSpec.java](https://codecov.io/gh/apache/skywalking/pull/6480/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9sb2ctYW5hbHl6ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL2xvZy9hbmFseXplci9kc2wvc3BlYy9wYXJzZXIvQWJzdHJhY3RQYXJzZXJTcGVjLmphdmE=) | `100.00% <100.00%> (ø)` | `1.00 <1.00> (?)` | |
| [...pache/skywalking/apm/agent/core/base64/Base64.java](https://codecov.io/gh/apache/skywalking/pull/6480/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvYmFzZTY0L0Jhc2U2NC5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-3.00%)` | |
| [...che/skywalking/apm/agent/core/meter/MeterType.java](https://codecov.io/gh/apache/skywalking/pull/6480/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvbWV0ZXIvTWV0ZXJUeXBlLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (ø%)` | |
| [...skywalking/oap/server/core/alarm/AlarmMessage.java](https://codecov.io/gh/apache/skywalking/pull/6480/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYWxhcm0vQWxhcm1NZXNzYWdlLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...e/skywalking/apm/agent/core/meter/CounterMode.java](https://codecov.io/gh/apache/skywalking/pull/6480/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvbWV0ZXIvQ291bnRlck1vZGUuamF2YQ==) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (ø%)` | |
| [...ywalking/apm/agent/core/logging/core/LogLevel.java](https://codecov.io/gh/apache/skywalking/pull/6480/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvbG9nZ2luZy9jb3JlL0xvZ0xldmVsLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| ... and [1359 more](https://codecov.io/gh/apache/skywalking/pull/6480/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/6480?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/6480?src=pr&el=footer). Last update [cb16e52...a8c1e14](https://codecov.io/gh/apache/skywalking/pull/6480?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6480: Remove unnecessary check for getSkyWalkingDynamicField invocation
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #6480:
URL: https://github.com/apache/skywalking/pull/6480#issuecomment-789727063
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/6480?src=pr&el=h1) Report
> Merging [#6480](https://codecov.io/gh/apache/skywalking/pull/6480?src=pr&el=desc) (9f84ae1) into [master](https://codecov.io/gh/apache/skywalking/commit/de6a731d72fb87dd574da1d9b42495fdd29b4311?el=desc) (de6a731) will **decrease** coverage by `21.57%`.
> The diff coverage is `19.04%`.
[![Impacted file tree graph](https://codecov.io/gh/apache/skywalking/pull/6480/graphs/tree.svg?width=650&height=150&src=pr&token=qrILxY5yA8)](https://codecov.io/gh/apache/skywalking/pull/6480?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #6480 +/- ##
=============================================
- Coverage 54.00% 32.43% -21.58%
+ Complexity 4075 2390 -1685
=============================================
Files 1777 1018 -759
Lines 37757 24759 -12998
Branches 4153 2429 -1724
=============================================
- Hits 20392 8030 -12362
+ Misses 16385 16114 -271
+ Partials 980 615 -365
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/6480?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...g/oap/log/analyzer/dsl/spec/filter/FilterSpec.java](https://codecov.io/gh/apache/skywalking/pull/6480/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9sb2ctYW5hbHl6ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL2xvZy9hbmFseXplci9kc2wvc3BlYy9maWx0ZXIvRmlsdGVyU3BlYy5qYXZh) | `44.61% <0.00%> (-6.27%)` | `7.00 <0.00> (ø)` | |
| [...p/log/analyzer/dsl/spec/parser/TextParserSpec.java](https://codecov.io/gh/apache/skywalking/pull/6480/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9sb2ctYW5hbHl6ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL2xvZy9hbmFseXplci9kc2wvc3BlYy9wYXJzZXIvVGV4dFBhcnNlclNwZWMuamF2YQ==) | `64.28% <0.00%> (-10.72%)` | `4.00 <0.00> (ø)` | |
| [...p/log/analyzer/dsl/spec/parser/YamlParserSpec.java](https://codecov.io/gh/apache/skywalking/pull/6480/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9sb2ctYW5hbHl6ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL2xvZy9hbmFseXplci9kc2wvc3BlYy9wYXJzZXIvWWFtbFBhcnNlclNwZWMuamF2YQ==) | `75.00% <ø> (ø)` | `1.00 <0.00> (ø)` | |
| [...p/log/analyzer/dsl/spec/parser/JsonParserSpec.java](https://codecov.io/gh/apache/skywalking/pull/6480/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9sb2ctYW5hbHl6ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL2xvZy9hbmFseXplci9kc2wvc3BlYy9wYXJzZXIvSnNvblBhcnNlclNwZWMuamF2YQ==) | `80.00% <50.00%> (+5.00%)` | `1.00 <0.00> (ø)` | |
| [...g/analyzer/dsl/spec/parser/AbstractParserSpec.java](https://codecov.io/gh/apache/skywalking/pull/6480/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9sb2ctYW5hbHl6ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL2xvZy9hbmFseXplci9kc2wvc3BlYy9wYXJzZXIvQWJzdHJhY3RQYXJzZXJTcGVjLmphdmE=) | `100.00% <100.00%> (ø)` | `1.00 <1.00> (?)` | |
| [...pache/skywalking/apm/agent/core/base64/Base64.java](https://codecov.io/gh/apache/skywalking/pull/6480/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvYmFzZTY0L0Jhc2U2NC5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-3.00%)` | |
| [...che/skywalking/apm/agent/core/meter/MeterType.java](https://codecov.io/gh/apache/skywalking/pull/6480/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvbWV0ZXIvTWV0ZXJUeXBlLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (ø%)` | |
| [...skywalking/oap/server/core/alarm/AlarmMessage.java](https://codecov.io/gh/apache/skywalking/pull/6480/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYWxhcm0vQWxhcm1NZXNzYWdlLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...e/skywalking/apm/agent/core/meter/CounterMode.java](https://codecov.io/gh/apache/skywalking/pull/6480/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvbWV0ZXIvQ291bnRlck1vZGUuamF2YQ==) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (ø%)` | |
| [...ywalking/apm/agent/core/logging/core/LogLevel.java](https://codecov.io/gh/apache/skywalking/pull/6480/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvbG9nZ2luZy9jb3JlL0xvZ0xldmVsLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| ... and [1381 more](https://codecov.io/gh/apache/skywalking/pull/6480/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/6480?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/6480?src=pr&el=footer). Last update [cb16e52...a8c1e14](https://codecov.io/gh/apache/skywalking/pull/6480?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6480: Remove unnecessary check for getSkyWalkingDynamicField invocation
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #6480:
URL: https://github.com/apache/skywalking/pull/6480#issuecomment-789727063
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/6480?src=pr&el=h1) Report
> Merging [#6480](https://codecov.io/gh/apache/skywalking/pull/6480?src=pr&el=desc) (9f84ae1) into [master](https://codecov.io/gh/apache/skywalking/commit/de6a731d72fb87dd574da1d9b42495fdd29b4311?el=desc) (de6a731) will **decrease** coverage by `30.72%`.
> The diff coverage is `19.04%`.
[![Impacted file tree graph](https://codecov.io/gh/apache/skywalking/pull/6480/graphs/tree.svg?width=650&height=150&src=pr&token=qrILxY5yA8)](https://codecov.io/gh/apache/skywalking/pull/6480?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #6480 +/- ##
=============================================
- Coverage 54.00% 23.28% -30.73%
+ Complexity 4075 1733 -2342
=============================================
Files 1777 987 -790
Lines 37757 23786 -13971
Branches 4153 2316 -1837
=============================================
- Hits 20392 5538 -14854
- Misses 16385 17851 +1466
+ Partials 980 397 -583
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/6480?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...g/oap/log/analyzer/dsl/spec/filter/FilterSpec.java](https://codecov.io/gh/apache/skywalking/pull/6480/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9sb2ctYW5hbHl6ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL2xvZy9hbmFseXplci9kc2wvc3BlYy9maWx0ZXIvRmlsdGVyU3BlYy5qYXZh) | `20.00% <0.00%> (-30.88%)` | `2.00 <0.00> (-5.00)` | |
| [...p/log/analyzer/dsl/spec/parser/TextParserSpec.java](https://codecov.io/gh/apache/skywalking/pull/6480/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9sb2ctYW5hbHl6ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL2xvZy9hbmFseXplci9kc2wvc3BlYy9wYXJzZXIvVGV4dFBhcnNlclNwZWMuamF2YQ==) | `14.28% <0.00%> (-60.72%)` | `1.00 <0.00> (-3.00)` | |
| [...p/log/analyzer/dsl/spec/parser/YamlParserSpec.java](https://codecov.io/gh/apache/skywalking/pull/6480/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9sb2ctYW5hbHl6ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL2xvZy9hbmFseXplci9kc2wvc3BlYy9wYXJzZXIvWWFtbFBhcnNlclNwZWMuamF2YQ==) | `75.00% <ø> (ø)` | `1.00 <0.00> (ø)` | |
| [...p/log/analyzer/dsl/spec/parser/JsonParserSpec.java](https://codecov.io/gh/apache/skywalking/pull/6480/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9sb2ctYW5hbHl6ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL2xvZy9hbmFseXplci9kc2wvc3BlYy9wYXJzZXIvSnNvblBhcnNlclNwZWMuamF2YQ==) | `80.00% <50.00%> (+5.00%)` | `1.00 <0.00> (ø)` | |
| [...g/analyzer/dsl/spec/parser/AbstractParserSpec.java](https://codecov.io/gh/apache/skywalking/pull/6480/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9sb2ctYW5hbHl6ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL2xvZy9hbmFseXplci9kc2wvc3BlYy9wYXJzZXIvQWJzdHJhY3RQYXJzZXJTcGVjLmphdmE=) | `100.00% <100.00%> (ø)` | `1.00 <1.00> (?)` | |
| [...he/skywalking/oap/server/core/source/GCPhrase.java](https://codecov.io/gh/apache/skywalking/pull/6480/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvc291cmNlL0dDUGhyYXNlLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...pache/skywalking/apm/agent/core/base64/Base64.java](https://codecov.io/gh/apache/skywalking/pull/6480/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvYmFzZTY0L0Jhc2U2NC5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-3.00%)` | |
| [...che/skywalking/apm/agent/core/meter/MeterType.java](https://codecov.io/gh/apache/skywalking/pull/6480/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvbWV0ZXIvTWV0ZXJUeXBlLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (ø%)` | |
| [...skywalking/oap/server/core/alarm/AlarmMessage.java](https://codecov.io/gh/apache/skywalking/pull/6480/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYWxhcm0vQWxhcm1NZXNzYWdlLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...skywalking/oap/server/core/source/RequestType.java](https://codecov.io/gh/apache/skywalking/pull/6480/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvc291cmNlL1JlcXVlc3RUeXBlLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| ... and [1473 more](https://codecov.io/gh/apache/skywalking/pull/6480/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/6480?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/6480?src=pr&el=footer). Last update [cb16e52...a8c1e14](https://codecov.io/gh/apache/skywalking/pull/6480?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6480: Remove unnecessary check for getSkyWalkingDynamicField invocation
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #6480:
URL: https://github.com/apache/skywalking/pull/6480#issuecomment-789727063
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/6480?src=pr&el=h1) Report
> Merging [#6480](https://codecov.io/gh/apache/skywalking/pull/6480?src=pr&el=desc) (9f84ae1) into [master](https://codecov.io/gh/apache/skywalking/commit/de6a731d72fb87dd574da1d9b42495fdd29b4311?el=desc) (de6a731) will **decrease** coverage by `18.52%`.
> The diff coverage is `19.04%`.
[![Impacted file tree graph](https://codecov.io/gh/apache/skywalking/pull/6480/graphs/tree.svg?width=650&height=150&src=pr&token=qrILxY5yA8)](https://codecov.io/gh/apache/skywalking/pull/6480?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #6480 +/- ##
=============================================
- Coverage 54.00% 35.48% -18.53%
+ Complexity 4075 2595 -1480
=============================================
Files 1777 1021 -756
Lines 37757 24865 -12892
Branches 4153 2440 -1713
=============================================
- Hits 20392 8823 -11569
+ Misses 16385 15371 -1014
+ Partials 980 671 -309
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/6480?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...g/oap/log/analyzer/dsl/spec/filter/FilterSpec.java](https://codecov.io/gh/apache/skywalking/pull/6480/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9sb2ctYW5hbHl6ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL2xvZy9hbmFseXplci9kc2wvc3BlYy9maWx0ZXIvRmlsdGVyU3BlYy5qYXZh) | `44.61% <0.00%> (-6.27%)` | `7.00 <0.00> (ø)` | |
| [...p/log/analyzer/dsl/spec/parser/TextParserSpec.java](https://codecov.io/gh/apache/skywalking/pull/6480/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9sb2ctYW5hbHl6ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL2xvZy9hbmFseXplci9kc2wvc3BlYy9wYXJzZXIvVGV4dFBhcnNlclNwZWMuamF2YQ==) | `64.28% <0.00%> (-10.72%)` | `4.00 <0.00> (ø)` | |
| [...p/log/analyzer/dsl/spec/parser/YamlParserSpec.java](https://codecov.io/gh/apache/skywalking/pull/6480/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9sb2ctYW5hbHl6ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL2xvZy9hbmFseXplci9kc2wvc3BlYy9wYXJzZXIvWWFtbFBhcnNlclNwZWMuamF2YQ==) | `75.00% <ø> (ø)` | `1.00 <0.00> (ø)` | |
| [...p/log/analyzer/dsl/spec/parser/JsonParserSpec.java](https://codecov.io/gh/apache/skywalking/pull/6480/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9sb2ctYW5hbHl6ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL2xvZy9hbmFseXplci9kc2wvc3BlYy9wYXJzZXIvSnNvblBhcnNlclNwZWMuamF2YQ==) | `80.00% <50.00%> (+5.00%)` | `1.00 <0.00> (ø)` | |
| [...g/analyzer/dsl/spec/parser/AbstractParserSpec.java](https://codecov.io/gh/apache/skywalking/pull/6480/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9sb2ctYW5hbHl6ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL2xvZy9hbmFseXplci9kc2wvc3BlYy9wYXJzZXIvQWJzdHJhY3RQYXJzZXJTcGVjLmphdmE=) | `100.00% <100.00%> (ø)` | `1.00 <1.00> (?)` | |
| [...pache/skywalking/apm/agent/core/base64/Base64.java](https://codecov.io/gh/apache/skywalking/pull/6480/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvYmFzZTY0L0Jhc2U2NC5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-3.00%)` | |
| [...che/skywalking/apm/agent/core/meter/MeterType.java](https://codecov.io/gh/apache/skywalking/pull/6480/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvbWV0ZXIvTWV0ZXJUeXBlLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (ø%)` | |
| [...skywalking/oap/server/core/alarm/AlarmMessage.java](https://codecov.io/gh/apache/skywalking/pull/6480/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYWxhcm0vQWxhcm1NZXNzYWdlLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...e/skywalking/apm/agent/core/meter/CounterMode.java](https://codecov.io/gh/apache/skywalking/pull/6480/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvbWV0ZXIvQ291bnRlck1vZGUuamF2YQ==) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (ø%)` | |
| [...ywalking/apm/agent/core/logging/core/LogLevel.java](https://codecov.io/gh/apache/skywalking/pull/6480/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvbG9nZ2luZy9jb3JlL0xvZ0xldmVsLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| ... and [1369 more](https://codecov.io/gh/apache/skywalking/pull/6480/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/6480?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/6480?src=pr&el=footer). Last update [cb16e52...a8c1e14](https://codecov.io/gh/apache/skywalking/pull/6480?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6480: Remove unnecessary check for getSkyWalkingDynamicField invocation
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #6480:
URL: https://github.com/apache/skywalking/pull/6480#issuecomment-789727063
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/6480?src=pr&el=h1) Report
> Merging [#6480](https://codecov.io/gh/apache/skywalking/pull/6480?src=pr&el=desc) (9f84ae1) into [master](https://codecov.io/gh/apache/skywalking/commit/de6a731d72fb87dd574da1d9b42495fdd29b4311?el=desc) (de6a731) will **decrease** coverage by `54.00%`.
> The diff coverage is `n/a`.
[![Impacted file tree graph](https://codecov.io/gh/apache/skywalking/pull/6480/graphs/tree.svg?width=650&height=150&src=pr&token=qrILxY5yA8)](https://codecov.io/gh/apache/skywalking/pull/6480?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #6480 +/- ##
============================================
- Coverage 54.00% 0.00% -54.01%
============================================
Files 1777 181 -1596
Lines 37757 4354 -33403
Branches 4153 498 -3655
============================================
- Hits 20392 0 -20392
+ Misses 16385 4354 -12031
+ Partials 980 0 -980
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/6480?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...pache/skywalking/apm/agent/core/base64/Base64.java](https://codecov.io/gh/apache/skywalking/pull/6480/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvYmFzZTY0L0Jhc2U2NC5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-3.00%)` | |
| [...king/apm/util/RunnableWithExceptionProtection.java](https://codecov.io/gh/apache/skywalking/pull/6480/diff?src=pr&el=tree#diff-YXBtLWNvbW1vbnMvYXBtLXV0aWwvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL3V0aWwvUnVubmFibGVXaXRoRXhjZXB0aW9uUHJvdGVjdGlvbi5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-2.00%)` | |
| [...ywalking/apm/agent/core/logging/core/LogLevel.java](https://codecov.io/gh/apache/skywalking/pull/6480/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvbG9nZ2luZy9jb3JlL0xvZ0xldmVsLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...ywalking/apm/agent/core/plugin/EnhanceContext.java](https://codecov.io/gh/apache/skywalking/pull/6480/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcGx1Z2luL0VuaGFuY2VDb250ZXh0LmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-5.00%)` | |
| [...ywalking/apm/agent/core/plugin/PluginSelector.java](https://codecov.io/gh/apache/skywalking/pull/6480/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcGx1Z2luL1BsdWdpblNlbGVjdG9yLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-2.00%)` | |
| [...ywalking/apm/agent/core/profile/ProfileStatus.java](https://codecov.io/gh/apache/skywalking/pull/6480/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcHJvZmlsZS9Qcm9maWxlU3RhdHVzLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...walking/apm/agent/core/context/SW8CarrierItem.java](https://codecov.io/gh/apache/skywalking/pull/6480/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29udGV4dC9TVzhDYXJyaWVySXRlbS5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-2.00%)` | |
| [...walking/apm/agent/core/jvm/cpu/SunCpuAccessor.java](https://codecov.io/gh/apache/skywalking/pull/6480/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvanZtL2NwdS9TdW5DcHVBY2Nlc3Nvci5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-2.00%)` | |
| [...walking/apm/agent/core/logging/core/LogOutput.java](https://codecov.io/gh/apache/skywalking/pull/6480/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvbG9nZ2luZy9jb3JlL0xvZ091dHB1dC5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...walking/apm/agent/core/plugin/match/NameMatch.java](https://codecov.io/gh/apache/skywalking/pull/6480/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcGx1Z2luL21hdGNoL05hbWVNYXRjaC5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-3.00%)` | |
| ... and [1748 more](https://codecov.io/gh/apache/skywalking/pull/6480/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/6480?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/6480?src=pr&el=footer). Last update [cb16e52...a8c1e14](https://codecov.io/gh/apache/skywalking/pull/6480?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6480: Remove unnecessary check for getSkyWalkingDynamicField invocation
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #6480:
URL: https://github.com/apache/skywalking/pull/6480#issuecomment-789727063
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/6480?src=pr&el=h1) Report
> Merging [#6480](https://codecov.io/gh/apache/skywalking/pull/6480?src=pr&el=desc) (b16aca4) into [master](https://codecov.io/gh/apache/skywalking/commit/cb16e524da2bf45258e67052443a6b9bc2460855?el=desc) (cb16e52) will **decrease** coverage by `54.08%`.
> The diff coverage is `n/a`.
[![Impacted file tree graph](https://codecov.io/gh/apache/skywalking/pull/6480/graphs/tree.svg?width=650&height=150&src=pr&token=qrILxY5yA8)](https://codecov.io/gh/apache/skywalking/pull/6480?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #6480 +/- ##
============================================
- Coverage 54.08% 0.00% -54.09%
============================================
Files 1778 199 -1579
Lines 37771 4797 -32974
Branches 4156 556 -3600
============================================
- Hits 20429 0 -20429
+ Misses 16361 4797 -11564
+ Partials 981 0 -981
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/6480?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...pache/skywalking/apm/agent/core/base64/Base64.java](https://codecov.io/gh/apache/skywalking/pull/6480/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvYmFzZTY0L0Jhc2U2NC5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-3.00%)` | |
| [...che/skywalking/apm/agent/core/meter/MeterType.java](https://codecov.io/gh/apache/skywalking/pull/6480/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvbWV0ZXIvTWV0ZXJUeXBlLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (ø%)` | |
| [...e/skywalking/apm/agent/core/meter/CounterMode.java](https://codecov.io/gh/apache/skywalking/pull/6480/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvbWV0ZXIvQ291bnRlck1vZGUuamF2YQ==) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (ø%)` | |
| [...king/apm/util/RunnableWithExceptionProtection.java](https://codecov.io/gh/apache/skywalking/pull/6480/diff?src=pr&el=tree#diff-YXBtLWNvbW1vbnMvYXBtLXV0aWwvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL3V0aWwvUnVubmFibGVXaXRoRXhjZXB0aW9uUHJvdGVjdGlvbi5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-2.00%)` | |
| [...ywalking/apm/agent/core/logging/core/LogLevel.java](https://codecov.io/gh/apache/skywalking/pull/6480/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvbG9nZ2luZy9jb3JlL0xvZ0xldmVsLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...ywalking/apm/agent/core/plugin/EnhanceContext.java](https://codecov.io/gh/apache/skywalking/pull/6480/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcGx1Z2luL0VuaGFuY2VDb250ZXh0LmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-5.00%)` | |
| [...ywalking/apm/agent/core/plugin/PluginSelector.java](https://codecov.io/gh/apache/skywalking/pull/6480/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcGx1Z2luL1BsdWdpblNlbGVjdG9yLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-2.00%)` | |
| [...ywalking/apm/agent/core/profile/ProfileStatus.java](https://codecov.io/gh/apache/skywalking/pull/6480/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcHJvZmlsZS9Qcm9maWxlU3RhdHVzLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...walking/apm/agent/core/context/SW8CarrierItem.java](https://codecov.io/gh/apache/skywalking/pull/6480/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29udGV4dC9TVzhDYXJyaWVySXRlbS5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-2.00%)` | |
| [...walking/apm/agent/core/jvm/cpu/SunCpuAccessor.java](https://codecov.io/gh/apache/skywalking/pull/6480/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvanZtL2NwdS9TdW5DcHVBY2Nlc3Nvci5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-2.00%)` | |
| ... and [1757 more](https://codecov.io/gh/apache/skywalking/pull/6480/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/6480?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/6480?src=pr&el=footer). Last update [9946ec4...5c9722d](https://codecov.io/gh/apache/skywalking/pull/6480?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6480: Remove unnecessary check for getSkyWalkingDynamicField invocation
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #6480:
URL: https://github.com/apache/skywalking/pull/6480#issuecomment-789727063
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/6480?src=pr&el=h1) Report
> Merging [#6480](https://codecov.io/gh/apache/skywalking/pull/6480?src=pr&el=desc) (b16aca4) into [master](https://codecov.io/gh/apache/skywalking/commit/cb16e524da2bf45258e67052443a6b9bc2460855?el=desc) (cb16e52) will **decrease** coverage by `54.08%`.
> The diff coverage is `n/a`.
[![Impacted file tree graph](https://codecov.io/gh/apache/skywalking/pull/6480/graphs/tree.svg?width=650&height=150&src=pr&token=qrILxY5yA8)](https://codecov.io/gh/apache/skywalking/pull/6480?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #6480 +/- ##
============================================
- Coverage 54.08% 0.00% -54.09%
============================================
Files 1778 182 -1596
Lines 37771 4475 -33296
Branches 4156 522 -3634
============================================
- Hits 20429 0 -20429
+ Misses 16361 4475 -11886
+ Partials 981 0 -981
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/6480?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...pache/skywalking/apm/agent/core/base64/Base64.java](https://codecov.io/gh/apache/skywalking/pull/6480/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvYmFzZTY0L0Jhc2U2NC5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-3.00%)` | |
| [...king/apm/util/RunnableWithExceptionProtection.java](https://codecov.io/gh/apache/skywalking/pull/6480/diff?src=pr&el=tree#diff-YXBtLWNvbW1vbnMvYXBtLXV0aWwvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL3V0aWwvUnVubmFibGVXaXRoRXhjZXB0aW9uUHJvdGVjdGlvbi5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-2.00%)` | |
| [...ywalking/apm/agent/core/logging/core/LogLevel.java](https://codecov.io/gh/apache/skywalking/pull/6480/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvbG9nZ2luZy9jb3JlL0xvZ0xldmVsLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...ywalking/apm/agent/core/plugin/EnhanceContext.java](https://codecov.io/gh/apache/skywalking/pull/6480/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcGx1Z2luL0VuaGFuY2VDb250ZXh0LmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-5.00%)` | |
| [...ywalking/apm/agent/core/plugin/PluginSelector.java](https://codecov.io/gh/apache/skywalking/pull/6480/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcGx1Z2luL1BsdWdpblNlbGVjdG9yLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-2.00%)` | |
| [...ywalking/apm/agent/core/profile/ProfileStatus.java](https://codecov.io/gh/apache/skywalking/pull/6480/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcHJvZmlsZS9Qcm9maWxlU3RhdHVzLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...walking/apm/agent/core/context/SW8CarrierItem.java](https://codecov.io/gh/apache/skywalking/pull/6480/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29udGV4dC9TVzhDYXJyaWVySXRlbS5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-2.00%)` | |
| [...walking/apm/agent/core/jvm/cpu/SunCpuAccessor.java](https://codecov.io/gh/apache/skywalking/pull/6480/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvanZtL2NwdS9TdW5DcHVBY2Nlc3Nvci5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-2.00%)` | |
| [...walking/apm/agent/core/logging/core/LogOutput.java](https://codecov.io/gh/apache/skywalking/pull/6480/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvbG9nZ2luZy9jb3JlL0xvZ091dHB1dC5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...walking/apm/agent/core/plugin/match/NameMatch.java](https://codecov.io/gh/apache/skywalking/pull/6480/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcGx1Z2luL21hdGNoL05hbWVNYXRjaC5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-3.00%)` | |
| ... and [1755 more](https://codecov.io/gh/apache/skywalking/pull/6480/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/6480?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/6480?src=pr&el=footer). Last update [9946ec4...5c9722d](https://codecov.io/gh/apache/skywalking/pull/6480?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6480: Remove unnecessary check for getSkyWalkingDynamicField invocation
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #6480:
URL: https://github.com/apache/skywalking/pull/6480#issuecomment-789727063
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/6480?src=pr&el=h1) Report
> Merging [#6480](https://codecov.io/gh/apache/skywalking/pull/6480?src=pr&el=desc) (9f84ae1) into [master](https://codecov.io/gh/apache/skywalking/commit/de6a731d72fb87dd574da1d9b42495fdd29b4311?el=desc) (de6a731) will **decrease** coverage by `30.72%`.
> The diff coverage is `19.04%`.
[![Impacted file tree graph](https://codecov.io/gh/apache/skywalking/pull/6480/graphs/tree.svg?width=650&height=150&src=pr&token=qrILxY5yA8)](https://codecov.io/gh/apache/skywalking/pull/6480?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #6480 +/- ##
=============================================
- Coverage 54.00% 23.28% -30.73%
+ Complexity 4075 1733 -2342
=============================================
Files 1777 987 -790
Lines 37757 23786 -13971
Branches 4153 2316 -1837
=============================================
- Hits 20392 5538 -14854
- Misses 16385 17851 +1466
+ Partials 980 397 -583
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/6480?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...g/oap/log/analyzer/dsl/spec/filter/FilterSpec.java](https://codecov.io/gh/apache/skywalking/pull/6480/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9sb2ctYW5hbHl6ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL2xvZy9hbmFseXplci9kc2wvc3BlYy9maWx0ZXIvRmlsdGVyU3BlYy5qYXZh) | `20.00% <0.00%> (-30.88%)` | `2.00 <0.00> (-5.00)` | |
| [...p/log/analyzer/dsl/spec/parser/TextParserSpec.java](https://codecov.io/gh/apache/skywalking/pull/6480/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9sb2ctYW5hbHl6ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL2xvZy9hbmFseXplci9kc2wvc3BlYy9wYXJzZXIvVGV4dFBhcnNlclNwZWMuamF2YQ==) | `14.28% <0.00%> (-60.72%)` | `1.00 <0.00> (-3.00)` | |
| [...p/log/analyzer/dsl/spec/parser/YamlParserSpec.java](https://codecov.io/gh/apache/skywalking/pull/6480/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9sb2ctYW5hbHl6ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL2xvZy9hbmFseXplci9kc2wvc3BlYy9wYXJzZXIvWWFtbFBhcnNlclNwZWMuamF2YQ==) | `75.00% <ø> (ø)` | `1.00 <0.00> (ø)` | |
| [...p/log/analyzer/dsl/spec/parser/JsonParserSpec.java](https://codecov.io/gh/apache/skywalking/pull/6480/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9sb2ctYW5hbHl6ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL2xvZy9hbmFseXplci9kc2wvc3BlYy9wYXJzZXIvSnNvblBhcnNlclNwZWMuamF2YQ==) | `80.00% <50.00%> (+5.00%)` | `1.00 <0.00> (ø)` | |
| [...g/analyzer/dsl/spec/parser/AbstractParserSpec.java](https://codecov.io/gh/apache/skywalking/pull/6480/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9sb2ctYW5hbHl6ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL2xvZy9hbmFseXplci9kc2wvc3BlYy9wYXJzZXIvQWJzdHJhY3RQYXJzZXJTcGVjLmphdmE=) | `100.00% <100.00%> (ø)` | `1.00 <1.00> (?)` | |
| [...he/skywalking/oap/server/core/source/GCPhrase.java](https://codecov.io/gh/apache/skywalking/pull/6480/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvc291cmNlL0dDUGhyYXNlLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...pache/skywalking/apm/agent/core/base64/Base64.java](https://codecov.io/gh/apache/skywalking/pull/6480/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvYmFzZTY0L0Jhc2U2NC5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-3.00%)` | |
| [...che/skywalking/apm/agent/core/meter/MeterType.java](https://codecov.io/gh/apache/skywalking/pull/6480/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvbWV0ZXIvTWV0ZXJUeXBlLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (ø%)` | |
| [...skywalking/oap/server/core/alarm/AlarmMessage.java](https://codecov.io/gh/apache/skywalking/pull/6480/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYWxhcm0vQWxhcm1NZXNzYWdlLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...skywalking/oap/server/core/source/RequestType.java](https://codecov.io/gh/apache/skywalking/pull/6480/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvc291cmNlL1JlcXVlc3RUeXBlLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| ... and [1473 more](https://codecov.io/gh/apache/skywalking/pull/6480/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/6480?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/6480?src=pr&el=footer). Last update [cb16e52...a8c1e14](https://codecov.io/gh/apache/skywalking/pull/6480?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6480: Remove unnecessary check for getSkyWalkingDynamicField invocation
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #6480:
URL: https://github.com/apache/skywalking/pull/6480#issuecomment-789727063
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/6480?src=pr&el=h1) Report
> Merging [#6480](https://codecov.io/gh/apache/skywalking/pull/6480?src=pr&el=desc) (b16aca4) into [master](https://codecov.io/gh/apache/skywalking/commit/cb16e524da2bf45258e67052443a6b9bc2460855?el=desc) (cb16e52) will **decrease** coverage by `23.48%`.
> The diff coverage is `n/a`.
[![Impacted file tree graph](https://codecov.io/gh/apache/skywalking/pull/6480/graphs/tree.svg?width=650&height=150&src=pr&token=qrILxY5yA8)](https://codecov.io/gh/apache/skywalking/pull/6480?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #6480 +/- ##
=============================================
- Coverage 54.08% 30.60% -23.49%
+ Complexity 4088 2194 -1894
=============================================
Files 1778 988 -790
Lines 37771 23986 -13785
Branches 4156 2348 -1808
=============================================
- Hits 20429 7341 -13088
+ Misses 16361 16098 -263
+ Partials 981 547 -434
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/6480?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...pache/skywalking/apm/agent/core/base64/Base64.java](https://codecov.io/gh/apache/skywalking/pull/6480/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvYmFzZTY0L0Jhc2U2NC5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-3.00%)` | |
| [...che/skywalking/apm/agent/core/meter/MeterType.java](https://codecov.io/gh/apache/skywalking/pull/6480/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvbWV0ZXIvTWV0ZXJUeXBlLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (ø%)` | |
| [...skywalking/oap/server/core/alarm/AlarmMessage.java](https://codecov.io/gh/apache/skywalking/pull/6480/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYWxhcm0vQWxhcm1NZXNzYWdlLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...kywalking/oap/server/core/storage/AbstractDAO.java](https://codecov.io/gh/apache/skywalking/pull/6480/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvc3RvcmFnZS9BYnN0cmFjdERBTy5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-2.00%)` | |
| [...e/skywalking/apm/agent/core/meter/CounterMode.java](https://codecov.io/gh/apache/skywalking/pull/6480/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvbWV0ZXIvQ291bnRlck1vZGUuamF2YQ==) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (ø%)` | |
| [...ywalking/apm/agent/core/logging/core/LogLevel.java](https://codecov.io/gh/apache/skywalking/pull/6480/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvbG9nZ2luZy9jb3JlL0xvZ0xldmVsLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...ywalking/apm/agent/core/plugin/EnhanceContext.java](https://codecov.io/gh/apache/skywalking/pull/6480/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcGx1Z2luL0VuaGFuY2VDb250ZXh0LmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-5.00%)` | |
| [...ywalking/apm/agent/core/plugin/PluginSelector.java](https://codecov.io/gh/apache/skywalking/pull/6480/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcGx1Z2luL1BsdWdpblNlbGVjdG9yLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-2.00%)` | |
| [...ywalking/apm/agent/core/profile/ProfileStatus.java](https://codecov.io/gh/apache/skywalking/pull/6480/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcHJvZmlsZS9Qcm9maWxlU3RhdHVzLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...walking/apm/agent/core/context/SW8CarrierItem.java](https://codecov.io/gh/apache/skywalking/pull/6480/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29udGV4dC9TVzhDYXJyaWVySXRlbS5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-2.00%)` | |
| ... and [1410 more](https://codecov.io/gh/apache/skywalking/pull/6480/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/6480?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/6480?src=pr&el=footer). Last update [9946ec4...5c9722d](https://codecov.io/gh/apache/skywalking/pull/6480?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6480: Remove unnecessary check for getSkyWalkingDynamicField invocation
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #6480:
URL: https://github.com/apache/skywalking/pull/6480#issuecomment-789727063
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/6480?src=pr&el=h1) Report
> Merging [#6480](https://codecov.io/gh/apache/skywalking/pull/6480?src=pr&el=desc) (9f84ae1) into [master](https://codecov.io/gh/apache/skywalking/commit/de6a731d72fb87dd574da1d9b42495fdd29b4311?el=desc) (de6a731) will **decrease** coverage by `20.96%`.
> The diff coverage is `19.04%`.
[![Impacted file tree graph](https://codecov.io/gh/apache/skywalking/pull/6480/graphs/tree.svg?width=650&height=150&src=pr&token=qrILxY5yA8)](https://codecov.io/gh/apache/skywalking/pull/6480?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #6480 +/- ##
=============================================
- Coverage 54.00% 33.04% -20.97%
+ Complexity 4075 2433 -1642
=============================================
Files 1777 1018 -759
Lines 37757 24759 -12998
Branches 4153 2429 -1724
=============================================
- Hits 20392 8181 -12211
+ Misses 16385 15960 -425
+ Partials 980 618 -362
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/6480?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...g/oap/log/analyzer/dsl/spec/filter/FilterSpec.java](https://codecov.io/gh/apache/skywalking/pull/6480/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9sb2ctYW5hbHl6ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL2xvZy9hbmFseXplci9kc2wvc3BlYy9maWx0ZXIvRmlsdGVyU3BlYy5qYXZh) | `44.61% <0.00%> (-6.27%)` | `7.00 <0.00> (ø)` | |
| [...p/log/analyzer/dsl/spec/parser/TextParserSpec.java](https://codecov.io/gh/apache/skywalking/pull/6480/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9sb2ctYW5hbHl6ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL2xvZy9hbmFseXplci9kc2wvc3BlYy9wYXJzZXIvVGV4dFBhcnNlclNwZWMuamF2YQ==) | `64.28% <0.00%> (-10.72%)` | `4.00 <0.00> (ø)` | |
| [...p/log/analyzer/dsl/spec/parser/YamlParserSpec.java](https://codecov.io/gh/apache/skywalking/pull/6480/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9sb2ctYW5hbHl6ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL2xvZy9hbmFseXplci9kc2wvc3BlYy9wYXJzZXIvWWFtbFBhcnNlclNwZWMuamF2YQ==) | `75.00% <ø> (ø)` | `1.00 <0.00> (ø)` | |
| [...p/log/analyzer/dsl/spec/parser/JsonParserSpec.java](https://codecov.io/gh/apache/skywalking/pull/6480/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9sb2ctYW5hbHl6ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL2xvZy9hbmFseXplci9kc2wvc3BlYy9wYXJzZXIvSnNvblBhcnNlclNwZWMuamF2YQ==) | `80.00% <50.00%> (+5.00%)` | `1.00 <0.00> (ø)` | |
| [...g/analyzer/dsl/spec/parser/AbstractParserSpec.java](https://codecov.io/gh/apache/skywalking/pull/6480/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9sb2ctYW5hbHl6ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL2xvZy9hbmFseXplci9kc2wvc3BlYy9wYXJzZXIvQWJzdHJhY3RQYXJzZXJTcGVjLmphdmE=) | `100.00% <100.00%> (ø)` | `1.00 <1.00> (?)` | |
| [...pache/skywalking/apm/agent/core/base64/Base64.java](https://codecov.io/gh/apache/skywalking/pull/6480/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvYmFzZTY0L0Jhc2U2NC5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-3.00%)` | |
| [...che/skywalking/apm/agent/core/meter/MeterType.java](https://codecov.io/gh/apache/skywalking/pull/6480/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvbWV0ZXIvTWV0ZXJUeXBlLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (ø%)` | |
| [...skywalking/oap/server/core/alarm/AlarmMessage.java](https://codecov.io/gh/apache/skywalking/pull/6480/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYWxhcm0vQWxhcm1NZXNzYWdlLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...e/skywalking/apm/agent/core/meter/CounterMode.java](https://codecov.io/gh/apache/skywalking/pull/6480/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvbWV0ZXIvQ291bnRlck1vZGUuamF2YQ==) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (ø%)` | |
| [...ywalking/apm/agent/core/logging/core/LogLevel.java](https://codecov.io/gh/apache/skywalking/pull/6480/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvbG9nZ2luZy9jb3JlL0xvZ0xldmVsLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| ... and [1378 more](https://codecov.io/gh/apache/skywalking/pull/6480/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/6480?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/6480?src=pr&el=footer). Last update [cb16e52...a8c1e14](https://codecov.io/gh/apache/skywalking/pull/6480?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6480: Remove unnecessary check for getSkyWalkingDynamicField invocation
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #6480:
URL: https://github.com/apache/skywalking/pull/6480#issuecomment-789727063
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/6480?src=pr&el=h1) Report
> Merging [#6480](https://codecov.io/gh/apache/skywalking/pull/6480?src=pr&el=desc) (a8c1e14) into [master](https://codecov.io/gh/apache/skywalking/commit/de6a731d72fb87dd574da1d9b42495fdd29b4311?el=desc) (de6a731) will **increase** coverage by `3.00%`.
> The diff coverage is `n/a`.
[![Impacted file tree graph](https://codecov.io/gh/apache/skywalking/pull/6480/graphs/tree.svg?width=650&height=150&src=pr&token=qrILxY5yA8)](https://codecov.io/gh/apache/skywalking/pull/6480?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #6480 +/- ##
============================================
+ Coverage 54.00% 57.01% +3.00%
+ Complexity 4075 822 -3253
============================================
Files 1777 176 -1601
Lines 37757 4301 -33456
Branches 4153 491 -3662
============================================
- Hits 20392 2452 -17940
+ Misses 16385 1537 -14848
+ Partials 980 312 -668
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/6480?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...t/status/HierarchyMatchExceptionCheckStrategy.java](https://codecov.io/gh/apache/skywalking/pull/6480/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29udGV4dC9zdGF0dXMvSGllcmFyY2h5TWF0Y2hFeGNlcHRpb25DaGVja1N0cmF0ZWd5LmphdmE=) | `9.09% <0.00%> (-90.91%)` | `1.00% <0.00%> (ø%)` | |
| [...alking/apm/agent/core/logging/core/FileWriter.java](https://codecov.io/gh/apache/skywalking/pull/6480/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvbG9nZ2luZy9jb3JlL0ZpbGVXcml0ZXIuamF2YQ==) | `0.00% <0.00%> (-88.10%)` | `0.00% <0.00%> (ø%)` | |
| [...g/apm/agent/core/context/status/StatusChecker.java](https://codecov.io/gh/apache/skywalking/pull/6480/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29udGV4dC9zdGF0dXMvU3RhdHVzQ2hlY2tlci5qYXZh) | `23.80% <0.00%> (-76.20%)` | `1.00% <0.00%> (ø%)` | |
| [...ywalking/apm/agent/core/plugin/PluginSelector.java](https://codecov.io/gh/apache/skywalking/pull/6480/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcGx1Z2luL1BsdWdpblNlbGVjdG9yLmphdmE=) | `28.57% <0.00%> (-71.43%)` | `2.00% <0.00%> (ø%)` | |
| [...re/logging/core/converters/AgentNameConverter.java](https://codecov.io/gh/apache/skywalking/pull/6480/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvbG9nZ2luZy9jb3JlL2NvbnZlcnRlcnMvQWdlbnROYW1lQ29udmVydGVyLmphdmE=) | `0.00% <0.00%> (-66.67%)` | `0.00% <0.00%> (ø%)` | |
| [...re/logging/core/converters/ThrowableConverter.java](https://codecov.io/gh/apache/skywalking/pull/6480/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvbG9nZ2luZy9jb3JlL2NvbnZlcnRlcnMvVGhyb3dhYmxlQ29udmVydGVyLmphdmE=) | `16.66% <0.00%> (-66.67%)` | `2.00% <0.00%> (ø%)` | |
| [...he/skywalking/apm/commons/datacarrier/EnvUtil.java](https://codecov.io/gh/apache/skywalking/pull/6480/diff?src=pr&el=tree#diff-YXBtLWNvbW1vbnMvYXBtLWRhdGFjYXJyaWVyL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL2FwbS9jb21tb25zL2RhdGFjYXJyaWVyL0VudlV0aWwuamF2YQ==) | `20.00% <0.00%> (-60.00%)` | `1.00% <0.00%> (ø%)` | |
| [...lking/apm/agent/core/context/ExtensionContext.java](https://codecov.io/gh/apache/skywalking/pull/6480/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29udGV4dC9FeHRlbnNpb25Db250ZXh0LmphdmE=) | `23.25% <0.00%> (-51.17%)` | `7.00% <0.00%> (ø%)` | |
| [...core/context/status/OffExceptionCheckStrategy.java](https://codecov.io/gh/apache/skywalking/pull/6480/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29udGV4dC9zdGF0dXMvT2ZmRXhjZXB0aW9uQ2hlY2tTdHJhdGVneS5qYXZh) | `50.00% <0.00%> (-50.00%)` | `1.00% <0.00%> (ø%)` | |
| [...kywalking/apm/commons/datacarrier/DataCarrier.java](https://codecov.io/gh/apache/skywalking/pull/6480/diff?src=pr&el=tree#diff-YXBtLWNvbW1vbnMvYXBtLWRhdGFjYXJyaWVyL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL2FwbS9jb21tb25zL2RhdGFjYXJyaWVyL0RhdGFDYXJyaWVyLmphdmE=) | `38.46% <0.00%> (-46.16%)` | `6.00% <0.00%> (-4.00%)` | |
| ... and [1691 more](https://codecov.io/gh/apache/skywalking/pull/6480/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/6480?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/6480?src=pr&el=footer). Last update [cb16e52...a8c1e14](https://codecov.io/gh/apache/skywalking/pull/6480?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6480: Remove unnecessary check for getSkyWalkingDynamicField invocation
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #6480:
URL: https://github.com/apache/skywalking/pull/6480#issuecomment-789727063
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/6480?src=pr&el=h1) Report
> Merging [#6480](https://codecov.io/gh/apache/skywalking/pull/6480?src=pr&el=desc) (9f84ae1) into [master](https://codecov.io/gh/apache/skywalking/commit/de6a731d72fb87dd574da1d9b42495fdd29b4311?el=desc) (de6a731) will **decrease** coverage by `18.38%`.
> The diff coverage is `19.04%`.
[![Impacted file tree graph](https://codecov.io/gh/apache/skywalking/pull/6480/graphs/tree.svg?width=650&height=150&src=pr&token=qrILxY5yA8)](https://codecov.io/gh/apache/skywalking/pull/6480?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #6480 +/- ##
=============================================
- Coverage 54.00% 35.62% -18.39%
+ Complexity 4075 2595 -1480
=============================================
Files 1777 1018 -759
Lines 37757 24766 -12991
Branches 4153 2429 -1724
=============================================
- Hits 20392 8823 -11569
+ Misses 16385 15272 -1113
+ Partials 980 671 -309
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/6480?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...g/oap/log/analyzer/dsl/spec/filter/FilterSpec.java](https://codecov.io/gh/apache/skywalking/pull/6480/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9sb2ctYW5hbHl6ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL2xvZy9hbmFseXplci9kc2wvc3BlYy9maWx0ZXIvRmlsdGVyU3BlYy5qYXZh) | `44.61% <0.00%> (-6.27%)` | `7.00 <0.00> (ø)` | |
| [...p/log/analyzer/dsl/spec/parser/TextParserSpec.java](https://codecov.io/gh/apache/skywalking/pull/6480/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9sb2ctYW5hbHl6ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL2xvZy9hbmFseXplci9kc2wvc3BlYy9wYXJzZXIvVGV4dFBhcnNlclNwZWMuamF2YQ==) | `64.28% <0.00%> (-10.72%)` | `4.00 <0.00> (ø)` | |
| [...p/log/analyzer/dsl/spec/parser/YamlParserSpec.java](https://codecov.io/gh/apache/skywalking/pull/6480/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9sb2ctYW5hbHl6ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL2xvZy9hbmFseXplci9kc2wvc3BlYy9wYXJzZXIvWWFtbFBhcnNlclNwZWMuamF2YQ==) | `75.00% <ø> (ø)` | `1.00 <0.00> (ø)` | |
| [...p/log/analyzer/dsl/spec/parser/JsonParserSpec.java](https://codecov.io/gh/apache/skywalking/pull/6480/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9sb2ctYW5hbHl6ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL2xvZy9hbmFseXplci9kc2wvc3BlYy9wYXJzZXIvSnNvblBhcnNlclNwZWMuamF2YQ==) | `80.00% <50.00%> (+5.00%)` | `1.00 <0.00> (ø)` | |
| [...g/analyzer/dsl/spec/parser/AbstractParserSpec.java](https://codecov.io/gh/apache/skywalking/pull/6480/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9sb2ctYW5hbHl6ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL2xvZy9hbmFseXplci9kc2wvc3BlYy9wYXJzZXIvQWJzdHJhY3RQYXJzZXJTcGVjLmphdmE=) | `100.00% <100.00%> (ø)` | `1.00 <1.00> (?)` | |
| [...pache/skywalking/apm/agent/core/base64/Base64.java](https://codecov.io/gh/apache/skywalking/pull/6480/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvYmFzZTY0L0Jhc2U2NC5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-3.00%)` | |
| [...che/skywalking/apm/agent/core/meter/MeterType.java](https://codecov.io/gh/apache/skywalking/pull/6480/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvbWV0ZXIvTWV0ZXJUeXBlLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (ø%)` | |
| [...skywalking/oap/server/core/alarm/AlarmMessage.java](https://codecov.io/gh/apache/skywalking/pull/6480/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYWxhcm0vQWxhcm1NZXNzYWdlLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...e/skywalking/apm/agent/core/meter/CounterMode.java](https://codecov.io/gh/apache/skywalking/pull/6480/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvbWV0ZXIvQ291bnRlck1vZGUuamF2YQ==) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (ø%)` | |
| [...ywalking/apm/agent/core/logging/core/LogLevel.java](https://codecov.io/gh/apache/skywalking/pull/6480/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvbG9nZ2luZy9jb3JlL0xvZ0xldmVsLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| ... and [1369 more](https://codecov.io/gh/apache/skywalking/pull/6480/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/6480?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/6480?src=pr&el=footer). Last update [cb16e52...a8c1e14](https://codecov.io/gh/apache/skywalking/pull/6480?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6480: Remove unnecessary check for getSkyWalkingDynamicField invocation
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #6480:
URL: https://github.com/apache/skywalking/pull/6480#issuecomment-789727063
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/6480?src=pr&el=h1) Report
> Merging [#6480](https://codecov.io/gh/apache/skywalking/pull/6480?src=pr&el=desc) (9f84ae1) into [master](https://codecov.io/gh/apache/skywalking/commit/de6a731d72fb87dd574da1d9b42495fdd29b4311?el=desc) (de6a731) will **decrease** coverage by `18.52%`.
> The diff coverage is `19.04%`.
[![Impacted file tree graph](https://codecov.io/gh/apache/skywalking/pull/6480/graphs/tree.svg?width=650&height=150&src=pr&token=qrILxY5yA8)](https://codecov.io/gh/apache/skywalking/pull/6480?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #6480 +/- ##
=============================================
- Coverage 54.00% 35.48% -18.53%
+ Complexity 4075 2595 -1480
=============================================
Files 1777 1021 -756
Lines 37757 24865 -12892
Branches 4153 2440 -1713
=============================================
- Hits 20392 8823 -11569
+ Misses 16385 15371 -1014
+ Partials 980 671 -309
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/6480?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...g/oap/log/analyzer/dsl/spec/filter/FilterSpec.java](https://codecov.io/gh/apache/skywalking/pull/6480/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9sb2ctYW5hbHl6ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL2xvZy9hbmFseXplci9kc2wvc3BlYy9maWx0ZXIvRmlsdGVyU3BlYy5qYXZh) | `44.61% <0.00%> (-6.27%)` | `7.00 <0.00> (ø)` | |
| [...p/log/analyzer/dsl/spec/parser/TextParserSpec.java](https://codecov.io/gh/apache/skywalking/pull/6480/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9sb2ctYW5hbHl6ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL2xvZy9hbmFseXplci9kc2wvc3BlYy9wYXJzZXIvVGV4dFBhcnNlclNwZWMuamF2YQ==) | `64.28% <0.00%> (-10.72%)` | `4.00 <0.00> (ø)` | |
| [...p/log/analyzer/dsl/spec/parser/YamlParserSpec.java](https://codecov.io/gh/apache/skywalking/pull/6480/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9sb2ctYW5hbHl6ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL2xvZy9hbmFseXplci9kc2wvc3BlYy9wYXJzZXIvWWFtbFBhcnNlclNwZWMuamF2YQ==) | `75.00% <ø> (ø)` | `1.00 <0.00> (ø)` | |
| [...p/log/analyzer/dsl/spec/parser/JsonParserSpec.java](https://codecov.io/gh/apache/skywalking/pull/6480/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9sb2ctYW5hbHl6ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL2xvZy9hbmFseXplci9kc2wvc3BlYy9wYXJzZXIvSnNvblBhcnNlclNwZWMuamF2YQ==) | `80.00% <50.00%> (+5.00%)` | `1.00 <0.00> (ø)` | |
| [...g/analyzer/dsl/spec/parser/AbstractParserSpec.java](https://codecov.io/gh/apache/skywalking/pull/6480/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9sb2ctYW5hbHl6ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL2xvZy9hbmFseXplci9kc2wvc3BlYy9wYXJzZXIvQWJzdHJhY3RQYXJzZXJTcGVjLmphdmE=) | `100.00% <100.00%> (ø)` | `1.00 <1.00> (?)` | |
| [...pache/skywalking/apm/agent/core/base64/Base64.java](https://codecov.io/gh/apache/skywalking/pull/6480/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvYmFzZTY0L0Jhc2U2NC5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-3.00%)` | |
| [...che/skywalking/apm/agent/core/meter/MeterType.java](https://codecov.io/gh/apache/skywalking/pull/6480/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvbWV0ZXIvTWV0ZXJUeXBlLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (ø%)` | |
| [...skywalking/oap/server/core/alarm/AlarmMessage.java](https://codecov.io/gh/apache/skywalking/pull/6480/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYWxhcm0vQWxhcm1NZXNzYWdlLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...e/skywalking/apm/agent/core/meter/CounterMode.java](https://codecov.io/gh/apache/skywalking/pull/6480/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvbWV0ZXIvQ291bnRlck1vZGUuamF2YQ==) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (ø%)` | |
| [...ywalking/apm/agent/core/logging/core/LogLevel.java](https://codecov.io/gh/apache/skywalking/pull/6480/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvbG9nZ2luZy9jb3JlL0xvZ0xldmVsLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| ... and [1369 more](https://codecov.io/gh/apache/skywalking/pull/6480/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/6480?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/6480?src=pr&el=footer). Last update [cb16e52...a8c1e14](https://codecov.io/gh/apache/skywalking/pull/6480?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6480: Remove unnecessary check for getSkyWalkingDynamicField invocation
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #6480:
URL: https://github.com/apache/skywalking/pull/6480#issuecomment-789727063
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/6480?src=pr&el=h1) Report
> Merging [#6480](https://codecov.io/gh/apache/skywalking/pull/6480?src=pr&el=desc) (a8c1e14) into [master](https://codecov.io/gh/apache/skywalking/commit/de6a731d72fb87dd574da1d9b42495fdd29b4311?el=desc) (de6a731) will **increase** coverage by `2.01%`.
> The diff coverage is `n/a`.
[![Impacted file tree graph](https://codecov.io/gh/apache/skywalking/pull/6480/graphs/tree.svg?width=650&height=150&src=pr&token=qrILxY5yA8)](https://codecov.io/gh/apache/skywalking/pull/6480?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #6480 +/- ##
============================================
+ Coverage 54.00% 56.02% +2.01%
+ Complexity 4075 822 -3253
============================================
Files 1777 181 -1596
Lines 37757 4377 -33380
Branches 4153 499 -3654
============================================
- Hits 20392 2452 -17940
+ Misses 16385 1613 -14772
+ Partials 980 312 -668
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/6480?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...ng/apm/agent/core/context/trace/LogDataEntity.java](https://codecov.io/gh/apache/skywalking/pull/6480/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29udGV4dC90cmFjZS9Mb2dEYXRhRW50aXR5LmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (ø%)` | |
| [...ent/core/context/status/ExceptionCheckContext.java](https://codecov.io/gh/apache/skywalking/pull/6480/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29udGV4dC9zdGF0dXMvRXhjZXB0aW9uQ2hlY2tDb250ZXh0LmphdmE=) | `0.00% <0.00%> (-90.91%)` | `0.00% <0.00%> (ø%)` | |
| [...t/status/HierarchyMatchExceptionCheckStrategy.java](https://codecov.io/gh/apache/skywalking/pull/6480/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29udGV4dC9zdGF0dXMvSGllcmFyY2h5TWF0Y2hFeGNlcHRpb25DaGVja1N0cmF0ZWd5LmphdmE=) | `9.09% <0.00%> (-90.91%)` | `1.00% <0.00%> (ø%)` | |
| [...alking/apm/agent/core/logging/core/FileWriter.java](https://codecov.io/gh/apache/skywalking/pull/6480/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvbG9nZ2luZy9jb3JlL0ZpbGVXcml0ZXIuamF2YQ==) | `0.00% <0.00%> (-88.10%)` | `0.00% <0.00%> (ø%)` | |
| [...king/apm/agent/core/context/util/KeyValuePair.java](https://codecov.io/gh/apache/skywalking/pull/6480/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29udGV4dC91dGlsL0tleVZhbHVlUGFpci5qYXZh) | `0.00% <0.00%> (-80.00%)` | `0.00% <0.00%> (ø%)` | |
| [...g/apm/agent/core/context/status/StatusChecker.java](https://codecov.io/gh/apache/skywalking/pull/6480/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29udGV4dC9zdGF0dXMvU3RhdHVzQ2hlY2tlci5qYXZh) | `23.80% <0.00%> (-76.20%)` | `1.00% <0.00%> (ø%)` | |
| [...ywalking/apm/agent/core/plugin/PluginSelector.java](https://codecov.io/gh/apache/skywalking/pull/6480/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcGx1Z2luL1BsdWdpblNlbGVjdG9yLmphdmE=) | `28.57% <0.00%> (-71.43%)` | `2.00% <0.00%> (ø%)` | |
| [.../agent/core/context/util/ThrowableTransformer.java](https://codecov.io/gh/apache/skywalking/pull/6480/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29udGV4dC91dGlsL1Rocm93YWJsZVRyYW5zZm9ybWVyLmphdmE=) | `0.00% <0.00%> (-69.24%)` | `0.00% <0.00%> (ø%)` | |
| [...re/logging/core/converters/AgentNameConverter.java](https://codecov.io/gh/apache/skywalking/pull/6480/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvbG9nZ2luZy9jb3JlL2NvbnZlcnRlcnMvQWdlbnROYW1lQ29udmVydGVyLmphdmE=) | `0.00% <0.00%> (-66.67%)` | `0.00% <0.00%> (ø%)` | |
| [...re/logging/core/converters/ThrowableConverter.java](https://codecov.io/gh/apache/skywalking/pull/6480/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvbG9nZ2luZy9jb3JlL2NvbnZlcnRlcnMvVGhyb3dhYmxlQ29udmVydGVyLmphdmE=) | `16.66% <0.00%> (-66.67%)` | `2.00% <0.00%> (ø%)` | |
| ... and [1691 more](https://codecov.io/gh/apache/skywalking/pull/6480/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/6480?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/6480?src=pr&el=footer). Last update [cb16e52...a8c1e14](https://codecov.io/gh/apache/skywalking/pull/6480?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6480: Remove unnecessary check for getSkyWalkingDynamicField invocation
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #6480:
URL: https://github.com/apache/skywalking/pull/6480#issuecomment-789727063
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/6480?src=pr&el=h1) Report
> Merging [#6480](https://codecov.io/gh/apache/skywalking/pull/6480?src=pr&el=desc) (9f84ae1) into [master](https://codecov.io/gh/apache/skywalking/commit/de6a731d72fb87dd574da1d9b42495fdd29b4311?el=desc) (de6a731) will **decrease** coverage by `54.00%`.
> The diff coverage is `n/a`.
[![Impacted file tree graph](https://codecov.io/gh/apache/skywalking/pull/6480/graphs/tree.svg?width=650&height=150&src=pr&token=qrILxY5yA8)](https://codecov.io/gh/apache/skywalking/pull/6480?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #6480 +/- ##
============================================
- Coverage 54.00% 0.00% -54.01%
============================================
Files 1777 182 -1595
Lines 37757 4359 -33398
Branches 4153 498 -3655
============================================
- Hits 20392 0 -20392
+ Misses 16385 4359 -12026
+ Partials 980 0 -980
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/6480?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...pache/skywalking/apm/agent/core/base64/Base64.java](https://codecov.io/gh/apache/skywalking/pull/6480/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvYmFzZTY0L0Jhc2U2NC5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-3.00%)` | |
| [...king/apm/util/RunnableWithExceptionProtection.java](https://codecov.io/gh/apache/skywalking/pull/6480/diff?src=pr&el=tree#diff-YXBtLWNvbW1vbnMvYXBtLXV0aWwvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL3V0aWwvUnVubmFibGVXaXRoRXhjZXB0aW9uUHJvdGVjdGlvbi5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-2.00%)` | |
| [...ywalking/apm/agent/core/logging/core/LogLevel.java](https://codecov.io/gh/apache/skywalking/pull/6480/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvbG9nZ2luZy9jb3JlL0xvZ0xldmVsLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...ywalking/apm/agent/core/plugin/EnhanceContext.java](https://codecov.io/gh/apache/skywalking/pull/6480/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcGx1Z2luL0VuaGFuY2VDb250ZXh0LmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-5.00%)` | |
| [...ywalking/apm/agent/core/plugin/PluginSelector.java](https://codecov.io/gh/apache/skywalking/pull/6480/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcGx1Z2luL1BsdWdpblNlbGVjdG9yLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-2.00%)` | |
| [...ywalking/apm/agent/core/profile/ProfileStatus.java](https://codecov.io/gh/apache/skywalking/pull/6480/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcHJvZmlsZS9Qcm9maWxlU3RhdHVzLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...walking/apm/agent/core/context/SW8CarrierItem.java](https://codecov.io/gh/apache/skywalking/pull/6480/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29udGV4dC9TVzhDYXJyaWVySXRlbS5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-2.00%)` | |
| [...walking/apm/agent/core/jvm/cpu/SunCpuAccessor.java](https://codecov.io/gh/apache/skywalking/pull/6480/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvanZtL2NwdS9TdW5DcHVBY2Nlc3Nvci5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-2.00%)` | |
| [...walking/apm/agent/core/logging/core/LogOutput.java](https://codecov.io/gh/apache/skywalking/pull/6480/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvbG9nZ2luZy9jb3JlL0xvZ091dHB1dC5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...walking/apm/agent/core/plugin/match/NameMatch.java](https://codecov.io/gh/apache/skywalking/pull/6480/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcGx1Z2luL21hdGNoL05hbWVNYXRjaC5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-3.00%)` | |
| ... and [1748 more](https://codecov.io/gh/apache/skywalking/pull/6480/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/6480?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/6480?src=pr&el=footer). Last update [cb16e52...a8c1e14](https://codecov.io/gh/apache/skywalking/pull/6480?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6480: Remove unnecessary check for getSkyWalkingDynamicField invocation
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #6480:
URL: https://github.com/apache/skywalking/pull/6480#issuecomment-789727063
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org