You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@mesos.apache.org by Jiang Yan Xu <ya...@jxu.me> on 2013/05/14 20:14:55 UTC
Review Request: Improved Mesos C++ Style Guide.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/11162/
-----------------------------------------------------------
Review request for mesos, Benjamin Hindman, Vinod Kone, and Ben Mahler.
Description
-------
See summary.
Diffs
-----
docs/Mesos-c++-style-guide.md 98fe302ddc7ef1803450411f3a1a1d8f53b1329c
Diff: https://reviews.apache.org/r/11162/diff/
Testing
-------
N/A
Thanks,
Jiang Yan Xu
Re: Review Request: Improved Mesos C++ Style Guide.
Posted by Ben Mahler <be...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/11162/#review21284
-----------------------------------------------------------
Hm.. this review mixes changes of mesos and libprocess, can you split it up?
- Ben Mahler
On May 16, 2013, 7:17 a.m., Jiang Yan Xu wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/11162/
> -----------------------------------------------------------
>
> (Updated May 16, 2013, 7:17 a.m.)
>
>
> Review request for mesos, Benjamin Hindman, Vinod Kone, and Ben Mahler.
>
>
> Description
> -------
>
> See summary.
>
>
> Diffs
> -----
>
> docs/Mesos-c++-style-guide.md 98fe302ddc7ef1803450411f3a1a1d8f53b1329c
> src/launcher/executor.cpp 1a6725a8098d21bb813d66649257263b5e96136e
> src/slave/process_isolator.cpp 2224d62d7a9604032cc3ba2656849135540d6bd9
> third_party/libprocess/include/process/socket.hpp 669a3334629e15b420ea8332e31cd0306d52066b
> third_party/libprocess/src/encoder.hpp ec5e2717fddd0ffc1ea1bccce25652b67e723f7f
> third_party/libprocess/src/httpd.cpp 793a5b08f4a428074ae4c8d37b1c8fc92223ede3
> third_party/libprocess/src/net.hpp 2fdc62adc4295a7723da0162a60853bc64c7073c
> third_party/libprocess/src/process.cpp edcb684332590f0277bafb2d69de68413fc82828
>
> Diff: https://reviews.apache.org/r/11162/diff/
>
>
> Testing
> -------
>
> N/A
>
>
> Thanks,
>
> Jiang Yan Xu
>
>
Re: Review Request 11162: Improved Mesos C++ Style Guide.
Posted by Jiang Yan Xu <ya...@jxu.me>.
> On June 1, 2013, 1:47 a.m., Ben Mahler wrote:
> > docs/Mesos-c++-style-guide.md, line 15
> > <https://reviews.apache.org/r/11162/diff/3/?file=299736#file299736line15>
> >
> > s/Strings as logging or exception content/Strings used in log messages/
> >
> > What did you mean by exception?
Such as Future<Nothing>::failed("Something is wrong here"). I changed it to "error messages"
- Jiang Yan
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/11162/#review21286
-----------------------------------------------------------
On June 1, 2013, 1:20 a.m., Jiang Yan Xu wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/11162/
> -----------------------------------------------------------
>
> (Updated June 1, 2013, 1:20 a.m.)
>
>
> Review request for mesos, Benjamin Hindman, Ben Mahler, and Vinod Kone.
>
>
> Repository: mesos
>
>
> Description
> -------
>
> See summary.
>
>
> Diffs
> -----
>
> docs/Mesos-c++-style-guide.md 98fe302ddc7ef1803450411f3a1a1d8f53b1329c
>
> Diff: https://reviews.apache.org/r/11162/diff/
>
>
> Testing
> -------
>
> N/A
>
>
> Thanks,
>
> Jiang Yan Xu
>
>
Re: Review Request: Improved Mesos C++ Style Guide.
Posted by Ben Mahler <be...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/11162/#review21286
-----------------------------------------------------------
docs/Mesos-c++-style-guide.md
<https://reviews.apache.org/r/11162/#comment44161>
Use dashes here as you did below?
docs/Mesos-c++-style-guide.md
<https://reviews.apache.org/r/11162/#comment44162>
s/Strings as logging or exception content/Strings used in log messages/
What did you mean by exception?
docs/Mesos-c++-style-guide.md
<https://reviews.apache.org/r/11162/#comment44163>
I'm ok with this, but "elements" is fairly vague.. how about "classes, structs, global functions"?
- Ben Mahler
On June 1, 2013, 1:20 a.m., Jiang Yan Xu wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/11162/
> -----------------------------------------------------------
>
> (Updated June 1, 2013, 1:20 a.m.)
>
>
> Review request for mesos, Benjamin Hindman, Vinod Kone, and Ben Mahler.
>
>
> Description
> -------
>
> See summary.
>
>
> Diffs
> -----
>
> docs/Mesos-c++-style-guide.md 98fe302ddc7ef1803450411f3a1a1d8f53b1329c
>
> Diff: https://reviews.apache.org/r/11162/diff/
>
>
> Testing
> -------
>
> N/A
>
>
> Thanks,
>
> Jiang Yan Xu
>
>
Re: Review Request 11162: Improved Mesos C++ Style Guide.
Posted by Ben Mahler <be...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/11162/#review23672
-----------------------------------------------------------
Ship it!
I added a comment below but I'm going to just manually apply them as I commit this, thanks Yan!
docs/Mesos-c++-style-guide.md
<https://reviews.apache.org/r/11162/#comment47570>
For consistency, let's use the numbers instead of words, so:
s/One/1/
s/two/2/
s/one/1/
- Ben Mahler
On July 22, 2013, 11:14 p.m., Jiang Yan Xu wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/11162/
> -----------------------------------------------------------
>
> (Updated July 22, 2013, 11:14 p.m.)
>
>
> Review request for mesos, Benjamin Hindman, Ben Mahler, Dave Lester, and Vinod Kone.
>
>
> Bugs: MESOS-565
> https://issues.apache.org/jira/browse/MESOS-565
>
>
> Repository: mesos
>
>
> Description
> -------
>
> See summary.
>
>
> Diffs
> -----
>
> docs/Mesos-c++-style-guide.md 98fe302
>
> Diff: https://reviews.apache.org/r/11162/diff/
>
>
> Testing
> -------
>
> N/A
>
>
> Thanks,
>
> Jiang Yan Xu
>
>
Re: Review Request 11162: Improved Mesos C++ Style Guide.
Posted by Jiang Yan Xu <ya...@jxu.me>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/11162/
-----------------------------------------------------------
(Updated July 22, 2013, 11:14 p.m.)
Review request for mesos, Benjamin Hindman, Ben Mahler, Dave Lester, and Vinod Kone.
Changes
-------
Addressed BenM's comments.
Bugs: MESOS-565
https://issues.apache.org/jira/browse/MESOS-565
Repository: mesos
Description
-------
See summary.
Diffs (updated)
-----
docs/Mesos-c++-style-guide.md 98fe302
Diff: https://reviews.apache.org/r/11162/diff/
Testing
-------
N/A
Thanks,
Jiang Yan Xu
Re: Review Request: Improved Mesos C++ Style Guide.
Posted by Jiang Yan Xu <ya...@jxu.me>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/11162/
-----------------------------------------------------------
(Updated June 1, 2013, 1:20 a.m.)
Review request for mesos, Benjamin Hindman, Vinod Kone, and Ben Mahler.
Changes
-------
Rebased against master. Now it contains just a single file.
Description
-------
See summary.
Diffs (updated)
-----
docs/Mesos-c++-style-guide.md 98fe302ddc7ef1803450411f3a1a1d8f53b1329c
Diff: https://reviews.apache.org/r/11162/diff/
Testing
-------
N/A
Thanks,
Jiang Yan Xu
Re: Review Request: Improved Mesos C++ Style Guide.
Posted by Jiang Yan Xu <ya...@jxu.me>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/11162/
-----------------------------------------------------------
(Updated May 16, 2013, 7:17 a.m.)
Review request for mesos, Benjamin Hindman, Vinod Kone, and Ben Mahler.
Changes
-------
Edited the doc together with @vinodkone
Description
-------
See summary.
Diffs (updated)
-----
docs/Mesos-c++-style-guide.md 98fe302ddc7ef1803450411f3a1a1d8f53b1329c
src/launcher/executor.cpp 1a6725a8098d21bb813d66649257263b5e96136e
src/slave/process_isolator.cpp 2224d62d7a9604032cc3ba2656849135540d6bd9
third_party/libprocess/include/process/socket.hpp 669a3334629e15b420ea8332e31cd0306d52066b
third_party/libprocess/src/encoder.hpp ec5e2717fddd0ffc1ea1bccce25652b67e723f7f
third_party/libprocess/src/httpd.cpp 793a5b08f4a428074ae4c8d37b1c8fc92223ede3
third_party/libprocess/src/net.hpp 2fdc62adc4295a7723da0162a60853bc64c7073c
third_party/libprocess/src/process.cpp edcb684332590f0277bafb2d69de68413fc82828
Diff: https://reviews.apache.org/r/11162/diff/
Testing
-------
N/A
Thanks,
Jiang Yan Xu
Re: Review Request: Improved Mesos C++ Style Guide.
Posted by Vinod Kone <vi...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/11162/#review20629
-----------------------------------------------------------
Ship it!
thanks for updating this! much needed.
docs/Mesos-c++-style-guide.md
<https://reviews.apache.org/r/11162/#comment42523>
i think you can revert this. the previous was clear. any reason you wanted to rephrase?
docs/Mesos-c++-style-guide.md
<https://reviews.apache.org/r/11162/#comment42520>
"80 in code" doesn't really belong here.
how about a section called "line wrapping"?
for some inspiration on naming the sections you can take a look at eclipse's (C++ --> CodeStyle --> Formatter)
docs/Mesos-c++-style-guide.md
<https://reviews.apache.org/r/11162/#comment42521>
Not just class definitions but all outer elements. for eg: class methods declared outside the class should still be separated by 2 lines.
docs/Mesos-c++-style-guide.md
<https://reviews.apache.org/r/11162/#comment42522>
only if they are inside the class.
- Vinod Kone
On May 14, 2013, 6:14 p.m., Jiang Yan Xu wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/11162/
> -----------------------------------------------------------
>
> (Updated May 14, 2013, 6:14 p.m.)
>
>
> Review request for mesos, Benjamin Hindman, Vinod Kone, and Ben Mahler.
>
>
> Description
> -------
>
> See summary.
>
>
> Diffs
> -----
>
> docs/Mesos-c++-style-guide.md 98fe302ddc7ef1803450411f3a1a1d8f53b1329c
>
> Diff: https://reviews.apache.org/r/11162/diff/
>
>
> Testing
> -------
>
> N/A
>
>
> Thanks,
>
> Jiang Yan Xu
>
>