You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@brooklyn.apache.org by tbouron <gi...@git.apache.org> on 2016/04/06 16:51:34 UTC

[GitHub] brooklyn-ui pull request: Update editor placeholder

GitHub user tbouron opened a pull request:

    https://github.com/apache/brooklyn-ui/pull/24

    Update editor placeholder

    The text now makes it clear that users can use drag & drop to add text files' content into the editor
    
    ![brooklyn js rest client](https://cloud.githubusercontent.com/assets/2082759/14321019/5cc569c2-fc0f-11e5-9205-3d819f90e002.png)

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/tbouron/brooklyn-ui feature/drag-and-drop

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/brooklyn-ui/pull/24.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #24
    
----
commit fc4e814a99925966c5b85e92d8d821176b64c36b
Author: Thomas Bouron <th...@cloudsoftcorp.com>
Date:   2016-04-06T14:49:40Z

    Update placeholder text to make clear that users can use drag & drop to add text files' content into the editor

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] brooklyn-ui pull request: Update editor placeholder

Posted by tbouron <gi...@git.apache.org>.
Github user tbouron commented on the pull request:

    https://github.com/apache/brooklyn-ui/pull/24#issuecomment-206456324
  
    We will probably have to cheat as the textarea is hidden by CodeMirror. AFAIK, we can still bound to those events but from the CodeMirror container rather than the textarea.
    
    I'll investigate more tomorrow


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] brooklyn-ui pull request: Update editor placeholder

Posted by m4rkmckenna <gi...@git.apache.org>.
Github user m4rkmckenna commented on the pull request:

    https://github.com/apache/brooklyn-ui/pull/24#issuecomment-206444894
  
    LGTM
    
    **MINOR**
    * Might be worth adding styling for dragover
    * Might be worth verifying the type of the dropped file


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] brooklyn-ui pull request: Update editor placeholder

Posted by tbouron <gi...@git.apache.org>.
Github user tbouron commented on the pull request:

    https://github.com/apache/brooklyn-ui/pull/24#issuecomment-206447871
  
    The drag & drop feature is provided by CodeMirror. I'm not sure it can be customised, I'll need to check that.
    
    That being said, the content of the file is inserted where your cursor / mouse cursor drop the file, so having a classic overlay "drop file here" won't work here.



---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] brooklyn-ui pull request: Update editor placeholder

Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:

    https://github.com/apache/brooklyn-ui/pull/24


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] brooklyn-ui pull request: Update editor placeholder

Posted by m4rkmckenna <gi...@git.apache.org>.
Github user m4rkmckenna commented on the pull request:

    https://github.com/apache/brooklyn-ui/pull/24#issuecomment-206451829
  
    My thinking was binding to the dragenter / dragover / dragleave events from the textarea assuming the codemirror code propagates said events.
    
    Then adding / removing a class from the textarea OR changing the drag icon 


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---