You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@weex.apache.org by CYJB <gi...@git.apache.org> on 2018/03/28 11:45:18 UTC
[GitHub] incubator-weex pull request #1090: [WEEX-267][ios]monitor the frequency of m...
GitHub user CYJB opened a pull request:
https://github.com/apache/incubator-weex/pull/1090
[WEEX-267][ios]monitor the frequency of module invoke
Add new optional method for module invoke monitor, do not use alarm anymore.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/CYJB/incubator-weex WEEX-267
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/incubator-weex/pull/1090.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #1090
----
commit 2c17b279c43a6e8d0b802f20c9f3db9b4d7ee769
Author: CYJB <f8...@...>
Date: 2018-03-28T11:43:32Z
[WEEX-267][ios]monitor the frequency of module invoke
Add new optional method for module invoke monitor, do not use alarm anymore.
----
---
[GitHub] incubator-weex pull request #1090: [WEEX-267][ios]monitor the frequency of m...
Posted by acton393 <gi...@git.apache.org>.
Github user acton393 commented on a diff in the pull request:
https://github.com/apache/incubator-weex/pull/1090#discussion_r177722055
--- Diff: ios/sdk/WeexSDK/Sources/Protocol/WXAppMonitorProtocol.h ---
@@ -54,4 +54,8 @@
- (void)commitAppMonitorAlarm:(NSString *)pageName monitorPoint:(NSString *)monitorPoint success:(BOOL)success errorCode:(NSString *)errorCode errorMsg:(NSString *)errorMsg arg:(NSString *)arg;
+@optional
+
+- (void)commitMonitorWithPage:(NSString *)pageName withPoint:(NSString *)monitorPoint withArgs:(NSDictionary *)args;
--- End diff --
maybe
` - (void)commitMonitorWithPage:(NSString *)pageName monitorPoint:(NSString *)monitorPoint args:(NSDictionary *)args `
is better?
---
[GitHub] incubator-weex issue #1090: [WEEX-267][ios]monitor the frequency of module i...
Posted by weex-bot <gi...@git.apache.org>.
Github user weex-bot commented on the issue:
https://github.com/apache/incubator-weex/pull/1090
<!--
0 failure:
0 warning:
2 messages
-->
<table>
<thead>
<tr>
<th width="50"></th>
<th width="100%" data-danger-table="true">Messages</th>
</tr>
</thead>
<tbody><tr>
<td>:book:</td>
<td>has no jsfm file changed.</td>
</tr>
<tr>
<td>:book:</td>
<td>jsfm test finished.</td>
</tr>
</tbody>
</table>
<p align="right">
Generated by :no_entry_sign: <a href="http://github.com/danger/danger-js/">dangerJS</a>
</p>
---
[GitHub] incubator-weex pull request #1090: [WEEX-267][ios]monitor the frequency of m...
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/incubator-weex/pull/1090
---
[GitHub] incubator-weex pull request #1090: [WEEX-267][ios]monitor the frequency of m...
Posted by CYJB <gi...@git.apache.org>.
Github user CYJB commented on a diff in the pull request:
https://github.com/apache/incubator-weex/pull/1090#discussion_r177723438
--- Diff: ios/sdk/WeexSDK/Sources/Protocol/WXAppMonitorProtocol.h ---
@@ -54,4 +54,8 @@
- (void)commitAppMonitorAlarm:(NSString *)pageName monitorPoint:(NSString *)monitorPoint success:(BOOL)success errorCode:(NSString *)errorCode errorMsg:(NSString *)errorMsg arg:(NSString *)arg;
+@optional
+
+- (void)commitMonitorWithPage:(NSString *)pageName withPoint:(NSString *)monitorPoint withArgs:(NSDictionary *)args;
--- End diff --
Yes, that is better
---