You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@arrow.apache.org by GitBox <gi...@apache.org> on 2022/08/25 14:03:04 UTC
[GitHub] [arrow-rs] tustvold opened a new pull request, #2590: ObjectStore cleanup (#2587)
tustvold opened a new pull request, #2590:
URL: https://github.com/apache/arrow-rs/pull/2590
# Which issue does this PR close?
<!--
We generally require a GitHub issue to be filed for all bug fixes and enhancements and this helps us generate change logs for our releases. You can link an issue to this PR using the GitHub syntax. For example `Closes #123` indicates that this PR will close issue #123.
-->
Closes #2587
# Rationale for this change
<!--
Why are you proposing this change? If this is already explained clearly in the issue then this section is not needed.
Explaining clearly why changes are proposed helps reviewers understand your changes and offer better suggestions for fixes.
-->
Fixes compilation errors and warnings when building with only a subset of the features
# What changes are included in this PR?
<!--
There is no need to duplicate the description in the issue here but it is sometimes worth providing a summary of the individual changes in this PR.
-->
Splits the oauth module into credential modules for the various object stores
# Are there any user-facing changes?
<!--
If there are user-facing changes then we may require documentation to be updated before approving the PR.
-->
<!---
If there are any breaking changes to public APIs, please add the `breaking change` label.
-->
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow-rs] tustvold commented on pull request #2590: ObjectStore cleanup (#2587)
Posted by GitBox <gi...@apache.org>.
tustvold commented on PR #2590:
URL: https://github.com/apache/arrow-rs/pull/2590#issuecomment-1227461750
@roeap perhaps you would be able to give this a review?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow-rs] tustvold commented on a diff in pull request #2590: ObjectStore cleanup (#2587)
Posted by GitBox <gi...@apache.org>.
tustvold commented on code in PR #2590:
URL: https://github.com/apache/arrow-rs/pull/2590#discussion_r955011191
##########
object_store/src/client/mod.rs:
##########
@@ -18,8 +18,6 @@
//! Generic utilities reqwest based ObjectStore implementations
pub mod backoff;
-#[cfg(any(feature = "gcp", feature = "azure"))]
-pub mod oauth;
Review Comment:
The original hope of this module was that it would allow sharing code between the implementations, it transpires this isn't actually possible, so we might as well just split the module apart
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow-rs] ursabot commented on pull request #2590: ObjectStore cleanup (#2587)
Posted by GitBox <gi...@apache.org>.
ursabot commented on PR #2590:
URL: https://github.com/apache/arrow-rs/pull/2590#issuecomment-1229227871
Benchmark runs are scheduled for baseline = 744412f751d926311851c30e7271e3f4f14757f7 and contender = 86446ea88b6fc3e11b47aeedb9eb24f4d69b2f13. 86446ea88b6fc3e11b47aeedb9eb24f4d69b2f13 is a master commit associated with this PR. Results will be available as each benchmark for each run completes.
Conbench compare runs links:
[Skipped :warning: Benchmarking of arrow-rs-commits is not supported on ec2-t3-xlarge-us-east-2] [ec2-t3-xlarge-us-east-2](https://conbench.ursa.dev/compare/runs/27951bf85bf94629b5577bf43a5dcfd4...537bc841557d435984278cafdfcf053b/)
[Skipped :warning: Benchmarking of arrow-rs-commits is not supported on test-mac-arm] [test-mac-arm](https://conbench.ursa.dev/compare/runs/7f7e64cdc9af4ced868b160c083082a4...5371220f472544eb8a4a05711dd91c81/)
[Skipped :warning: Benchmarking of arrow-rs-commits is not supported on ursa-i9-9960x] [ursa-i9-9960x](https://conbench.ursa.dev/compare/runs/168d0ce24cdb4772b73f73ecc700a9b3...9cb6a523b7414caf8abb3041a6f231e9/)
[Skipped :warning: Benchmarking of arrow-rs-commits is not supported on ursa-thinkcentre-m75q] [ursa-thinkcentre-m75q](https://conbench.ursa.dev/compare/runs/2830a483738e447ab1f66e82354bc4ef...405489af60884a91bb24b79b8aef6988/)
Buildkite builds:
Supported benchmarks:
ec2-t3-xlarge-us-east-2: Supported benchmark langs: Python, R. Runs only benchmarks with cloud = True
test-mac-arm: Supported benchmark langs: C++, Python, R
ursa-i9-9960x: Supported benchmark langs: Python, R, JavaScript
ursa-thinkcentre-m75q: Supported benchmark langs: C++, Java
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow-rs] tustvold merged pull request #2590: ObjectStore cleanup (#2587)
Posted by GitBox <gi...@apache.org>.
tustvold merged PR #2590:
URL: https://github.com/apache/arrow-rs/pull/2590
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow-rs] roeap commented on a diff in pull request #2590: ObjectStore cleanup (#2587)
Posted by GitBox <gi...@apache.org>.
roeap commented on code in PR #2590:
URL: https://github.com/apache/arrow-rs/pull/2590#discussion_r956576932
##########
object_store/src/client/mod.rs:
##########
@@ -18,8 +18,6 @@
//! Generic utilities reqwest based ObjectStore implementations
pub mod backoff;
-#[cfg(any(feature = "gcp", feature = "azure"))]
-pub mod oauth;
Review Comment:
makes absolute sense. I have not yet lost all hope, as we may be able to share for equivalent auth methods. I.e. I am hoping to add certificate based auth as in gcp, as well as managed / workload identity that should be similar to what aws is doing with the ec2 instance like stuff. But we'll see how that works out.
##########
object_store/src/azure/credential.rs:
##########
@@ -38,6 +43,18 @@ pub(crate) static DELETE_SNAPSHOTS: HeaderName =
pub(crate) static COPY_SOURCE: HeaderName = HeaderName::from_static("x-ms-copy-source");
static CONTENT_MD5: HeaderName = HeaderName::from_static("content-md5");
pub(crate) static RFC1123_FMT: &str = "%a, %d %h %Y %T GMT";
+const CONTENT_TYPE_JSON: &str = "application/json";
+
+#[derive(Debug, Snafu)]
+pub enum Error {
Review Comment:
More of a general question, since recently I have been wondering what errors should look like. Thus far I very much like the approach taken in object_store, having very specific errors internal to the modules, and surfacing it all in a single error type to the user. Users might still work with this local error via downcasting the genric type in the Generic folder, but i was wondering if the approach should be to make al interna errors private to the crate, and have top level variants, for everything we think the consumer might handle specifically.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow-rs] roeap commented on pull request #2590: ObjectStore cleanup (#2587)
Posted by GitBox <gi...@apache.org>.
roeap commented on PR #2590:
URL: https://github.com/apache/arrow-rs/pull/2590#issuecomment-1228155563
I would! Currently still traveling, but should get it done this we.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow-rs] tustvold commented on a diff in pull request #2590: ObjectStore cleanup (#2587)
Posted by GitBox <gi...@apache.org>.
tustvold commented on code in PR #2590:
URL: https://github.com/apache/arrow-rs/pull/2590#discussion_r956581908
##########
object_store/src/azure/credential.rs:
##########
@@ -38,6 +43,18 @@ pub(crate) static DELETE_SNAPSHOTS: HeaderName =
pub(crate) static COPY_SOURCE: HeaderName = HeaderName::from_static("x-ms-copy-source");
static CONTENT_MD5: HeaderName = HeaderName::from_static("content-md5");
pub(crate) static RFC1123_FMT: &str = "%a, %d %h %Y %T GMT";
+const CONTENT_TYPE_JSON: &str = "application/json";
+
+#[derive(Debug, Snafu)]
+pub enum Error {
Review Comment:
That is definitely the approach, this module is crate private and therefore so is the error.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow-rs] tustvold commented on pull request #2590: ObjectStore cleanup (#2587)
Posted by GitBox <gi...@apache.org>.
tustvold commented on PR #2590:
URL: https://github.com/apache/arrow-rs/pull/2590#issuecomment-1229192430
I intend to move the module as a follow up, I didn't to avoid messing up the diff (GitHub's UI is not very smart)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow-rs] tustvold commented on a diff in pull request #2590: ObjectStore cleanup (#2587)
Posted by GitBox <gi...@apache.org>.
tustvold commented on code in PR #2590:
URL: https://github.com/apache/arrow-rs/pull/2590#discussion_r955011191
##########
object_store/src/client/mod.rs:
##########
@@ -18,8 +18,6 @@
//! Generic utilities reqwest based ObjectStore implementations
pub mod backoff;
-#[cfg(any(feature = "gcp", feature = "azure"))]
-pub mod oauth;
Review Comment:
The original hope of this module was that it would allow sharing code between the implementations, it transpires this isn't actually possible, so we might as well just split the module apart and avoid having to feature flag various things
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org