[GitHub] [kylin] xiacongling commented on a change in pull request #1163: KYLIN-4423 fix bug: null input for EncryptUtil raise IllegalArgumentException

[GitBox <gi...@apache.org>]

xiacongling commented on a change in pull request #1163: KYLIN-4423 fix bug: null input for EncryptUtil raise IllegalArgumentException
URL: https://github.com/apache/kylin/pull/1163#discussion_r393752193
 
 

 ##########
 File path: core-common/src/main/java/org/apache/kylin/common/util/EncryptUtil.java
 ##########
 @@ -32,6 +32,9 @@
             0x65, 0x79 };
 
     public static String encrypt(String strToEncrypt) {
+        if (strToEncrypt == null) {
 
 Review comment:
   Hi, zzcclp:
   Thanks for the suggestion. But actually, a blank string can be encrypted and its cypher text is not a blank string. 
   e.g. result of EncryptUtil.encrypt("") is "719bTBvphWewRiCiCj3D/A=="
   So only null check is needed, I think.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services