You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@servicemix.apache.org by "Sergiy Mamitko (JIRA)" <ji...@apache.org> on 2009/12/22 17:55:41 UTC

[jira] Created: (SM-1920) Deployment/Undeployment troubles if one of already deployed SU doesn't contain xbean.xml file in serviceUnitRootPath

Deployment/Undeployment troubles if one of already deployed SU doesn't contain xbean.xml file in serviceUnitRootPath
--------------------------------------------------------------------------------------------------------------------

                 Key: SM-1920
                 URL: https://issues.apache.org/activemq/browse/SM-1920
             Project: ServiceMix
          Issue Type: Bug
          Components: servicemix-core
    Affects Versions: 3.3.1
            Reporter: Sergiy Mamitko


If for some unknown reasons file xbean.xml was removed from deployed SU (from serviceUnitRootPath) then it is impossible to remove a whole SA without forther troubles.
Looking into sources there is Deployer.canDeploy method which is used in implementations for doDeploy and for doUndeploy. But if xbean.xml is necessary for deployment why it is need for undeployment process. 
Moreover if xbean is absent, then SU will not be unregistered from component and it will be impossible to redeploy the same SA.


-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Commented: (SM-1920) Deployment/Undeployment troubles if one of already deployed SU doesn't contain xbean.xml file in serviceUnitRootPath

Posted by "Sergiy Mamitko (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/activemq/browse/SM-1920?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=56637#action_56637 ] 

Sergiy Mamitko commented on SM-1920:
------------------------------------

Hi Freeman,

The situation is not exactly in xbean.xml but in implementation of Deployer interface and class BaseServiceUnitManager. Why last one asks Deployer for possibility to deploy when really going to perform undeploy? Maybe Deployer interface need method canUndeploy()?

Yes, it is possible to remove data folder, but it will not clean up some registries without restarting servicemix. Restart of SMX is not accepted in our scenarious.
That is why during next deployment (Now I copy SA *.zip to install or hotdeploy folder) SA will not be installed successfully because it is already registered (or some SU already registered).

So, question is how to successfully undeploy or redeploy SA without restart of SMX if some registries were not cleaned up successfully?

Sergiy M

> Deployment/Undeployment troubles if one of already deployed SU doesn't contain xbean.xml file in serviceUnitRootPath
> --------------------------------------------------------------------------------------------------------------------
>
>                 Key: SM-1920
>                 URL: https://issues.apache.org/activemq/browse/SM-1920
>             Project: ServiceMix
>          Issue Type: Bug
>          Components: servicemix-core
>    Affects Versions: 3.3.1
>            Reporter: Sergiy Mamitko
>            Assignee: Freeman Fang
>
> If for some unknown reasons file xbean.xml was removed from deployed SU (from serviceUnitRootPath) then it is impossible to remove a whole SA without forther troubles.
> Looking into sources there is Deployer.canDeploy method which is used in implementations for doDeploy and for doUndeploy. But if xbean.xml is necessary for deployment why it is need for undeployment process. 
> Moreover if xbean is absent, then SU will not be unregistered from component and it will be impossible to redeploy the same SA.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Assigned: (SM-1920) Deployment/Undeployment troubles if one of already deployed SU doesn't contain xbean.xml file in serviceUnitRootPath

Posted by "Freeman Fang (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/activemq/browse/SM-1920?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Freeman Fang reassigned SM-1920:
--------------------------------

    Assignee: Freeman Fang

> Deployment/Undeployment troubles if one of already deployed SU doesn't contain xbean.xml file in serviceUnitRootPath
> --------------------------------------------------------------------------------------------------------------------
>
>                 Key: SM-1920
>                 URL: https://issues.apache.org/activemq/browse/SM-1920
>             Project: ServiceMix
>          Issue Type: Bug
>          Components: servicemix-core
>    Affects Versions: 3.3.1
>            Reporter: Sergiy Mamitko
>            Assignee: Freeman Fang
>
> If for some unknown reasons file xbean.xml was removed from deployed SU (from serviceUnitRootPath) then it is impossible to remove a whole SA without forther troubles.
> Looking into sources there is Deployer.canDeploy method which is used in implementations for doDeploy and for doUndeploy. But if xbean.xml is necessary for deployment why it is need for undeployment process. 
> Moreover if xbean is absent, then SU will not be unregistered from component and it will be impossible to redeploy the same SA.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Resolved: (SM-1920) Deployment/Undeployment troubles if one of already deployed SU doesn't contain xbean.xml file in serviceUnitRootPath

Posted by "Freeman Fang (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/activemq/browse/SM-1920?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Freeman Fang resolved SM-1920.
------------------------------

    Resolution: Working as Designed

> Deployment/Undeployment troubles if one of already deployed SU doesn't contain xbean.xml file in serviceUnitRootPath
> --------------------------------------------------------------------------------------------------------------------
>
>                 Key: SM-1920
>                 URL: https://issues.apache.org/activemq/browse/SM-1920
>             Project: ServiceMix
>          Issue Type: Bug
>          Components: servicemix-core
>    Affects Versions: 3.3.1
>            Reporter: Sergiy Mamitko
>            Assignee: Freeman Fang
>
> If for some unknown reasons file xbean.xml was removed from deployed SU (from serviceUnitRootPath) then it is impossible to remove a whole SA without forther troubles.
> Looking into sources there is Deployer.canDeploy method which is used in implementations for doDeploy and for doUndeploy. But if xbean.xml is necessary for deployment why it is need for undeployment process. 
> Moreover if xbean is absent, then SU will not be unregistered from component and it will be impossible to redeploy the same SA.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Commented: (SM-1920) Deployment/Undeployment troubles if one of already deployed SU doesn't contain xbean.xml file in serviceUnitRootPath

Posted by "Freeman Fang (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/activemq/browse/SM-1920?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=56631#action_56631 ] 

Freeman Fang commented on SM-1920:
----------------------------------

Hi Sergiy,

I don't think this is a bug.
the xbean.xml is also very useful for undeployment as this give us opportunity to clean up some resources which init from this spring bean.
You can't only remove some xbean.xml from data folder, as this will damage the integrity of deployed artifact, but you can remove data folder as a whole to get a clean enviorment.

Freeman

> Deployment/Undeployment troubles if one of already deployed SU doesn't contain xbean.xml file in serviceUnitRootPath
> --------------------------------------------------------------------------------------------------------------------
>
>                 Key: SM-1920
>                 URL: https://issues.apache.org/activemq/browse/SM-1920
>             Project: ServiceMix
>          Issue Type: Bug
>          Components: servicemix-core
>    Affects Versions: 3.3.1
>            Reporter: Sergiy Mamitko
>            Assignee: Freeman Fang
>
> If for some unknown reasons file xbean.xml was removed from deployed SU (from serviceUnitRootPath) then it is impossible to remove a whole SA without forther troubles.
> Looking into sources there is Deployer.canDeploy method which is used in implementations for doDeploy and for doUndeploy. But if xbean.xml is necessary for deployment why it is need for undeployment process. 
> Moreover if xbean is absent, then SU will not be unregistered from component and it will be impossible to redeploy the same SA.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Commented: (SM-1920) Deployment/Undeployment troubles if one of already deployed SU doesn't contain xbean.xml file in serviceUnitRootPath

Posted by "Freeman Fang (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/activemq/browse/SM-1920?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=56638#action_56638 ] 

Freeman Fang commented on SM-1920:
----------------------------------

Hi Sergiy,

Of course you can redeploy your SA without restart the smx container.
If you copy SA to the hotdeploy folder, it will first undeploy and then deploy.
The error you saw I believe comes from the xbean.xml removed from data folder, which means the integrity of installed artifacts get damaged, which shouldn't happen at all.

Regards
Freeman

> Deployment/Undeployment troubles if one of already deployed SU doesn't contain xbean.xml file in serviceUnitRootPath
> --------------------------------------------------------------------------------------------------------------------
>
>                 Key: SM-1920
>                 URL: https://issues.apache.org/activemq/browse/SM-1920
>             Project: ServiceMix
>          Issue Type: Bug
>          Components: servicemix-core
>    Affects Versions: 3.3.1
>            Reporter: Sergiy Mamitko
>            Assignee: Freeman Fang
>
> If for some unknown reasons file xbean.xml was removed from deployed SU (from serviceUnitRootPath) then it is impossible to remove a whole SA without forther troubles.
> Looking into sources there is Deployer.canDeploy method which is used in implementations for doDeploy and for doUndeploy. But if xbean.xml is necessary for deployment why it is need for undeployment process. 
> Moreover if xbean is absent, then SU will not be unregistered from component and it will be impossible to redeploy the same SA.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Commented: (SM-1920) Deployment/Undeployment troubles if one of already deployed SU doesn't contain xbean.xml file in serviceUnitRootPath

Posted by "Sergiy Mamitko (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/activemq/browse/SM-1920?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=56641#action_56641 ] 

Sergiy Mamitko commented on SM-1920:
------------------------------------

Hello, Freeman

Can you take a look at the BaseServiceUnitManager.undeploy()  and swap next two rows

            if (serviceUnitRootPath != null) { doUndeploy(su);  }
            component.getRegistry().unregisterServiceUnit(su);

If it is impossible then can you tell why registering performed after deployment and unregistering performed after undeployment?
Are resources should not release in vice versa way to initialization process?

Thanks, 
Sergiy

> Deployment/Undeployment troubles if one of already deployed SU doesn't contain xbean.xml file in serviceUnitRootPath
> --------------------------------------------------------------------------------------------------------------------
>
>                 Key: SM-1920
>                 URL: https://issues.apache.org/activemq/browse/SM-1920
>             Project: ServiceMix
>          Issue Type: Bug
>          Components: servicemix-core
>    Affects Versions: 3.3.1
>            Reporter: Sergiy Mamitko
>            Assignee: Freeman Fang
>
> If for some unknown reasons file xbean.xml was removed from deployed SU (from serviceUnitRootPath) then it is impossible to remove a whole SA without forther troubles.
> Looking into sources there is Deployer.canDeploy method which is used in implementations for doDeploy and for doUndeploy. But if xbean.xml is necessary for deployment why it is need for undeployment process. 
> Moreover if xbean is absent, then SU will not be unregistered from component and it will be impossible to redeploy the same SA.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.