[GitHub] [spark] HeartSaVioR commented on a change in pull request #27747: [SPARK-30993][SQL] Use its sql type for UDT when checking the type of length (fixed/var) or mutable

[GitBox <gi...@apache.org>]

HeartSaVioR commented on a change in pull request #27747: [SPARK-30993][SQL] Use its sql type for UDT when checking the type of length (fixed/var) or mutable
URL: https://github.com/apache/spark/pull/27747#discussion_r386154074
 
 

 ##########
 File path: sql/catalyst/src/test/scala/org/apache/spark/sql/catalyst/expressions/codegen/GenerateUnsafeRowJoinerSuite.scala
 ##########
 @@ -99,6 +101,23 @@ class GenerateUnsafeRowJoinerSuite extends SparkFunSuite {
     testConcatOnce(N, N, variable)
   }
 
+  test("SPARK-30993: UserDefinedType matched to fixed length SQL type shouldn't be corrupted") {
 
 Review comment:
   Actually I missed the existence of SPARK-30986 and created SPARK-30993. I left my issue as it is, because SPARK-30986 is describing only one of issue SPARK-30993 could incur - SPARK-30993 has a broader coverage.
   
   I can maybe add E2E test for SPARK-30986 here (though not sure we want to use two JIRA issues here), but wondering is it preferable to add SS test if it can be reproduced in batch query test. From my side it's easier to add SS test, because SPARK-30986 has it - just need to refine a bit.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org