You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@cloudstack.apache.org by Marcus Sorensen <sh...@gmail.com> on 2012/10/12 23:16:33 UTC

Review Request: re-add configure-info and sccs-info to cloud.spec

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/7570/
-----------------------------------------------------------

Review request for cloudstack and Chip Childers.


Description
-------

This fixes the git build. Does this break the tarball build?


This addresses bug CLOUDSTACK-329.


Diffs
-----

  cloud.spec 7e31edf 

Diff: https://reviews.apache.org/r/7570/diff/


Testing
-------

built fresh RPMs from current git repo code


Thanks,

Marcus Sorensen


Re: Review Request: re-add configure-info and sccs-info to cloud.spec

Posted by edison su <ed...@citrix.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/7570/#review12407
-----------------------------------------------------------


Oops, David deliberately deletes sccs-info, as "waf rpm" doesn't work, if there is no git info in the source code. It breaks the rpm/deb build in our release tar ball. David will comment out build_utils_docs in wscript_build, then this issue will go away.

- edison su


On Oct. 12, 2012, 9:16 p.m., Marcus Sorensen wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/7570/
> -----------------------------------------------------------
> 
> (Updated Oct. 12, 2012, 9:16 p.m.)
> 
> 
> Review request for cloudstack and Chip Childers.
> 
> 
> Description
> -------
> 
> This fixes the git build. Does this break the tarball build?
> 
> 
> This addresses bug CLOUDSTACK-329.
> 
> 
> Diffs
> -----
> 
>   cloud.spec 7e31edf 
> 
> Diff: https://reviews.apache.org/r/7570/diff/
> 
> 
> Testing
> -------
> 
> built fresh RPMs from current git repo code
> 
> 
> Thanks,
> 
> Marcus Sorensen
> 
>