[GitHub] [iceberg] aokolnychyi commented on a change in pull request #1955: Spark: Sort retained rows in DELETE FROM by file and position

[GitBox <gi...@apache.org>]

aokolnychyi commented on a change in pull request #1955:
URL: https://github.com/apache/iceberg/pull/1955#discussion_r545694599



##########
File path: core/src/main/java/org/apache/iceberg/MetadataColumns.java
##########
@@ -55,4 +55,16 @@ private MetadataColumns() {
   public static Set<Integer> metadataFieldIds() {
     return META_IDS;
   }
+
+  public static NestedField get(String name) {
+    return META_COLUMNS.get(name);
+  }
+
+  public static boolean isMetadataColumn(String name) {
+    return META_COLUMNS.containsKey(name);
+  }
+
+  public static boolean nonMetadataColumn(String name) {

Review comment:
       nit: should it be `isNonMetadataColumn` to indicate it is a boolean flag?




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org