[GitHub] [maven] xstefank commented on a diff in pull request #1178: [MNG-7818] Removed exclusion of hamcrest from junit 4

["xstefank (via GitHub)" <gi...@apache.org>]

xstefank commented on code in PR #1178:
URL: https://github.com/apache/maven/pull/1178#discussion_r1238029877


##########
pom.xml:
##########
@@ -525,20 +526,20 @@ under the License.
       <dependency>
         <groupId>org.hamcrest</groupId>
         <artifactId>hamcrest</artifactId>
-        <version>2.2</version>
+        <version>${hamcrestVersion}</version>
+        <scope>test</scope>
+      </dependency>
+      <dependency>
+        <groupId>org.hamcrest</groupId>
+        <artifactId>hamcrest-core</artifactId>
+        <version>${hamcrestVersion}</version>
         <scope>test</scope>
       </dependency>
       <dependency>
         <groupId>junit</groupId>
         <artifactId>junit</artifactId>
         <version>${junitVersion}</version>
         <scope>test</scope>
-        <exclusions>

Review Comment:
   Shouldn't you actually keep the exclusion to not pull older version of hamcrest that conflicts with the one you defined on the top level?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org