(shardingsphere) branch master updated: Add more test cases for Grantee (#33242)

[du...@apache.org]

This is an automated email from the ASF dual-hosted git repository.

duanzhengqiang pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/shardingsphere.git


The following commit(s) were added to refs/heads/master by this push:
     new 56bb60eab72 Add more test cases for Grantee (#33242)
56bb60eab72 is described below

commit 56bb60eab72b69388c8261a7498624f2f543cb5a
Author: Liang Zhang <zh...@apache.org>
AuthorDate: Mon Oct 14 14:53:09 2024 +0800

    Add more test cases for Grantee (#33242)
---
 .../infra/metadata/user/GranteeTest.java           | 39 +++++++++++++---------
 1 file changed, 24 insertions(+), 15 deletions(-)

diff --git a/infra/common/src/test/java/org/apache/shardingsphere/infra/metadata/user/GranteeTest.java b/infra/common/src/test/java/org/apache/shardingsphere/infra/metadata/user/GranteeTest.java
index c4ccb730503..55ff8718f38 100644
--- a/infra/common/src/test/java/org/apache/shardingsphere/infra/metadata/user/GranteeTest.java
+++ b/infra/common/src/test/java/org/apache/shardingsphere/infra/metadata/user/GranteeTest.java
@@ -22,32 +22,48 @@ import org.junit.jupiter.api.Test;
 import static org.hamcrest.CoreMatchers.is;
 import static org.hamcrest.CoreMatchers.not;
 import static org.hamcrest.MatcherAssert.assertThat;
+import static org.junit.jupiter.api.Assertions.assertFalse;
 import static org.junit.jupiter.api.Assertions.assertTrue;
 
 class GranteeTest {
     
     @Test
-    void assertGetUsername() {
-        assertThat(new Grantee("foo", "").getUsername(), is("foo"));
+    void assertAccept() {
+        Grantee grantee = new Grantee("name", "%");
+        assertTrue(grantee.accept(new Grantee("name", "")));
+        assertTrue(grantee.accept(new Grantee("name", "127.0.0.1")));
     }
     
     @Test
-    void assertGetHostname() {
-        assertThat(new Grantee("name", "%").getHostname(), is("%"));
-        assertThat(new Grantee("name", "").getHostname(), is("%"));
+    void assertNotAcceptWithDifferentUsername() {
+        assertFalse(new Grantee("name", "%").accept(new Grantee("name1", "")));
+    }
+    
+    @Test
+    void assertNotAcceptWithoutPermittedHost() {
+        assertFalse(new Grantee("name", "127.0.0.1").accept(new Grantee("name", "127.0.0.2")));
     }
     
     @Test
     void assertEquals() {
-        Grantee grantee = new Grantee("name", "%");
-        assertThat(grantee, is(new Grantee("name", "")));
+        assertThat(new Grantee("name", "%"), is(new Grantee("NAME", "")));
     }
     
     @Test
-    void assertNotEquals() {
+    void assertNotEqualsWithDifferentClassTypes() {
         assertThat(new Grantee("name", "%"), not(new Object()));
     }
     
+    @Test
+    void assertNotEqualsWithDifferentUsername() {
+        assertThat(new Grantee("name", "%"), not(new Grantee("name1", "%")));
+    }
+    
+    @Test
+    void assertNotEqualsWithDifferentHostname() {
+        assertThat(new Grantee("name", "%"), not(new Grantee("name", "127.0.0.1")));
+    }
+    
     @Test
     void assertSameHashCode() {
         assertThat(new Grantee("name", "%").hashCode(), is(new Grantee("name", "").hashCode()));
@@ -58,13 +74,6 @@ class GranteeTest {
         assertThat(new Grantee("name", "").hashCode(), not(new Grantee("name", "127.0.0.1").hashCode()));
     }
     
-    @Test
-    void assertAccept() {
-        Grantee grantee = new Grantee("name", "%");
-        assertTrue(grantee.accept(new Grantee("name", "")));
-        assertTrue(grantee.accept(new Grantee("name", "127.0.0.1")));
-    }
-    
     @Test
     void assertToString() {
         assertThat(new Grantee("name").toString(), is("name@%"));