You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@maven.apache.org by GitBox <gi...@apache.org> on 2023/01/11 07:54:20 UTC
[GitHub] [maven] psiroky opened a new pull request, #951: Jenkinsfile: pickup results from ITs
psiroky opened a new pull request, #951:
URL: https://github.com/apache/maven/pull/951
* trying to make Jenkins pick-up the IT results - currently, if some of the ITs fail, Jenkins won't pick-up the results and the build would be "green"
* not 100% sure this is the fix though, I have no way of testing this locally so will rely on the PR builds
Following this checklist to help us incorporate your
contribution quickly and easily:
- [ ] Make sure there is a [JIRA issue](https://issues.apache.org/jira/browse/MNG) filed
for the change (usually before you start working on it). Trivial changes like typos do not
require a JIRA issue. Your pull request should address just this issue, without
pulling in other changes.
- [x] Each commit in the pull request should have a meaningful subject line and body.
- [ ] Format the pull request title like `[MNG-XXX] SUMMARY`,
where you replace `MNG-XXX` and `SUMMARY` with the appropriate JIRA issue.
- [ ] Also format the first line of the commit message like `[MNG-XXX] SUMMARY`.
Best practice is to use the JIRA issue title in both the pull request title and in the first line of the commit message.
- [x] Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
- [] Run `mvn clean verify` to make sure basic checks pass. A more thorough check will
be performed on your pull request automatically.
- [] You have run the [Core IT][core-its] successfully.
If your pull request is about ~20 lines of code you don't need to sign an
[Individual Contributor License Agreement](https://www.apache.org/licenses/icla.pdf) if you are unsure
please ask on the developers list.
To make clear that you license your contribution under
the [Apache License Version 2.0, January 2004](http://www.apache.org/licenses/LICENSE-2.0)
you have to acknowledge this by using the following check-box.
- [x] I hereby declare this contribution to be licenced under the [Apache License Version 2.0, January 2004](http://www.apache.org/licenses/LICENSE-2.0)
- [x] In any other case, please file an [Apache Individual Contributor License Agreement](https://www.apache.org/licenses/icla.pdf).
[core-its]: https://maven.apache.org/core-its/core-it-suite/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [maven] psiroky commented on pull request #951: Jenkinsfile: pickup results from ITs
Posted by GitBox <gi...@apache.org>.
psiroky commented on PR #951:
URL: https://github.com/apache/maven/pull/951#issuecomment-1378479188
I noticed there is also [Jenkinsfile.its](https://github.com/apache/maven/blob/master/Jenkinsfile.its) which seems unused? Should it be just removed, or am I missing the usage somewhere?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [maven] slawekjaranowski commented on a diff in pull request #951: Jenkinsfile: pickup results from ITs
Posted by GitBox <gi...@apache.org>.
slawekjaranowski commented on code in PR #951:
URL: https://github.com/apache/maven/pull/951#discussion_r1066690933
##########
Jenkinsfile:
##########
@@ -112,7 +112,7 @@ for (String os in runITsOses) {
}
}
} finally {
- //junit testResults: '**/core-it-suite/**/target/surefire-reports/*.xml', allowEmptyResults: true
+ junit testResults: '**/core-it-suite/**/target/surefire-reports/*.xml', allowEmptyResults: true
Review Comment:
What with standard path, like `**target/surefire-reports/*.xml` and for failsafe?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [maven] psiroky commented on a diff in pull request #951: Jenkinsfile: pickup results from ITs
Posted by GitBox <gi...@apache.org>.
psiroky commented on code in PR #951:
URL: https://github.com/apache/maven/pull/951#discussion_r1066726575
##########
Jenkinsfile:
##########
@@ -112,7 +112,7 @@ for (String os in runITsOses) {
}
}
} finally {
- //junit testResults: '**/core-it-suite/**/target/surefire-reports/*.xml', allowEmptyResults: true
+ junit testResults: '**/core-it-suite/**/target/surefire-reports/*.xml', allowEmptyResults: true
Review Comment:
I am not sure. I assumed these patterns were tested before and it the junit step was accidentally left commented out.
I think we could go with `**target/surefire-reports/*.xml`. It will pick-up some test results from `core-it-support`, but that may be desirable.
There are no `failsafe-reports` directories right now, but to be safe we could include those as well.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [maven] slawekjaranowski closed pull request #951: Jenkinsfile: pickup results from ITs
Posted by GitBox <gi...@apache.org>.
slawekjaranowski closed pull request #951: Jenkinsfile: pickup results from ITs
URL: https://github.com/apache/maven/pull/951
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [maven] slawekjaranowski commented on pull request #951: Jenkinsfile: pickup results from ITs
Posted by GitBox <gi...@apache.org>.
slawekjaranowski commented on PR #951:
URL: https://github.com/apache/maven/pull/951#issuecomment-1379324294
@psiroky Thanks for PR, I will try it on branch in maven repo ... PR from fork are not build by jenkins
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [maven] psiroky commented on a diff in pull request #951: Jenkinsfile: pickup results from ITs
Posted by GitBox <gi...@apache.org>.
psiroky commented on code in PR #951:
URL: https://github.com/apache/maven/pull/951#discussion_r1066726575
##########
Jenkinsfile:
##########
@@ -112,7 +112,7 @@ for (String os in runITsOses) {
}
}
} finally {
- //junit testResults: '**/core-it-suite/**/target/surefire-reports/*.xml', allowEmptyResults: true
+ junit testResults: '**/core-it-suite/**/target/surefire-reports/*.xml', allowEmptyResults: true
Review Comment:
I am not sure. I assumed these patterns were tested before and the junit step was accidentally left commented out.
I think we could go with `**target/surefire-reports/*.xml`. It will pick-up some test results from `core-it-support`, but that may be desirable.
There are no `failsafe-reports` directories right now, but to be safe we could include those as well.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [maven] psiroky commented on pull request #951: Jenkinsfile: pickup results from ITs
Posted by GitBox <gi...@apache.org>.
psiroky commented on PR #951:
URL: https://github.com/apache/maven/pull/951#issuecomment-1378432912
I updated the PR to also pickup `failsafe-reports`. I haven't really tried locally, but according to https://www.jenkins.io/doc/pipeline/steps/junit/ separating the patterns with comma should work.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [maven] slawekjaranowski commented on pull request #951: Jenkinsfile: pickup results from ITs
Posted by GitBox <gi...@apache.org>.
slawekjaranowski commented on PR #951:
URL: https://github.com/apache/maven/pull/951#issuecomment-1379901954
Suppressed by #953
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [maven] psiroky commented on a diff in pull request #951: Jenkinsfile: pickup results from ITs
Posted by GitBox <gi...@apache.org>.
psiroky commented on code in PR #951:
URL: https://github.com/apache/maven/pull/951#discussion_r1066726575
##########
Jenkinsfile:
##########
@@ -112,7 +112,7 @@ for (String os in runITsOses) {
}
}
} finally {
- //junit testResults: '**/core-it-suite/**/target/surefire-reports/*.xml', allowEmptyResults: true
+ junit testResults: '**/core-it-suite/**/target/surefire-reports/*.xml', allowEmptyResults: true
Review Comment:
I am not sure. I assumed these patterns were tested before and it the junit step was accidentally left commented out.
I think we could go with `**target/surefire-reports/*.xml`. It will pick-up some test results from `core-it-support`, but that may be desirable.
There are not `failsafe-reports` directories, but to be safe we could include those as well.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org