You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@myfaces.apache.org by "Nuno Marques (JIRA)" <de...@myfaces.apache.org> on 2006/04/24 18:34:07 UTC

[jira] Created: (TOMAHAWK-383) DataScroller always renders children

DataScroller always renders children
------------------------------------

         Key: TOMAHAWK-383
         URL: http://issues.apache.org/jira/browse/TOMAHAWK-383
     Project: MyFaces Tomahawk
        Type: Bug

  Components: Data Scroller  
    Versions: 1.1.1    
 Environment: WINXP, OC4J10.1.3
    Reporter: Nuno Marques
    Priority: Minor


the following snippet prints the message in the appBundle when it shoudn't...

<t:dataScroller styleClass="paging" id="scroll" for="data"
	rowsCountVar="rowsCount" fastStep="10" pageCountVar="pageCount"
	pageIndexVar="pageIndex" paginator="true" paginatorMaxPages="9"
	displayedRowsCountVar="displayedRowsCountVar"
	renderFacetsIfSinglePage="false" firstRowIndexVar="firstRowIndex"
	lastRowIndexVar="lastRowIndex" rendered="false">
	<h:outputFormat value="#{appBundle.found}" styleClass="msg" rendered="false">
		<f:param value="#{rowsCount}" />
		<f:param value="#{firstRowIndex}" />
		<f:param value="#{lastRowIndex}" />
		<f:param value="#{pageIndex}" />
		<f:param value="#{pageCount}" />
	</h:outputFormat>
</t:dataScroller>

but this works,

<t:dataScroller styleClass="paging" id="scroll" for="data"
	rowsCountVar="rowsCount" fastStep="10" pageCountVar="pageCount"
	pageIndexVar="pageIndex" paginator="true" paginatorMaxPages="9"
	displayedRowsCountVar="displayedRowsCountVar"
	renderFacetsIfSinglePage="false" firstRowIndexVar="firstRowIndex"
	lastRowIndexVar="lastRowIndex">
	<f:facet name="messageFromBundle">
	<h:outputFormat value="#{appBundle.found}" styleClass="msg">
		<f:param value="#{rowsCount}" />
		<f:param value="#{firstRowIndex}" />
		<f:param value="#{lastRowIndex}" />
		<f:param value="#{pageIndex}" />
		<f:param value="#{pageCount}" />
	</h:outputFormat>
	</f:facet>
</t:dataScroller>

Isn't this the behaviour against the specs?

Chapter 2 page 9

If the isRendered() method of a component returns false, the renderer for
that component must not generate any markup, and none of its facets or children
(if any) should be rendered.

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
   http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see:
   http://www.atlassian.com/software/jira


[jira] Resolved: (TOMAHAWK-383) DataScroller always renders children

Posted by "Martin Marinschek (JIRA)" <de...@myfaces.apache.org>.
     [ http://issues.apache.org/jira/browse/TOMAHAWK-383?page=all ]

Martin Marinschek resolved TOMAHAWK-383.
----------------------------------------

    Fix Version/s: 1.1.4-SNAPSHOT
       Resolution: Cannot Reproduce
         Assignee: Martin Marinschek

According to user feedback already fixed.

> DataScroller always renders children
> ------------------------------------
>
>                 Key: TOMAHAWK-383
>                 URL: http://issues.apache.org/jira/browse/TOMAHAWK-383
>             Project: MyFaces Tomahawk
>          Issue Type: Bug
>          Components: Data Scroller
>    Affects Versions: 1.1.1
>         Environment: WINXP, OC4J10.1.3
>            Reporter: Nuno Marques
>         Assigned To: Martin Marinschek
>            Priority: Minor
>             Fix For: 1.1.4-SNAPSHOT
>
>
> the following snippet prints the message in the appBundle when it shoudn't...
> <t:dataScroller styleClass="paging" id="scroll" for="data"
> 	rowsCountVar="rowsCount" fastStep="10" pageCountVar="pageCount"
> 	pageIndexVar="pageIndex" paginator="true" paginatorMaxPages="9"
> 	displayedRowsCountVar="displayedRowsCountVar"
> 	renderFacetsIfSinglePage="false" firstRowIndexVar="firstRowIndex"
> 	lastRowIndexVar="lastRowIndex" rendered="false">
> 	<h:outputFormat value="#{appBundle.found}" styleClass="msg" rendered="false">
> 		<f:param value="#{rowsCount}" />
> 		<f:param value="#{firstRowIndex}" />
> 		<f:param value="#{lastRowIndex}" />
> 		<f:param value="#{pageIndex}" />
> 		<f:param value="#{pageCount}" />
> 	</h:outputFormat>
> </t:dataScroller>
> but this works,
> <t:dataScroller styleClass="paging" id="scroll" for="data"
> 	rowsCountVar="rowsCount" fastStep="10" pageCountVar="pageCount"
> 	pageIndexVar="pageIndex" paginator="true" paginatorMaxPages="9"
> 	displayedRowsCountVar="displayedRowsCountVar"
> 	renderFacetsIfSinglePage="false" firstRowIndexVar="firstRowIndex"
> 	lastRowIndexVar="lastRowIndex">
> 	<f:facet name="messageFromBundle">
> 	<h:outputFormat value="#{appBundle.found}" styleClass="msg">
> 		<f:param value="#{rowsCount}" />
> 		<f:param value="#{firstRowIndex}" />
> 		<f:param value="#{lastRowIndex}" />
> 		<f:param value="#{pageIndex}" />
> 		<f:param value="#{pageCount}" />
> 	</h:outputFormat>
> 	</f:facet>
> </t:dataScroller>
> Isn't this the behaviour against the specs?
> Chapter 2 page 9
> If the isRendered() method of a component returns false, the renderer for
> that component must not generate any markup, and none of its facets or children
> (if any) should be rendered.

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] Commented: (TOMAHAWK-383) DataScroller always renders children

Posted by "Torsten Krah (JIRA)" <de...@myfaces.apache.org>.
    [ http://issues.apache.org/jira/browse/TOMAHAWK-383?page=comments#action_12420886 ] 

Torsten Krah commented on TOMAHAWK-383:
---------------------------------------

Used this too in 1.1.3 - rendered="false" works fine for me.

kind regards

Torsten

> DataScroller always renders children
> ------------------------------------
>
>          Key: TOMAHAWK-383
>          URL: http://issues.apache.org/jira/browse/TOMAHAWK-383
>      Project: MyFaces Tomahawk
>         Type: Bug

>   Components: Data Scroller
>     Versions: 1.1.1
>  Environment: WINXP, OC4J10.1.3
>     Reporter: Nuno Marques
>     Priority: Minor

>
> the following snippet prints the message in the appBundle when it shoudn't...
> <t:dataScroller styleClass="paging" id="scroll" for="data"
> 	rowsCountVar="rowsCount" fastStep="10" pageCountVar="pageCount"
> 	pageIndexVar="pageIndex" paginator="true" paginatorMaxPages="9"
> 	displayedRowsCountVar="displayedRowsCountVar"
> 	renderFacetsIfSinglePage="false" firstRowIndexVar="firstRowIndex"
> 	lastRowIndexVar="lastRowIndex" rendered="false">
> 	<h:outputFormat value="#{appBundle.found}" styleClass="msg" rendered="false">
> 		<f:param value="#{rowsCount}" />
> 		<f:param value="#{firstRowIndex}" />
> 		<f:param value="#{lastRowIndex}" />
> 		<f:param value="#{pageIndex}" />
> 		<f:param value="#{pageCount}" />
> 	</h:outputFormat>
> </t:dataScroller>
> but this works,
> <t:dataScroller styleClass="paging" id="scroll" for="data"
> 	rowsCountVar="rowsCount" fastStep="10" pageCountVar="pageCount"
> 	pageIndexVar="pageIndex" paginator="true" paginatorMaxPages="9"
> 	displayedRowsCountVar="displayedRowsCountVar"
> 	renderFacetsIfSinglePage="false" firstRowIndexVar="firstRowIndex"
> 	lastRowIndexVar="lastRowIndex">
> 	<f:facet name="messageFromBundle">
> 	<h:outputFormat value="#{appBundle.found}" styleClass="msg">
> 		<f:param value="#{rowsCount}" />
> 		<f:param value="#{firstRowIndex}" />
> 		<f:param value="#{lastRowIndex}" />
> 		<f:param value="#{pageIndex}" />
> 		<f:param value="#{pageCount}" />
> 	</h:outputFormat>
> 	</f:facet>
> </t:dataScroller>
> Isn't this the behaviour against the specs?
> Chapter 2 page 9
> If the isRendered() method of a component returns false, the renderer for
> that component must not generate any markup, and none of its facets or children
> (if any) should be rendered.

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
   http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see:
   http://www.atlassian.com/software/jira