You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@zeppelin.apache.org by corneadoug <gi...@git.apache.org> on 2016/06/15 07:11:50 UTC
[GitHub] zeppelin pull request #1015: [ZEPPPELIN-1009] Trying to Fix selenium modal e...
GitHub user corneadoug opened a pull request:
https://github.com/apache/zeppelin/pull/1015
[ZEPPPELIN-1009] Trying to Fix selenium modal error
### What is this PR for?
This is to check Selenium test failing on Master and #979
### What type of PR is it?
Flacky test fix
### What is the Jira issue?
https://issues.apache.org/jira/browse/ZEPPELIN-1009
### Questions:
* Does the licenses files need update? No
* Is there breaking changes for older versions? No
* Does this needs documentation? No
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/corneadoug/incubator-zeppelin fix/modalSelenium
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/zeppelin/pull/1015.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #1015
----
commit c9231087fbde2867e723ea92250014839e5e51ee
Author: Damien CORNEAU <co...@gmail.com>
Date: 2016-06-15T07:07:48Z
Trying to make test fail like the master
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zeppelin issue #1015: [ZEPPPELIN-1009] Trying to Fix selenium modal error
Posted by bzz <gi...@git.apache.org>.
Github user bzz commented on the issue:
https://github.com/apache/zeppelin/pull/1015
Two CI failures here
1. **Python test failure**
[logs](https://s3.amazonaws.com/archive.travis-ci.org/jobs/137725472/log.txt) AFAIK never seen before (might be related to #1009)
```
Running org.apache.zeppelin.python.PythonInterpreterTest
org.apache.zeppelin.python.PythonInterpreterTest
testClose(org.apache.zeppelin.python.PythonInterpreterTest) Time elapsed: 0.436 sec <<< FAILURE!
java.lang.AssertionError: null
at org.junit.Assert.fail(Assert.java:86)
at org.junit.Assert.assertTrue(Assert.java:41)
at org.junit.Assert.assertFalse(Assert.java:64)
at org.junit.Assert.assertFalse(Assert.java:74)
at org.apache.zeppelin.python.PythonInterpreterTest.testClose(PythonInterpreterTest.java:170)
Results :
Failed tests:
PythonInterpreterTest.testClose:170 null
Tests run: 5, Failures: 1, Errors: 0, Skipped: 0
```
2. **Integration Tests failure**
[Logs](https://s3.amazonaws.com/archive.travis-ci.org/jobs/137725478/log.txt)
```
Tests in error:
ZeppelinIT.testSparkInterpreterDependencyLoading:214->AbstractZeppelinIT.createNewNote:133 » Timeout
ParagraphActionsIT.testRemoveButton:165 » NoSuchElement Unable to locate eleme...
ParagraphActionsIT.testCreateNewButton:92 » NoSuchElement Unable to locate ele...
Tests run: 14, Failures: 0, Errors: 3, Skipped: 0
```
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zeppelin issue #1015: [ZEPPPELIN-1009] Trying to Fix selenium modal error
Posted by corneadoug <gi...@git.apache.org>.
Github user corneadoug commented on the issue:
https://github.com/apache/zeppelin/pull/1015
Only both errors about delete button are there after running the CI again
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zeppelin issue #1015: [ZEPPPELIN-1009] Trying to Fix selenium modal error
Posted by bzz <gi...@git.apache.org>.
Github user bzz commented on the issue:
https://github.com/apache/zeppelin/pull/1015
@corneadoug sounds good! Screenshot is in the logs in base64.
Could you post current CI failure in the same way as I did above? Then we could iterate faster on it
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zeppelin issue #1015: [ZEPPPELIN-1009] Trying to Fix selenium modal error
Posted by Leemoonsoo <gi...@git.apache.org>.
Github user Leemoonsoo commented on the issue:
https://github.com/apache/zeppelin/pull/1015
`handleException()` take screenshot. `ParagraphActionIT` catches all exceptions during test and call `handleException()` to screenshot.
To take screenshot manually, Insert following line where you want,
```java
try { handleException("ANY MSG", new RuntimeException();} catch (Exception e) {};
```
I was working on #1034, it does not fix all the selenium error, but it fixes all errors on `ZeppelinIT`.
Please take a look and feel free to merge #1034.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zeppelin pull request #1015: [ZEPPPELIN-1009] Trying to Fix selenium modal e...
Posted by corneadoug <gi...@git.apache.org>.
Github user corneadoug closed the pull request at:
https://github.com/apache/zeppelin/pull/1015
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zeppelin issue #1015: [ZEPPPELIN-1009] Trying to Fix selenium modal error
Posted by bzz <gi...@git.apache.org>.
Github user bzz commented on the issue:
https://github.com/apache/zeppelin/pull/1015
on #1021 in [logs](https://s3.amazonaws.com/archive.travis-ci.org/jobs/137973583/log.txt) I can see
**ParagraphActionsIT.testRemoveButton**
```
org.apache.zeppelin.integration.ParagraphActionsIT.testRemoveButton(ParagraphActionsIT.java:152)
03:13:23,791 INFO org.apache.zeppelin.AbstractZeppelinIT:59 - Finished.
03:13:53,820 ERROR org.apache.zeppelin.AbstractZeppelinIT:153 - Exception in ParagraphActionsIT while testRemoveButton
org.openqa.selenium.NoSuchElementException: Unable to locate element: {"method":"xpath","selector":"//div[@class='modal-dialog'][contains(.,'delete this paragraph')]//div[@class='modal-footer']//button[contains(.,'OK')]"}
Command duration or timeout: 30.03 seconds
```
when the browser gets trapped in this state, as one can see - there is indeed no modal dialog on the screen
So may be its [previous line](https://github.com/apache/zeppelin/blob/master/zeppelin-server/src/test/java/org/apache/zeppelin/integration/ParagraphActionsIT.java#L146), `//ul/li/a[@ng-click='removeParagraph()']` that fails to trigger paragrpah removal here?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zeppelin issue #1015: [ZEPPPELIN-1009] Trying to Fix selenium modal error
Posted by corneadoug <gi...@git.apache.org>.
Github user corneadoug commented on the issue:
https://github.com/apache/zeppelin/pull/1015
@bzz Do you know in which case it takes a screenshot?
I see this in the log before the screenshot
```
09:14:21,371 ERROR org.apache.zeppelin.AbstractZeppelinIT:155 - ScreenShot::
```
However, the log place the error at line 166
cf:
```
Tests in error:
ParagraphActionsIT.testRemoveButton:166 » NoSuchElement Unable to locate eleme...
ParagraphActionsIT.testCreateNewButton:92 » NoSuchElement Unable to locate ele...
```
```
09:11:54,159 INFO org.apache.zeppelin.AbstractZeppelinIT:51 - Caller: org.apache.zeppelin.integration.ParagraphActionsIT.testRemoveButton(ParagraphActionsIT.java:158)
09:11:55,160 INFO org.apache.zeppelin.AbstractZeppelinIT:59 - Finished.
09:12:55,241 ERROR org.apache.zeppelin.AbstractZeppelinIT:153 - Exception in ParagraphActionsIT while testRemoveButton
org.openqa.selenium.NoSuchElementException: Unable to locate element: {"method":"xpath","selector":"//div[@class='bootstrap-dialog-footer']//button[contains(text() ,'OK')]"}
Command duration or timeout: 30.07 seconds
```
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zeppelin issue #1015: [ZEPPPELIN-1009] Trying to Fix selenium modal error
Posted by bzz <gi...@git.apache.org>.
Github user bzz commented on the issue:
https://github.com/apache/zeppelin/pull/1015
@corneadoug as a first step, how about re-open the PR to trigger CI and see, which ones are reproducible by posting same report for new CI build results?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zeppelin issue #1015: [ZEPPPELIN-1009] Trying to Fix selenium modal error
Posted by corneadoug <gi...@git.apache.org>.
Github user corneadoug commented on the issue:
https://github.com/apache/zeppelin/pull/1015
@bzz where did you get the screenshot from?
The modal is supposed to show, I modified the test in this PR to have a check on that, and current scenario looks like this:
* Find the paragraph icon-setting and click on it
* Find the remove paragraph button and click on it
* Does Modal Exist? -> True
* Find the Modal Ok button and Click on It -> failed
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zeppelin issue #1015: [ZEPPPELIN-1009] Trying to Fix selenium modal error
Posted by corneadoug <gi...@git.apache.org>.
Github user corneadoug commented on the issue:
https://github.com/apache/zeppelin/pull/1015
@Leemoonsoo Yes we will go with your PR, so I will close this one
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zeppelin issue #1015: [ZEPPPELIN-1009] Trying to Fix selenium modal error
Posted by corneadoug <gi...@git.apache.org>.
Github user corneadoug commented on the issue:
https://github.com/apache/zeppelin/pull/1015
No problem running the test locally
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---