You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@superset.apache.org by "massucattoj (via GitHub)" <gi...@apache.org> on 2026/04/11 16:04:32 UTC
[PR] fix(explore): prevent unnecessary scrollbars during chart rendering [superset]
massucattoj opened a new pull request, #39291:
URL: https://github.com/apache/superset/pull/39291
### SUMMARY
Charts in the Explore page were occasionally showing unnecessary vertical and horizontal scrollbars on first load, which would disappear after a refresh. This was caused by a race condition in the chart rendering
lifecycle — the ResizeObserver (debounced at 300ms) could report layout dimensions before the container had fully stabilized, causing the chart to momentarily overflow its container.
The chart panel wrapper used `overflow: auto`, which made these transient dimension mismatches visible as scrollbars. Changing to `overflow: hidden` prevents this, since charts are always explicitly sized to fit
their container via the `width` and `height` props passed to `SuperChart`.
PS: This fix only applies to the Explore page. The dashboard path was already protected — `ChartWrapper` in the dashboard grid uses `overflow: hidden` by default.
### BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
Not applicable — this was a race condition that appeared intermittently during chart load. The fix prevents scrollbars from appearing regardless of ResizeObserver timing. Charts should now render without
unnecessary scrollbars on first load.
### TESTING INSTRUCTIONS
1. Navigate to Explore and open any chart (e.g. a line chart)
2. Observe that no scrollbars appear during initial chart rendering
3. Resize the browser window while a chart is displayed — confirm no scrollbars flash
4. Open a dashboard with multiple charts — confirm no scrollbars appear during load
5. Open the Data Tables pane (Results/Samples) below the chart — confirm it still scrolls correctly
### ADDITIONAL INFORMATION
<!--- Check any relevant boxes with "x" -->
<!--- HINT: Include "Fixes #nnn" if you are fixing an existing issue -->
- [ ] Has associated issue:
- [ ] Required feature flags:
- [x] Changes UI
- [ ] Includes DB Migration (follow approval process in [SIP-59](https://github.com/apache/superset/issues/13351))
- [ ] Migration is atomic, supports rollback & is backwards-compatible
- [ ] Confirm DB migration upgrade and downgrade tested
- [ ] Runtime estimates and downtime expectations provided
- [ ] Introduces new feature or API
- [ ] Removes existing feature or API
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
Re: [PR] fix(explore): prevent unnecessary scrollbars during chart rendering [superset]
Posted by "michaelmorera-preset (via GitHub)" <gi...@apache.org>.
michaelmorera-preset commented on PR #39291:
URL: https://github.com/apache/superset/pull/39291#issuecomment-4328757729
Chart does not have unnecessary scrollbars during chart loading. The appliction is working as expected.
## Steps
1. Navigate to Explore and open any chart (e.g. a line chart)
2. Observe that no scrollbars appear during initial chart rendering
3. Resize the browser window while a chart is displayed
4. Open a dashboard with multiple charts
5. Open the Data Tables pane (Results/Samples) below the chart — confirm it still scrolls correctly
## Current result
After the step 3, no scrollbars flash.
After the step 4, no scrollbars appear during load
After the step 5, results/samples scrolls correctly
## Evidence
<img width="800" height="381" alt="Noscrolldisplayedonchartloadingbeforeandaf" src="https://github.com/user-attachments/assets/fedce1bf-9bfc-44a9-b27e-e24ad49c5a1d" />
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
Re: [PR] fix(explore): prevent unnecessary scrollbars during chart rendering [superset]
Posted by "msyavuz (via GitHub)" <gi...@apache.org>.
msyavuz commented on PR #39291:
URL: https://github.com/apache/superset/pull/39291#issuecomment-4251819048
Before/after screenshots would be nice
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
Re: [PR] fix(explore): prevent unnecessary scrollbars during chart rendering [superset]
Posted by "bito-code-review[bot] (via GitHub)" <gi...@apache.org>.
bito-code-review[bot] commented on PR #39291:
URL: https://github.com/apache/superset/pull/39291#issuecomment-4229725059
AI Code Review is in progress (usually takes 3 to 15 minutes unless it's a very large PR).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
Re: [PR] fix(explore): prevent unnecessary scrollbars during chart rendering [superset]
Posted by "sadpandajoe (via GitHub)" <gi...@apache.org>.
sadpandajoe merged PR #39291:
URL: https://github.com/apache/superset/pull/39291
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
Re: [PR] fix(explore): prevent unnecessary scrollbars during chart rendering [superset]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #39291:
URL: https://github.com/apache/superset/pull/39291#issuecomment-4328313246
🎪 [Showtime](https://github.com/mistercrunch/superset-showtime) is building environment on [GHA](https://github.com/apache/superset/actions/runs/25004075449) for [0921387](https://github.com/apache/superset/commit/0921387)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
Re: [PR] fix(explore): prevent unnecessary scrollbars during chart rendering [superset]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #39291:
URL: https://github.com/apache/superset/pull/39291#issuecomment-4328446808
🎪 [Showtime](https://github.com/mistercrunch/superset-showtime) deployed environment on [GHA](https://github.com/apache/superset/actions/runs/25004075449) for [0921387](https://github.com/apache/superset/commit/0921387)
• **Environment:** http://34.223.233.71:8080 (admin/admin)
• **Lifetime:** 48h auto-cleanup
• **Updates:** New commits create fresh environments automatically
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
Re: [PR] fix(explore): prevent unnecessary scrollbars during chart rendering [superset]
Posted by "codecov[bot] (via GitHub)" <gi...@apache.org>.
codecov[bot] commented on PR #39291:
URL: https://github.com/apache/superset/pull/39291#issuecomment-4229750371
## [Codecov](https://app.codecov.io/gh/apache/superset/pull/39291?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report
:white_check_mark: All modified and coverable lines are covered by tests.
:white_check_mark: Project coverage is 64.42%. Comparing base ([`de40b58`](https://app.codecov.io/gh/apache/superset/commit/de40b58e1050c823167a8d98da5a49603bf4cfa1?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`7b2846e`](https://app.codecov.io/gh/apache/superset/commit/7b2846e34cd8fa850d1c84b88793ef68a01ecf45?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)).
:x: Your project check has failed because the head coverage (99.81%) is below the target coverage (100.00%). You can increase the head coverage or adjust the [target](https://docs.codecov.com/docs/commit-status#target) coverage.
<details><summary>Additional details and impacted files</summary>
```diff
@@ Coverage Diff @@
## master #39291 +/- ##
=======================================
Coverage 64.42% 64.42%
=======================================
Files 2553 2553
Lines 132588 132588
Branches 30758 30758
=======================================
Hits 85416 85416
Misses 45686 45686
Partials 1486 1486
```
| [Flag](https://app.codecov.io/gh/apache/superset/pull/39291/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
|---|---|---|
| [javascript](https://app.codecov.io/gh/apache/superset/pull/39291/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `66.11% <ø> (ø)` | |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#carryforward-flags-in-the-pull-request-comment) to find out more.
</details>
[:umbrella: View full report in Codecov by Sentry](https://app.codecov.io/gh/apache/superset/pull/39291?dropdown=coverage&src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache).
:loudspeaker: Have feedback on the report? [Share it here](https://about.codecov.io/codecov-pr-comment-feedback/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache).
<details><summary> :rocket: New features to boost your workflow: </summary>
- :snowflake: [Test Analytics](https://docs.codecov.com/docs/test-analytics): Detect flaky tests, report on failures, and find test suite problems.
- :package: [JS Bundle Analysis](https://docs.codecov.com/docs/javascript-bundle-analysis): Save yourself from yourself by tracking and limiting bundle sizes in JS merges.
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org