You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@superset.apache.org by "xavier-GitHub76 (via GitHub)" <gi...@apache.org> on 2025/02/10 14:01:26 UTC

[I] 7 permissions "RowLevelSecurityFiltersModelView" don't exist but documentation mentions them [superset]

xavier-GitHub76 opened a new issue, #32205:
URL: https://github.com/apache/superset/issues/32205

   ### Bug description
   
   7 permissions "RowLevelSecurityFiltersModelView" don't exist in Superset 4.0.2
   but documentation mentions them.
   
   https://github.com/apache/superset/blob/master/RESOURCES/STANDARD_ROLES.md
   
   ![Image](https://github.com/user-attachments/assets/4a366b7b-68a2-4fc0-8600-7b351ba752ea)
   
   
   
   
   ### Screenshots/recordings
   
   _No response_
   
   ### Superset version
   
   4.0.2
   
   ### Python version
   
   3.9
   
   ### Node version
   
   16
   
   ### Browser
   
   Chrome
   
   ### Additional context
   
   _No response_
   
   ### Checklist
   
   - [x] I have searched Superset docs and Slack and didn't find a solution to my problem.
   - [x] I have searched the GitHub issue tracker and didn't find a similar bug report.
   - [ ] I have checked Superset's logs for errors and if I found a relevant Python stacktrace, I included it here as text in the "additional context" section.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org


Re: [I] 7 permissions "RowLevelSecurityFiltersModelView" don't exist but documentation mentions them [superset]

Posted by "rusackas (via GitHub)" <gi...@apache.org>.
rusackas commented on issue #32205:
URL: https://github.com/apache/superset/issues/32205#issuecomment-2917498033

   Indeed, that markdown file was an earnest attempt at being correct at the time, but is almost certainly in need of updating/maintenance. Whilst we wait to have versioned documentation (it's coming!) do we have any volunteers to update the docs with a PR?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org


Re: [I] 7 permissions "RowLevelSecurityFiltersModelView" don't exist but documentation mentions them [superset]

Posted by "rusackas (via GitHub)" <gi...@apache.org>.
rusackas commented on issue #32205:
URL: https://github.com/apache/superset/issues/32205#issuecomment-3942643004

   Closing as completed - PR #33670 fixed the documentation. Thanks @xavier-GitHub76 for both reporting and fixing this!


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org


Re: [I] 7 permissions "RowLevelSecurityFiltersModelView" don't exist but documentation mentions them [superset]

Posted by "dosubot[bot] (via GitHub)" <gi...@apache.org>.
dosubot[bot] commented on issue #32205:
URL: https://github.com/apache/superset/issues/32205#issuecomment-2648086126

   <!-- Answer -->
   The discrepancy you're observing between the documentation and the actual implementation of permissions for `RowLevelSecurityFiltersModelView` in Superset 4.0.2 might be due to a few reasons. The `RowLevelSecurityFiltersModelView` is implemented as `RLSRestApi` in the codebase, and it includes permissions for CRUD operations and other functionalities <sup>[[1]](https://github.com/apache/superset/blob/master/superset/row_level_security/api.py)</sup>. However, the permissions matrix in the `STANDARD_ROLES.md` file might not have been updated to reflect the current state of the codebase.
   
   Additionally, the `RowLevelSecurityFiltersModelView` is listed under `ADMIN_ONLY_VIEW_MENUS`, indicating that its permissions are intended for admin users only <sup>[[2]](https://github.com/apache/superset/blob/master/superset/security/manager.py)</sup>. This could explain why certain permissions are not available to other roles as mentioned in the documentation.
   
   If the permissions are indeed missing, it could be an oversight in the documentation or a feature that hasn't been implemented yet. It might be helpful to check the test suite for `RowLevelSecurityFiltersModelView` to verify the expected behavior and permissions <sup>[[3]](https://github.com/apache/superset/blob/master/tests/integration_tests/security/row_level_security_tests.py)</sup>.
   
   
   <!-- Dosu Comment Footer -->
   *To continue talking to [Dosu](https://dosu.dev), mention @dosu.*
   
   ---
   <sup>Help Dosu learn! Give it feedback: [Great Response](https://app.dosu.dev/response-feedback/2e2d9979-ce95-4c4f-9069-cbbf16a64d87?feedback_type=great_response) | [Irrelevant Answer](https://app.dosu.dev/response-feedback/2e2d9979-ce95-4c4f-9069-cbbf16a64d87?feedback_type=irrelevant_answer) | [Incorrect Sources](https://app.dosu.dev/response-feedback/2e2d9979-ce95-4c4f-9069-cbbf16a64d87?feedback_type=incorrect_sources) | [Too Verbose](https://app.dosu.dev/response-feedback/2e2d9979-ce95-4c4f-9069-cbbf16a64d87?feedback_type=too_verbose) | [Hallucination](https://app.dosu.dev/response-feedback/2e2d9979-ce95-4c4f-9069-cbbf16a64d87?feedback_type=hallucination) | [Other](https://app.dosu.dev/response-feedback/2e2d9979-ce95-4c4f-9069-cbbf16a64d87?feedback_type=other)</sup>
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org


Re: [I] 7 permissions "RowLevelSecurityFiltersModelView" don't exist but documentation mentions them [superset]

Posted by "rusackas (via GitHub)" <gi...@apache.org>.
rusackas closed issue #32205: 7 permissions "RowLevelSecurityFiltersModelView" don't exist but documentation mentions them
URL: https://github.com/apache/superset/issues/32205


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org


Re: [I] 7 permissions "RowLevelSecurityFiltersModelView" don't exist but documentation mentions them [superset]

Posted by "xavier-GitHub76 (via GitHub)" <gi...@apache.org>.
xavier-GitHub76 commented on issue #32205:
URL: https://github.com/apache/superset/issues/32205#issuecomment-2934430237

   PR is created
   https://github.com/apache/superset/pull/33670


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org