You are viewing a plain text version of this content. The canonical link for it is here.

Posted to reviews@mesos.apache.org by Chun-Hung Hsiao <ch...@mesosphere.io> on 2018/02/03 01:39:44 UTC

Review Request 65499: Fixed the flakiness of the ROOT_ConvertPreExistingVolume test.

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/65499/
-----------------------------------------------------------

Review request for mesos, Alexander Rukletsov, Gaston Kleiman, Greg Mann, and Jie Yu.


Bugs: MESOS-8474
    https://issues.apache.org/jira/browse/MESOS-8474


Repository: mesos


Description
-------

This unit test is flaky because the master might send out an offer
before both offer operations of a previous `ACCEPT` call are finished.
This is fixed by manipulating the clock such that no offer won't be
sent out until the master receives status updates for both operations.


Diffs
-----

  src/tests/storage_local_resource_provider_tests.cpp ce241617ee555e5a67e552dd30b0e7afee161386 


Diff: https://reviews.apache.org/r/65499/diff/1/


Testing
-------

sudo make check
Ran in repetition.


Thanks,

Chun-Hung Hsiao