You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@hudi.apache.org by GitBox <gi...@apache.org> on 2019/11/01 15:55:57 UTC
[GitHub] [incubator-hudi] vinothchandar commented on a change in pull
request #987: [HUDI-321] Support bulkinsert in HDFSParquetImporter
vinothchandar commented on a change in pull request #987: [HUDI-321] Support bulkinsert in HDFSParquetImporter
URL: https://github.com/apache/incubator-hudi/pull/987#discussion_r341636756
##########
File path: hudi-utilities/src/main/java/org/apache/hudi/utilities/UtilHelpers.java
##########
@@ -190,7 +190,9 @@ public static HoodieWriteClient createHoodieClient(JavaSparkContext jsc, String
.withCompactionStrategy(ReflectionUtils.loadClass(strategy)).build())
.orElse(HoodieCompactionConfig.newBuilder().withInlineCompaction(false).build());
HoodieWriteConfig config =
- HoodieWriteConfig.newBuilder().withPath(basePath).withParallelism(parallelism, parallelism)
+ HoodieWriteConfig.newBuilder().withPath(basePath)
+ .withParallelism(parallelism, parallelism)
+ .withBulkInsertParallelism(parallelism)
Review comment:
yes. should be safe.. its only used by the write client . good callout.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services