You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@falcon.apache.org by Balu Vellanki <bv...@hortonworks.com> on 2015/08/31 21:57:22 UTC

Review Request 37965: HiveDR does not work when job is run on destination cluster

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37965/
-----------------------------------------------------------

Review request for Falcon, Sowmya Ramesh and Venkat Ranganathan.


Bugs: FALCON-1373
    https://issues.apache.org/jira/browse/FALCON-1373


Repository: falcon-git


Description
-------

This happens because the sourceStagingPaths used for DistCp of events from source to target does not have the fully qualified sourceNameNode as part of stagingPath uri.


Diffs
-----

  addons/hivedr/src/main/java/org/apache/falcon/hive/util/EventUtils.java 0b4200c 

Diff: https://reviews.apache.org/r/37965/diff/


Testing
-------

Patch was tested end2end by support team.


Thanks,

Balu Vellanki


Re: Review Request 37965: HiveDR does not work when job is run on destination cluster

Posted by Venkat Ranganathan <n....@live.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37965/#review98237
-----------------------------------------------------------

Ship it!


Thanks for catching it Balu

- Venkat Ranganathan


On Aug. 31, 2015, 12:57 p.m., Balu Vellanki wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/37965/
> -----------------------------------------------------------
> 
> (Updated Aug. 31, 2015, 12:57 p.m.)
> 
> 
> Review request for Falcon, Sowmya Ramesh and Venkat Ranganathan.
> 
> 
> Bugs: FALCON-1373
>     https://issues.apache.org/jira/browse/FALCON-1373
> 
> 
> Repository: falcon-git
> 
> 
> Description
> -------
> 
> This happens because the sourceStagingPaths used for DistCp of events from source to target does not have the fully qualified sourceNameNode as part of stagingPath uri.
> 
> 
> Diffs
> -----
> 
>   addons/hivedr/src/main/java/org/apache/falcon/hive/util/EventUtils.java 0b4200c 
> 
> Diff: https://reviews.apache.org/r/37965/diff/
> 
> 
> Testing
> -------
> 
> Patch was tested end2end by support team.
> 
> 
> Thanks,
> 
> Balu Vellanki
> 
>


Re: Review Request 37965: HiveDR does not work when job is run on destination cluster

Posted by Balu Vellanki <bv...@hortonworks.com>.

> On Sept. 9, 2015, 8:55 p.m., Sowmya Ramesh wrote:
> > addons/hivedr/src/main/java/org/apache/falcon/hive/util/EventUtils.java, line 322
> > <https://reviews.apache.org/r/37965/diff/1/?file=1060499#file1060499line322>
> >
> >     Minor nit: Can targetStagingUri be renamed to fullyQualifiedTargetStagingUri?

Incorporated feedback in new patch.


- Balu


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37965/#review98261
-----------------------------------------------------------


On Aug. 31, 2015, 7:57 p.m., Balu Vellanki wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/37965/
> -----------------------------------------------------------
> 
> (Updated Aug. 31, 2015, 7:57 p.m.)
> 
> 
> Review request for Falcon, Sowmya Ramesh and Venkat Ranganathan.
> 
> 
> Bugs: FALCON-1373
>     https://issues.apache.org/jira/browse/FALCON-1373
> 
> 
> Repository: falcon-git
> 
> 
> Description
> -------
> 
> This happens because the sourceStagingPaths used for DistCp of events from source to target does not have the fully qualified sourceNameNode as part of stagingPath uri.
> 
> 
> Diffs
> -----
> 
>   addons/hivedr/src/main/java/org/apache/falcon/hive/util/EventUtils.java 0b4200c 
> 
> Diff: https://reviews.apache.org/r/37965/diff/
> 
> 
> Testing
> -------
> 
> Patch was tested end2end by support team.
> 
> 
> Thanks,
> 
> Balu Vellanki
> 
>


Re: Review Request 37965: HiveDR does not work when job is run on destination cluster

Posted by Sowmya Ramesh <sr...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37965/#review98261
-----------------------------------------------------------



addons/hivedr/src/main/java/org/apache/falcon/hive/util/EventUtils.java (line 322)
<https://reviews.apache.org/r/37965/#comment154602>

    Minor nit: Can targetStagingUri be renamed to fullyQualifiedTargetStagingUri?


- Sowmya Ramesh


On Aug. 31, 2015, 7:57 p.m., Balu Vellanki wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/37965/
> -----------------------------------------------------------
> 
> (Updated Aug. 31, 2015, 7:57 p.m.)
> 
> 
> Review request for Falcon, Sowmya Ramesh and Venkat Ranganathan.
> 
> 
> Bugs: FALCON-1373
>     https://issues.apache.org/jira/browse/FALCON-1373
> 
> 
> Repository: falcon-git
> 
> 
> Description
> -------
> 
> This happens because the sourceStagingPaths used for DistCp of events from source to target does not have the fully qualified sourceNameNode as part of stagingPath uri.
> 
> 
> Diffs
> -----
> 
>   addons/hivedr/src/main/java/org/apache/falcon/hive/util/EventUtils.java 0b4200c 
> 
> Diff: https://reviews.apache.org/r/37965/diff/
> 
> 
> Testing
> -------
> 
> Patch was tested end2end by support team.
> 
> 
> Thanks,
> 
> Balu Vellanki
> 
>