You are viewing a plain text version of this content. The canonical link for it is here.

Posted to github@arrow.apache.org by "candiduslynx (via GitHub)" <gi...@apache.org> on 2023/05/25 07:45:33 UTC

[GitHub] [arrow] candiduslynx commented on pull request #35687: GH-35686:[Go] Add AppendTime to TimestampBuilder

candiduslynx commented on PR #35687:
URL: https://github.com/apache/arrow/pull/35687#issuecomment-1562434960

   Hi @zeroshade!
   
   I'm overtaking this PR from @yevgenypats.
   
   I've extracted timestamp from numeric gen (array, builder, tests, traits).
   
   Additionally, I propose to introduce a helper func for creation of `arrow.Timestamp` from `time.Time` and `arrow.TimeUnit`.
   
   The logic was tested and introduced in https://github.com/cloudquery/arrow/pull/17 (in this PR: 1689eee0ec81da6e62f545eb06f8f71ed3f69a22).


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org