You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@shardingsphere.apache.org by GitBox <gi...@apache.org> on 2021/08/10 08:17:33 UTC
[GitHub] [shardingsphere] RaigorJiang opened a new pull request #11742: Main structure code of processing SCTL dist SQL.
RaigorJiang opened a new pull request #11742:
URL: https://github.com/apache/shardingsphere/pull/11742
For #11677.
Due to cooperation needs, the main structure code is submitted first. Does not affect any existing functions.
Known issues:
- Missing test code
- The preview syntax needs to be redefined
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [shardingsphere] RaigorJiang commented on a change in pull request #11742: Main structure code of processing SCTL dist SQL.
Posted by GitBox <gi...@apache.org>.
RaigorJiang commented on a change in pull request #11742:
URL: https://github.com/apache/shardingsphere/pull/11742#discussion_r686476033
##########
File path: shardingsphere-distsql-parser/shardingsphere-distsql-parser-engine/src/main/java/org/apache/shardingsphere/distsql/parser/api/DistSQLStatementParserEngine.java
##########
@@ -38,7 +39,11 @@ public SQLStatement parse(final String sql) {
try {
return new ResourceSQLStatementParserEngine().parse(sql);
} catch (final ParseCancellationException | SQLParsingException ignored) {
- return new RuleSQLStatementParserEngine().parse(sql);
+ try {
Review comment:
Maybe we can fefer to [ShardingSphereSQLParserEngine#parse0](https://github.com/apache/shardingsphere/blob/master/shardingsphere-infra/shardingsphere-infra-parser/src/main/java/org/apache/shardingsphere/infra/parser/ShardingSphereSQLParserEngine.java)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [shardingsphere] RaigorJiang commented on pull request #11742: Main structure code of processing SCTL dist SQL.
Posted by GitBox <gi...@apache.org>.
RaigorJiang commented on pull request #11742:
URL: https://github.com/apache/shardingsphere/pull/11742#issuecomment-897306287
Hi @tristaZero ,
After adjusting the name of `SCTL` this time, the structure of RAL statements are as shown in the picture.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [shardingsphere] codecov-commenter edited a comment on pull request #11742: Main structure code of processing SCTL dist SQL.
Posted by GitBox <gi...@apache.org>.
codecov-commenter edited a comment on pull request #11742:
URL: https://github.com/apache/shardingsphere/pull/11742#issuecomment-895936431
# [Codecov](https://codecov.io/gh/apache/shardingsphere/pull/11742?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#11742](https://codecov.io/gh/apache/shardingsphere/pull/11742?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (84cf145) into [master](https://codecov.io/gh/apache/shardingsphere/commit/226f0934196cfcef99b9b3c6b8fbdb6808626df2?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (226f093) will **decrease** coverage by `0.17%`.
> The diff coverage is `3.22%`.
[](https://codecov.io/gh/apache/shardingsphere/pull/11742?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
```diff
@@ Coverage Diff @@
## master #11742 +/- ##
============================================
- Coverage 63.67% 63.49% -0.18%
- Complexity 1126 1194 +68
============================================
Files 2272 2306 +34
Lines 34666 34890 +224
Branches 6035 6050 +15
============================================
+ Hits 22075 22155 +80
- Misses 10824 10964 +140
- Partials 1767 1771 +4
```
| [Impacted Files](https://codecov.io/gh/apache/shardingsphere/pull/11742?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
|---|---|---|
| [...stsql/parser/api/DistSQLStatementParserEngine.java](https://codecov.io/gh/apache/shardingsphere/pull/11742/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2hhcmRpbmdzcGhlcmUtZGlzdHNxbC1wYXJzZXIvc2hhcmRpbmdzcGhlcmUtZGlzdHNxbC1wYXJzZXItZW5naW5lL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9zaGFyZGluZ3NwaGVyZS9kaXN0c3FsL3BhcnNlci9hcGkvRGlzdFNRTFN0YXRlbWVudFBhcnNlckVuZ2luZS5qYXZh) | `0.00% <0.00%> (ø)` | |
| [...istsql/parser/core/common/CommonDistSQLParser.java](https://codecov.io/gh/apache/shardingsphere/pull/11742/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2hhcmRpbmdzcGhlcmUtZGlzdHNxbC1wYXJzZXIvc2hhcmRpbmdzcGhlcmUtZGlzdHNxbC1wYXJzZXItZW5naW5lL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9zaGFyZGluZ3NwaGVyZS9kaXN0c3FsL3BhcnNlci9jb3JlL2NvbW1vbi9Db21tb25EaXN0U1FMUGFyc2VyLmphdmE=) | `0.00% <ø> (ø)` | |
| [...ore/common/CommonDistSQLStatementParserEngine.java](https://codecov.io/gh/apache/shardingsphere/pull/11742/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2hhcmRpbmdzcGhlcmUtZGlzdHNxbC1wYXJzZXIvc2hhcmRpbmdzcGhlcmUtZGlzdHNxbC1wYXJzZXItZW5naW5lL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9zaGFyZGluZ3NwaGVyZS9kaXN0c3FsL3BhcnNlci9jb3JlL2NvbW1vbi9Db21tb25EaXN0U1FMU3RhdGVtZW50UGFyc2VyRW5naW5lLmphdmE=) | `0.00% <0.00%> (ø)` | |
| [...ser/core/common/CommonDistSQLStatementVisitor.java](https://codecov.io/gh/apache/shardingsphere/pull/11742/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2hhcmRpbmdzcGhlcmUtZGlzdHNxbC1wYXJzZXIvc2hhcmRpbmdzcGhlcmUtZGlzdHNxbC1wYXJzZXItZW5naW5lL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9zaGFyZGluZ3NwaGVyZS9kaXN0c3FsL3BhcnNlci9jb3JlL2NvbW1vbi9Db21tb25EaXN0U1FMU3RhdGVtZW50VmlzaXRvci5qYXZh) | `0.00% <0.00%> (ø)` | |
| [...ore/ReadwriteSplittingRuleSQLStatementVisitor.java](https://codecov.io/gh/apache/shardingsphere/pull/11742/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2hhcmRpbmdzcGhlcmUtZmVhdHVyZXMvc2hhcmRpbmdzcGhlcmUtcmVhZHdyaXRlLXNwbGl0dGluZy9zaGFyZGluZ3NwaGVyZS1yZWFkd3JpdGUtc3BsaXR0aW5nLWRpc3RzcWwvc2hhcmRpbmdzcGhlcmUtcmVhZHdyaXRlLXNwbGl0dGluZy1kaXN0c3FsLXBhcnNlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2hhcmRpbmdzcGhlcmUvcmVhZHdyaXRlc3BsaXR0aW5nL2Rpc3RzcWwvcGFyc2VyL2NvcmUvUmVhZHdyaXRlU3BsaXR0aW5nUnVsZVNRTFN0YXRlbWVudFZpc2l0b3IuamF2YQ==) | `0.00% <0.00%> (ø)` | |
| [...end/text/distsql/ral/RALBackendHandlerFactory.java](https://codecov.io/gh/apache/shardingsphere/pull/11742/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2hhcmRpbmdzcGhlcmUtcHJveHkvc2hhcmRpbmdzcGhlcmUtcHJveHktYmFja2VuZC9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2hhcmRpbmdzcGhlcmUvcHJveHkvYmFja2VuZC90ZXh0L2Rpc3RzcWwvcmFsL1JBTEJhY2tlbmRIYW5kbGVyRmFjdG9yeS5qYXZh) | `0.00% <0.00%> (ø)` | |
| [...ral/common/CommonDistSQLBackendHandlerFactory.java](https://codecov.io/gh/apache/shardingsphere/pull/11742/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2hhcmRpbmdzcGhlcmUtcHJveHkvc2hhcmRpbmdzcGhlcmUtcHJveHktYmFja2VuZC9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2hhcmRpbmdzcGhlcmUvcHJveHkvYmFja2VuZC90ZXh0L2Rpc3RzcWwvcmFsL2NvbW1vbi9Db21tb25EaXN0U1FMQmFja2VuZEhhbmRsZXJGYWN0b3J5LmphdmE=) | `0.00% <0.00%> (ø)` | |
| [.../distsql/ral/common/HintDistSQLBackendHandler.java](https://codecov.io/gh/apache/shardingsphere/pull/11742/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2hhcmRpbmdzcGhlcmUtcHJveHkvc2hhcmRpbmdzcGhlcmUtcHJveHktYmFja2VuZC9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2hhcmRpbmdzcGhlcmUvcHJveHkvYmFja2VuZC90ZXh0L2Rpc3RzcWwvcmFsL2NvbW1vbi9IaW50RGlzdFNRTEJhY2tlbmRIYW5kbGVyLmphdmE=) | `0.00% <0.00%> (ø)` | |
| [...istsql/ral/common/PrviewDistSQLBackendHandler.java](https://codecov.io/gh/apache/shardingsphere/pull/11742/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2hhcmRpbmdzcGhlcmUtcHJveHkvc2hhcmRpbmdzcGhlcmUtcHJveHktYmFja2VuZC9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2hhcmRpbmdzcGhlcmUvcHJveHkvYmFja2VuZC90ZXh0L2Rpc3RzcWwvcmFsL2NvbW1vbi9QcnZpZXdEaXN0U1FMQmFja2VuZEhhbmRsZXIuamF2YQ==) | `0.00% <0.00%> (ø)` | |
| [...t/distsql/ral/common/SetDistSQLBackendHandler.java](https://codecov.io/gh/apache/shardingsphere/pull/11742/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2hhcmRpbmdzcGhlcmUtcHJveHkvc2hhcmRpbmdzcGhlcmUtcHJveHktYmFja2VuZC9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2hhcmRpbmdzcGhlcmUvcHJveHkvYmFja2VuZC90ZXh0L2Rpc3RzcWwvcmFsL2NvbW1vbi9TZXREaXN0U1FMQmFja2VuZEhhbmRsZXIuamF2YQ==) | `0.00% <0.00%> (ø)` | |
| ... and [101 more](https://codecov.io/gh/apache/shardingsphere/pull/11742/diff?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/shardingsphere/pull/11742?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/shardingsphere/pull/11742?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [226f093...84cf145](https://codecov.io/gh/apache/shardingsphere/pull/11742?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [shardingsphere] codecov-commenter edited a comment on pull request #11742: Main structure code of processing SCTL dist SQL.
Posted by GitBox <gi...@apache.org>.
codecov-commenter edited a comment on pull request #11742:
URL: https://github.com/apache/shardingsphere/pull/11742#issuecomment-895936431
# [Codecov](https://codecov.io/gh/apache/shardingsphere/pull/11742?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#11742](https://codecov.io/gh/apache/shardingsphere/pull/11742?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (beb901f) into [master](https://codecov.io/gh/apache/shardingsphere/commit/226f0934196cfcef99b9b3c6b8fbdb6808626df2?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (226f093) will **decrease** coverage by `0.08%`.
> The diff coverage is `3.22%`.
[](https://codecov.io/gh/apache/shardingsphere/pull/11742?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
```diff
@@ Coverage Diff @@
## master #11742 +/- ##
============================================
- Coverage 63.67% 63.58% -0.09%
- Complexity 1126 1128 +2
============================================
Files 2272 2294 +22
Lines 34666 34828 +162
Branches 6035 6061 +26
============================================
+ Hits 22075 22147 +72
- Misses 10824 10911 +87
- Partials 1767 1770 +3
```
| [Impacted Files](https://codecov.io/gh/apache/shardingsphere/pull/11742?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
|---|---|---|
| [...stsql/parser/api/DistSQLStatementParserEngine.java](https://codecov.io/gh/apache/shardingsphere/pull/11742/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2hhcmRpbmdzcGhlcmUtZGlzdHNxbC1wYXJzZXIvc2hhcmRpbmdzcGhlcmUtZGlzdHNxbC1wYXJzZXItZW5naW5lL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9zaGFyZGluZ3NwaGVyZS9kaXN0c3FsL3BhcnNlci9hcGkvRGlzdFNRTFN0YXRlbWVudFBhcnNlckVuZ2luZS5qYXZh) | `0.00% <0.00%> (ø)` | |
| [...istsql/parser/core/common/CommonDistSQLParser.java](https://codecov.io/gh/apache/shardingsphere/pull/11742/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2hhcmRpbmdzcGhlcmUtZGlzdHNxbC1wYXJzZXIvc2hhcmRpbmdzcGhlcmUtZGlzdHNxbC1wYXJzZXItZW5naW5lL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9zaGFyZGluZ3NwaGVyZS9kaXN0c3FsL3BhcnNlci9jb3JlL2NvbW1vbi9Db21tb25EaXN0U1FMUGFyc2VyLmphdmE=) | `0.00% <ø> (ø)` | |
| [...ore/common/CommonDistSQLStatementParserEngine.java](https://codecov.io/gh/apache/shardingsphere/pull/11742/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2hhcmRpbmdzcGhlcmUtZGlzdHNxbC1wYXJzZXIvc2hhcmRpbmdzcGhlcmUtZGlzdHNxbC1wYXJzZXItZW5naW5lL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9zaGFyZGluZ3NwaGVyZS9kaXN0c3FsL3BhcnNlci9jb3JlL2NvbW1vbi9Db21tb25EaXN0U1FMU3RhdGVtZW50UGFyc2VyRW5naW5lLmphdmE=) | `0.00% <0.00%> (ø)` | |
| [...ser/core/common/CommonDistSQLStatementVisitor.java](https://codecov.io/gh/apache/shardingsphere/pull/11742/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2hhcmRpbmdzcGhlcmUtZGlzdHNxbC1wYXJzZXIvc2hhcmRpbmdzcGhlcmUtZGlzdHNxbC1wYXJzZXItZW5naW5lL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9zaGFyZGluZ3NwaGVyZS9kaXN0c3FsL3BhcnNlci9jb3JlL2NvbW1vbi9Db21tb25EaXN0U1FMU3RhdGVtZW50VmlzaXRvci5qYXZh) | `0.00% <0.00%> (ø)` | |
| [...ore/ReadwriteSplittingRuleSQLStatementVisitor.java](https://codecov.io/gh/apache/shardingsphere/pull/11742/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2hhcmRpbmdzcGhlcmUtZmVhdHVyZXMvc2hhcmRpbmdzcGhlcmUtcmVhZHdyaXRlLXNwbGl0dGluZy9zaGFyZGluZ3NwaGVyZS1yZWFkd3JpdGUtc3BsaXR0aW5nLWRpc3RzcWwvc2hhcmRpbmdzcGhlcmUtcmVhZHdyaXRlLXNwbGl0dGluZy1kaXN0c3FsLXBhcnNlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2hhcmRpbmdzcGhlcmUvcmVhZHdyaXRlc3BsaXR0aW5nL2Rpc3RzcWwvcGFyc2VyL2NvcmUvUmVhZHdyaXRlU3BsaXR0aW5nUnVsZVNRTFN0YXRlbWVudFZpc2l0b3IuamF2YQ==) | `0.00% <0.00%> (ø)` | |
| [...end/text/distsql/ral/RALBackendHandlerFactory.java](https://codecov.io/gh/apache/shardingsphere/pull/11742/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2hhcmRpbmdzcGhlcmUtcHJveHkvc2hhcmRpbmdzcGhlcmUtcHJveHktYmFja2VuZC9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2hhcmRpbmdzcGhlcmUvcHJveHkvYmFja2VuZC90ZXh0L2Rpc3RzcWwvcmFsL1JBTEJhY2tlbmRIYW5kbGVyRmFjdG9yeS5qYXZh) | `0.00% <0.00%> (ø)` | |
| [...xt/distsql/ral/sctl/SCTLBackendHandlerFactory.java](https://codecov.io/gh/apache/shardingsphere/pull/11742/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2hhcmRpbmdzcGhlcmUtcHJveHkvc2hhcmRpbmdzcGhlcmUtcHJveHktYmFja2VuZC9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2hhcmRpbmdzcGhlcmUvcHJveHkvYmFja2VuZC90ZXh0L2Rpc3RzcWwvcmFsL3NjdGwvU0NUTEJhY2tlbmRIYW5kbGVyRmFjdG9yeS5qYXZh) | `0.00% <0.00%> (ø)` | |
| [.../text/distsql/ral/sctl/SCTLHintBackendHandler.java](https://codecov.io/gh/apache/shardingsphere/pull/11742/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2hhcmRpbmdzcGhlcmUtcHJveHkvc2hhcmRpbmdzcGhlcmUtcHJveHktYmFja2VuZC9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2hhcmRpbmdzcGhlcmUvcHJveHkvYmFja2VuZC90ZXh0L2Rpc3RzcWwvcmFsL3NjdGwvU0NUTEhpbnRCYWNrZW5kSGFuZGxlci5qYXZh) | `0.00% <0.00%> (ø)` | |
| [...ext/distsql/ral/sctl/SCTLPrviewBackendHandler.java](https://codecov.io/gh/apache/shardingsphere/pull/11742/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2hhcmRpbmdzcGhlcmUtcHJveHkvc2hhcmRpbmdzcGhlcmUtcHJveHktYmFja2VuZC9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2hhcmRpbmdzcGhlcmUvcHJveHkvYmFja2VuZC90ZXh0L2Rpc3RzcWwvcmFsL3NjdGwvU0NUTFBydmlld0JhY2tlbmRIYW5kbGVyLmphdmE=) | `0.00% <0.00%> (ø)` | |
| [...d/text/distsql/ral/sctl/SCTLSetBackendHandler.java](https://codecov.io/gh/apache/shardingsphere/pull/11742/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2hhcmRpbmdzcGhlcmUtcHJveHkvc2hhcmRpbmdzcGhlcmUtcHJveHktYmFja2VuZC9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2hhcmRpbmdzcGhlcmUvcHJveHkvYmFja2VuZC90ZXh0L2Rpc3RzcWwvcmFsL3NjdGwvU0NUTFNldEJhY2tlbmRIYW5kbGVyLmphdmE=) | `0.00% <0.00%> (ø)` | |
| ... and [85 more](https://codecov.io/gh/apache/shardingsphere/pull/11742/diff?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/shardingsphere/pull/11742?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/shardingsphere/pull/11742?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [226f093...beb901f](https://codecov.io/gh/apache/shardingsphere/pull/11742?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [shardingsphere] codecov-commenter commented on pull request #11742: Main structure code of processing SCTL dist SQL.
Posted by GitBox <gi...@apache.org>.
codecov-commenter commented on pull request #11742:
URL: https://github.com/apache/shardingsphere/pull/11742#issuecomment-895936431
# [Codecov](https://codecov.io/gh/apache/shardingsphere/pull/11742?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#11742](https://codecov.io/gh/apache/shardingsphere/pull/11742?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (4417115) into [master](https://codecov.io/gh/apache/shardingsphere/commit/226f0934196cfcef99b9b3c6b8fbdb6808626df2?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (226f093) will **decrease** coverage by `0.20%`.
> The diff coverage is `0.00%`.
[](https://codecov.io/gh/apache/shardingsphere/pull/11742?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
```diff
@@ Coverage Diff @@
## master #11742 +/- ##
============================================
- Coverage 63.67% 63.47% -0.21%
Complexity 1126 1126
============================================
Files 2272 2293 +21
Lines 34666 34797 +131
Branches 6035 6057 +22
============================================
+ Hits 22075 22086 +11
- Misses 10824 10940 +116
- Partials 1767 1771 +4
```
| [Impacted Files](https://codecov.io/gh/apache/shardingsphere/pull/11742?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
|---|---|---|
| [...stsql/parser/api/DistSQLStatementParserEngine.java](https://codecov.io/gh/apache/shardingsphere/pull/11742/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2hhcmRpbmdzcGhlcmUtZGlzdHNxbC1wYXJzZXIvc2hhcmRpbmdzcGhlcmUtZGlzdHNxbC1wYXJzZXItZW5naW5lL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9zaGFyZGluZ3NwaGVyZS9kaXN0c3FsL3BhcnNlci9hcGkvRGlzdFNRTFN0YXRlbWVudFBhcnNlckVuZ2luZS5qYXZh) | `0.00% <0.00%> (ø)` | |
| [.../parser/core/administration/SCTLDistSQLParser.java](https://codecov.io/gh/apache/shardingsphere/pull/11742/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2hhcmRpbmdzcGhlcmUtZGlzdHNxbC1wYXJzZXIvc2hhcmRpbmdzcGhlcmUtZGlzdHNxbC1wYXJzZXItZW5naW5lL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9zaGFyZGluZ3NwaGVyZS9kaXN0c3FsL3BhcnNlci9jb3JlL2FkbWluaXN0cmF0aW9uL1NDVExEaXN0U1FMUGFyc2VyLmphdmE=) | `0.00% <0.00%> (ø)` | |
| [...re/administration/SCTLDistSQLStatementVisitor.java](https://codecov.io/gh/apache/shardingsphere/pull/11742/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2hhcmRpbmdzcGhlcmUtZGlzdHNxbC1wYXJzZXIvc2hhcmRpbmdzcGhlcmUtZGlzdHNxbC1wYXJzZXItZW5naW5lL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9zaGFyZGluZ3NwaGVyZS9kaXN0c3FsL3BhcnNlci9jb3JlL2FkbWluaXN0cmF0aW9uL1NDVExEaXN0U1FMU3RhdGVtZW50VmlzaXRvci5qYXZh) | `0.00% <0.00%> (ø)` | |
| [...core/administration/SCTLStatementParserEngine.java](https://codecov.io/gh/apache/shardingsphere/pull/11742/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2hhcmRpbmdzcGhlcmUtZGlzdHNxbC1wYXJzZXIvc2hhcmRpbmdzcGhlcmUtZGlzdHNxbC1wYXJzZXItZW5naW5lL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9zaGFyZGluZ3NwaGVyZS9kaXN0c3FsL3BhcnNlci9jb3JlL2FkbWluaXN0cmF0aW9uL1NDVExTdGF0ZW1lbnRQYXJzZXJFbmdpbmUuamF2YQ==) | `0.00% <0.00%> (ø)` | |
| [.../apache/shardingsphere/infra/hint/HintManager.java](https://codecov.io/gh/apache/shardingsphere/pull/11742/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2hhcmRpbmdzcGhlcmUtaW5mcmEvc2hhcmRpbmdzcGhlcmUtaW5mcmEtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9zaGFyZGluZ3NwaGVyZS9pbmZyYS9oaW50L0hpbnRNYW5hZ2VyLmphdmE=) | `90.90% <0.00%> (-5.87%)` | :arrow_down: |
| [...end/text/distsql/ral/RALBackendHandlerFactory.java](https://codecov.io/gh/apache/shardingsphere/pull/11742/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2hhcmRpbmdzcGhlcmUtcHJveHkvc2hhcmRpbmdzcGhlcmUtcHJveHktYmFja2VuZC9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2hhcmRpbmdzcGhlcmUvcHJveHkvYmFja2VuZC90ZXh0L2Rpc3RzcWwvcmFsL1JBTEJhY2tlbmRIYW5kbGVyRmFjdG9yeS5qYXZh) | `0.00% <0.00%> (ø)` | |
| [...xt/distsql/ral/sctl/SCTLBackendHandlerFactory.java](https://codecov.io/gh/apache/shardingsphere/pull/11742/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2hhcmRpbmdzcGhlcmUtcHJveHkvc2hhcmRpbmdzcGhlcmUtcHJveHktYmFja2VuZC9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2hhcmRpbmdzcGhlcmUvcHJveHkvYmFja2VuZC90ZXh0L2Rpc3RzcWwvcmFsL3NjdGwvU0NUTEJhY2tlbmRIYW5kbGVyRmFjdG9yeS5qYXZh) | `0.00% <0.00%> (ø)` | |
| [.../text/distsql/ral/sctl/SCTLHintBackendHandler.java](https://codecov.io/gh/apache/shardingsphere/pull/11742/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2hhcmRpbmdzcGhlcmUtcHJveHkvc2hhcmRpbmdzcGhlcmUtcHJveHktYmFja2VuZC9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2hhcmRpbmdzcGhlcmUvcHJveHkvYmFja2VuZC90ZXh0L2Rpc3RzcWwvcmFsL3NjdGwvU0NUTEhpbnRCYWNrZW5kSGFuZGxlci5qYXZh) | `0.00% <0.00%> (ø)` | |
| [...ext/distsql/ral/sctl/SCTLPrviewBackendHandler.java](https://codecov.io/gh/apache/shardingsphere/pull/11742/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2hhcmRpbmdzcGhlcmUtcHJveHkvc2hhcmRpbmdzcGhlcmUtcHJveHktYmFja2VuZC9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2hhcmRpbmdzcGhlcmUvcHJveHkvYmFja2VuZC90ZXh0L2Rpc3RzcWwvcmFsL3NjdGwvU0NUTFBydmlld0JhY2tlbmRIYW5kbGVyLmphdmE=) | `0.00% <0.00%> (ø)` | |
| [...d/text/distsql/ral/sctl/SCTLSetBackendHandler.java](https://codecov.io/gh/apache/shardingsphere/pull/11742/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2hhcmRpbmdzcGhlcmUtcHJveHkvc2hhcmRpbmdzcGhlcmUtcHJveHktYmFja2VuZC9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2hhcmRpbmdzcGhlcmUvcHJveHkvYmFja2VuZC90ZXh0L2Rpc3RzcWwvcmFsL3NjdGwvU0NUTFNldEJhY2tlbmRIYW5kbGVyLmphdmE=) | `0.00% <0.00%> (ø)` | |
| ... and [60 more](https://codecov.io/gh/apache/shardingsphere/pull/11742/diff?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/shardingsphere/pull/11742?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/shardingsphere/pull/11742?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [226f093...4417115](https://codecov.io/gh/apache/shardingsphere/pull/11742?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [shardingsphere] tristaZero commented on a change in pull request #11742: Main structure code of processing SCTL dist SQL.
Posted by GitBox <gi...@apache.org>.
tristaZero commented on a change in pull request #11742:
URL: https://github.com/apache/shardingsphere/pull/11742#discussion_r686398432
##########
File path: shardingsphere-distsql-parser/shardingsphere-distsql-parser-engine/src/main/antlr4/imports/Keyword.g4
##########
@@ -78,3 +90,36 @@ NAME
PROPERTIES
: P R O P E R T I E S
;
+
+VARIABLE
+ : V A R I A B L E
+ ;
+
+HINT
+ : H I N T
+ ;
+
+SOURCE
+ : S O U R C E
+ ;
+
+STATUS
+ : S T A T U S
+ ;
+
+SHARDING
+ : S H A R D I N G
+ ;
+
+READWRITE_SPLITTING
+ : R E A D W R I T E UL_ S P L I T T I N G
+ ;
+
+DATABASE_VALUE
+ : D A T A B A S E UL_ V A L U E
+ ;
+
+TABLE_VALUE
+ : T A B L E UL_ V A L U E
+ ;
+
Review comment:
The last line is expected to be a new line instead of a line with indent.
##########
File path: shardingsphere-distsql-parser/shardingsphere-distsql-parser-engine/src/main/java/org/apache/shardingsphere/distsql/parser/api/DistSQLStatementParserEngine.java
##########
@@ -38,7 +39,11 @@ public SQLStatement parse(final String sql) {
try {
return new ResourceSQLStatementParserEngine().parse(sql);
} catch (final ParseCancellationException | SQLParsingException ignored) {
- return new RuleSQLStatementParserEngine().parse(sql);
+ try {
+ return new RuleSQLStatementParserEngine().parse(sql);
+ } catch (final SQLParsingException ignoredToo) {
+ return new SCTLStatementParserEngine().parse(sql);
Review comment:
Same with the above question.
##########
File path: shardingsphere-distsql-parser/shardingsphere-distsql-parser-engine/src/main/antlr4/org/apache/shardingsphere/distsql/parser/autogen/SCTLStatement.g4
##########
@@ -0,0 +1,33 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+grammar SCTLStatement;
Review comment:
I suggest we merge `SCTLStatement ` and `ResourceStatement`, and then rename this new class.
##########
File path: shardingsphere-distsql-parser/shardingsphere-distsql-parser-engine/src/main/antlr4/imports/RALStatement.g4
##########
@@ -0,0 +1,73 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+grammar RALStatement;
+
+import Keyword, Literals, Symbol;
+
+setVariable
+ : SET VARIABLE name EQ value
+ ;
+
+showVariable
+ : SHOW VARIABLE name
+ ;
+
+previewSQL
+ : PREVIEW sql
+ ;
+
+setReadwriteSplittingHintSource
+ : SET READWRITE_SPLITTING HINT SOURCE EQ value
+ ;
+
+setShardingHintDatabaseValue
+ : SET SHARDING HINT DATABASE_VALUE EQ value
+ ;
+
+addShardingHintDatabaseValue
+ : ADD SHARDING HINT DATABASE_VALUE name EQ value
+ ;
+
+addShardingHintTableValue
+ : ADD SHARDING HINT TABLE_VALUE name EQ value
+ ;
+
+showHintStatus
+ : SHOW feature HINT STATUS
+ ;
+
+clearHint
+ : CLEAR feature? HINT
+ ;
+
+name
+ : IDENTIFIER
+ ;
+
+value
+ : IDENTIFIER
+ ;
+
+sql
+ : STRING
+ ;
+
+feature
+ : SHARDING | READWRITE_SPLITTING
+ ;
+
Review comment:
A new-line issue
##########
File path: shardingsphere-distsql-parser/shardingsphere-distsql-parser-engine/src/main/antlr4/imports/Keyword.g4
##########
@@ -78,3 +90,36 @@ NAME
PROPERTIES
: P R O P E R T I E S
;
+
+VARIABLE
+ : V A R I A B L E
+ ;
+
+HINT
+ : H I N T
+ ;
+
+SOURCE
+ : S O U R C E
+ ;
+
+STATUS
+ : S T A T U S
+ ;
+
+SHARDING
Review comment:
Do you think `sharding` and `read-write-splitting` are supposed to move to their own feature distsql packages?
##########
File path: shardingsphere-distsql-parser/shardingsphere-distsql-parser-engine/src/main/java/org/apache/shardingsphere/distsql/parser/api/DistSQLStatementParserEngine.java
##########
@@ -38,7 +39,11 @@ public SQLStatement parse(final String sql) {
try {
return new ResourceSQLStatementParserEngine().parse(sql);
} catch (final ParseCancellationException | SQLParsingException ignored) {
- return new RuleSQLStatementParserEngine().parse(sql);
+ try {
Review comment:
Why do we need `catch` to parse `RuleSQLStatementParserEngine`?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [shardingsphere] codecov-commenter edited a comment on pull request #11742: Main structure code of processing SCTL dist SQL.
Posted by GitBox <gi...@apache.org>.
codecov-commenter edited a comment on pull request #11742:
URL: https://github.com/apache/shardingsphere/pull/11742#issuecomment-895936431
# [Codecov](https://codecov.io/gh/apache/shardingsphere/pull/11742?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#11742](https://codecov.io/gh/apache/shardingsphere/pull/11742?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (e3c6e3c) into [master](https://codecov.io/gh/apache/shardingsphere/commit/226f0934196cfcef99b9b3c6b8fbdb6808626df2?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (226f093) will **decrease** coverage by `0.16%`.
> The diff coverage is `2.81%`.
[](https://codecov.io/gh/apache/shardingsphere/pull/11742?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
```diff
@@ Coverage Diff @@
## master #11742 +/- ##
============================================
- Coverage 63.67% 63.50% -0.17%
- Complexity 1126 1127 +1
============================================
Files 2272 2297 +25
Lines 34666 34831 +165
Branches 6035 6059 +24
============================================
+ Hits 22075 22121 +46
- Misses 10824 10939 +115
- Partials 1767 1771 +4
```
| [Impacted Files](https://codecov.io/gh/apache/shardingsphere/pull/11742?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
|---|---|---|
| [...stsql/parser/api/DistSQLStatementParserEngine.java](https://codecov.io/gh/apache/shardingsphere/pull/11742/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2hhcmRpbmdzcGhlcmUtZGlzdHNxbC1wYXJzZXIvc2hhcmRpbmdzcGhlcmUtZGlzdHNxbC1wYXJzZXItZW5naW5lL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9zaGFyZGluZ3NwaGVyZS9kaXN0c3FsL3BhcnNlci9hcGkvRGlzdFNRTFN0YXRlbWVudFBhcnNlckVuZ2luZS5qYXZh) | `0.00% <0.00%> (ø)` | |
| [.../parser/core/administration/SCTLDistSQLParser.java](https://codecov.io/gh/apache/shardingsphere/pull/11742/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2hhcmRpbmdzcGhlcmUtZGlzdHNxbC1wYXJzZXIvc2hhcmRpbmdzcGhlcmUtZGlzdHNxbC1wYXJzZXItZW5naW5lL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9zaGFyZGluZ3NwaGVyZS9kaXN0c3FsL3BhcnNlci9jb3JlL2FkbWluaXN0cmF0aW9uL1NDVExEaXN0U1FMUGFyc2VyLmphdmE=) | `0.00% <0.00%> (ø)` | |
| [...re/administration/SCTLDistSQLStatementVisitor.java](https://codecov.io/gh/apache/shardingsphere/pull/11742/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2hhcmRpbmdzcGhlcmUtZGlzdHNxbC1wYXJzZXIvc2hhcmRpbmdzcGhlcmUtZGlzdHNxbC1wYXJzZXItZW5naW5lL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9zaGFyZGluZ3NwaGVyZS9kaXN0c3FsL3BhcnNlci9jb3JlL2FkbWluaXN0cmF0aW9uL1NDVExEaXN0U1FMU3RhdGVtZW50VmlzaXRvci5qYXZh) | `0.00% <0.00%> (ø)` | |
| [...core/administration/SCTLStatementParserEngine.java](https://codecov.io/gh/apache/shardingsphere/pull/11742/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2hhcmRpbmdzcGhlcmUtZGlzdHNxbC1wYXJzZXIvc2hhcmRpbmdzcGhlcmUtZGlzdHNxbC1wYXJzZXItZW5naW5lL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9zaGFyZGluZ3NwaGVyZS9kaXN0c3FsL3BhcnNlci9jb3JlL2FkbWluaXN0cmF0aW9uL1NDVExTdGF0ZW1lbnRQYXJzZXJFbmdpbmUuamF2YQ==) | `0.00% <0.00%> (ø)` | |
| [...ore/ReadwriteSplittingRuleSQLStatementVisitor.java](https://codecov.io/gh/apache/shardingsphere/pull/11742/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2hhcmRpbmdzcGhlcmUtZmVhdHVyZXMvc2hhcmRpbmdzcGhlcmUtcmVhZHdyaXRlLXNwbGl0dGluZy9zaGFyZGluZ3NwaGVyZS1yZWFkd3JpdGUtc3BsaXR0aW5nLWRpc3RzcWwvc2hhcmRpbmdzcGhlcmUtcmVhZHdyaXRlLXNwbGl0dGluZy1kaXN0c3FsLXBhcnNlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2hhcmRpbmdzcGhlcmUvcmVhZHdyaXRlc3BsaXR0aW5nL2Rpc3RzcWwvcGFyc2VyL2NvcmUvUmVhZHdyaXRlU3BsaXR0aW5nUnVsZVNRTFN0YXRlbWVudFZpc2l0b3IuamF2YQ==) | `0.00% <0.00%> (ø)` | |
| [...end/text/distsql/ral/RALBackendHandlerFactory.java](https://codecov.io/gh/apache/shardingsphere/pull/11742/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2hhcmRpbmdzcGhlcmUtcHJveHkvc2hhcmRpbmdzcGhlcmUtcHJveHktYmFja2VuZC9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2hhcmRpbmdzcGhlcmUvcHJveHkvYmFja2VuZC90ZXh0L2Rpc3RzcWwvcmFsL1JBTEJhY2tlbmRIYW5kbGVyRmFjdG9yeS5qYXZh) | `0.00% <0.00%> (ø)` | |
| [...xt/distsql/ral/sctl/SCTLBackendHandlerFactory.java](https://codecov.io/gh/apache/shardingsphere/pull/11742/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2hhcmRpbmdzcGhlcmUtcHJveHkvc2hhcmRpbmdzcGhlcmUtcHJveHktYmFja2VuZC9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2hhcmRpbmdzcGhlcmUvcHJveHkvYmFja2VuZC90ZXh0L2Rpc3RzcWwvcmFsL3NjdGwvU0NUTEJhY2tlbmRIYW5kbGVyRmFjdG9yeS5qYXZh) | `0.00% <0.00%> (ø)` | |
| [.../text/distsql/ral/sctl/SCTLHintBackendHandler.java](https://codecov.io/gh/apache/shardingsphere/pull/11742/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2hhcmRpbmdzcGhlcmUtcHJveHkvc2hhcmRpbmdzcGhlcmUtcHJveHktYmFja2VuZC9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2hhcmRpbmdzcGhlcmUvcHJveHkvYmFja2VuZC90ZXh0L2Rpc3RzcWwvcmFsL3NjdGwvU0NUTEhpbnRCYWNrZW5kSGFuZGxlci5qYXZh) | `0.00% <0.00%> (ø)` | |
| [...ext/distsql/ral/sctl/SCTLPrviewBackendHandler.java](https://codecov.io/gh/apache/shardingsphere/pull/11742/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2hhcmRpbmdzcGhlcmUtcHJveHkvc2hhcmRpbmdzcGhlcmUtcHJveHktYmFja2VuZC9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2hhcmRpbmdzcGhlcmUvcHJveHkvYmFja2VuZC90ZXh0L2Rpc3RzcWwvcmFsL3NjdGwvU0NUTFBydmlld0JhY2tlbmRIYW5kbGVyLmphdmE=) | `0.00% <0.00%> (ø)` | |
| [...d/text/distsql/ral/sctl/SCTLSetBackendHandler.java](https://codecov.io/gh/apache/shardingsphere/pull/11742/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2hhcmRpbmdzcGhlcmUtcHJveHkvc2hhcmRpbmdzcGhlcmUtcHJveHktYmFja2VuZC9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2hhcmRpbmdzcGhlcmUvcHJveHkvYmFja2VuZC90ZXh0L2Rpc3RzcWwvcmFsL3NjdGwvU0NUTFNldEJhY2tlbmRIYW5kbGVyLmphdmE=) | `0.00% <0.00%> (ø)` | |
| ... and [72 more](https://codecov.io/gh/apache/shardingsphere/pull/11742/diff?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/shardingsphere/pull/11742?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/shardingsphere/pull/11742?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [226f093...e3c6e3c](https://codecov.io/gh/apache/shardingsphere/pull/11742?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [shardingsphere] RaigorJiang commented on a change in pull request #11742: Main structure code of processing SCTL dist SQL.
Posted by GitBox <gi...@apache.org>.
RaigorJiang commented on a change in pull request #11742:
URL: https://github.com/apache/shardingsphere/pull/11742#discussion_r686438012
##########
File path: shardingsphere-distsql-parser/shardingsphere-distsql-parser-engine/src/main/antlr4/imports/Keyword.g4
##########
@@ -78,3 +90,36 @@ NAME
PROPERTIES
: P R O P E R T I E S
;
+
+VARIABLE
+ : V A R I A B L E
+ ;
+
+HINT
+ : H I N T
+ ;
+
+SOURCE
+ : S O U R C E
+ ;
+
+STATUS
+ : S T A T U S
+ ;
+
+SHARDING
Review comment:
It's really better, thanks for the suggestion.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [shardingsphere] tristaZero commented on a change in pull request #11742: Main structure code of processing SCTL dist SQL.
Posted by GitBox <gi...@apache.org>.
tristaZero commented on a change in pull request #11742:
URL: https://github.com/apache/shardingsphere/pull/11742#discussion_r686724584
##########
File path: shardingsphere-proxy/shardingsphere-proxy-backend/src/main/java/org/apache/shardingsphere/proxy/backend/text/distsql/ral/RALBackendHandlerFactory.java
##########
@@ -39,14 +43,18 @@
* @param sqlStatement RAL statement
* @param backendConnection backend connection
* @return RAL backend handler
+ * @throws SQLException SQL exception
*/
- public static TextProtocolBackendHandler newInstance(final RALStatement sqlStatement, final BackendConnection backendConnection) {
+ public static TextProtocolBackendHandler newInstance(final RALStatement sqlStatement, final BackendConnection backendConnection) throws SQLException {
if (sqlStatement instanceof QueryableRALStatement) {
return QueryableRALBackendHandlerFactory.newInstance((QueryableRALStatement) sqlStatement, backendConnection);
}
if (sqlStatement instanceof UpdatableRALStatement) {
return UpdatableRALBackendHandlerFactory.newInstance((UpdatableRALStatement) sqlStatement);
}
+ if (sqlStatement instanceof SCTLStatement) {
Review comment:
`QueryableRALStatement`, `UpdatableRALStatement`, and `SCTLStatement` are in parallel level?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [shardingsphere] RaigorJiang commented on a change in pull request #11742: Main structure code of processing SCTL dist SQL.
Posted by GitBox <gi...@apache.org>.
RaigorJiang commented on a change in pull request #11742:
URL: https://github.com/apache/shardingsphere/pull/11742#discussion_r686437519
##########
File path: shardingsphere-distsql-parser/shardingsphere-distsql-parser-engine/src/main/antlr4/imports/Keyword.g4
##########
@@ -78,3 +90,36 @@ NAME
PROPERTIES
: P R O P E R T I E S
;
+
+VARIABLE
+ : V A R I A B L E
+ ;
+
+HINT
+ : H I N T
+ ;
+
+SOURCE
+ : S O U R C E
+ ;
+
+STATUS
+ : S T A T U S
+ ;
+
+SHARDING
+ : S H A R D I N G
+ ;
+
+READWRITE_SPLITTING
+ : R E A D W R I T E UL_ S P L I T T I N G
+ ;
+
+DATABASE_VALUE
+ : D A T A B A S E UL_ V A L U E
+ ;
+
+TABLE_VALUE
+ : T A B L E UL_ V A L U E
+ ;
+
Review comment:
Sure, I'll fix it.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [shardingsphere] tristaZero merged pull request #11742: Main structure code of processing SCTL dist SQL.
Posted by GitBox <gi...@apache.org>.
tristaZero merged pull request #11742:
URL: https://github.com/apache/shardingsphere/pull/11742
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [shardingsphere] RaigorJiang commented on a change in pull request #11742: Main structure code of processing SCTL dist SQL.
Posted by GitBox <gi...@apache.org>.
RaigorJiang commented on a change in pull request #11742:
URL: https://github.com/apache/shardingsphere/pull/11742#discussion_r686455997
##########
File path: shardingsphere-distsql-parser/shardingsphere-distsql-parser-engine/src/main/antlr4/org/apache/shardingsphere/distsql/parser/autogen/SCTLStatement.g4
##########
@@ -0,0 +1,33 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+grammar SCTLStatement;
Review comment:
What about AdministrationStatement?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org