You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@inlong.apache.org by "gong (via GitHub)" <gi...@apache.org> on 2023/06/15 05:03:24 UTC

[GitHub] [inlong] gong commented on a diff in pull request #8238: [INLONG-8236][Sort][WIP] Iceberg supports dynamic switching between append and upsert

gong commented on code in PR #8238:
URL: https://github.com/apache/inlong/pull/8238#discussion_r1230430744


##########
inlong-sort/sort-flink/sort-flink-v1.13/sort-connectors/iceberg/src/main/java/org/apache/inlong/sort/iceberg/sink/multiple/IcebergSingleStreamWriter.java:
##########
@@ -94,6 +105,8 @@ public IcebergSingleStreamWriter(
         this.dirtyOptions = dirtyOptions;
         this.dirtySink = dirtySink;
         this.multipleSink = multipleSink;
+        this.tableSchema = tableSchema;
+        this.cachedWriteResults = new LinkedList<>();

Review Comment:
   Maybe use ArrayList is better. You just append add element to tail



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@inlong.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org