[GitHub] [dubbo] guohao commented on a change in pull request #9112: [3.0] Add connectivity validation, router snapshot

[GitBox <gi...@apache.org>]

guohao commented on a change in pull request #9112:
URL: https://github.com/apache/dubbo/pull/9112#discussion_r737084993



##########
File path: dubbo-cluster/src/main/java/org/apache/dubbo/rpc/cluster/RouterChain.java
##########
@@ -163,40 +166,115 @@ public void addStateRouters(List<StateRouter> stateRouters) {
      * @param invocation
      * @return
      */
-    public List<Invoker<T>> route(URL url, Invocation invocation) {
+    public BitList<Invoker<T>> route(URL url, Invocation invocation) {
 
         AddrCache<T> cache = this.cache.get();
-        List<Invoker<T>> finalInvokers = null;
+        BitList<Invoker<T>> resultInvokers = invokers.clone();

Review comment:
       Is `clone` here  necessary ? 




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org